Re: Labels in SVN ?
Costin Manolache wrote: What I want is to be able to do "cvs diff -r my_label_before_sandbox_copy", so I can see what changed. I want to keep my experiments in the sandbox - instead of a branch. Costin Copies are cheap in SVN, so tags are just copies. And in a similar manner to CVS branches are just tags that you start making changes to. What I suggest is that I make the following SVN changes: - create /sandbox/trunk, /sandbox/tags, /sandbox/branches - move the current contents of /sandbox to /sandbox/trunk Then when you want to make a tag you just do a copy of the form svn copy https://svn.apache.org/repos/asf/tomcat/sandbox/optional/path https://svn.apache.org/repos/asf/tomcat/sandbox/tags/nameOfTag This way you can tag all of sandbox or just part of it. Let me know if you want me to make the top level changes to sandbox or if you are happy making them yourself. Mark - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Labels in SVN ?
I was not sure if you can tag a small subtree ( connectors/util/java ) , or only the entire connectors/. I think I'll just do diffs by date - it's probably easier. Costin On 11/20/05, Mark Thomas <[EMAIL PROTECTED]> wrote: > Costin Manolache wrote: > > What I want is to be able to do "cvs diff -r my_label_before_sandbox_copy", > > so I can see what changed. > > I want to keep my experiments in the sandbox - instead of a branch. > > > > Costin > > Copies are cheap in SVN, so tags are just copies. And in a similar > manner to CVS branches are just tags that you start making changes to. > > What I suggest is that I make the following SVN changes: > - create /sandbox/trunk, /sandbox/tags, /sandbox/branches > - move the current contents of /sandbox to /sandbox/trunk > > Then when you want to make a tag you just do a copy of the form > svn copy https://svn.apache.org/repos/asf/tomcat/sandbox/optional/path > https://svn.apache.org/repos/asf/tomcat/sandbox/tags/nameOfTag > > This way you can tag all of sandbox or just part of it. > > Let me know if you want me to make the top level changes to sandbox or > if you are happy making them yourself. > > Mark > > > - > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r345767 - in /tomcat/sandbox/java/org/apache/coyote/http11: Http11AprProcessor.java Http11Processor.java InternalAprInputBuffer.java InternalInputBuffer.java
Author: costin
Date: Sun Nov 20 10:19:56 2005
New Revision: 345767
URL: http://svn.apache.org/viewcvs?rev=345767&view=rev
Log:
Remove even more dups. It seems the apr and non-apr were not actually in
sync, there are at least 2 places where extra SecurityManager magic was
used in non-apr.
Modified:
tomcat/sandbox/java/org/apache/coyote/http11/Http11AprProcessor.java
tomcat/sandbox/java/org/apache/coyote/http11/Http11Processor.java
tomcat/sandbox/java/org/apache/coyote/http11/InternalAprInputBuffer.java
tomcat/sandbox/java/org/apache/coyote/http11/InternalInputBuffer.java
Modified: tomcat/sandbox/java/org/apache/coyote/http11/Http11AprProcessor.java
URL:
http://svn.apache.org/viewcvs/tomcat/sandbox/java/org/apache/coyote/http11/Http11AprProcessor.java?rev=345767&r1=345766&r2=345767&view=diff
==
--- tomcat/sandbox/java/org/apache/coyote/http11/Http11AprProcessor.java
(original)
+++ tomcat/sandbox/java/org/apache/coyote/http11/Http11AprProcessor.java Sun
Nov 20 10:19:56 2005
@@ -19,12 +19,11 @@
import java.io.ByteArrayInputStream;
import java.io.IOException;
import java.io.InterruptedIOException;
-import java.net.InetAddress;
+import java.security.cert.CertificateFactory;
+import java.security.cert.X509Certificate;
import java.util.StringTokenizer;
import java.util.regex.Pattern;
import java.util.regex.PatternSyntaxException;
-import java.security.cert.CertificateFactory;
-import java.security.cert.X509Certificate;
import org.apache.coyote.ActionCode;
import org.apache.coyote.ActionHook;
@@ -32,6 +31,7 @@
import org.apache.coyote.Request;
import org.apache.coyote.RequestInfo;
import org.apache.coyote.Response;
+import org.apache.coyote.http11.filters.BufferedInputFilter;
import org.apache.coyote.http11.filters.ChunkedInputFilter;
import org.apache.coyote.http11.filters.ChunkedOutputFilter;
import org.apache.coyote.http11.filters.GzipOutputFilter;
@@ -40,7 +40,6 @@
import org.apache.coyote.http11.filters.SavedRequestInputFilter;
import org.apache.coyote.http11.filters.VoidInputFilter;
import org.apache.coyote.http11.filters.VoidOutputFilter;
-import org.apache.coyote.http11.filters.BufferedInputFilter;
import org.apache.tomcat.jni.Address;
import org.apache.tomcat.jni.SSL;
import org.apache.tomcat.jni.SSLSocket;
@@ -64,20 +63,7 @@
*/
public class Http11AprProcessor extends Http11Processor implements ActionHook {
-
-/**
- * Logger.
- */
-protected static org.apache.commons.logging.Log log
-=
org.apache.commons.logging.LogFactory.getLog(Http11AprProcessor.class);
-
-/**
- * The string manager for this package.
- */
-protected static StringManager sm =
-StringManager.getManager(Constants.Package);
-
-
+
// --- Constructors
@@ -92,643 +78,52 @@
}
inputBuffer = new InternalAprInputBuffer(request, headerBufferSize,
readTimeout);
-request.setInputBuffer(inputBuffer);
-
-response = new Response();
-response.setHook(this);
-outputBuffer = new InternalAprOutputBuffer(response, headerBufferSize);
-response.setOutputBuffer(outputBuffer);
-request.setResponse(response);
-
-ssl = !"off".equalsIgnoreCase(endpoint.getSSLEngine());
-
-initializeFilters();
-
-// Cause loading of HexUtils
-int foo = HexUtils.DEC[0];
-
-// Cause loading of FastHttpDateFormat
-FastHttpDateFormat.getCurrentDate();
-
-}
-
-
-// - Instance Variables
-
-
-/**
- * Associated adapter.
- */
-protected Adapter adapter = null;
-
-
-/**
- * Request object.
- */
-protected Request request = null;
-
-
-/**
- * Response object.
- */
-protected Response response = null;
-
-
-/**
- * Input.
- */
-protected InternalAprInputBuffer inputBuffer = null;
-
-
-/**
- * Output.
- */
-protected InternalAprOutputBuffer outputBuffer = null;
-
-
-/**
- * State flag.
- */
-protected boolean started = false;
-
-
-/**
- * Error flag.
- */
-protected boolean error = false;
-
-
-/**
- * Keep-alive.
- */
-protected boolean keepAlive = true;
-
-
-/**
- * HTTP/1.1 flag.
- */
-protected boolean http11 = true;
-
-
-/**
- * HTTP/0.9 flag.
- */
-protected boolean http09 = false;
-
-
-/**
- * Sendfile data.
- */
-protected AprEndpoint.SendfileData sendfileData = null;
-
-
-/**
- * Content delimitator for the request (if false, the connection will
- * be closed at the end of the request).
- */
-protected boolean contentDelimitation = true;
-
-
-/**
- * Is there an expectation ?
- */
-protected boolean expectation = false;
-
-
-/**
- * List of
Re: [VOTE] APR or NIO ?
Costin Manolache wrote: On 11/19/05, Remy Maucherat <[EMAIL PROTECTED]> wrote: Costin Manolache wrote: < > 1. Yes, it's how things should be done < > 2. No, it can be done better My opionion is (2). My opinion is 1. I will not participate in the design of the upcoming Tomcat branch, then. Well, I'm not planning any 'upcoming branch' - or 'design' for that matter, just small adjustments, in sandbox first. Fair enough. The minute you commit your "refactoring" to the main branch, I will leave this project (besides casual bugfixing). Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: svn commit: r345767 - in /tomcat/sandbox/java/org/apache/coyote/http11: Http11AprProcessor.java Http11Processor.java InternalAprInputBuffer.java InternalInputBuffer.java
[EMAIL PROTECTED] wrote: Author: costin Date: Sun Nov 20 10:19:56 2005 New Revision: 345767 URL: http://svn.apache.org/viewcvs?rev=345767&view=rev Log: Remove even more dups. It seems the apr and non-apr were not actually in sync, there are at least 2 places where extra SecurityManager magic was used in non-apr. Modified: tomcat/sandbox/java/org/apache/coyote/http11/Http11AprProcessor.java tomcat/sandbox/java/org/apache/coyote/http11/Http11Processor.java tomcat/sandbox/java/org/apache/coyote/http11/InternalAprInputBuffer.java tomcat/sandbox/java/org/apache/coyote/http11/InternalInputBuffer.java I am not going to bother tetsing this stuff. As you may have noticed, many of the algorithms used behaves in subtly different ways. The result of the merge is of course going to be exponentially more difficult to maintain (and, obviously, I am not going to be the one doing it). Why not removing APR support instead since you (and all the other members of the community, it seems) don't like it ? As for the security manager magic, I refactored some of it. As HTTP on java.io is robust, well tested, but not optimal anyway, I didn't bother porting back those simplifications. Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Bug report for Tomcat 3 [2005/11/20]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=CriticalMAJ=Major | | | | MIN=Minor NOR=Normal ENH=Enhancement | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | | 2350|Ver|Nor|2001-06-27|ServletConfig.getInitParameter() requires url-patt| | 2478|Opn|Cri|2001-07-06|Passing Session variables between JSP's and Servle| | 4551|Opn|Nor|2001-10-31|Ctx( /tt01 ): IOException in: R( /tt01 + /com/abc/| | 4980|New|Min|2001-11-20|Startup message indicates incorrect log file | | 4994|New|Nor|2001-11-21|Tomcat needs a mechanism for clean and certain shu| | 5064|New|Cri|2001-11-25|Socket write error when include files is more than| | 5108|New|Maj|2001-11-26|Docs for Tomcat 3.2.x appear to be for Tomcat 3.3 | | 5137|New|Nor|2001-11-27|Null pointer in class loader after attempting to r| | 5160|Unc|Maj|2001-11-28|'IllegalStateException' | | 5331|New|Nor|2001-12-09|getPathInfo vs URL normalization | | 5510|New|Blk|2001-12-19|How to call ejb deployed in JBoss from Tomcat serv| | 5756|New|Nor|2002-01-08|jspc.bat exits with wrong ERRORLEVEL | | 5797|New|Nor|2002-01-10|UnCatched ? StringIndexOutOfBoundsException: Strin| | 6027|New|Maj|2002-01-25|Tomcat Automatically shuts down as service | | 6168|New|Blk|2002-02-01|IllegalStateException | | 6451|New|Cri|2002-02-14|Stackoverflow | | 6478|New|Enh|2002-02-14|Default Tomcat Encoding | | 6488|Ver|Maj|2002-02-15|Error: 304. Apparent bug in default ErrorHandler c| | 6648|New|Nor|2002-02-25|jakarta-servletapi build with java 1.4 javadoc err| | 6702|New|Cri|2002-02-27|win 2k services not working | | 6796|New|Cri|2002-03-01|Tomcat dies periodically | | 6989|New|Maj|2002-03-08|Unable to read tld file during parallel JSP compil| | 7013|New|Cri|2002-03-10|Entering a servlet path with non-ISO8859-1 charact| | 7227|New|Nor|2002-03-19| directive don't work | | 7626|New|Nor|2002-03-29|classloader not working properly | | 7652|New|Cri|2002-04-01|Tomcat stalls periodically| | 7785|New|Blk|2002-04-06|tomcat bug in context reloading | | 7863|New|Maj|2002-04-09|I have a problem when running Tomcat with IIS | | 8187|New|Cri|2002-04-17|Errors when Tomcat used with MS Access database | | 8239|New|Cri|2002-04-18|Resource temporary unavailable| | 8263|New|Cri|2002-04-18|url-pattern easy to circumvent| | 9250|New|Maj|2002-05-20|outOfMemoryError | | 9367|New|Maj|2002-05-23|HttpSessionBindingEvent not thrown for HttpSession| | 9390|New|Nor|2002-05-24|jasper compilation error in tomcat| | 9480|New|Nor|2002-05-29|Data connection pooling | | 9607|New|Maj|2002-06-04|precompile JSP| | 9737|Ver|Nor|2002-06-10|ArrayIndexOutOfBoundsException when sending just p| |10047|New|Cri|2002-06-20|IllegalStateException | |10202|New|Maj|2002-06-25|Tomcat is not responding in time | |10357|Unc|Blk|2002-06-30|java.lang.IllegalArgumentException: Short Read| |10406|New|Cri|2002-07-02|IllegalStateException | |11087|New|Blk|2002-07-23|IllegalStateException | |11286|New|Maj|2002-07-30|Tomcat threads not respond if increase JVM size | |11466|New|Nor|2002-08-05|ContextManager: SocketException reading request | |12156|New|Cri|2002-08-29|Apache and Tomcat 3.3.1 Interworking problem | |12194|New|Maj|2002-08-30|Tomcat does not send WWW-Authenticate header | |12852|New|Nor|2002-09-20|May be error in _jspService() -> out.flushBuffers(| |14386|New|Maj|2002-11-08|Date headers corrupted using setDateHeader| |15632|New|Nor|2002-12-23|Problem with the Tomcat Sessions Parameter on URL | |16363|New|Cri|2003-01-23|Stack Overflow accessing compiled JSP - Tomcat 3.2| |17081|New|Min|2003-02-14|Some javadoc comment fixes| |17915|New|Maj|2003
Bug report for Tomcat 5 [2005/11/20]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=CriticalMAJ=Major | | | | MIN=Minor NOR=Normal ENH=Enhancement | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |17310|Ver|Nor|2003-02-22|;jsessionid confuses StandardHostcan't find Co| |19803|Ver|Maj|2003-05-09|manager reload fails and disables app - Incompatib| |19958|Ver|Maj|2003-05-15|Problems reading ServletInputStream | |21045|Ver|Nor|2003-06-24|Manager app does find resources | |21600|Ver|Nor|2003-07-15|'s lost after manager stop/start or rel| |22679|Ver|Enh|2003-08-24|how to access ssl session ID out of tomcat to prev| |22986|Ver|Nor|2003-09-08|Web apps with context XML file don't start if CATA| |24413|Ver|Nor|2003-11-04|bundled JMX implementation not compliant to specif| |24943|Ver|Nor|2003-11-24|Tomcat 5.0.14 / Windows 2000 Service does not star| |25078|Ver|Nor|2003-11-29|Catalina Ant Serverinfo task always fails | |27338|Ver|Maj|2004-03-01|Wrong mappings for JSP Documents (.jspx) | |28039|New|Enh|2004-03-30|Cluster Support for SingleSignOn | |28633|New|Nor|2004-04-27|Add JMX Support to ClusterManager | |28634|New|Nor|2004-04-27|Extend StandardManager/StandardSession for DeltaMa| |28709|Ver|Nor|2004-04-30|javax.servlet.http.HttpServletRequest.isRequestedS| |28875|Ver|Nor|2004-05-10|Multi-byte characters in default error page aren't| |29091|Opn|Nor|2004-05-19|Non-ascii characters are not handled correctly... | |29160|Ver|Enh|2004-05-23|precompile problem: _jspx_meth_* (javax.servlet.js| |29494|Opn|Enh|2004-06-10|No way to set PATH when running as a service on Wi| |29497|Unc|Nor|2004-06-10|Connection pool, redeployment | |29521|Ver|Cri|2004-06-11|No destroy methods called on service shutdown | |30241|Ver|Enh|2004-07-21|Enhance build script to use branch argument when c| |30833|Ver|Nor|2004-08-24|request.getServerPort() returns wrong port (WAS: r| |31125|Opn|Nor|2004-09-08|conf/web.xml not valid| |31804|Opn|Maj|2004-10-20|setParent() is not called on nested tags in a tag | |32081|Inf| |2004-11-05|Wrapper scripts require a JDK to be present. | |32180|New|Nor|2004-11-11|EL functions are executed in privileged context | |32280|Ver|Cri|2004-11-17|Problem clustering tomcat when a failed server is | |32569|Ass|Nor|2004-12-07|ServletContextListener will not die | |32593|Inf|Maj|2004-12-09|Server (Apache 2.0.48) reached MaxClients setting | |32754|Inf|Nor|2004-12-17|Can't modify thread configuration attributes of AJ| |32832|Ver|Maj|2004-12-23|request.getSession(false) fails to return null. | |33180|Ver|Nor|2005-01-20|JSTL automatic type conversion gives unexpected re| |33262|Inf|Nor|2005-01-27|Service Manager autostart should check for adminis| |33356|Inf|Maj|2005-02-02|Incorrect parsing of tag attributes | |33407|Inf|Nor|2005-02-05|\$ is quoted even with el-ignored=true| |33453|Opn|Enh|2005-02-08|Jasper should recompile JSP files whose datestamps| |33494|New|Enh|2005-02-10|jscv configure script fails on x86_64 | |33650|Inf|Enh|2005-02-19|Jasper performance for multiple files processing | |33671|Opn|Enh|2005-02-21|Manual Windows service installation with custom na| |33831|Ver|Nor|2005-03-03|RequestDispatcher.forward and resource missing| |34006|Ver|Nor|2005-03-14|Undeploy of webapps with antiResourceLocking in ME| |34016|Ver|Nor|2005-03-15|antiResourceLocking webapp fails to deploy on Tomc| |34033|Ver|Nor|2005-03-16|Cannot delete users using Administration Tool weba| |34076|Inf|Nor|2005-03-18|overriding content.xml docBase with manager webapp| |34319|New|Nor|2005-04-06|StoreBase.processExpires() is very inefficient| |34396|Inf| |2005-04-11|security exception using datasource in| |35606|New|Maj|2005-07-05|Problem with Session cookies and multiple webapps | |35635|New|Nor|2005-07-06|Tomcat service does not log startup error messages| |35710|New|Enh|2005-07-12|Enable Session Replication via Cross Context calls| |35715|New|Nor|2005-07-13|Buffering in JK needs to be configurable for IIS | |35746|Inf
Bug report for Tomcat 4 [2005/11/20]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=CriticalMAJ=Major | | | | MIN=Minor NOR=Normal ENH=Enhancement | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | | 3839|Opn|Enh|2001-09-26|Problem bookmarking login page| | 4227|Opn|Enh|2001-10-17|Invalid CGI path | | 5329|New|Enh|2001-12-08|NT Service exits startup before Tomcat is finished| | 5795|New|Enh|2002-01-10|Catalina Shutdown relies on localhost causing prob| | 5829|New|Enh|2002-01-13|StandardManager needs to cope with sessions throwi| | 5985|New|Enh|2002-01-23|Tomcat should perform a more restrictive validatio| | 6600|Opn|Enh|2002-02-20|enodeURL adds 'jsession' when 'isRequestedSessionI| | 6614|New|Enh|2002-02-21|Have Bootstrap and StandardClassLoader use the sam| | 6671|New|Enh|2002-02-25|Simple custom tag example uses old declaration sty| | 7043|New|Enh|2002-03-12|database user and password for JDBC Based Store | | 7374|New|Enh|2002-03-22|Apache Tomcat/4.0.1 message on standard output| | 7676|New|Enh|2002-04-02|Allow name property to use match experssions in without className in server.xml produces N| |11069|Opn|Enh|2002-07-23|Tomcat not flag error if tld is outside of /WEB-IN| |11129|New|Enh|2002-07-24|New valve for putting the sessionIDs in the reques| |11248|New|Enh|2002-07-29|DefaultServlet doesn't send expires header| |11754|Opn|Enh|2002-08-15|Synchronous shutdown script - shutdown.sh should w| |12069|New|Enh|2002-08-27|Creation of more HttpSession objects for one previ| |12658|New|Enh|2002-09-15|a proxy host and port at the element level | |12766|New|Enh|2002-09-18|Tomcat should use tld files in /WEB-INF/ over vers| |13040|New|Nor|2002-09-26|can't retrieve external context who's uri is a sub| |13309|Opn|Enh|2002-10-04|Catalina calls System.exit() | |13634|New|Enh|2002-10-15|Allowing system properties to be substituted in co| |13689|Opn|Enh|2002-10-16|Classloader paths for 'Common' classes and librari| |13731|New|Enh|2002-10-17|Final request, response, session and other variabl| |13846|New|Nor|2002-10-22|If-Modified-Since results in incorrect headers| |13941|New|Enh|2002-10-24|reload is VERY slow | |13965|New|Enh|2002-10-25|Catalina.sh correction request for Tru64 Unix | |13983|New|Nor|2002-10-25|RMI call from Web Application throws SocketExcepti| |14097|New|Enh|2002-10-30|hardcoded registry value for vm lets tomcat servic| |14416|New|Enh|2002-11-10|blank tag name in TLD cause NullPointerException | |14635|New|Enh|2002-11-18|Should be possible not to have -MM-DD in log f| |14766|New|Enh|2002-11-22|Redirect Vavle| |14993|New|Enh|2002-12-02|Possible obselete synchronized declaration| |15115|New|Enh|2002-12-05|correct docs... XML parser *cannot* be overridden | |15417|Opn|Enh|2002-12-16|Add port for forced compilation of JSP pages | |15570|New|Nor|2002-12-20|incorrect role-name mapping for "*" with respect t| |15688|New|Enh|2002-12-27|full-qualified names instead of imports | |15893|New|Enh|2003-01-08|Need a getPort() method on Connector or similar fu| |15941|New|Enh|2003-01-10|Expose rootCause exceptions at deeper levels | |15946|New|Nor|2003-01-10|Documentation change | |16185|New|Nor|2003-01-16|UserDatabase is not bound in this context | |16294|New|Enh|2003-01-21|Configurable URL Decoding.| |16357|New|Enh|2003-01-23|"connection timeout reached" | |16531|New|Enh|2003-01-29|Updating already deployed ".war" files in a single| |16579|New|Enh|2003-01-30|documentation page layout/style breaks wrapping to| |16596|New|Enh|2003-01-30|option for disabling log rotation | |17070|New|Enh|2003-02-14|The Catalina Ant tasks do not allow for 'reusable'| |17146|New|Enh|2003-02-18|Simplify build.xml using whose target performs a 'forward' do| |21669|New|Enh|2003-07-16|JNDIRealm roleBase pattern enahncement| |21804|New|Enh|2003-07-22|Tomcat ignores "allowLinking" resource on DefaultC| |22113|New|Enh|2003-08-04|Improvable E
Bug report for Watchdog [2005/11/20]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=CriticalMAJ=Major | | | | MIN=Minor NOR=Normal ENH=Enhancement | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | | 278|Unc|Nor|2000-12-04|Bug in GetParameterValuesTestServlet.java file Bug| | 279|Unc|Nor|2000-12-04|Logical Error in GetParameterValuesTestServlet Bug| | 469|Unc|Nor|2001-01-17|in example-taglib.tld "urn" should be "uri" BugRat| | 470|Unc|Nor|2001-01-17|FAIL positiveForward.jsp and positiveInclude.jsp B| | 9634|New|Enh|2002-06-05|No tests exist for ServletContext.getResourcePaths| |10703|New|Enh|2002-07-11|Need to test getRequestURI after RequestDispatcher| |11336|New|Enh|2002-07-31|Test wrapped path methods with RD.foward()| |11663|New|Maj|2002-08-13|JSP precompile tests rely on Jasper specific behav| |11664|New|Maj|2002-08-13|A sweep is needed of all Watchdog 4.0 tag librarie| |11665|New|Maj|2002-08-13|ServletToJSPErrorPageTest and ServletToServletErro| |11666|New|Maj|2002-08-13|SetBufferSize_1TestServlet is invalid.| |14004|New|Maj|2002-10-28|Incorrent behaviour of all attribute-related lifec| |15504|New|Nor|2002-12-18|JSP positiveGetValues test relies on order preserv| |24649|New|Nor|2003-11-12|getRemoteHost fails when agent has uppercase chara| |29398|New|Nor|2004-06-04|Update site and note current status | +-+---+---+--+--+ | Total 15 bugs | +---+ - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: JAAS Realm not working since 5.5.10 (possible solution provided)
Markus Plail <[EMAIL PROTECTED]> writes: > I recently wanted to upgrade to Tomcat 5.5.12 from 5.5.9. I use JAAS > realm with a custom implementation of LoginModule. I couldn't > authenticate myself with any of the username password combinations. So > I tried 5.5.11 and 5.5.10 but nothing changed. > > The debug trace looked very strange (see my post on tomcat-user), so I > decided to dig into the code and see what is happening. To make a long > story short I think I found a bug. > > In RealmBase hasResourcePermission(...) calls > request.getUserPrincipal() to get the principal and then calls > hasRole(...) to see if the principal has the necessary > role. hasRole(...) only succeeds if the principal is an instance of > GenericPrincipal, but request.getUserPrincipal() checks if the > principal is an instance of GenericPrincipal and if this is the case, > it returns the underlying principal. Thus I don't think that a > JAASRealm based login can ever succeed in Tomcat > 5.5.9. > > I removed the if clause and just return the principal and now my login > is working beautifully again. Not a single answer? Can't it be reproduced or what's the problem with my problem? If I am right it would be a significant issue wouldn't it? regards Markus - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: JAAS Realm not working since 5.5.10 (possible solution provided)
Markus Plail wrote: Not a single answer? Can't it be reproduced or what's the problem with my problem? If I am right it would be a significant issue wouldn't it? Sorry. Two bug reports about this, and should be fixed in CVS. Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [VOTE] APR or NIO ?
I hope you are not serious... Sorry if I sounded too critical of the APR code - it is a great piece of code in many ways, I just didn't like some (probably minor) things. If you have a problem with 'refactoring' - right now it is in sandbox, and I can as well change the package name and make it a completely separate connector. And I'm in no hurry to check anything in the main branch - the sandbox is prefect for me, so no need to worry about this. Costin On 11/20/05, Remy Maucherat <[EMAIL PROTECTED]> wrote: > Costin Manolache wrote: > > On 11/19/05, Remy Maucherat <[EMAIL PROTECTED]> wrote: > > > >>Costin Manolache wrote: > >> > >>>< > 1. Yes, it's how things should be done > >>>< > 2. No, it can be done better > >>> > >>>My opionion is (2). > >> > >>My opinion is 1. I will not participate in the design of the upcoming > >>Tomcat branch, then. > > > > Well, I'm not planning any 'upcoming branch' - or 'design' for that > > matter, just > > small adjustments, in sandbox first. > > Fair enough. The minute you commit your "refactoring" to the main > branch, I will leave this project (besides casual bugfixing). > > Rémy > > - > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: svn commit: r345767 - in /tomcat/sandbox/java/org/apache/coyote/http11: Http11AprProcessor.java Http11Processor.java InternalAprInputBuffer.java InternalInputBuffer.java
On 11/20/05, Remy Maucherat <[EMAIL PROTECTED]> wrote: > [EMAIL PROTECTED] wrote: > > Author: costin > > Date: Sun Nov 20 10:19:56 2005 > > New Revision: 345767 > > > > URL: http://svn.apache.org/viewcvs?rev=345767&view=rev > > Log: > > Remove even more dups. It seems the apr and non-apr were not actually in > > sync, there are at least 2 places where extra SecurityManager magic was > > used in non-apr. > > > > Modified: > > tomcat/sandbox/java/org/apache/coyote/http11/Http11AprProcessor.java > > tomcat/sandbox/java/org/apache/coyote/http11/Http11Processor.java > > tomcat/sandbox/java/org/apache/coyote/http11/InternalAprInputBuffer.java > > tomcat/sandbox/java/org/apache/coyote/http11/InternalInputBuffer.java > > I am not going to bother tetsing this stuff. As you may have noticed, > many of the algorithms used behaves in subtly different ways. The result > of the merge is of course going to be exponentially more difficult to > maintain (and, obviously, I am not going to be the one doing it). Why > not removing APR support instead since you (and all the other members of > the community, it seems) don't like it ? I didn't say I don't like it - I like having APR support very much, and I like APR more than I like NIO. I don't like 'alghoritms that behave in sublty different ways', or duplicating extremely complex classes just for 3-4 lines of code that is different. I know it is simpler to write and probably maintain the code ( for people who wrote it ), but not easier to understand for me. In any case - it's sandbox. People can try things in sandbox - many may not work. Think of this as a way for me to understand those subtle alghoritms by seeing what is really different. Costin - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
