Re: Is the JSSE15SocketFactory class missing from the standard tomcat 5.5.12 binary distribution?

2005-11-18 Thread Cédrik LIME
+1 on building with 1.5 by default, *as long as 
it doesn't preventing tc from running on 1.4* (we 
use tc 5.5 / Java 1.4 in production right now, 
with no sign of switching JDK in the near future).

If it breaks 1.4 compatibility, wait for tc 6.0 to switch compiler version.

How about building Java 5-specific parts of tc in 
a separate jar? Would that solve the problem?
I use this technique in a project of mine 
(shameless plug:  :-)) and it works great.


Cédrik

At 19:13 17/11/2005 -0800, you wrote:

Hi,
Mmm, I'm not sure.  The download page is already somewhat cluttered with a
bunch of different distributions and their assorted files (zip/tar.gz, PGP and
MD5 for each, etc.)  I don't want to double the number of binary distributions
per release.

And I'm even less excited about doing something like retroweaver
(http://retroweaver.sourceforge.net/) to cross-compile 1.5 source to 1.4
compatibility.

But perhaps it's time we just start building with J2SE 5.0 by default, instead
of 1.4?

Yoav

--- Bruce Keats <[EMAIL PROTECTED]> wrote:

> Is is possible to put 5.0 JSK version up on the downloads site? I can
> certainly build the missing JSSE components, 
but I would rather stick with a

> prebuilt official version.
>  Bruce
>
>  On 11/17/05, Yoav Shapira <[EMAIL PROTECTED]> wrote:
> >
> > Hi,
> > Bill is correct.
> >
> > I do have both the 1.4 and 5.0 JDKs on my build machine. I wonder if we
> > should
> > change the build.xml to build both if both are present, rather than just
> > one.
> > Would we have multiple JAVA_HOMEs? Seems dirty...
> >
> > Yoav
> >
> > --- Bill Barker <[EMAIL PROTECTED]> wrote:
> >
> > > I believe that Yoav creates the binary distro with a 1.4 JVM, so the
> > > 15SocketFactory is excluded.
> > >
> > > You need to compile at least JSSE15*.java. However it's probably easier
> > > to just build all of j-t-c/util.
[snip] 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Is the JSSE15SocketFactory class missing from the standard tomcat 5.5.12 binary distribution?

2005-11-18 Thread Remy Maucherat

Yoav Shapira wrote:

Hi,
Mmm, I'm not sure.  The download page is already somewhat cluttered with a
bunch of different distributions and their assorted files (zip/tar.gz, PGP and
MD5 for each, etc.)  I don't want to double the number of binary distributions
per release.

And I'm even less excited about doing something like retroweaver
(http://retroweaver.sourceforge.net/) to cross-compile 1.5 source to 1.4
compatibility.

But perhaps it's time we just start building with J2SE 5.0 by default, instead
of 1.4?


It's a bit risky though. Will the JSSE impl for 1.4 be built properly ?

Rémy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Any other functionality missing from Tomcat 5.5.12 that relies on JSDK 5.0?

2005-11-18 Thread Bruce Keats
Hi,
 Given the discussion on missing JSSE15SocketFactory because tomcat
5.5.12was build using JAVA
1.4, I am trying to determine if I need to rebuild the whole source tree
under JSDK 5.0 or just the missing JSSE15SocketFactory. In order to make
that judgement call, I need to understand if there is any other
functionality that is missing.
 Other than JSSE15SocketFactory, is there any other functionality missing
from tomcat 5.5.12 because it was build using JAVA 1.4?
 Bruce


DO NOT REPLY [Bug 37407] - file descriptor leak in jasper

2005-11-18 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37407


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED




--- Additional Comments From [EMAIL PROTECTED]  2005-11-18 16:09 ---
Makes sense to me: thanks for reporting this and investigating it.  Will apply.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r345501 - /tomcat/jasper/tc5.5.x/jasper2/src/share/org/apache/jasper/compiler/JspReader.java

2005-11-18 Thread yoavs
Author: yoavs
Date: Fri Nov 18 07:35:28 2005
New Revision: 345501

URL: http://svn.apache.org/viewcvs?rev=345501&view=rev
Log:
Bugzilla 37407 (http://issues.apache.org/bugzilla/show_bug.cgi?id=37407) and 
other minor additions to JspReader.  Kept Vector implementation class for 
sourceFiles as the code may rely on its thread-safety features, but improved to 
List interface style.

Modified:

tomcat/jasper/tc5.5.x/jasper2/src/share/org/apache/jasper/compiler/JspReader.java

Modified: 
tomcat/jasper/tc5.5.x/jasper2/src/share/org/apache/jasper/compiler/JspReader.java
URL: 
http://svn.apache.org/viewcvs/tomcat/jasper/tc5.5.x/jasper2/src/share/org/apache/jasper/compiler/JspReader.java?rev=345501&r1=345500&r2=345501&view=diff
==
--- 
tomcat/jasper/tc5.5.x/jasper2/src/share/org/apache/jasper/compiler/JspReader.java
 (original)
+++ 
tomcat/jasper/tc5.5.x/jasper2/src/share/org/apache/jasper/compiler/JspReader.java
 Fri Nov 18 07:35:28 2005
@@ -1,5 +1,5 @@
 /*
- * Copyright 1999,2004 The Apache Software Foundation.
+ * Copyright 1999,2004-2005 The Apache Software Foundation.
  * 
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -20,6 +20,7 @@
 import java.io.FileNotFoundException;
 import java.io.IOException;
 import java.io.InputStreamReader;
+import java.util.List;
 import java.util.Vector;
 import java.util.jar.JarFile;
 import java.net.URL;
@@ -48,26 +49,64 @@
 
 class JspReader {
 
-// Logger
+/**
+ * Logger.
+ */
 private Log log = LogFactory.getLog(JspReader.class);
 
+/**
+ * The current spot in the file.
+ */
 private Mark current;
+
+/**
+ * What is this?
+ */
 private String master;
-private Vector sourceFiles;
+
+/**
+ * The list of source files.
+ */
+private List sourceFiles;
+
+/**
+ * The current file ID (-1 indicates an error or no file).
+ */
 private int currFileId;
+
+/**
+ * Seems redundant.
+ */
 private int size;
+
+/**
+ * The compilation context.
+ */
 private JspCompilationContext context;
+
+/**
+ * The Jasper error dispatcher.
+ */
 private ErrorDispatcher err;
 
-/*
+/**
  * Set to true when using the JspReader on a single file where we read up
  * to the end and reset to the beginning many times.
  * (as in ParserController.figureOutJspDocument()).
  */
 private boolean singleFile;
 
-/*
+/**
  * Constructor.
+ *
+ * @param ctxt The compilation context
+ * @param fname The file name
+ * @param encoding The file encoding
+ * @param jarFile ?
+ * @param err The error dispatcher
+ * @throws JasperException If a Jasper-internal error occurs
+ * @throws FileNotFoundException If the JSP file is not found (or is 
unreadable)
+ * @throws IOException If an IO-level error occurs, e.g. reading the file
  */
 public JspReader(JspCompilationContext ctxt,
  String fname,
@@ -81,8 +120,9 @@
  err);
 }
 
-/*
- * Constructor.
+/**
+ * Constructor: same as above constructor but with initialized reader
+ * to the file given.
  */
 public JspReader(JspCompilationContext ctxt,
  String fname,
@@ -100,7 +140,7 @@
 pushFile(fname, encoding, reader);
 }
 
-/*
+/**
  * @return JSP compilation context with which this JspReader is 
  * associated
  */
@@ -108,10 +148,22 @@
 return context;
 }
 
-String getFile(int fileid) {
-return (String) sourceFiles.elementAt(fileid);
+/**
+ * Returns the file at the given position in the list.
+ *
+ * @param fileid The file position in the list
+ * @return The file at that position, if found, null otherwise
+ */
+String getFile(final int fileid) {
+return (String) sourceFiles.get(fileid);
 }
-
+   
+/**
+ * Checks if the current file has more input.
+ *
+ * @return True if more reading is possible
+ * @throws JasperException if an error occurs
+ */ 
 boolean hasMoreInput() throws JasperException {
 if (current.cursor >= current.stream.length) {
 if (singleFile) return false; 
@@ -476,11 +528,14 @@
  *
  * @return The index of the now registered file.
  */
-private int registerSourceFile(String file) {
-if (sourceFiles.contains(file))
+private int registerSourceFile(final String file) {
+if (sourceFiles.contains(file)) {
 return -1;
-sourceFiles.addElement(file);
+}
+
+sourceFiles.add(file);
 this.size++;
+
 return sourceFiles.size() - 1;
 }
 
@@ -493,10 +548,12 @@
  *
  * @return The index of the now registered file.
  */
-private int unregist

svn commit: r345502 - /tomcat/container/tc5.5.x/webapps/docs/changelog.xml

2005-11-18 Thread yoavs
Author: yoavs
Date: Fri Nov 18 07:35:53 2005
New Revision: 345502

URL: http://svn.apache.org/viewcvs?rev=345502&view=rev
Log:
Bugzilla 37407: http://issues.apache.org/bugzilla/show_bug.cgi?id=37407

Modified:
tomcat/container/tc5.5.x/webapps/docs/changelog.xml

Modified: tomcat/container/tc5.5.x/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewcvs/tomcat/container/tc5.5.x/webapps/docs/changelog.xml?rev=345502&r1=345501&r2=345502&view=diff
==
--- tomcat/container/tc5.5.x/webapps/docs/changelog.xml (original)
+++ tomcat/container/tc5.5.x/webapps/docs/changelog.xml Fri Nov 18 07:35:53 2005
@@ -133,6 +133,10 @@
 37062: Helpful JSP exception message containing file, line 
numbers.  Patch by
 Tim Fennell at http://www.tfenne.com/jasper/. (yoavs)
   
+  
+37407: File descriptor leak in JspReader.  Thanks to Fred 
for the patch.  I also
+did some minor cleanup in the class. (yoavs)
+  
 
   
   



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 37407] - file descriptor leak in jasper

2005-11-18 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37407


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2005-11-18 16:36 ---
Fixed.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 36922] - setup.sh file mis-advertised and missing

2005-11-18 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=36922


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|NEEDINFO




--- Additional Comments From [EMAIL PROTECTED]  2005-11-18 16:44 ---
It CAN be in two places: first it's in the tar.gz file, then it's wherever you
expand the tar.gz file.

But let's try this: please provide the text you'd like to see on the setup
documentation page.  I'll be glad to apply any clarifications or further
explanations on the documentation that make you happy.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 32081] - Wrapper scripts require a JDK to be present.

2005-11-18 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=32081


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |NEEDINFO




--- Additional Comments From [EMAIL PROTECTED]  2005-11-18 16:46 ---
Ben, any luck putting together the same type of patch for the Windows batch
scripts?  If you have it, I'll gladly look at / apply it.

Las, besides not being able to reproduce what you're claiming, I'm not sure it's
related to this specific Bugzilla issue.  I'd try asking on the
users@tomcat.apache.org list if I were you.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r345508 - in /tomcat/container/tc5.5.x: catalina/src/bin/catalina.sh catalina/src/bin/setclasspath.sh catalina/src/bin/startup.sh webapps/docs/changelog.xml

2005-11-18 Thread yoavs
Author: yoavs
Date: Fri Nov 18 07:54:56 2005
New Revision: 345508

URL: http://svn.apache.org/viewcvs?rev=345508&view=rev
Log:
Bugzilla 37284: http://issues.apache.org/bugzilla/show_bug.cgi?id=37284

Modified:
tomcat/container/tc5.5.x/catalina/src/bin/catalina.sh
tomcat/container/tc5.5.x/catalina/src/bin/setclasspath.sh
tomcat/container/tc5.5.x/catalina/src/bin/startup.sh
tomcat/container/tc5.5.x/webapps/docs/changelog.xml

Modified: tomcat/container/tc5.5.x/catalina/src/bin/catalina.sh
URL: 
http://svn.apache.org/viewcvs/tomcat/container/tc5.5.x/catalina/src/bin/catalina.sh?rev=345508&r1=345507&r2=345508&view=diff
==
--- tomcat/container/tc5.5.x/catalina/src/bin/catalina.sh (original)
+++ tomcat/container/tc5.5.x/catalina/src/bin/catalina.sh Fri Nov 18 07:54:56 
2005
@@ -45,9 +45,11 @@
 # OS specific support.  $var _must_ be set to either true or false.
 cygwin=false
 os400=false
+darwin=false
 case "`uname`" in
 CYGWIN*) cygwin=true;;
 OS400*) os400=true;;
+Darwin*) darwin=true;;
 esac
 
 # resolve links - $0 may be a softlink

Modified: tomcat/container/tc5.5.x/catalina/src/bin/setclasspath.sh
URL: 
http://svn.apache.org/viewcvs/tomcat/container/tc5.5.x/catalina/src/bin/setclasspath.sh?rev=345508&r1=345507&r2=345508&view=diff
==
--- tomcat/container/tc5.5.x/catalina/src/bin/setclasspath.sh (original)
+++ tomcat/container/tc5.5.x/catalina/src/bin/setclasspath.sh Fri Nov 18 
07:54:56 2005
@@ -10,9 +10,14 @@
 
 # Make sure prerequisite environment variables are set
 if [ -z "$JAVA_HOME" -a -z "$JRE_HOME" ]; then
-  echo "Neither the JAVA_HOME nor the JRE_HOME environment variable is defined"
-  echo "At least one of these environment variable is needed to run this 
program"
-  exit 1
+  # Bugzilla 37284
+  if $darwin && [ -d 
"/System/Library/Frameworks/JavaVM.framework/Versions/1.5/Home" ]; then
+export 
JAVA_HOME="/System/Library/Frameworks/JavaVM.framework/Versions/1.5/Home"
+  else
+echo "Neither the JAVA_HOME nor the JRE_HOME environment variable is 
defined"
+echo "At least one of these environment variable is needed to run this 
program"
+exit 1
+  fi
 fi
 if [ -z "$JAVA_HOME" -a "$1" = "debug" ]; then
   echo "JAVA_HOME should point to a JDK in order to run in debug mode."

Modified: tomcat/container/tc5.5.x/catalina/src/bin/startup.sh
URL: 
http://svn.apache.org/viewcvs/tomcat/container/tc5.5.x/catalina/src/bin/startup.sh?rev=345508&r1=345507&r2=345508&view=diff
==
--- tomcat/container/tc5.5.x/catalina/src/bin/startup.sh (original)
+++ tomcat/container/tc5.5.x/catalina/src/bin/startup.sh Fri Nov 18 07:54:56 
2005
@@ -7,9 +7,11 @@
 
 # Better OS/400 detection: see Bugzilla 31132
 os400=false
+darwin=false
 case "`uname`" in
 CYGWIN*) cygwin=true;;
 OS400*) os400=true;;
+Darwin*) darwin=true;;
 esac
 
 # resolve links - $0 may be a softlink

Modified: tomcat/container/tc5.5.x/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewcvs/tomcat/container/tc5.5.x/webapps/docs/changelog.xml?rev=345508&r1=345507&r2=345508&view=diff
==
--- tomcat/container/tc5.5.x/webapps/docs/changelog.xml (original)
+++ tomcat/container/tc5.5.x/webapps/docs/changelog.xml Fri Nov 18 07:54:56 2005
@@ -43,6 +43,9 @@
 Added Eclipse .project, .classpath, and associated files to make 
building Tomcat from
 Eclipse significantly easier. (markt)
   
+   
+37284: Guess JSE 5.0 location on Mac OS X, patch by Stepan 
Koltsov. (yoavs)
+  
 
   
   



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 37284] - guess JDK location on Mac OS X

2005-11-18 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37284


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2005-11-18 16:55 ---
Thanks for submitting this enhancement.  I've applied it for 5.5.13.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 37285] - POST of document through CGI

2005-11-18 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37285


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |NEEDINFO




--- Additional Comments From [EMAIL PROTECTED]  2005-11-18 16:56 ---
Just so I understand, you're requesting that we modify the CGIServlet to not
echo query parameters and not count them in the content-length of the response?

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 37285] - POST of document through CGI

2005-11-18 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37285





--- Additional Comments From [EMAIL PROTECTED]  2005-11-18 17:55 ---
In comparing Tomcat CGI implementation with Apache 2, when a POST of content 
type text/xml occurs for Apache the query parameters are not included as part 
of the content (posted XML document).  Through scripts it is possible to 
identify and strip off the line containing the query parameters, but this seems 
unnecessary.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Any other functionality missing from Tomcat 5.5.12 that relies on JSDK 5.0?

2005-11-18 Thread Costin Manolache
Check the build.xml files, look for 'unless'.

Probably the right solution to avoid this would be to stop using
'unless' and ant checks,
and instead move all the 'conditional' code in separate targets and
jar files. In particular, the
whole SSL stuff is an unpredictible mess.

I'm not even sure if/how can we use OpenSSL via APR ( I found some
code, and it should work ). The whole connection layer should be
refactored to allow better abstraction for APR, NIO, old-style
sockets/threads... The current approach in APR ( duplicate everything
) may be good for quick tests, but it can't be the long term solution
( some people like to add a NIO equivalent ).

Costin

On 11/18/05, Bruce Keats <[EMAIL PROTECTED]> wrote:
> Hi,
>  Given the discussion on missing JSSE15SocketFactory because tomcat
> 5.5.12was build using JAVA
> 1.4, I am trying to determine if I need to rebuild the whole source tree
> under JSDK 5.0 or just the missing JSSE15SocketFactory. In order to make
> that judgement call, I need to understand if there is any other
> functionality that is missing.
>  Other than JSSE15SocketFactory, is there any other functionality missing
> from tomcat 5.5.12 because it was build using JAVA 1.4?
>  Bruce
>
>

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



why is commons-collections being modified?

2005-11-18 Thread Andy Cutright
hi all, 

i'm building 5.5.12. the jakarta-tomcat-5/build.xml explicity removes
code from the commons-collections code base. i see in the change log
some reference about this saying it is being repackaged to reduce the
package size. is this the reason why? or are the are additional reasons?
for instance: 






why is this code being removed? is there some bug? or is this simply to
save space? 

we package tomcat along with other components, some of which may have
dependencies on commons-collections. i would prefer to use a single copy
of commons-collections, so i'm wondering if i can simply use
commons-collections as is within tomcat. 

cheers,
andy 

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: why is commons-collections being modified?

2005-11-18 Thread Bill Barker
Tomcat repackages commons-collections, so Tomcat won't know or care if you
ship the actual commons-collections jar with your application.  It's looking
for classes in the org.apache.tomcat.dbcp package, not the
org.apache.commons one.


- Original Message -
From: "Andy Cutright" <[EMAIL PROTECTED]>
To: 
Sent: Friday, November 18, 2005 12:33 PM
Subject: why is commons-collections being modified?


hi all,

i'm building 5.5.12. the jakarta-tomcat-5/build.xml explicity removes
code from the commons-collections code base. i see in the change log
some reference about this saying it is being repackaged to reduce the
package size. is this the reason why? or are the are additional reasons?
for instance:

  
  
  
  

why is this code being removed? is there some bug? or is this simply to
save space?

we package tomcat along with other components, some of which may have
dependencies on commons-collections. i would prefer to use a single copy
of commons-collections, so i'm wondering if i can simply use
commons-collections as is within tomcat.

cheers,
andy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




This message is intended only for the use of the person(s) listed above as the 
intended recipient(s), and may contain information that is PRIVILEGED and 
CONFIDENTIAL.  If you are not an intended recipient, you may not read, copy, or 
distribute this message or any attachment. If you received this communication 
in error, please notify us immediately by e-mail and then delete all copies of 
this message and any attachments.

In addition you should be aware that ordinary (unencrypted) e-mail sent through 
the Internet is not secure. Do not send confidential or sensitive information, 
such as social security numbers, account numbers, personal identification 
numbers and passwords, to us via ordinary (unencrypted) e-mail.


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r345567 - in /tomcat/container/tc5.5.x: modules/cluster/src/share/org/apache/catalina/cluster/tcp/ modules/cluster/src/share/org/apache/catalina/cluster/util/ webapps/docs/

2005-11-18 Thread pero
Author: pero
Date: Fri Nov 18 13:07:23 2005
New Revision: 345567

URL: http://svn.apache.org/viewcvs?rev=345567&view=rev
Log:
Fix that sendMessage signature at all DataSender subclasses must be changed.
Fix that socket at o.a.c.cluster.tcp.FastAsyncSocketSender can be 
disconnect/connect

Modified:

tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/tcp/AsyncSocketSender.java

tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/tcp/DataSender.java

tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/tcp/FastAsyncSocketSender.java

tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/tcp/PooledSocketSender.java

tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/tcp/ReplicationTransmitter.java

tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/util/FastQueue.java

tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/util/SingleRemoveSynchronizedAddLock.java
tomcat/container/tc5.5.x/webapps/docs/changelog.xml

Modified: 
tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/tcp/AsyncSocketSender.java
URL: 
http://svn.apache.org/viewcvs/tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/tcp/AsyncSocketSender.java?rev=345567&r1=345566&r2=345567&view=diff
==
--- 
tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/tcp/AsyncSocketSender.java
 (original)
+++ 
tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/tcp/AsyncSocketSender.java
 Fri Nov 18 13:07:23 2005
@@ -152,23 +152,23 @@
 super.disconnect();
 }
 
-/*
+/**
  * Send message to queue for later sending
  * 
- * @see 
org.apache.catalina.cluster.tcp.IDataSender#sendMessage(java.lang.String,
- *  byte[])
+ * @see org.apache.catalina.cluster.tcp.DataSender#pushMessage(ClusterData)
  */
-public void sendMessage(String messageid, ClusterData data)
+public void sendMessage(ClusterData data)
 throws java.io.IOException {
-SmartQueue.SmartEntry entry = new SmartQueue.SmartEntry(messageid, 
data);
+SmartQueue.SmartEntry entry = new 
SmartQueue.SmartEntry(data.getUniqueId(), data);
 queue.add(entry);
 synchronized (this) {
 inQueueCounter++;
-queueThread.incQueuedNrOfBytes(data.getMessage().length);
+if(queueThread != null)
+queueThread.incQueuedNrOfBytes(data.getMessage().length);
}
 if (log.isTraceEnabled())
 log.trace(sm.getString("AsyncSocketSender.queue.message",
-getAddress().getHostAddress(), new Integer(getPort()), 
messageid, new Long(
+getAddress().getHostAddress(), new Integer(getPort()), 
data.getUniqueId(), new Long(
 data.getMessage().length)));
 }
 

Modified: 
tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/tcp/DataSender.java
URL: 
http://svn.apache.org/viewcvs/tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/tcp/DataSender.java?rev=345567&r1=345566&r2=345567&view=diff
==
--- 
tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/tcp/DataSender.java
 (original)
+++ 
tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/tcp/DataSender.java
 Fri Nov 18 13:07:23 2005
@@ -666,6 +666,11 @@
if(isConnected())
return ;
try {
+   throw new Exception("open socket") ;
+   } catch ( Exception ex2) {
+   log.debug("open socket exception",ex2);
+   }
+   try {
 createSocket();
 if (isWaitForAck())
 socket.setSoTimeout((int) ackTimeout);

Modified: 
tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/tcp/FastAsyncSocketSender.java
URL: 
http://svn.apache.org/viewcvs/tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/tcp/FastAsyncSocketSender.java?rev=345567&r1=345566&r2=345567&view=diff
==
--- 
tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/tcp/FastAsyncSocketSender.java
 (original)
+++ 
tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/tcp/FastAsyncSocketSender.java
 Fri Nov 18 13:07:23 2005
@@ -273,15 +273,16 @@
 
 // - Public Methods
 
-/*
- * Connect to socket and start background thread to ppush queued messages
+/**
+ * Connect to socket and start background thread to pus

RE: why is commons-collections being modified?

2005-11-18 Thread Andy Cutright
thanks for the info, 

cheers,
andy  

> -Original Message-
> From: Bill Barker [mailto:[EMAIL PROTECTED] 
> Sent: Friday, November 18, 2005 12:53 PM
> To: Tomcat Developers List
> Subject: Re: why is commons-collections being modified? 
> 
> Tomcat repackages commons-collections, so Tomcat won't know 
> or care if you
> ship the actual commons-collections jar with your 
> application.  It's looking
> for classes in the org.apache.tomcat.dbcp package, not the
> org.apache.commons one.
> 

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r345579 - /tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/tcp/DataSender.java

2005-11-18 Thread pero
Author: pero
Date: Fri Nov 18 13:32:27 2005
New Revision: 345579

URL: http://svn.apache.org/viewcvs?rev=345579&view=rev
Log:
remove debugging statements

Modified:

tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/tcp/DataSender.java

Modified: 
tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/tcp/DataSender.java
URL: 
http://svn.apache.org/viewcvs/tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/tcp/DataSender.java?rev=345579&r1=345578&r2=345579&view=diff
==
--- 
tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/tcp/DataSender.java
 (original)
+++ 
tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/tcp/DataSender.java
 Fri Nov 18 13:32:27 2005
@@ -666,11 +666,6 @@
if(isConnected())
return ;
try {
-   throw new Exception("open socket") ;
-   } catch ( Exception ex2) {
-   log.debug("open socket exception",ex2);
-   }
-   try {
 createSocket();
 if (isWaitForAck())
 socket.setSoTimeout((int) ackTimeout);



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Any other functionality missing from Tomcat 5.5.12 that relies on JSDK 5.0?

2005-11-18 Thread Remy Maucherat

Costin Manolache wrote:

Check the build.xml files, look for 'unless'.

Probably the right solution to avoid this would be to stop using
'unless' and ant checks,
and instead move all the 'conditional' code in separate targets and
jar files. In particular, the
whole SSL stuff is an unpredictible mess.

I'm not even sure if/how can we use OpenSSL via APR ( I found some
code, and it should work ). The whole connection layer should be


It actually works.


refactored to allow better abstraction for APR, NIO, old-style
sockets/threads... The current approach in APR ( duplicate everything
) may be good for quick tests, but it can't be the long term solution
( some people like to add a NIO equivalent ).


I'm perfectly fine with it. I prefer duplicating things than having a 
complex abstraction layer (if you compare the APR API with the NIO/Java 
IO API, you'll see APR is simpler, so the connector code can be a bit 
simpler - for equivalent functionality at least). At this point, I see 
non APR connectors as having no future production wise.


Rémy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Any other functionality missing from Tomcat 5.5.12 that relies on JSDK 5.0?

2005-11-18 Thread Costin Manolache
On 11/18/05, Remy Maucherat <[EMAIL PROTECTED]> wrote:

> >
> > I'm not even sure if/how can we use OpenSSL via APR ( I found some
> > code, and it should work ). The whole connection layer should be
>
> It actually works.

I'm happy I got regular HTTP/APR working, wasn't easy :-)


>
> > refactored to allow better abstraction for APR, NIO, old-style
> > sockets/threads... The current approach in APR ( duplicate everything
> > ) may be good for quick tests, but it can't be the long term solution
> > ( some people like to add a NIO equivalent ).
>
> I'm perfectly fine with it. I prefer duplicating things than having a
> complex abstraction layer (if you compare the APR API with the NIO/Java
> IO API, you'll see APR is simpler, so the connector code can be a bit
> simpler - for equivalent functionality at least). At this point, I see
> non APR connectors as having no future production wise.

So for NIO - we should create another copy of 5 large files ? Most of
the functions are complete duplicates - a simple extend would eliminate
them.

The problems are in few abstractions - like Handler - which can be
easily fixed to
accomodate NIO / APR or traditional.

NIO is a valid solution - and may be as fast as APR, in particular
with JDK1.6 -
and it avoids the JNI layer.

I like APR more too - but I don't think it's wise to say there will be
no better solution
in the future :-) It just happens that today APR is faster - and has a
lot of features beyond
NIO.

IMO the future is in features integrated at the low-level with the VM
- in particular
if they can bypass JNI or use non-garbage-collected heaps ( as in
real-time java ). It
would be hard for any JNI solution to beat this - but of course,
that's future, not so easy
to predict...

Costin

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r345597 - in /tomcat/site/trunk: docs/lists.html xdocs/lists.xml

2005-11-18 Thread markt
Author: markt
Date: Fri Nov 18 15:16:31 2005
New Revision: 345597

URL: http://svn.apache.org/viewcvs?rev=345597&view=rev
Log:
Fix MARC links. Add actual posting addresses to hopefully stop people sending 
messages to the owner address asking how to post once they have subscribed.

Modified:
tomcat/site/trunk/docs/lists.html
tomcat/site/trunk/xdocs/lists.xml

Modified: tomcat/site/trunk/docs/lists.html
URL: 
http://svn.apache.org/viewcvs/tomcat/site/trunk/docs/lists.html?rev=345597&r1=345596&r2=345597&view=diff
==
--- tomcat/site/trunk/docs/lists.html (original)
+++ tomcat/site/trunk/docs/lists.html Fri Nov 18 15:16:31 2005
@@ -187,7 +187,7 @@
 
 
  
-User support and discussion
+User support and discussion
 
  
 Development mailing list and source change reports
@@ -253,6 +253,13 @@
 
  
  
+  Posting questions to the list:
+  
+mailto:users@tomcat.apache.org";>
+  users@tomcat.apache.org
+
+ 
+ 
   Getting help with the list:
   
 mailto:[EMAIL PROTECTED]">
@@ -263,7 +270,7 @@
   Archives:
   
 http://mail-archives.apache.org";>at Apache,
-http://marc.theaimsgroup.com/?l=apache-tomcat-user";>at MARC.
+http://marc.theaimsgroup.com/?l=tomcat-user";>at MARC.
   
  
 
@@ -325,6 +332,13 @@
 
  
  
+  Posting questions to the list:
+  
+mailto:dev@tomcat.apache.org";>
+  dev@tomcat.apache.org
+
+ 
+ 
   Unsubscription addresses:
   
 mailto:[EMAIL PROTECTED]">
@@ -344,7 +358,7 @@
   Searchable Archives:
   
 http://mail-archives.apache.org/mod_mbox/tomcat-dev/";>at 
Apache,
-http://marc.theaimsgroup.com/?l=apache-tomcat-dev";>at MARC.
+http://marc.theaimsgroup.com/?l=tomcat-dev";>at MARC.
   
  
 

Modified: tomcat/site/trunk/xdocs/lists.xml
URL: 
http://svn.apache.org/viewcvs/tomcat/site/trunk/xdocs/lists.xml?rev=345597&r1=345596&r2=345597&view=diff
==
--- tomcat/site/trunk/xdocs/lists.xml (original)
+++ tomcat/site/trunk/xdocs/lists.xml Fri Nov 18 15:16:31 2005
@@ -23,7 +23,7 @@
 to access most of the lists with a news reader.
 
 
- User support and discussion
+ User support and discussion
  Development mailing list and source change 
reports
 
 
@@ -61,6 +61,11 @@
   [EMAIL PROTECTED]
  
  
+  Posting questions to the list:
+  mailto:users@tomcat.apache.org";>
+  users@tomcat.apache.org
+ 
+ 
   Getting help with the list:
   mailto:[EMAIL PROTECTED]">
   [EMAIL PROTECTED]
@@ -69,7 +74,7 @@
   Archives:
   
 http://mail-archives.apache.org";>at Apache,
-http://marc.theaimsgroup.com/?l=apache-tomcat-user";>at MARC.
+http://marc.theaimsgroup.com/?l=tomcat-user";>at MARC.
   
  
 
@@ -107,6 +112,11 @@
   [EMAIL PROTECTED]
  
  
+  Posting questions to the list:
+  mailto:dev@tomcat.apache.org";>
+  dev@tomcat.apache.org
+ 
+ 
   Unsubscription addresses:
   mailto:[EMAIL PROTECTED]">
   [EMAIL PROTECTED]
@@ -122,7 +132,7 @@
   Searchable Archives:
   
 http://mail-archives.apache.org/mod_mbox/tomcat-dev/";>at 
Apache,
-http://marc.theaimsgroup.com/?l=apache-tomcat-dev";>at MARC.
+http://marc.theaimsgroup.com/?l=tomcat-dev";>at MARC.
   
  
 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Any other functionality missing from Tomcat 5.5.12 that relies on JSDK 5.0?

2005-11-18 Thread Remy Maucherat

Costin Manolache wrote:

So for NIO - we should create another copy of 5 large files ? Most of
the functions are complete duplicates - a simple extend would eliminate
them.

The problems are in few abstractions - like Handler - which can be
easily fixed to
accomodate NIO / APR or traditional.

NIO is a valid solution - and may be as fast as APR, in particular
with JDK1.6 -
and it avoids the JNI layer.

I like APR more too - but I don't think it's wise to say there will be
no better solution
in the future :-) It just happens that today APR is faster - and has a
lot of features beyond
NIO.

IMO the future is in features integrated at the low-level with the VM
- in particular
if they can bypass JNI or use non-garbage-collected heaps ( as in
real-time java ). It
would be hard for any JNI solution to beat this - but of course,
that's future, not so easy
to predict...


I completely disagree. APR is a well accepted IO impl for webservers 
(obviously), and works very well. There's room for experimentation as 
separate implementations, but should NIO get better and support the 
features we need (somehow, I doubt the second one will ever be the case 
...), there's going to be ample time to switch to it later (emphasis on 
later; Java 6 as the Tomcat target is quite far away). In the meantime, 
I don't see the point of yet another abstraction layer.


Rémy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Any other functionality missing from Tomcat 5.5.12 that relies on JSDK 5.0?

2005-11-18 Thread Costin Manolache
On 11/18/05, Remy Maucherat <[EMAIL PROTECTED]> wrote:
> Costin Manolache wrote:
> > So for NIO - we should create another copy of 5 large files ? Most of
> > the functions are complete duplicates - a simple extend would eliminate
> > them.
> >
> > The problems are in few abstractions - like Handler - which can be
> > easily fixed to
> > accomodate NIO / APR or traditional.
> >
> > NIO is a valid solution - and may be as fast as APR, in particular
> > with JDK1.6 -
> > and it avoids the JNI layer.
> >
> > I like APR more too - but I don't think it's wise to say there will be
> > no better solution
> > in the future :-) It just happens that today APR is faster - and has a
> > lot of features beyond
> > NIO.
> >
> > IMO the future is in features integrated at the low-level with the VM
> > - in particular
> > if they can bypass JNI or use non-garbage-collected heaps ( as in
> > real-time java ). It
> > would be hard for any JNI solution to beat this - but of course,
> > that's future, not so easy
> > to predict...
>
> I completely disagree. APR is a well accepted IO impl for webservers
> (obviously), and works very well.

For C++ servers - yes.
For Java servers - is anyone else using it besides tomcat ? Even in
tomcat - how many
people are using the bindings ( compared with the non-apr connector ) ?

Unfortunately - NIO is the well-accepted solution for java servers (
all except tomcat
are using it ). We know APR is better - but can't pretend it's an
'accepted' solution.


> There's room for experimentation as
> separate implementations, but should NIO get better and support the
> features we need (somehow, I doubt the second one will ever be the case
> ...), there's going to be ample time to switch to it later (emphasis on
> later; Java 6 as the Tomcat target is quite far away). In the meantime,
> I don't see the point of yet another abstraction layer.

Not a new abstraction layer - just adjustments to the current one.
For example - add the 'long' socket to TcpConnection - and adjust comments in
TcpConnectionHandler - so it can be used instead of the Handler. Then most Apr
classes could extend the corresponding non-APR classes, and only
override what's
different.

It's not the perfect abstraction - but if you also add NIO, you could
later extract
a base class that has none of the apr/nio/classic methods, and avoid
duplication.
Adding NIO in the same way as APR was added would be a nightmare - the current
APR code is already messy ( Sendfile for example ).

I'm sorry, I like APR, but I can't like the current implementation (
except as a good
initial step ).

Costin

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Any other functionality missing from Tomcat 5.5.12 that relies on JSDK 5.0?

2005-11-18 Thread Remy Maucherat

Costin Manolache wrote:

For C++ servers - yes.
For Java servers - is anyone else using it besides tomcat ? Even in
tomcat - how many
people are using the bindings ( compared with the non-apr connector ) ?

Unfortunately - NIO is the well-accepted solution for java servers (
all except tomcat
are using it ). We know APR is better - but can't pretend it's an
'accepted' solution.


The truth is, few people are using Java web servers, and it's not going 
to change. I'm curious to know how NIO is a well accepted solution for 
web servers, BTW.



Not a new abstraction layer - just adjustments to the current one.
For example - add the 'long' socket to TcpConnection - and adjust comments in
TcpConnectionHandler - so it can be used instead of the Handler. Then most Apr
classes could extend the corresponding non-APR classes, and only
override what's
different.

It's not the perfect abstraction - but if you also add NIO, you could
later extract
a base class that has none of the apr/nio/classic methods, and avoid
duplication.
Adding NIO in the same way as APR was added would be a nightmare - the current
APR code is already messy ( Sendfile for example ).

I'm sorry, I like APR, but I can't like the current implementation (
except as a good
initial step ).


Again, I completely disagree. The low level code is small enough that an 
abstraction layer is useless. Similarly, a lot of the code in j-t-c/util 
should go (starting with the "threads" package).


To get down to the root of the problem, I don't like the argument that 
NIO is any good as an IO API. Besides the (many) utility classes like 
the buffers, and as a JNI access method, both of which can be used 
without sencond thoughts (and are actually used right now), all the 
actual IO code is still all native (no surprise) and the Java API on top 
is over engineered. It doesn't make sense to me.


Rémy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Any other functionality missing from Tomcat 5.5.12 that relies on JSDK 5.0?

2005-11-18 Thread Costin Manolache
On 11/18/05, Remy Maucherat <[EMAIL PROTECTED]> wrote:
> Costin Manolache wrote:
> > For C++ servers - yes.
> > For Java servers - is anyone else using it besides tomcat ? Even in
> > tomcat - how many
> > people are using the bindings ( compared with the non-apr connector ) ?
> >
> > Unfortunately - NIO is the well-accepted solution for java servers (
> > all except tomcat
> > are using it ). We know APR is better - but can't pretend it's an
> > 'accepted' solution.
>
> The truth is, few people are using Java web servers, and it's not going
> to change. I'm curious to know how NIO is a well accepted solution for
> web servers, BTW.

NIO is used AFAIK by Jetty and Resin, and probably others. And it's
the 'standard'
solution for select-like operations ( even if the standard is as usual
not the best solution ).


> > I'm sorry, I like APR, but I can't like the current implementation (
> > except as a good
> > initial step ).
>
> Again, I completely disagree. The low level code is small enough that an
> abstraction layer is useless. Similarly, a lot of the code in j-t-c/util
> should go (starting with the "threads" package).

Agree, the threads package shouldn't be used as an API - and a lot of code in
j-t-c/util should be deprecated. One of the nice things about NIO is
that you can't
get rid of a lot of some stuff.

Duplicating the entire HTTP parser class just because you don't want a
small abstraction
( which was actually already there ) is not right.



> To get down to the root of the problem, I don't like the argument that
> NIO is any good as an IO API. Besides the (many) utility classes like
> the buffers, and as a JNI access method, both of which can be used
> without sencond thoughts (and are actually used right now), all the
> actual IO code is still all native (no surprise) and the Java API on top
> is over engineered. It doesn't make sense to me.

Well, most java APIs - including the servlet - are over engineered.
And most are
far from perfect solution ( again, servlet is a good example :-). Yes,
I also hate
the way buffers flip and you can't know where is the data ( before or
after position ),
most of the channel and select are more complex than the APR equivalent.

But NIO is a valid solution - with 1.6 I'm pretty sure the performance
will be comparable
( with poll, etc ). APR is not the only valid solution ( and on top of
that - the way we
implement the connector on top of APR is far from either simple or right ).


Costin

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]