Re: SolrBot running again

2025-05-26 Thread Christos Malliaridis
Nice to see it running again.

Please note that for the PRs that have a green checkmark you still have to
do some basic checks before merging, like making sure the license and
notice files are up-to-date with the files of the dependency. More
information about this can be found in help/dependencies.txt

.

Best,
Christos

On Mon, May 26, 2025 at 10:21 AM Jan Høydahl  wrote:

> SolrBot (Renovate dependency updates) had paused itself a month ago.
> Kicked it running again, so expect some new and some updated bot PRs.
>
> If you want to help keeping Solr's dependencies up to date, here is the
> list of PRs:
>
> https://github.com/apache/solr/issues?q=is%3Apr+is%3Aopen+author%3Asolrbot
>
> The ones with a green checkmark would be ready for merging.
> The ones with a red X typically need a manual commit to add a missing
> license file or similar.
>
> Back-porting dependency updates to 9x has become a bit more work due to
> the differences in build. Working on establishing a separate SolrBot run
> for that branch.
>
> Jan
>


Re: "solr start -e techproducts" failing on MacOS

2025-05-26 Thread Christos Malliaridis
I am able to run Solr with branch_9x without the patch from
https://github.com/apache/solr/pull/3359 and it seems that it works without
errors. Are you sure Solr 9x is affected by this? No objection in
backporting this though, just making sure we are not trying to fix
something that is not an issue in 9x.

Christos

On Thu, May 22, 2025 at 7:02 PM Kevin Risden  wrote:

> Its not just a main / Jetty 12 issue. This should be backported to 9.x as
> well where security manager isn't going away.
>
> Kevin Risden
>
>
> On Thu, May 22, 2025 at 11:22 AM Rahul Goswami 
> wrote:
>
> > Great find Kevin! That makes sense. Can confirm that  starting with
> > --jvm-opts "-Djava.io.tmpdir=$(cd $TMPDIR; pwd -P)" works too. Also,
> thanks
> > for the PR!
> >
> > I'd say that fixing this by passing "pwd -P" in the start opts in
> bin/solr
> > _seems_ like the right way to go. But I am also conflicted on whether
> > disabling security manager altogether is the solution that could be
> > considered here (?). Especially since it's going away in Java 24 anyway.
> >
> > Rahul
> >
> > On Wed, May 21, 2025 at 10:07 PM Kevin Risden 
> wrote:
> >
> > > The underlying issue is that /tmp is a symlink on Mac. Java security
> > > manager permissions need the ability to read the symlink AND the
> > underlying
> > > directory. Since we only have
> > >
> > > permission java.io.FilePermission "${java.io.tmpdir}", "read,write";
> > > permission java.io.FilePermission "${java.io.tmpdir}${/}-",
> > > "read,write,delete";
> > >
> > > in security.policy it by default is just the symlink.
> > >
> > > We actually do similar fixes in our bin/solr script already using `pwd
> > -P`
> > > to ensure that we don't have symlinks in the path. See SOLR-16457 /
> > > https://github.com/apache/solr/pull/1282
> > >
> > > an example that works:
> > >
> > > ./bin/solr start -f --jvm-opts "-Djava.io.tmpdir=$(cd $TMPDIR; pwd -P)"
> > >
> > > This takes the existing TMPDIR environment variable and forces
> > > `java.io.tmpdir` to not be a symlink anymore using the `pwd -P`
> > expansion.
> > >
> > > This can be done in bin/solr as well if we want and set tmpdir in say
> > > SOLR_START_OPTS. Here is a PR to show how this could be done
> > > https://github.com/apache/solr/pull/3359
> > >
> > > As you already found out you can also just disable the security
> manager -
> > > here is a one liner that doesn't require changing any files either.
> > >
> > > SOLR_SECURITY_MANAGER_ENABLED=false ./bin/solr start -f
> > >
> > > As a final note this is not new to Jetty 12 but has been an issue in
> the
> > > past - see https://issues.apache.org/jira/browse/SOLR-17542. It might
> be
> > > new how its popping up now with Jetty 12 doing something with the temp
> > > directory but there are other ways to hit it.
> > >
> > > Kevin Risden
> > >
> > >
> > > On Wed, May 21, 2025 at 5:52 PM Rahul Goswami 
> > > wrote:
> > >
> > > > That worked. Thanks Christos!
> > > >
> > > > On Wed, May 21, 2025 at 5:30 PM Christos Malliaridis <
> > > > malliari...@apache.org>
> > > > wrote:
> > > >
> > > > > I have faced the same issue recently.
> > > > >
> > > > > There is a configuration option in bin/solr.in.sh <
> http://sole.in.sh
> > >
> > > > for
> > > > > the security manager:
> > > > >
> > > > > #SOLR_SECURITY_MANAGER_ENABLED=true
> > > > >
> > > > > Removing the comment and setting it to false worked for me.
> > > > >
> > > > > On Wed, 21 May 2025, 23:19 Rahul Goswami, 
> > > wrote:
> > > > >
> > > > > > Sanjay,
> > > > > > Thanks for looking into this. I also tried disabling the security
> > > > manager
> > > > > > on MacOS by running "solr start -e techproducts
> > > > > > -Djdk.security.manager=disallow" and still see the same behavior
> > with
> > > > the
> > > > > > same stacktrace in log.
> > > > > >
> > > > > > -Rahul
> > > > > >
> > > > > > On Tue, May 20, 2025 at 11:55 PM sanjay dutt <
> > > > > > sanjaydutt.unoffic...@gmail.com> wrote:
> > > > > >
> > > > > > > Recently I merged changes related to jetty upgrade. I will look
> > > into
> > > > > it.
> > > > > > > https://github.com/apache/solr/pull/2876
> > > > > > >
> > > > > > > On Wed, May 21, 2025 at 5:44 AM Rahul Goswami <
> > > rahul196...@gmail.com
> > > > >
> > > > > > > wrote:
> > > > > > >
> > > > > > > > For additional context, this is working fine on Windows.
> > Failing
> > > > > > > > consistently on MacOS.
> > > > > > > >
> > > > > > > > Thanks,
> > > > > > > > Rahul
> > > > > > > >
> > > > > > > >
> > > > > > > > On Tue, May 20, 2025 at 5:32 PM Rahul Goswami <
> > > > rahul196...@gmail.com
> > > > > >
> > > > > > > > wrote:
> > > > > > > >
> > > > > > > > > I checked out main, and then "gradlew dev". Tried running
> the
> > > > > > > > techproducts
> > > > > > > > > example, but it seems to get into some exception with
> > > > initializing
> > > > > > the
> > > > > > > > > context (hitting 503 error).
> > > > > > > > >
> > > > > > > > >
> > > > > > > > > Logs are complaining about AccessControlException while
> >