Re: [PR] Jetty12 + EE10 [solr]
Wow. Nice catch. More reason we shouldn't be cramming everything into one filter... On Sun, Apr 13, 2025 at 2:13 AM dsmiley (via GitHub) wrote: > > dsmiley commented on PR #2876: > URL: https://github.com/apache/solr/pull/2876#issuecomment-2799731147 > >Finally I found the root cause of `PackageToolTest.testPackageTool`! > Lots of debugging today. It probably doesn't have to do with this PR but > the new versions of Jetty seem to tickle it to happening often but not > every time. Not sure if it ever happened before; maybe not if the test has > been reliable. I filed https://issues.apache.org/jira/browse/SOLR-17740 > describing the problem; I will work on a fix. In the mean time, it's okay > to add a temporary ignore on that test to unblock this PR, assuming it's > only that test which fails. (?) But it'll hopefully be fixed very soon so > we can just wait. > > > -- > This is an automated message from the Apache Git Service. > To respond to the message, please log on to GitHub and use the > URL above to go to the specific comment. > > To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org > > For queries about this service, please contact Infrastructure at: > us...@infra.apache.org > > > - > To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org > For additional commands, e-mail: issues-h...@solr.apache.org > > -- http://www.needhamsoftware.com (work) https://a.co/d/b2sZLD9 (my fantasy fiction book)
Re: SIP proposal: Switch from DropWizard to OpenTelemetry
I'm excited about the change! Where I work, it would *significantly* simplify our metrics pipeline if Solr were to embrace OTel for metrics, as we could then use company-provided OTel plugins. The broad industry adoption of OTel points to this being the least friction. With DropWizard, it appears we hacked attributes onto it, in a sense. The primary criteria/requirement that comes to mind is to have strong/sophisticated ways to filter the right metrics to publish. Solr has that today. On Fri, Apr 11, 2025 at 5:00 PM Matthew Biscocho (BLOOMBERG/ 919 3RD A) < mbisco...@bloomberg.net> wrote: > Hey everyone, > > Making this thread because I was interested in writing up a SIP for > SOLR-17458 https://issues.apache.org/jira/browse/SOLR-17458 and starting > a discussion around this. The proposed change involves migrating Solr's > metrics framework from DropWizard to OpenTelemetry (OTel). This will move > Solr to an attribute based metric framework and will also help > future-proofing by keeping it from vendor lock-in, given OpenTelemetry's > stance on being vendor-neutral and working with many different pipelines. > Since Solr already packages an Open Telemetry SDK as a module for exporting > spans through OTLP, we can use that foundation to have it push metrics as > well. There will be a significant change here which will probably break > many components and no longer be backwards compatible so this will probably > need to be a major release version change but we can potentially keep a few > things backwards compatible if needed. Just some things off the top of my > head: > > * The Prometheus Exporter (Maybe should be deprecated?) > * GET /admin/metrics endpoint > * JVM metrics collected from OTel > * Metric reporters? > > Anyone have thoughts?
