Looking for final review of SOLR-16842

2024-06-21 Thread Eric Pugh
Hi all, I’m planning on merging https://github.com/apache/solr/pull/1768, 
SOLR-16824: Adopt Linux Command line tool pattern of -- for long option 
commands tomorrow (Saturday).

I’m going to be traveling (Spain!) for three weeks starting June 29th, and I’d 
like to make sure this fairly big change has plenty time for any panicky follow 
up fixes that turn out to be needed when it goes into main and branch_9x.

Eric


___
Eric Pugh | Founder | OpenSource Connections, LLC | 434.466.1467 | 
http://www.opensourceconnections.com  | 
My Free/Busy   
Co-Author: Apache Solr Enterprise Search Server, 3rd Ed 


This e-mail and all contents, including attachments, is considered to be 
Company Confidential unless explicitly stated otherwise, regardless of whether 
attachments are marked as such.



Re: Looking for final review of SOLR-16842

2024-06-21 Thread Jason Gerlowski
Hey Eric,

Sorry for the delay - I am hoping to review that PR.  I'll try to have
a review done by Monday (if not today).  That should leave a week or
so for any followups prior to your big trip!  (Safe travels!)

If Monday isn't early enough and you need to merge on Saturday, IMO
that's fine.  The PR's been open for nearly a year and you've been
more than patient at this point.  In that case I'll just review
post-merge and we can handle any follow ups as needed.

Best,

Jason

On Fri, Jun 21, 2024 at 12:07 PM Eric Pugh
 wrote:
>
> Hi all, I’m planning on merging https://github.com/apache/solr/pull/1768, 
> SOLR-16824: Adopt Linux Command line tool pattern of -- for long option 
> commands tomorrow (Saturday).
>
> I’m going to be traveling (Spain!) for three weeks starting June 29th, and 
> I’d like to make sure this fairly big change has plenty time for any panicky 
> follow up fixes that turn out to be needed when it goes into main and 
> branch_9x.
>
> Eric
>
>
> ___
> Eric Pugh | Founder | OpenSource Connections, LLC | 434.466.1467 | 
> http://www.opensourceconnections.com  
> | My Free/Busy 
> Co-Author: Apache Solr Enterprise Search Server, 3rd Ed 
> 
> This e-mail and all contents, including attachments, is considered to be 
> Company Confidential unless explicitly stated otherwise, regardless of 
> whether attachments are marked as such.
>

-
To unsubscribe, e-mail: dev-unsubscr...@solr.apache.org
For additional commands, e-mail: dev-h...@solr.apache.org