code review request: PR 2508 (SOLR-13350, multi-threaded search threadpool type)

[Christine Poerschke (BLOOMBERG/ LONDON)]

Hi Everyone,

For the https://github.com/apache/solr/pull/2508 change, I'd appreciate a code 
review or two if/when people have bandwidth.

The change itself is very minimal but my 
https://issues.apache.org/jira/browse/SOLR-13350?page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel&focusedCommentId=17850405#comment-17850405
 and 
https://issues.apache.org/jira/browse/SOLR-13350?page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel&focusedCommentId=17853178#comment-17853178
 comments on the JIRA ticket contain more background as to how the proposed 
change came about.

Thanks,
Christine

Re: Simplify Ref Guide Examples by Merging Windows and Mac/Linux Examples?

[Eric Pugh]

Thanks all, I created https://issues.apache.org/jira/browse/SOLR-17336 to track 
this.



> On Jun 14, 2024, at 3:17 PM, Jan Høydahl  wrote:
> 
> +1
> 
> I have done this myself with paths when running java on Windows - easier to 
> handle forward/slash, less escaping etc.
> 
> PS: I still hope we can remove bin\solr.cmd from 10.0 (but keep support for 
> Windows paths etc in Java).
> 
> Jan
> 
>> 14. juni 2024 kl. 19:30 skrev David Smiley :
>> 
>> +1
>> 
>> ~ David Smiley
>> Apache Lucene/Solr Search Developer
>> http://www.linkedin.com/in/davidwsmiley
>> 
>> 
>> On Fri, Jun 14, 2024 at 3:30 PM Eric Pugh 
>> wrote:
>> 
>>> In the ref guide we duplicate all out bin/solr post examples to deal with
>>> the / for unix/Mac and \ for windows.
>>> 
>>> I asked ChatGPT about this, and it said that Java just deals with it…
>>> 
>>> I was thinking we could reduce the duplication by just providing the linux
>>> example, and not labeling it “Linux/Mac” and not having a separate windows
>>> one…
>>> 
>>> Thoughts?
>>> 
>>> Eric
>>> 
>>> 
>>> What ChatGPT said:
>>> In Java, the file path handling is designed to be platform-independent, so
>>> a path like example/films/films.json will generally work on both Unix-based
>>> systems (like Linux or macOS) and Windows, regardless of the underlying
>>> file system conventions.
>>> 
>>> Java's File class, which is used to interact with the file system,
>>> automatically handles the differences in path separators between platforms.
>>> On Unix-based systems, the path separator is the forward slash (/), while
>>> on Windows, it's the backslash (\).
>>> 
>>> When you pass a path like example/films/films.json to Java, it will
>>> interpret the path correctly on both platforms. On Windows, Java will
>>> automatically convert the forward slashes to backslashes as needed.
>>> 
>>> Similarly, if you pass a Windows-style path like example\films\films.json,
>>> Java will also handle that correctly on both Unix-based systems and Windows.
>>> 
>>> The key point is that Java abstracts away the differences in file system
>>> conventions between platforms, allowing your code to work consistently
>>> across different operating systems. As long as you use Java's file system
>>> APIs (such as File, Path, or Paths), you don't need to worry about the
>>> underlying path separator characters.
>>> 
>>> ___
>>> Eric Pugh | Founder | OpenSource Connections, LLC | 434.466.1467 |
>>> http://www.opensourceconnections.com <
>>> http://www.opensourceconnections.com/> | My Free/Busy <
>>> http://tinyurl.com/eric-cal>
>>> Co-Author: Apache Solr Enterprise Search Server, 3rd Ed <
>>> https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterprise-search-server-third-edition-raw>
>>> 
>>> This e-mail and all contents, including attachments, is considered to be
>>> Company Confidential unless explicitly stated otherwise, regardless of
>>> whether attachments are marked as such.
>>> 
>>> 
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@solr.apache.org
> For additional commands, e-mail: dev-h...@solr.apache.org
> 

___
Eric Pugh | Founder | OpenSource Connections, LLC | 434.466.1467 | 
http://www.opensourceconnections.com  | 
My Free/Busy   
Co-Author: Apache Solr Enterprise Search Server, 3rd Ed 


This e-mail and all contents, including attachments, is considered to be 
Company Confidential unless explicitly stated otherwise, regardless of whether 
attachments are marked as such.