[VOTE] Release Lucene/Solr 8.11.3 RC1

[Ishan Chattopadhyaya]

Please vote for release candidate 1 for Lucene/Solr 8.11.3

The artifacts can be downloaded from:
https://dist.apache.org/repos/dist/dev/lucene/lucene-solr-8.11.3-RC1-rev10d925469f3d4e66b6339b9e1c7d4d4afa4cf206

You can run the smoke tester directly with this command:

python3 -u dev-tools/scripts/smokeTestRelease.py \
https://dist.apache.org/repos/dist/dev/lucene/lucene-solr-8.11.3-RC1-rev10d925469f3d4e66b6339b9e1c7d4d4afa4cf206

The vote will be open for at least 72 hours i.e. until 2023-11-03 10:00 UTC.

[ ] +1  approve
[ ] +0  no opinion
[ ] -1  disapprove (and reason why)

Here is my +1

Re: 8.11.3 release

[Ishan Chattopadhyaya]

Had to BadApple these tests:
https://issues.apache.org/jira/browse/SOLR-17061

On Mon, 30 Oct 2023 at 20:30, Ishan Chattopadhyaya <
ichattopadhy...@gmail.com> wrote:

> There were a few tests that were failing on PRS seeds. Noble and I fixed
> them over the weekend.
>
> There are some intermittent failures on a variety of tests in the branch,
> and I'm finding it hard to get a full test run done in order to build the
> artifacts. At the moment, none of them look serious or suspicious.
> I think I might have to bad-apple a few of those tests, in order to get a
> release out. I shall update here on that.
>
> Thanks everyone for your patience.
>
> On Sat, 28 Oct 2023 at 00:55, Jan Høydahl  wrote:
>
>> I also enabled the smoketest job, and it passes:
>> https://ci-builds.apache.org/job/Lucene/job/Lucene-Solr-SmokeRelease-8.11/lastSuccessfulBuild/
>> !
>>
>> The Lucene-Solr-Tests-8.11 has failed a few times, but on different
>> tests, so things are looking good.
>>
>> Jan
>>
>> > 27. okt. 2023 kl. 13:55 skrev Ishan Chattopadhyaya <
>> ichattopadhy...@gmail.com>:
>> >
>> > Thanks Jan. Some tests are failing; Noble and I are looking into them.
>> If
>> > all goes well, I'm planning to spin the RC1 by this weekend.
>> >
>> > On Fri, 27 Oct, 2023, 2:45 pm Jan Høydahl, 
>> wrote:
>> >
>> >> Thanks Kevin, Ishan for doing the prep work here.
>> >>
>> >> I re-enabled the jenkins job
>> >> https://ci-builds.apache.org/job/Lucene/job/Lucene-Solr-Tests-8.11/ to
>> >> get a feel for the current status. We also have a smokeTest job that
>> should
>> >> be enabled when release is approaching.
>> >>
>> >> Jan
>> >>
>> >>> 12. okt. 2023 kl. 19:38 skrev Kevin Risden :
>> >>>
>> >>> I've pushed a few things to branch_8_11 recently
>> >>> *
>> >>>
>> >>
>> https://github.com/apache/lucene-solr/commit/e491400d961b771f146c6e12a7f8ed89eafe128f
>> >>> *
>> >>>
>> >>
>> https://github.com/apache/lucene-solr/commit/8e545e8f2154698e9bfeee92c40f8541fd7d0152
>> >>> *
>> >>>
>> >>
>> https://github.com/apache/lucene-solr/commit/e7560cd2ab024d4315933cd3965aab2961bba994
>> >>>
>> >>> https://github.com/apache/lucene-solr/pull/2681 is in draft and
>> updated
>> >> a
>> >>> bunch of relatively low risk dependencies. There might be others we
>> want
>> >> to
>> >>> upgrade, but figured it was a decent start.
>> >>>
>> >>> Kevin Risden
>> >>>
>> >>>
>> >>> On Thu, Oct 5, 2023 at 4:27 AM Pierre Salagnac <
>> >> pierre.salag...@gmail.com>
>> >>> wrote:
>> >>>
>>  I just opened a pull request.
>>  https://github.com/apache/lucene-solr/pull/2679
>>  Details are in the PR.
>> 
>>  Thanks !
>> 
>>  Le lun. 2 oct. 2023 à 20:25, Ishan Chattopadhyaya <
>>  ichattopadhy...@gmail.com>
>>  a écrit :
>> 
>> > Thanks Pierre, I'll have it included in 8.11 once you are able to
>> have
>> >> a
>>  PR
>> > for this. Thanks!
>> >
>> > On Mon, 2 Oct 2023 at 22:22, Pierre Salagnac <
>> >> pierre.salag...@gmail.com>
>> > wrote:
>> >
>> >> Hi Ishan,
>> >> Sorry for the late chime in.
>> >>
>> >> Some time ago I filled a Jira for a Solr 8 specific bug:
>> >> https://issues.apache.org/jira/browse/SOLR-16843
>> >>
>> >> At that time, I wasn't expecting more 8.x releases, so I did not
>> open
>> >> a
>> > PR
>> >> for it.
>> >> I can work on a fix if we have a few days more before the release.
>> I
>> > think
>> >> it is worth to have it in solr 8 (that's not a backport)
>> >>
>> >> Thanks
>> >>
>> >>
>> >> Le ven. 29 sept. 2023 à 23:24, Ishan Chattopadhyaya <
>> >> ichattopadhy...@gmail.com> a écrit :
>> >>
>> >>> I'm going to track items from 9x releases in the following sheet.
>> >>>
>> >>>
>> >>
>> >
>> 
>> >>
>> https://docs.google.com/spreadsheets/d/1FADkjDS0yfXpaUi3fbwsa7Izy5HOxE9AR_NKiss1sIo/edit#gid=0
>> >>>
>> >>> Please let me know if there's any item there that you think would
>> be
>> >> useful
>> >>> to backport (if easy) to 8.11, and want me to take a look at
>> > backporting
>> >>> it.
>> >>> Regards,
>> >>> Ishan
>> >>>
>> >>> On Tue, 19 Sept 2023 at 01:15, Ishan Chattopadhyaya <
>> >>> ichattopadhy...@gmail.com> wrote:
>> >>>
>>  Just a reminder to backport any issues one sees fit for a 8.11.3
>> >> release.
>>  I'll try to get an RC out by the end of September, so still more
>> > than a
>>  week away.
>> 
>>  On Wed, 23 Aug 2023 at 17:09, Ishan Chattopadhyaya <
>>  ichattopadhy...@gmail.com> wrote:
>> 
>> > Hi Jan,
>> > Yes, still targeting September. But I will slip on my initial
>> plan
>> > of
>> > doing it by first week of September. I'm foreseeing mid
>> September
>> >>> timeframe.
>> > Thanks for checking in.
>> > Regards,
>> > Ishan
>> >
>> > On Wed, 23 Aug, 2023, 5:05 pm Jan Høydahl, <
>> jan@com

Re: [VOTE] Release Lucene/Solr 8.11.3 RC1

[Jan Høydahl]

Hi,

Thanks for doing the release. I'm running smoke tester

However, there seems to be still open blocker issues in JIRA: 
https://issues.apache.org/jira/issues/?filter=12352945
I just resolved one other that was solved yesterday, but for the remaining 
three I cannot see that they are fixed.
Not 100% sure if all three qualify as blockers either, but they all look 
security related.

Jan

> 31. okt. 2023 kl. 10:24 skrev Ishan Chattopadhyaya 
> :
> 
> 
> Please vote for release candidate 1 for Lucene/Solr 8.11.3
> 
> The artifacts can be downloaded from:
> https://dist.apache.org/repos/dist/dev/lucene/lucene-solr-8.11.3-RC1-rev10d925469f3d4e66b6339b9e1c7d4d4afa4cf206
> 
> You can run the smoke tester directly with this command:
> 
> python3 -u dev-tools/scripts/smokeTestRelease.py \
> https://dist.apache.org/repos/dist/dev/lucene/lucene-solr-8.11.3-RC1-rev10d925469f3d4e66b6339b9e1c7d4d4afa4cf206
> 
> The vote will be open for at least 72 hours i.e. until 2023-11-03 10:00 UTC.
> 
> [ ] +1  approve
> [ ] +0  no opinion
> [ ] -1  disapprove (and reason why)
> 
> Here is my +1
> 
> 
> 

Re: [VOTE] Release Lucene/Solr 8.11.3 RC1

[Ishan Chattopadhyaya]

Ah, damn, I missed those private issues. Also the backup/restore RCE.
Thanks, Jan! I'll respin.

On Tue, 31 Oct 2023 at 18:08, Jan Høydahl  wrote:

> Hi,
>
> Thanks for doing the release. I'm running smoke tester
>
> However, there seems to be still open blocker issues in JIRA:
> https://issues.apache.org/jira/issues/?filter=12352945
> I just resolved one other that was solved yesterday, but for the remaining
> three I cannot see that they are fixed.
> Not 100% sure if all three qualify as blockers either, but they all look
> security related.
>
> Jan
>
> 31. okt. 2023 kl. 10:24 skrev Ishan Chattopadhyaya <
> ichattopadhy...@gmail.com>:
>
>
> Please vote for release candidate 1 for Lucene/Solr 8.11.3
>
> The artifacts can be downloaded from:
>
> https://dist.apache.org/repos/dist/dev/lucene/lucene-solr-8.11.3-RC1-rev10d925469f3d4e66b6339b9e1c7d4d4afa4cf206
>
> You can run the smoke tester directly with this command:
>
> python3 -u dev-tools/scripts/smokeTestRelease.py \
>
> https://dist.apache.org/repos/dist/dev/lucene/lucene-solr-8.11.3-RC1-rev10d925469f3d4e66b6339b9e1c7d4d4afa4cf206
>
> The vote will be open for at least 72 hours i.e. until 2023-11-03 10:00
> UTC.
>
> [ ] +1  approve
> [ ] +0  no opinion
> [ ] -1  disapprove (and reason why)
>
> Here is my +1
> 
>
>
>
>

Re: [VOTE] Release Lucene/Solr 8.11.3 RC1

[Houston Putman]

SOLR-16963  - This is an
open issue. It's easy to fix, much like what we did in main and 9x, but its
hard to test since we lose the integration testing framework. If we respin
I can try to get it in.
SOLR-16948  - This should
be included. I thought it was the impetus for this release actually
SOLR-16949  - I think we
were pretty confident that my original fix didn't actually work (you could
get around the limitations added by my commit)? I think we may need to go
back to the drawing board and think about how to fix this.

- Houston

On Tue, Oct 31, 2023 at 9:49 AM Ishan Chattopadhyaya <
ichattopadhy...@gmail.com> wrote:

> Ah, damn, I missed those private issues. Also the backup/restore RCE.
> Thanks, Jan! I'll respin.
>
> On Tue, 31 Oct 2023 at 18:08, Jan Høydahl  wrote:
>
> > Hi,
> >
> > Thanks for doing the release. I'm running smoke tester
> >
> > However, there seems to be still open blocker issues in JIRA:
> > https://issues.apache.org/jira/issues/?filter=12352945
> > I just resolved one other that was solved yesterday, but for the
> remaining
> > three I cannot see that they are fixed.
> > Not 100% sure if all three qualify as blockers either, but they all look
> > security related.
> >
> > Jan
> >
> > 31. okt. 2023 kl. 10:24 skrev Ishan Chattopadhyaya <
> > ichattopadhy...@gmail.com>:
> >
> >
> > Please vote for release candidate 1 for Lucene/Solr 8.11.3
> >
> > The artifacts can be downloaded from:
> >
> >
> https://dist.apache.org/repos/dist/dev/lucene/lucene-solr-8.11.3-RC1-rev10d925469f3d4e66b6339b9e1c7d4d4afa4cf206
> >
> > You can run the smoke tester directly with this command:
> >
> > python3 -u dev-tools/scripts/smokeTestRelease.py \
> >
> >
> https://dist.apache.org/repos/dist/dev/lucene/lucene-solr-8.11.3-RC1-rev10d925469f3d4e66b6339b9e1c7d4d4afa4cf206
> >
> > The vote will be open for at least 72 hours i.e. until 2023-11-03 10:00
> > UTC.
> >
> > [ ] +1  approve
> > [ ] +0  no opinion
> > [ ] -1  disapprove (and reason why)
> >
> > Here is my +1
> > 
> >
> >
> >
> >
>

Re: Jenkins Build Errors

[Houston Putman]

Ok one last failure! Exciting stuff.

The last one is Solr-Smoketest-9.x
, which is
failing to build the artifacts with tons of errors like:

> Execution failed for task 
> ':solr:solrj:publishJarsPublicationToBuildRepository'.
> > Failed to publish publication 'jars' to repository 'build'
>> Invalid publication 'jars': artifact file does not exist: 
> '/home/jenkins/jenkins-slave/workspace/Solr/Solr-Smoketest-9.x/solr/solrj/build/libs/solr-solrj-9.5.0-javadoc.jar.asc'
>
> This is happening on basically all of the modules, and for every type of
artifact file (jars, poms, etc).

Since this isn't happening on branch_9_4, I would guess that this has
something to do with the Gradle 8 upgrade SOLR-17026


- Houston

On Mon, Oct 30, 2023 at 2:26 PM Houston Putman  wrote:

> The http1 and http2 code in the Http2SolrClient ultimately create
> different errors when there are TLS issues.
> So the fix was merely to accept both types of errors, when checking the
> output of failed commands.
>
> These should be fixed on main, branch_9x and branch_9_4.
> So let's give it a day and see what other lovely errors are left for us to
> deal with in Jenkins!
>
> - Houston
>
> On Mon, Oct 30, 2023 at 11:57 AM Houston Putman 
> wrote:
>
>> Ok, I've determined that the mTLS errors are due to using http1 vs http2
>> in the client.
>> I'm not sure why http1 is used by default in different environments (Its
>> enabled by the `-Dsolr.http1=true` System Property),
>> but now at least the cause is known. I'll try to fix the ssl integration
>> tests for the http1 client today.
>>
>> - Houston
>>
>> On Mon, Oct 30, 2023 at 10:58 AM Houston Putman 
>> wrote:
>>
>>> If you scroll down on the output of
>>> https://builds.apache.org/job/Solr/job/Solr-Check-main/8273, you can
>>> see it in the integration tests.
>>> Search for "not ok 75 start solr with mTLS needed"
>>>
>>> For the builds using crave.io (Solr-Check-9.x), the same failures will
>>> happen but every time. The builds using the jenkins boxes
>>> (Solr-Check-main), will only fail these integration tests if they use the*
>>> lucene-solr-1* machine.
>>>
>>> - Houston
>>>
>>> On Sat, Oct 28, 2023 at 12:46 PM Mikhail Khludnev 
>>> wrote:
>>>
 Hello Houston.
 Thanks for your efforts. How can I check that "MTLs issue"? I looked
 through recent failures, but can't find anything.

>>>

Re: [VOTE] Release Lucene/Solr 8.11.3 RC1

[Ishan Chattopadhyaya]

Hi Houston,
I can take up SOLR-16963 and SOLR-16948. Can you please help out with
SOLR-16949?

On Tue, 31 Oct 2023 at 19:46, Houston Putman  wrote:

> SOLR-16963  - This is an
> open issue. It's easy to fix, much like what we did in main and 9x, but its
> hard to test since we lose the integration testing framework. If we respin
> I can try to get it in.
> SOLR-16948  - This
> should
> be included. I thought it was the impetus for this release actually
> SOLR-16949  - I think we
> were pretty confident that my original fix didn't actually work (you could
> get around the limitations added by my commit)? I think we may need to go
> back to the drawing board and think about how to fix this.
>
> - Houston
>
> On Tue, Oct 31, 2023 at 9:49 AM Ishan Chattopadhyaya <
> ichattopadhy...@gmail.com> wrote:
>
> > Ah, damn, I missed those private issues. Also the backup/restore RCE.
> > Thanks, Jan! I'll respin.
> >
> > On Tue, 31 Oct 2023 at 18:08, Jan Høydahl  wrote:
> >
> > > Hi,
> > >
> > > Thanks for doing the release. I'm running smoke tester
> > >
> > > However, there seems to be still open blocker issues in JIRA:
> > > https://issues.apache.org/jira/issues/?filter=12352945
> > > I just resolved one other that was solved yesterday, but for the
> > remaining
> > > three I cannot see that they are fixed.
> > > Not 100% sure if all three qualify as blockers either, but they all
> look
> > > security related.
> > >
> > > Jan
> > >
> > > 31. okt. 2023 kl. 10:24 skrev Ishan Chattopadhyaya <
> > > ichattopadhy...@gmail.com>:
> > >
> > >
> > > Please vote for release candidate 1 for Lucene/Solr 8.11.3
> > >
> > > The artifacts can be downloaded from:
> > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/lucene/lucene-solr-8.11.3-RC1-rev10d925469f3d4e66b6339b9e1c7d4d4afa4cf206
> > >
> > > You can run the smoke tester directly with this command:
> > >
> > > python3 -u dev-tools/scripts/smokeTestRelease.py \
> > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/lucene/lucene-solr-8.11.3-RC1-rev10d925469f3d4e66b6339b9e1c7d4d4afa4cf206
> > >
> > > The vote will be open for at least 72 hours i.e. until 2023-11-03 10:00
> > > UTC.
> > >
> > > [ ] +1  approve
> > > [ ] +0  no opinion
> > > [ ] -1  disapprove (and reason why)
> > >
> > > Here is my +1
> > > 
> > >
> > >
> > >
> > >
> >
>

Re: Jenkins Build Errors

[Houston Putman]

Ok the artifact building should be fixed. Tomorrow all builds should be
green (maybe some orange, due to unit test failures)!

- Houston

On Tue, Oct 31, 2023 at 10:32 AM Houston Putman  wrote:

> Ok one last failure! Exciting stuff.
>
> The last one is Solr-Smoketest-9.x
> , which is
> failing to build the artifacts with tons of errors like:
>
>> Execution failed for task 
>> ':solr:solrj:publishJarsPublicationToBuildRepository'.
>> > Failed to publish publication 'jars' to repository 'build'
>>> Invalid publication 'jars': artifact file does not exist: 
>> '/home/jenkins/jenkins-slave/workspace/Solr/Solr-Smoketest-9.x/solr/solrj/build/libs/solr-solrj-9.5.0-javadoc.jar.asc'
>>
>> This is happening on basically all of the modules, and for every type of
> artifact file (jars, poms, etc).
>
> Since this isn't happening on branch_9_4, I would guess that this has
> something to do with the Gradle 8 upgrade SOLR-17026
> 
>
> - Houston
>
> On Mon, Oct 30, 2023 at 2:26 PM Houston Putman  wrote:
>
>> The http1 and http2 code in the Http2SolrClient ultimately create
>> different errors when there are TLS issues.
>> So the fix was merely to accept both types of errors, when checking the
>> output of failed commands.
>>
>> These should be fixed on main, branch_9x and branch_9_4.
>> So let's give it a day and see what other lovely errors are left for us
>> to deal with in Jenkins!
>>
>> - Houston
>>
>> On Mon, Oct 30, 2023 at 11:57 AM Houston Putman 
>> wrote:
>>
>>> Ok, I've determined that the mTLS errors are due to using http1 vs http2
>>> in the client.
>>> I'm not sure why http1 is used by default in different environments (Its
>>> enabled by the `-Dsolr.http1=true` System Property),
>>> but now at least the cause is known. I'll try to fix the ssl integration
>>> tests for the http1 client today.
>>>
>>> - Houston
>>>
>>> On Mon, Oct 30, 2023 at 10:58 AM Houston Putman 
>>> wrote:
>>>
 If you scroll down on the output of
 https://builds.apache.org/job/Solr/job/Solr-Check-main/8273, you can
 see it in the integration tests.
 Search for "not ok 75 start solr with mTLS needed"

 For the builds using crave.io (Solr-Check-9.x), the same failures will
 happen but every time. The builds using the jenkins boxes
 (Solr-Check-main), will only fail these integration tests if they use the*
 lucene-solr-1* machine.

 - Houston

 On Sat, Oct 28, 2023 at 12:46 PM Mikhail Khludnev 
 wrote:

> Hello Houston.
> Thanks for your efforts. How can I check that "MTLs issue"? I looked
> through recent failures, but can't find anything.
>