Re: [Maven Artifact Resolver] Different dependency resolution results

2024-08-09 Thread Tamás Cservenák
Howdy,

How could I reproduce this locally?

T

On Sat, Jul 20, 2024 at 1:28 PM Nick Hensel 
wrote:

> Hi,
>
> I'm resolving dependencies with the help of Maven Artifact Resolver
> (2.0) and I have an issue where resolved (transitive) dependencies
> differ from run to run. Currently I'm using "new
> ConfigurationVersionSelector(new ConfigurableVersionSelector.Highest())"
> as my VersionSelector.
>
> In most cases the same (transitive) dependencies are resolved, but
> occasionally some dependencies are missing or too much.
>
> In my particular test case
> (
> https://codeberg.org/goldmensch/jack/src/branch/jdk-installation-checksum-support/test_project/project/Jack.toml)
>
> the transitive dependencies "javax.inject:javax.inject:1" and
> "org.eclipse.sisu:org.eclipse.sisu.inject:0.9.0.M3" are sometimes
> resolved and sometimes not.
>
> The involved code is located here
>
> https://codeberg.org/goldmensch/jack/src/branch/jdk-installation-checksum-support/src/main/java/io/github/goldmensch/dependencies
> .
>
>
> Best regards,
>
> Nick Hensel
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
>


Re: [Maven Artifact Resolver] Different dependency resolution results

2024-08-09 Thread Tamás Cservenák
Howdy,

tried locally, and I think I got it.
But, by tweaking your code, I spotted that it is your input that is
unstable (different), and hence Resolver comes up with different output as
well.
Make sure you feed the same input (we talk about the same test case, so
project is same) for the same project and then you can expect the same
(resolver) output, otherwise Resolver will carry on the "randomization"
from your code.
Simply put, the project Jack.toml produces different calls to Resolver, but
did not dig deep into the reasons (concurrency?)

Thanks
T

On Fri, Aug 9, 2024 at 11:09 AM Tamás Cservenák  wrote:

> Howdy,
>
> How could I reproduce this locally?
>
> T
>
> On Sat, Jul 20, 2024 at 1:28 PM Nick Hensel
>  wrote:
>
>> Hi,
>>
>> I'm resolving dependencies with the help of Maven Artifact Resolver
>> (2.0) and I have an issue where resolved (transitive) dependencies
>> differ from run to run. Currently I'm using "new
>> ConfigurationVersionSelector(new ConfigurableVersionSelector.Highest())"
>> as my VersionSelector.
>>
>> In most cases the same (transitive) dependencies are resolved, but
>> occasionally some dependencies are missing or too much.
>>
>> In my particular test case
>> (
>> https://codeberg.org/goldmensch/jack/src/branch/jdk-installation-checksum-support/test_project/project/Jack.toml)
>>
>> the transitive dependencies "javax.inject:javax.inject:1" and
>> "org.eclipse.sisu:org.eclipse.sisu.inject:0.9.0.M3" are sometimes
>> resolved and sometimes not.
>>
>> The involved code is located here
>>
>> https://codeberg.org/goldmensch/jack/src/branch/jdk-installation-checksum-support/src/main/java/io/github/goldmensch/dependencies
>> .
>>
>>
>> Best regards,
>>
>> Nick Hensel
>>
>>
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
>> For additional commands, e-mail: dev-h...@maven.apache.org
>>
>>


Re: [Maven Artifact Resolver] Different dependency resolution results

2024-08-09 Thread Tamás Cservenák
Just some details:
"tweak" == added some logging to method
> DependencyResult
retrieve(List
jackDependencies)
and basically your List is unstable for the same project. And dependency
ordering do matter (a LOT).

Thanks
T

On Fri, Aug 9, 2024 at 11:32 AM Tamás Cservenák  wrote:

> Howdy,
>
> tried locally, and I think I got it.
> But, by tweaking your code, I spotted that it is your input that is
> unstable (different), and hence Resolver comes up with different output as
> well.
> Make sure you feed the same input (we talk about the same test case, so
> project is same) for the same project and then you can expect the same
> (resolver) output, otherwise Resolver will carry on the "randomization"
> from your code.
> Simply put, the project Jack.toml produces different calls to Resolver,
> but did not dig deep into the reasons (concurrency?)
>
> Thanks
> T
>
> On Fri, Aug 9, 2024 at 11:09 AM Tamás Cservenák 
> wrote:
>
>> Howdy,
>>
>> How could I reproduce this locally?
>>
>> T
>>
>> On Sat, Jul 20, 2024 at 1:28 PM Nick Hensel
>>  wrote:
>>
>>> Hi,
>>>
>>> I'm resolving dependencies with the help of Maven Artifact Resolver
>>> (2.0) and I have an issue where resolved (transitive) dependencies
>>> differ from run to run. Currently I'm using "new
>>> ConfigurationVersionSelector(new ConfigurableVersionSelector.Highest())"
>>> as my VersionSelector.
>>>
>>> In most cases the same (transitive) dependencies are resolved, but
>>> occasionally some dependencies are missing or too much.
>>>
>>> In my particular test case
>>> (
>>> https://codeberg.org/goldmensch/jack/src/branch/jdk-installation-checksum-support/test_project/project/Jack.toml)
>>>
>>> the transitive dependencies "javax.inject:javax.inject:1" and
>>> "org.eclipse.sisu:org.eclipse.sisu.inject:0.9.0.M3" are sometimes
>>> resolved and sometimes not.
>>>
>>> The involved code is located here
>>>
>>> https://codeberg.org/goldmensch/jack/src/branch/jdk-installation-checksum-support/src/main/java/io/github/goldmensch/dependencies
>>> .
>>>
>>>
>>> Best regards,
>>>
>>> Nick Hensel
>>>
>>>
>>>
>>> -
>>> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
>>> For additional commands, e-mail: dev-h...@maven.apache.org
>>>
>>>


Re: Summer status of planned Resolver releases

2024-08-09 Thread Tamás Cservenák
Howdy,

Resolver 1.9.22 and 2.0.1 are out, next are upcoming Maven releases...
please keep eye and review PRs (for both, if possible)

Thanks
T

On Fri, Aug 2, 2024 at 11:29 AM Tamás Cservenák  wrote:

> Howdy,
>
> just a heads up: we have some nice resolver (memory consumption)
> improvements that will probably yield Resolver 1.x/2.x releases soon (2.x
> has much more aside of these above):
>
> 1.x:
>
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20MRESOLVER%20AND%20fixVersion%20%3D%201.9.22
>
> 2.x:
>
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20MRESOLVER%20AND%20fixVersion%20%3D%202.0.1
>
> Then, following Resolver releases, Maven 3/4 releases are about to happen
> as well (and mvnd also).
>
> Basically, resolver -> maven -> mvnd.
>
> Thanks
> T
>


Re: Summer status of planned Resolver releases

2024-08-09 Thread Martin Desruisseaux

Le 2024-08-09 à 17 h 01, Tamás Cservenák a écrit :

Resolver 1.9.22 and 2.0.1 are out, next are upcoming Maven releases... 
please keep eye and review PRs (for both, if possible)



If it includes Maven 4, can we call it "beta" again?

    Martin



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org