Re: [VOTE] Release Apache Log4net 3.0.0
I don't think I saw a [RESULT] message with a tally of the result. Gary On Sun, Sep 15, 2024 at 3:26 PM Davyd McColl wrote: > > Hi > > Apologies for the late response. FWIW, my +1 too. > > -d > > > On 15 September 2024 20:59:13 Jan Friedrich wrote: > > > Hi, > > > > and here is my +1. > > > > With that the vote passed with 3 +1 votes from Piotr P. Karwasz, Volkan > > Yazıcı and myself. > > I will continue the release process. > > > > Jan > > > > Friday, September 13, 2024, 9:17:46 AM, you wrote: > > > >> +1 > > > >> ✅ Signatures > >> ✅ Checksums > >> ✅ Build (using Docker) > >> ✅ Tests (using Docker) > > > >> Congratulations to the Log4net crew (in particular, to Jan and Davyd 🙇) > >> for their 3rd major release! 🎉 Keep up the great work! 💯 > > > > > > > >> On Thu, Sep 12, 2024 at 8:54 PM Jan Friedrich > >> wrote: > > > >>> This is a vote to release the Apache Log4net 3.0.0. > >>> > >>> Website: > >>> https://logging.staged.apache.org/log4net/release/release-notes.html > >>> GitHub: https://github.com/apache/logging-log4net > >>> GitHub release (pre-release): > >>> https://github.com/apache/logging-log4net/releases/tag/rc/3.0.0-rc1 > >>> Commit: 42ba791745ceb7ff922d828c6c5572ed918df84b > >>> Distribution: https://dist.apache.org/repos/dist/dev/logging/log4net > >>> Signing key: 0x7D24496A230E29D6349A99EF583E491578F02D5D > >>> > >>> > >>> Please download, test, and cast your votes on this mailing list. > >>> > >>> How to run the unit tests? > >>> - install docker (if you haven't already) > >>> - https://docs.docker.com/engine/install/ > >>> - in logging/log4net run > >>> - `docker build -t log4net-builder .` > >>> - `docker run -it log4net-builder` > >>> - this will > >>> - install all dependencies in the container > >>> - build src/log4net.sln > >>> - inside the container run > >>> - `dotnet test /logging-log4net/src/log4net.sln` > >>> > >>> [ ] +1, release the artifacts > >>> [ ] -1, don't release, because ... > >>> > >>> This vote is open for 72 hours and will pass unless getting a > >>> net negative vote count. All votes are welcome and we encourage > >>> everyone to test the release, but only the Logging Services PMC > >>> votes are officially counted. > >>> > >>> > >
Re: [VOTE] Release Apache Log4net 3.0.0
Hi Gary, please see https://lists.apache.org/thread/v8kyxz7zdvp3cypo1506yflk3bbvysym I did not change the subject to [RESULT]. Regards. Jan On 16 September 2024 15:17:06 CEST, Gary Gregory wrote: >I don't think I saw a [RESULT] message with a tally of the result. > >Gary > >On Sun, Sep 15, 2024 at 3:26 PM Davyd McColl wrote: >> >> Hi >> >> Apologies for the late response. FWIW, my +1 too. >> >> -d >> >> >> On 15 September 2024 20:59:13 Jan Friedrich wrote: >> >> > Hi, >> > >> > and here is my +1. >> > >> > With that the vote passed with 3 +1 votes from Piotr P. Karwasz, Volkan >> > Yazıcı and myself. >> > I will continue the release process. >> > >> > Jan >> > >> > Friday, September 13, 2024, 9:17:46 AM, you wrote: >> > >> >> +1 >> > >> >> ✅ Signatures >> >> ✅ Checksums >> >> ✅ Build (using Docker) >> >> ✅ Tests (using Docker) >> > >> >> Congratulations to the Log4net crew (in particular, to Jan and Davyd 🙇) >> >> for their 3rd major release! 🎉 Keep up the great work! 💯 >> > >> > >> > >> >> On Thu, Sep 12, 2024 at 8:54 PM Jan Friedrich >> >> wrote: >> > >> >>> This is a vote to release the Apache Log4net 3.0.0. >> >>> >> >>> Website: >> >>> https://logging.staged.apache.org/log4net/release/release-notes.html >> >>> GitHub: https://github.com/apache/logging-log4net >> >>> GitHub release (pre-release): >> >>> https://github.com/apache/logging-log4net/releases/tag/rc/3.0.0-rc1 >> >>> Commit: 42ba791745ceb7ff922d828c6c5572ed918df84b >> >>> Distribution: https://dist.apache.org/repos/dist/dev/logging/log4net >> >>> Signing key: 0x7D24496A230E29D6349A99EF583E491578F02D5D >> >>> >> >>> >> >>> Please download, test, and cast your votes on this mailing list. >> >>> >> >>> How to run the unit tests? >> >>> - install docker (if you haven't already) >> >>> - https://docs.docker.com/engine/install/ >> >>> - in logging/log4net run >> >>> - `docker build -t log4net-builder .` >> >>> - `docker run -it log4net-builder` >> >>> - this will >> >>> - install all dependencies in the container >> >>> - build src/log4net.sln >> >>> - inside the container run >> >>> - `dotnet test /logging-log4net/src/log4net.sln` >> >>> >> >>> [ ] +1, release the artifacts >> >>> [ ] -1, don't release, because ... >> >>> >> >>> This vote is open for 72 hours and will pass unless getting a >> >>> net negative vote count. All votes are welcome and we encourage >> >>> everyone to test the release, but only the Logging Services PMC >> >>> votes are officially counted. >> >>> >> >>> >> > Jan
Re: Can't build log4j main branch
I just pulled main since we've had changes there, now I get: [ERROR] Tests run: 3, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 15.31 s <<< FAILURE! -- in org.apache.logging.log4j.core.appender.SocketAppenderReconnectTest [ERROR] org.apache.logging.log4j.core.appender.SocketAppenderReconnectTest.repeating_reconnect_failures_should_be_propagated -- Time elapsed: 3.323 s <<< ERROR! org.apache.logging.log4j.core.appender.AppenderLoggingException: Error writing to TCP:localhost:57111 for connection localhost/127.0.0.1:57111 at org.apache.logging.log4j.core.net.TcpSocketManager.write(TcpSocketManager.java:211) at org.apache.logging.log4j.core.appender.OutputStreamManager.write(OutputStreamManager.java:181) at org.apache.logging.log4j.core.appender.AbstractOutputStreamAppender.writeByteArrayToManager(AbstractOutputStreamAppender.java:218) at org.apache.logging.log4j.core.appender.SocketAppender.directEncodeEvent(SocketAppender.java:338) at org.apache.logging.log4j.core.appender.AbstractOutputStreamAppender.tryAppend(AbstractOutputStreamAppender.java:202) at org.apache.logging.log4j.core.appender.AbstractOutputStreamAppender.append(AbstractOutputStreamAppender.java:193) at org.apache.logging.log4j.core.config.AppenderControl.tryCallAppender(AppenderControl.java:155) at org.apache.logging.log4j.core.config.AppenderControl.callAppender0(AppenderControl.java:128) at org.apache.logging.log4j.core.config.AppenderControl.callAppenderPreventRecursion(AppenderControl.java:119) at org.apache.logging.log4j.core.config.AppenderControl.callAppender(AppenderControl.java:83) at org.apache.logging.log4j.core.config.LoggerConfig.callAppenders(LoggerConfig.java:626) at org.apache.logging.log4j.core.config.LoggerConfig.processLogEvent(LoggerConfig.java:586) at org.apache.logging.log4j.core.config.LoggerConfig.log(LoggerConfig.java:562) at org.apache.logging.log4j.core.config.LoggerConfig.log(LoggerConfig.java:496) at org.apache.logging.log4j.core.config.AwaitCompletionReliabilityStrategy.log(AwaitCompletionReliabilityStrategy.java:92) at org.apache.logging.log4j.core.Logger.doLog(Logger.java:158) at org.apache.logging.log4j.kit.logger.AbstractLogger.tryLogMessage(AbstractLogger.java:266) at org.apache.logging.log4j.kit.logger.AbstractLogger.logMessageTrackRecursion(AbstractLogger.java:234) at org.apache.logging.log4j.kit.logger.AbstractLogger.logMessageSafely(AbstractLogger.java:215) at org.apache.logging.log4j.kit.logger.AbstractLogger.logMessage(AbstractLogger.java:340) at org.apache.logging.log4j.kit.logger.AbstractLogger.logIfEnabled(AbstractLogger.java:1092) at org.apache.logging.log4j.kit.logger.AbstractLogger.info(AbstractLogger.java:2336) at org.apache.logging.log4j.core.appender.SocketAppenderReconnectTest.lambda$verifyLoggingSuccess$2(SocketAppenderReconnectTest.java:361) at org.awaitility.core.CallableCondition$ConditionEvaluationWrapper.eval(CallableCondition.java:99) at org.awaitility.core.ConditionAwaiter$ConditionPoller.call(ConditionAwaiter.java:248) at org.awaitility.core.ConditionAwaiter$ConditionPoller.call(ConditionAwaiter.java:235) at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) at java.base/java.lang.Thread.run(Thread.java:840) Caused by: java.net.SocketException: Connection reset by peer at java.base/sun.nio.ch.NioSocketImpl.implWrite(NioSocketImpl.java:425) at java.base/sun.nio.ch.NioSocketImpl.write(NioSocketImpl.java:445) at java.base/sun.nio.ch.NioSocketImpl$2.write(NioSocketImpl.java:831) at java.base/java.net.Socket$SocketOutputStream.write(Socket.java:1035) at org.apache.logging.log4j.core.net.TcpSocketManager.writeAndFlush(TcpSocketManager.java:221) at org.apache.logging.log4j.core.net.TcpSocketManager.write(TcpSocketManager.java:182) ... 29 more Gary On 2024/09/12 12:08:07 "Gary D. Gregory" wrote: > On 2024/09/12 06:51:22 "Piotr P. Karwasz" wrote: > > Hi Gary, > > > > On Wed, 11 Sept 2024 at 22:13, Gary D. Gregory wrote: > > > Running 'mvn clean install' on git main [1] gives me: > > > > > > [ERROR] Failures: > > > [ERROR] AsyncLoggerConfigTest.testSingleFilterInvocation:114 > > > Wanted but not invoked: > > > appender.append(); > > > -> at > > > org.apache.logging.log4j.async.logger.AsyncLoggerConfigTest.testSingleFilterInvocation(AsyncLoggerConfigTest.java:114) > > > > > > However, there was exactly 1 interaction with this mock: > > > appender.getName(); > > > -> at > > > org.apache.logging.log4j.core.config.AppenderControl.(AppenderControl.java:50) > > >
Re: [VOTE] Release Apache Log4net 3.0.0
Ah, thank you. Gary On Mon, Sep 16, 2024, 9:50 AM Jan Friedrich wrote: > Hi Gary, > > please see > https://lists.apache.org/thread/v8kyxz7zdvp3cypo1506yflk3bbvysym > > I did not change the subject to [RESULT]. > > Regards. > > Jan > > On 16 September 2024 15:17:06 CEST, Gary Gregory > wrote: > >I don't think I saw a [RESULT] message with a tally of the result. > > > >Gary > > > >On Sun, Sep 15, 2024 at 3:26 PM Davyd McColl wrote: > >> > >> Hi > >> > >> Apologies for the late response. FWIW, my +1 too. > >> > >> -d > >> > >> > >> On 15 September 2024 20:59:13 Jan Friedrich > wrote: > >> > >> > Hi, > >> > > >> > and here is my +1. > >> > > >> > With that the vote passed with 3 +1 votes from Piotr P. Karwasz, > Volkan > >> > Yazıcı and myself. > >> > I will continue the release process. > >> > > >> > Jan > >> > > >> > Friday, September 13, 2024, 9:17:46 AM, you wrote: > >> > > >> >> +1 > >> > > >> >> ✅ Signatures > >> >> ✅ Checksums > >> >> ✅ Build (using Docker) > >> >> ✅ Tests (using Docker) > >> > > >> >> Congratulations to the Log4net crew (in particular, to Jan and Davyd > 🙇) > >> >> for their 3rd major release! 🎉 Keep up the great work! 💯 > >> > > >> > > >> > > >> >> On Thu, Sep 12, 2024 at 8:54 PM Jan Friedrich > wrote: > >> > > >> >>> This is a vote to release the Apache Log4net 3.0.0. > >> >>> > >> >>> Website: > >> >>> > https://logging.staged.apache.org/log4net/release/release-notes.html > >> >>> GitHub: https://github.com/apache/logging-log4net > >> >>> GitHub release (pre-release): > >> >>> https://github.com/apache/logging-log4net/releases/tag/rc/3.0.0-rc1 > >> >>> Commit: 42ba791745ceb7ff922d828c6c5572ed918df84b > >> >>> Distribution: > https://dist.apache.org/repos/dist/dev/logging/log4net > >> >>> Signing key: 0x7D24496A230E29D6349A99EF583E491578F02D5D > >> >>> > >> >>> > >> >>> Please download, test, and cast your votes on this mailing list. > >> >>> > >> >>> How to run the unit tests? > >> >>> - install docker (if you haven't already) > >> >>> - https://docs.docker.com/engine/install/ > >> >>> - in logging/log4net run > >> >>> - `docker build -t log4net-builder .` > >> >>> - `docker run -it log4net-builder` > >> >>> - this will > >> >>> - install all dependencies in the container > >> >>> - build src/log4net.sln > >> >>> - inside the container run > >> >>> - `dotnet test /logging-log4net/src/log4net.sln` > >> >>> > >> >>> [ ] +1, release the artifacts > >> >>> [ ] -1, don't release, because ... > >> >>> > >> >>> This vote is open for 72 hours and will pass unless getting a > >> >>> net negative vote count. All votes are welcome and we encourage > >> >>> everyone to test the release, but only the Logging Services PMC > >> >>> votes are officially counted. > >> >>> > >> >>> > >> > > > Jan
Re: Can't build log4j main branch
Hi Gary, On Mon, 16 Sept 2024 at 16:50, Gary D. Gregory wrote: > > I just pulled main since we've had changes there, now I get: > > [ERROR] Tests run: 3, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 15.31 > s <<< FAILURE! -- in > org.apache.logging.log4j.core.appender.SocketAppenderReconnectTest > [ERROR] > org.apache.logging.log4j.core.appender.SocketAppenderReconnectTest.repeating_reconnect_failures_should_be_propagated > -- Time elapsed: 3.323 s <<< ERROR! > org.apache.logging.log4j.core.appender.AppenderLoggingException: Error > writing to TCP:localhost:57111 for connection localhost/127.0.0.1:57111 This is a test with a proven history of flakiness[1]. I guess we need to add more conditions to the test (e.g. wait until the server received a connection request from the client). Piotr [1] https://ge.apache.org/scans/tests?search.relativeStartTime=P90D&search.rootProjectNames=Apache%20Log4j%20BOM&search.timeZoneId=Europe%2FWarsaw&tests.container=org.apache.logging.log4j.core.net.SocketAppenderReconnectTest#
Re: Can't build log4j main branch
Gary has a failure on L361, that is, it retries every 100ms to succeed with `logger.info()` for at most 2mins. I doubt if more waiting will solve the problem. I tried to improve that test several times (see its history), but Windows just behaves weird with sockets. I'd appreciate it if Windows users can share some tips on what else we can do. Piotr, you say "a proven history of flakiness", but the link you shared states, out of 1.26k times, in the last 90 days, it has failed only 2 times, and was flaky only 16 times. What is our definition of flakiness here? On Mon, Sep 16, 2024 at 7:09 PM Piotr P. Karwasz wrote: > Hi Gary, > > On Mon, 16 Sept 2024 at 16:50, Gary D. Gregory > wrote: > > > > I just pulled main since we've had changes there, now I get: > > > > [ERROR] Tests run: 3, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: > 15.31 s <<< FAILURE! -- in > org.apache.logging.log4j.core.appender.SocketAppenderReconnectTest > > [ERROR] > org.apache.logging.log4j.core.appender.SocketAppenderReconnectTest.repeating_reconnect_failures_should_be_propagated > -- Time elapsed: 3.323 s <<< ERROR! > > org.apache.logging.log4j.core.appender.AppenderLoggingException: Error > writing to TCP:localhost:57111 for connection localhost/127.0.0.1:57111 > > This is a test with a proven history of flakiness[1]. I guess we need > to add more conditions to the test (e.g. wait until the server > received a connection request from the client). > > Piotr > > [1] > https://ge.apache.org/scans/tests?search.relativeStartTime=P90D&search.rootProjectNames=Apache%20Log4j%20BOM&search.timeZoneId=Europe%2FWarsaw&tests.container=org.apache.logging.log4j.core.net.SocketAppenderReconnectTest# >
