Re: Website footer copyright
Hi Robert, On Tue, 13 Aug 2024 at 00:11, Robert Middleton wrote: > > Stephen has gone and made an update to the log4cxx footer: > https://github.com/apache/logging-log4cxx/pull/406/files > This mentions dormant projects(e.g. chainsaw, log4php) and also > mentions Oracle. Should there be a common footer, or should it be > more unique on a per-project basis? Should we remove the dormant > projects? +1 for a common footer. I think that dormant projects should be there. Their names are reserved and nobody should call their product `Chainsaw` or `Log4PHP`. Piotr
Re: Unable to locate plugin type for Custom log4j2 Appender
Hi Amanda, I am crossposting this to dev@logging.apache.org. Please answer to that mailing list. On Tue, 6 Aug 2024 at 01:05, Amanda Liu wrote: > The reason I want a custom appender is to pretty print the JSON log objects > produced by JsonTemplateLayout, to make it more readable. I see in the log4j > docs that JSON pretty print is supported in JsonLayout, but not > JsonTemplateLayout. I don't want to use JsonLayout, since it's deprecated and > doesn't support some other features that JSONTemplateLayout has. > > Is there any strong reason why JsonTemplateLayout does not support JSON > pretty print? Or could I contribute to the JsonTemplateLayout file in the > log4j repo to add this feature? (here: > https://github.com/apache/logging-log4j2/blob/a884e991c1a551cb321b2efed770a15fbc55aa2b/log4j-layout-template-json/src/main/java/org/apache/logging/log4j/layout/template/json/JsonTemplateLayout.java). > This would resolve my issue, and I think other log4j JsonTemplateLayout > users may be interested in the pretty print feature. There is no special reason why `JsonTemplateLayout` does not support pretty print. It was simply never implemented. Currently JTL only writes to a small `JsonWriter`[1] class through `TemplateResolver.resolve()`[2]. This could be easily generalized (probably in `3.x`) by replacing `JsonWriter` with an interface, to support multiple serialization formats. There is already a JIRA issue for that (see LOG4J2-3082[0]). Admittedly this requires quite some work, but it is within the grasp of a semester-long student project or Google Summer of Code. If you are willing to contribute such a feature, we can always assist you with the Log4j-related details. Piotr BTW: I added more info about shading applications that use Log4j Core to our documentation[3] [0] https://issues.apache.org/jira/browse/LOG4J2-3082 [1] https://javadoc.io/static/org.apache.logging.log4j/log4j-layout-template-json/2.19.0/org/apache/logging/log4j/layout/template/json/util/JsonWriter.html [2] https://javadoc.io/static/org.apache.logging.log4j/log4j-layout-template-json/2.19.0/org/apache/logging/log4j/layout/template/json/resolver/TemplateResolver.html#resolve-V-org.apache.logging.log4j.layout.template.json.util.JsonWriter- [3] https://github.com/apache/logging-log4j2/blob/2.x/src/site/antora/modules/ROOT/pages/faq.adoc#how-do-i-create-a-single-jar-application-containing-log4j-core
Release timeline for log4j 2.24.0?
HI - just curious when the updated ThreadContextMap will be available? The latest release is 2.23.1, over five months ago. Thanks! :) John
Re: Release timeline for log4j 2.24.0?
Hi John, On Tue, 13 Aug 2024 at 21:10, John Engebretson wrote: > HI - just curious when the updated ThreadContextMap will be available? > The latest release is 2.23.1, over five months ago. We just finished a long series of documentation tasks that kept us occupied for the past since May[1]. I will be able to concentrate on cutting this almost mythical 2.24.0 release in the next few weeks. Piotr [1] https://github.com/apache/logging-log4j2/issues/2542
Re: Release timeline for log4j 2.24.0?
John, You should test our snapshot builds just in case ;-) Gary On Tue, Aug 13, 2024, 3:43 PM Piotr P. Karwasz wrote: > Hi John, > > On Tue, 13 Aug 2024 at 21:10, John Engebretson > wrote: > > HI - just curious when the updated ThreadContextMap will be available? > > The latest release is 2.23.1, over five months ago. > > We just finished a long series of documentation tasks that kept us > occupied for the past since May[1]. > > I will be able to concentrate on cutting this almost mythical 2.24.0 > release in the next few weeks. > > Piotr > > [1] https://github.com/apache/logging-log4j2/issues/2542 >
Re: Release timeline for log4j 2.24.0?
Piotr, I am still concerned that you never looked into the issues I had with StringArrayThreadContextMap. My performance tests were showing that it was fast because it wasn’t actually setting values. Ralph > On Aug 13, 2024, at 12:43 PM, Piotr P. Karwasz > wrote: > > Hi John, > > On Tue, 13 Aug 2024 at 21:10, John Engebretson wrote: >> HI - just curious when the updated ThreadContextMap will be available? >> The latest release is 2.23.1, over five months ago. > > We just finished a long series of documentation tasks that kept us > occupied for the past since May[1]. > > I will be able to concentrate on cutting this almost mythical 2.24.0 > release in the next few weeks. > > Piotr > > [1] https://github.com/apache/logging-log4j2/issues/2542
Re: Release timeline for log4j 2.24.0?
Isn't that assertable from a unit test? Gary On Tue, Aug 13, 2024, 6:00 PM Ralph Goers wrote: > Piotr, I am still concerned that you never looked into the issues I had > with StringArrayThreadContextMap. My performance tests were showing that it > was fast because it wasn’t actually setting values. > > Ralph > > > On Aug 13, 2024, at 12:43 PM, Piotr P. Karwasz > wrote: > > > > Hi John, > > > > On Tue, 13 Aug 2024 at 21:10, John Engebretson > wrote: > >> HI - just curious when the updated ThreadContextMap will be available? > >> The latest release is 2.23.1, over five months ago. > > > > We just finished a long series of documentation tasks that kept us > > occupied for the past since May[1]. > > > > I will be able to concentrate on cutting this almost mythical 2.24.0 > > release in the next few weeks. > > > > Piotr > > > > [1] https://github.com/apache/logging-log4j2/issues/2542 > >
Re: Release timeline for log4j 2.24.0?
The benchmark code I used was https://github.com/apache/logging-log4j2/blob/feature/move-thread-context/log4j-perf-test/src/main/java/org/apache/logging/log4j/perf/jmh/ThreadContextVsScopedContextBenchmark.java Ralph > On Aug 13, 2024, at 3:00 PM, Ralph Goers wrote: > > Piotr, I am still concerned that you never looked into the issues I had with > StringArrayThreadContextMap. My performance tests were showing that it was > fast because it wasn’t actually setting values. > > Ralph > >> On Aug 13, 2024, at 12:43 PM, Piotr P. Karwasz >> wrote: >> >> Hi John, >> >> On Tue, 13 Aug 2024 at 21:10, John Engebretson wrote: >>> HI - just curious when the updated ThreadContextMap will be available? >>> The latest release is 2.23.1, over five months ago. >> >> We just finished a long series of documentation tasks that kept us >> occupied for the past since May[1]. >> >> I will be able to concentrate on cutting this almost mythical 2.24.0 >> release in the next few weeks. >> >> Piotr >> >> [1] https://github.com/apache/logging-log4j2/issues/2542 >
Re: Release timeline for log4j 2.24.0?
Hi Ralph, On Wed, 14 Aug 2024 at 00:00, Ralph Goers wrote: > > Piotr, I am still concerned that you never looked into the issues I had with > StringArrayThreadContextMap. My performance tests were showing that it was > fast because it wasn’t actually setting values. It's on my TODO list. Note that the PR that changes the default ContextMap implementation[1] has not been merged yet. Piotr [1] https://github.com/apache/logging-log4j2/pull/2690