[VOTE] Release Apache Log4j Kotlin API `1.5.0` RC1

2024-08-03 Thread Volkan Yazıcı
This is a vote to release the Apache Log4j Kotlin API `1.5.0`.

Website: https://logging.staged.apache.org/log4j/kotlin-1.5.0
GitHub: https://github.com/apache/logging-log4j-kotlin
Commit: 57bc699b9e91a94a7df279f226e4f0ae86769062
Distribution: https://dist.apache.org/repos/dist/dev/logging/log4j-kotlin
Nexus:
https://repository.apache.org/content/repositories/orgapachelogging-1290
Signing key: 0x077e8893a6dcc33dd4a4d5b256e73ba9a0b592d0

Please download, test, and cast your votes on this mailing list.

[ ] +1, release the artifacts
[ ] -1, don't release, because...

This vote is open for 72 hours and will pass unless getting a
net negative vote count. All votes are welcome and we encourage
everyone to test the release, but only the Logging Services PMC
votes are officially counted. At least 3 +1 votes and more
positive than negative votes are required.

== Review kit

The minimum set of steps needed to review the uploaded distribution
files in the Subversion repository can be summarized as follows:

# Check out the distribution
svn co https://dist.apache.org/repos/dist/dev/logging/log4j-kotlin &&
cd $_

# Verify checksums
shasum --check *.sha512

# Verify signatures
wget -O - https://downloads.apache.org/logging/KEYS | gpg --import
for sigFile in *.asc; do gpg --verify $sigFile; done

# Verify reproduciblity
umask 0022
unzip *-src.zip -d src
cd src
export NEXUS_REPO=
https://repository.apache.org/content/repositories/orgapachelogging-1290
sh mvnw -Prelease verify artifact:compare -Dreference.repo=$NEXUS_REPO
# If preferred, augment `mvnw` with `-DskipTests` to speed things up

== Release Notes

This release contains improvements to Kotlin coroutine integration.

=== Added

* Add convenience functions for managing logging context in coroutines (#65)

=== Changed

* Migrate website to Antora (apache/logging-log4j2#2443)

=== Updated

* Update `org.apache.logging.log4j:log4j-bom` to version `2.23.1` (#70)


Re: [VOTE] Release Apache Log4j Kotlin API `1.5.0` RC1

2024-08-03 Thread Gary Gregory
Using the review kit, running:

sh mvnw -Prelease verify artifact:compare -Dreference.repo=$NEXUS_REPO

I get:

[INFO] --- artifact:3.5.0:compare (default-cli) @ log4j-api-kotlin-parent ---
Downloading from reference:
https://repository.apache.org/content/repositories/orgapachelogging-1290/org/apache/logging/log4j/log4j-api-kotlin-parent/1.4.0/log4j-api-kotlin-parent-1.4.0.buildinfo
[INFO] Reference buildinfo file not found: it will be generated from
downloaded reference artifacts
Downloading from reference:
https://repository.apache.org/content/repositories/orgapachelogging-1290/org/apache/logging/log4j/log4j-api-kotlin-parent/1.4.0/log4j-api-kotlin-parent-1.4.0.pom
[WARNING] Reference artifact not found
org.apache.logging.log4j:log4j-api-kotlin-parent:pom:1.4.0
Downloading from reference:
https://repository.apache.org/content/repositories/orgapachelogging-1290/org/apache/logging/log4j/log4j-api-kotlin-parent/1.4.0/log4j-api-kotlin-parent-1.4.0-cyclonedx.xml
[WARNING] Reference artifact not found
org.apache.logging.log4j:log4j-api-kotlin-parent:xml:cyclonedx:1.4.0
[INFO] Minimal buildinfo generated from downloaded artifacts:
/Users/garydgregory/rc/log4j-kotlin/src/target/reference/log4j-api-kotlin-parent-1.4.0.buildinfo
[ERROR] size mismatch log4j-api-kotlin-parent-1.4.0.pom: investigate
with diffoscope
target/reference/org.apache.logging.log4j/log4j-api-kotlin-parent-1.4.0.pom
.flattened-pom.xml
[ERROR] size mismatch log4j-api-kotlin-parent-1.4.0-cyclonedx.xml:
investigate with diffoscope
target/reference/org.apache.logging.log4j/log4j-api-kotlin-parent-1.4.0-cyclonedx.xml
target/bom.xml
[ERROR] Reproducible Build output summary: 0 files ok, 2 different
[ERROR] see diff
target/reference/log4j-api-kotlin-parent-1.4.0.buildinfo
target/log4j-api-kotlin-parent-1.4.0.buildinfo
[ERROR] see also
https://maven.apache.org/guides/mini/guide-reproducible-builds.html
[INFO] Reproducible Build output comparison saved to
/Users/garydgregory/rc/log4j-kotlin/src/target/log4j-api-kotlin-parent-1.4.0.buildcompare
[INFO] Aggregate buildcompare copied to
/Users/garydgregory/rc/log4j-kotlin/src/target/log4j-api-kotlin-parent-1.4.0.buildcompare
[INFO] 
[INFO] Reactor Summary for Apache Log4j Kotlin API Parent 1.4.0:
[INFO]
[INFO] Apache Log4j Kotlin API Parent . FAILURE [ 28.636 s]
[INFO] Apache Log4j Kotlin API  SKIPPED
[INFO] Apache Log4j Kotlin API samples  SKIPPED
[INFO] log4j-api-kotlin-benchmark . SKIPPED
[INFO] 
[INFO] BUILD FAILURE
[INFO] 
[INFO] Total time:  32.610 s
[INFO] Finished at: 2024-08-03T17:45:38-04:00
[INFO] 

Ideas?

Gary

On Sat, Aug 3, 2024 at 1:23 PM Volkan Yazıcı  wrote:
>
> This is a vote to release the Apache Log4j Kotlin API `1.5.0`.
>
> Website: https://logging.staged.apache.org/log4j/kotlin-1.5.0
> GitHub: https://github.com/apache/logging-log4j-kotlin
> Commit: 57bc699b9e91a94a7df279f226e4f0ae86769062
> Distribution: https://dist.apache.org/repos/dist/dev/logging/log4j-kotlin
> Nexus:
> https://repository.apache.org/content/repositories/orgapachelogging-1290
> Signing key: 0x077e8893a6dcc33dd4a4d5b256e73ba9a0b592d0
>
> Please download, test, and cast your votes on this mailing list.
>
> [ ] +1, release the artifacts
> [ ] -1, don't release, because...
>
> This vote is open for 72 hours and will pass unless getting a
> net negative vote count. All votes are welcome and we encourage
> everyone to test the release, but only the Logging Services PMC
> votes are officially counted. At least 3 +1 votes and more
> positive than negative votes are required.
>
> == Review kit
>
> The minimum set of steps needed to review the uploaded distribution
> files in the Subversion repository can be summarized as follows:
>
> # Check out the distribution
> svn co https://dist.apache.org/repos/dist/dev/logging/log4j-kotlin &&
> cd $_
>
> # Verify checksums
> shasum --check *.sha512
>
> # Verify signatures
> wget -O - https://downloads.apache.org/logging/KEYS | gpg --import
> for sigFile in *.asc; do gpg --verify $sigFile; done
>
> # Verify reproduciblity
> umask 0022
> unzip *-src.zip -d src
> cd src
> export NEXUS_REPO=
> https://repository.apache.org/content/repositories/orgapachelogging-1290
> sh mvnw -Prelease verify artifact:compare -Dreference.repo=$NEXUS_REPO
> # If preferred, augment `mvnw` with `-DskipTests` to speed things up
>
> == Release Notes
>
> This release contains improvements to Kotlin coroutine integration.
>
> === Added
>
> * Add convenience functions for managing logging context in coroutines (#65)
>
> === Changed
>
> * Migrate website to Antora (apache/logging-log4

Re: [VOTE] Release Apache Log4j Kotlin API `1.5.0` RC1

2024-08-03 Thread Gary Gregory
I am using:

openjdk version "17.0.12" 2024-07-16
OpenJDK Runtime Environment Homebrew (build 17.0.12+0)
OpenJDK 64-Bit Server VM Homebrew (build 17.0.12+0, mixed mode, sharing)

Apache Maven 3.9.8 (36645f6c9b5079805ea5009217e36f2cffd34256)
Maven home: /usr/local/Cellar/maven/3.9.8/libexec
Java version: 17.0.12, vendor: Homebrew, runtime:
/usr/local/Cellar/openjdk@17/17.0.12/libexec/openjdk.jdk/Contents/Home
Default locale: en_US, platform encoding: UTF-8
OS name: "mac os x", version: "14.6", arch: "x86_64", family: "mac"

Darwin  23.6.0 Darwin Kernel Version 23.6.0: Fri Jul  5 17:54:20
PDT 2024; root:xnu-10063.141.1~2/RELEASE_X86_64 x86_64

Gary

On Sat, Aug 3, 2024 at 5:46 PM Gary Gregory  wrote:
>
> Using the review kit, running:
>
> sh mvnw -Prelease verify artifact:compare -Dreference.repo=$NEXUS_REPO
>
> I get:
>
> [INFO] --- artifact:3.5.0:compare (default-cli) @ log4j-api-kotlin-parent ---
> Downloading from reference:
> https://repository.apache.org/content/repositories/orgapachelogging-1290/org/apache/logging/log4j/log4j-api-kotlin-parent/1.4.0/log4j-api-kotlin-parent-1.4.0.buildinfo
> [INFO] Reference buildinfo file not found: it will be generated from
> downloaded reference artifacts
> Downloading from reference:
> https://repository.apache.org/content/repositories/orgapachelogging-1290/org/apache/logging/log4j/log4j-api-kotlin-parent/1.4.0/log4j-api-kotlin-parent-1.4.0.pom
> [WARNING] Reference artifact not found
> org.apache.logging.log4j:log4j-api-kotlin-parent:pom:1.4.0
> Downloading from reference:
> https://repository.apache.org/content/repositories/orgapachelogging-1290/org/apache/logging/log4j/log4j-api-kotlin-parent/1.4.0/log4j-api-kotlin-parent-1.4.0-cyclonedx.xml
> [WARNING] Reference artifact not found
> org.apache.logging.log4j:log4j-api-kotlin-parent:xml:cyclonedx:1.4.0
> [INFO] Minimal buildinfo generated from downloaded artifacts:
> /Users/garydgregory/rc/log4j-kotlin/src/target/reference/log4j-api-kotlin-parent-1.4.0.buildinfo
> [ERROR] size mismatch log4j-api-kotlin-parent-1.4.0.pom: investigate
> with diffoscope
> target/reference/org.apache.logging.log4j/log4j-api-kotlin-parent-1.4.0.pom
> .flattened-pom.xml
> [ERROR] size mismatch log4j-api-kotlin-parent-1.4.0-cyclonedx.xml:
> investigate with diffoscope
> target/reference/org.apache.logging.log4j/log4j-api-kotlin-parent-1.4.0-cyclonedx.xml
> target/bom.xml
> [ERROR] Reproducible Build output summary: 0 files ok, 2 different
> [ERROR] see diff
> target/reference/log4j-api-kotlin-parent-1.4.0.buildinfo
> target/log4j-api-kotlin-parent-1.4.0.buildinfo
> [ERROR] see also
> https://maven.apache.org/guides/mini/guide-reproducible-builds.html
> [INFO] Reproducible Build output comparison saved to
> /Users/garydgregory/rc/log4j-kotlin/src/target/log4j-api-kotlin-parent-1.4.0.buildcompare
> [INFO] Aggregate buildcompare copied to
> /Users/garydgregory/rc/log4j-kotlin/src/target/log4j-api-kotlin-parent-1.4.0.buildcompare
> [INFO] 
> 
> [INFO] Reactor Summary for Apache Log4j Kotlin API Parent 1.4.0:
> [INFO]
> [INFO] Apache Log4j Kotlin API Parent . FAILURE [ 28.636 
> s]
> [INFO] Apache Log4j Kotlin API  SKIPPED
> [INFO] Apache Log4j Kotlin API samples  SKIPPED
> [INFO] log4j-api-kotlin-benchmark . SKIPPED
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time:  32.610 s
> [INFO] Finished at: 2024-08-03T17:45:38-04:00
> [INFO] 
> 
>
> Ideas?
>
> Gary
>
> On Sat, Aug 3, 2024 at 1:23 PM Volkan Yazıcı  wrote:
> >
> > This is a vote to release the Apache Log4j Kotlin API `1.5.0`.
> >
> > Website: https://logging.staged.apache.org/log4j/kotlin-1.5.0
> > GitHub: https://github.com/apache/logging-log4j-kotlin
> > Commit: 57bc699b9e91a94a7df279f226e4f0ae86769062
> > Distribution: https://dist.apache.org/repos/dist/dev/logging/log4j-kotlin
> > Nexus:
> > https://repository.apache.org/content/repositories/orgapachelogging-1290
> > Signing key: 0x077e8893a6dcc33dd4a4d5b256e73ba9a0b592d0
> >
> > Please download, test, and cast your votes on this mailing list.
> >
> > [ ] +1, release the artifacts
> > [ ] -1, don't release, because...
> >
> > This vote is open for 72 hours and will pass unless getting a
> > net negative vote count. All votes are welcome and we encourage
> > everyone to test the release, but only the Logging Services PMC
> > votes are officially counted. At least 3 +1 votes and more
> > positive than negative votes are required.
> >
> > == Review kit
> >
> > The minimum set of steps needed to review the uploaded distribution
> > files in the Subversion repository can be summarized as follows:
> >
> > # Check out the distribution
> >  

Re: [VOTE] Release Apache Log4j Kotlin API `1.5.0` RC1

2024-08-03 Thread Piotr P. Karwasz
Hi Gary,

On Sat, 3 Aug 2024 at 23:47, Gary Gregory  wrote:
>
> Using the review kit, running:
>
> sh mvnw -Prelease verify artifact:compare -Dreference.repo=$NEXUS_REPO
>
> I get:
>
> [INFO] --- artifact:3.5.0:compare (default-cli) @ log4j-api-kotlin-parent ---
> Downloading from reference:
> https://repository.apache.org/content/repositories/orgapachelogging-1290/org/apache/logging/log4j/log4j-api-kotlin-parent/1.4.0/log4j-api-kotlin-parent-1.4.0.buildinfo

The Subversion repo still has old 1.4.0 sources.
Those you should use are in the 1.5.0 subfolder:
https://dist.apache.org/repos/dist/dev/logging/log4j-kotlin/1.5.0/

Piotr


Re: [VOTE] Release Apache Log4j Kotlin API `1.5.0` RC1

2024-08-03 Thread Gary Gregory
Could the "review kit" instructions be incorrect then? I'm pretty sure I
just followed the steps.

Gary

On Sat, Aug 3, 2024, 6:15 PM Piotr P. Karwasz 
wrote:

> Hi Gary,
>
> On Sat, 3 Aug 2024 at 23:47, Gary Gregory  wrote:
> >
> > Using the review kit, running:
> >
> > sh mvnw -Prelease verify artifact:compare -Dreference.repo=$NEXUS_REPO
> >
> > I get:
> >
> > [INFO] --- artifact:3.5.0:compare (default-cli) @
> log4j-api-kotlin-parent ---
> > Downloading from reference:
> >
> https://repository.apache.org/content/repositories/orgapachelogging-1290/org/apache/logging/log4j/log4j-api-kotlin-parent/1.4.0/log4j-api-kotlin-parent-1.4.0.buildinfo
>
> The Subversion repo still has old 1.4.0 sources.
> Those you should use are in the 1.5.0 subfolder:
> https://dist.apache.org/repos/dist/dev/logging/log4j-kotlin/1.5.0/
>
> Piotr
>