Re: Deterministic formatter

[Piotr P. Karwasz]

Hi all,

On Thu, 21 Sept 2023 at 07:15, Piotr P. Karwasz  wrote:
> Spotless supports many formatter plugins, the main ones being Eclipse,
> Google and Palantir formatters. All three are IDE agnostic.

I created two PRs using the Google (AOSP variant)[1] and Palantir[2] formatter.

If we were to adopt one of these we are facing around 15% of changes
in LOCs (mostly wrapping of long lines). This seems acceptable to me,
what do you think?

Piotr

[1] https://github.com/apache/logging-log4j2/pull/1910
[2] https://github.com/apache/logging-log4j2/pull/1911

Re: Deterministic formatter

[Matt Sicker]

Seems reasonable to me. I can’t really tell what the difference is between the 
two resulting outputs, though.

> On Oct 25, 2023, at 3:06 PM, Piotr P. Karwasz  wrote:
> 
> Hi all,
> 
> On Thu, 21 Sept 2023 at 07:15, Piotr P. Karwasz  
> wrote:
>> Spotless supports many formatter plugins, the main ones being Eclipse,
>> Google and Palantir formatters. All three are IDE agnostic.
> 
> I created two PRs using the Google (AOSP variant)[1] and Palantir[2] 
> formatter.
> 
> If we were to adopt one of these we are facing around 15% of changes
> in LOCs (mostly wrapping of long lines). This seems acceptable to me,
> what do you think?
> 
> Piotr
> 
> [1] https://github.com/apache/logging-log4j2/pull/1910
> [2] https://github.com/apache/logging-log4j2/pull/1911

Re: Deterministic formatter

[Piotr P. Karwasz]

Hi Matt,

On Thu, 26 Oct 2023 at 01:03, Matt Sicker  wrote:
>
> Seems reasonable to me. I can’t really tell what the difference is between 
> the two resulting outputs, though.

There was no difference (I must have used the same Spotless config
twice), so I corrected it.

Anyway the differences are very subtle and are mainly in the wrapping algorithm:

https://github.com/palantir/palantir-java-format

Piotr