Re: [VOTE] Release Apache Log4j 2.21.0

2023-10-14 Thread Gary D. Gregory
I just ran mvn clean verify and I think I need a new machine ;-) I took... 13 
hours?

[INFO] Reactor Summary for Apache Log4j BOM 2.21.0:
[INFO]
[INFO] Apache Log4j BOM ... SUCCESS [ 22.553 s]
[INFO] Apache Log4j Parent  SUCCESS [  1.001 s]
[INFO] Apache Log4j API Java 9 support  SUCCESS [ 13.793 s]
[INFO] Apache Log4j API ... SUCCESS [ 17.593 s]
[INFO] Apache Log4j Implementation Java 9 support . SUCCESS [  3.302 s]
[INFO] Apache Log4j Core .. SUCCESS [ 53.174 s]
[INFO] Apache Log4j API Tests . SUCCESS [01:31 min]
[INFO] Apache Log4j Core Tests  SUCCESS [  12:48 h]
[INFO] Apache Log4j 1.x Compatibility API . SUCCESS [01:27 min]
[INFO] Apache Log4j App Server Support  SUCCESS [  3.361 s]
[INFO] Apache Log4j to SLF4J Adapter .. SUCCESS [ 10.116 s]
[INFO] Apache Log4j SLF4J Binding . SUCCESS [ 16.419 s]
[INFO] Apache Log4j Cassandra . SUCCESS [  9.899 s]
[INFO] Apache Log4j Core Integration Tests  SUCCESS [  6.208 s]
[INFO] Apache Log4j CouchDB ... SUCCESS [  3.788 s]
[INFO] Apache Log4j Docker Library  SUCCESS [  3.271 s]
[INFO] Apache Log4j Commons Logging Bridge  SUCCESS [ 21.961 s]
[INFO] Apache Log4j Flume Bridge .. SUCCESS [01:25 min]
[INFO] Apache Log4j Streaming Interface ... SUCCESS [ 23.117 s]
[INFO] Apache Log4j Jakarta SMTP .. SUCCESS [  9.385 s]
[INFO] Apache Log4j Jakarta Web ... SUCCESS [ 13.454 s]
[INFO] Apache Log4j JPA ... SUCCESS [ 24.396 s]
[INFO] Apache Log4j JDK Platform Logging Adapter .. SUCCESS [  7.531 s]
[INFO] Apache Log4j JDBC DBCP 2 ... SUCCESS [  8.388 s]
[INFO] Apache Log4j JUL Adapter ... SUCCESS [ 22.978 s]
[INFO] Apache Log4j Kubernetes Library  SUCCESS [  9.065 s]
[INFO] Apache Log4j JSON Template Layout .. SUCCESS [  8.276 s]
[INFO] Apache Log4j JSON Template Layout tests  SUCCESS [ 46.068 s]
[INFO] Apache Log4j MongoDB 3 . SUCCESS [ 52.379 s]
[INFO] Apache Log4j MongoDB 4 . SUCCESS [ 44.917 s]
[INFO] Apache Log4j to JUL Bridge . SUCCESS [  7.898 s]
[INFO] Apache Log4j OSGi .. SUCCESS [ 12.320 s]
[INFO] Apache Log4J Performance Tests . SUCCESS [ 15.628 s]
[INFO] Apache Log4j SLF4J 2.0 Binding . SUCCESS [ 16.239 s]
[INFO] Apache Log4j Spring Boot Support ... SUCCESS [ 11.931 s]
[INFO] Apache Log4j Spring Cloud Config Support ... SUCCESS [  0.746 s]
[INFO] Apache Log4j Spring Cloud Config Client Support  SUCCESS [ 13.337 s]
[INFO] Apache Log4j Web ... SUCCESS [ 14.779 s]
[INFO] Apache Log4j Tag Library ... SUCCESS [ 15.585 s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time:  13:02 h
[INFO] Finished at: 2023-10-14T00:10:38-04:00
[INFO] 

My machine must have been busy doing something else. Aside from that, I tested 
the src zip file. ASC OK. SHA OK. I also ran a separate RAT check: OK.

+1

Gary


On 2023/10/13 09:08:28 Christian Grobmeier wrote:
> This is a vote to release the Apache Log4j 2.21.0.
> 
> Website: https://logging-log4j.staged.apache.org/log4j/2.x/
> GitHub: https://github.com/apache/logging-log4j2
> Commit: 493d9a9daabc72d10582c4682538baa93a2a
> Distribution: https://dist.apache.org/repos/dist/dev/logging/log4j
> Nexus: 
> https://repository.apache.org/content/repositories/orgapachelogging-1202
> Signing key: 0x077e8893a6dcc33dd4a4d5b256e73ba9a0b592d0
> 
> Please download, test, and cast your votes on this mailing list.
> 
> [ ] +1, release the artifacts
> [ ] -1, don't release, because...
> 
> This vote is open for 72 hours and will pass unless getting a
> net negative vote count. All votes are welcome and we encourage
> everyone to test the release, but only the Logging Services PMC
> votes are officially counted.
> 
> == Release Notes
> 
> This release primarily focuses on enhancements to our OSGi and JPMS support 
> and contains several bug fixes.
> It will be the first release built and signed by the CI using the 
> https://keyserver.ubuntu.com/pks/lookup?search=077E8893A6DCC33DD4A4D5B256E73BA9A0B592D0&op=index[ASF
>  Logging Services Release Manager GPG key], which is shared in 
> ht

Re: [VOTE] Release Apache Log4j 2.21.0

2023-10-14 Thread Piotr P. Karwasz
Hi Gary,

On Sat, 14 Oct 2023 at 13:56, Gary D. Gregory  wrote:
>
> I just ran mvn clean verify and I think I need a new machine ;-) I took... 13 
> hours?

This happened also on the CI yesterday (for the first time in several
months IIRC): 
https://github.com/apache/logging-log4j2/actions/runs/6508918262/attempts/1

I checked the run out, the test that took several hours was:
RollingAppenderDeleteScriptFri13thTest ;-)

Piotr


Re: [VOTE] Release Apache Log4j 2.21.0

2023-10-14 Thread Ralph Goers
Well guess what? Yesterday was Fri 13. I wonder if that confuses the test.

Ralph

> On Oct 14, 2023, at 9:02 AM, Piotr P. Karwasz  wrote:
> 
> Hi Gary,
> 
> On Sat, 14 Oct 2023 at 13:56, Gary D. Gregory  wrote:
>> 
>> I just ran mvn clean verify and I think I need a new machine ;-) I took... 
>> 13 hours?
> 
> This happened also on the CI yesterday (for the first time in several
> months IIRC): 
> https://github.com/apache/logging-log4j2/actions/runs/6508918262/attempts/1
> 
> I checked the run out, the test that took several hours was:
> RollingAppenderDeleteScriptFri13thTest ;-)
> 
> Piotr



Re: [VOTE] Release Apache Log4j 2.21.0

2023-10-14 Thread Ralph Goers
+1

My first attempt at building from the source failed with

[ERROR]   
SyslogAppenderCustomLayoutTest>SyslogAppenderTest.testUDPAppender:80->SyslogAppenderTestBase.sendAndCheckLegacyBsdMessage:75->SyslogAppenderTestBase.checkTheNumberOfSentAndReceivedMessages:113
 The number of received messages should be equal with the number of sent 
messages expected:<1> but was:<0>

My second attempt failed with

[ERROR] Failures: 
[ERROR]   SystemClockTest.testAfterWaitStillLessThan2Millis:43 diff too large: 
12 ==> expected:  but was: 

On the third try the build succeeded.

On the positive side, log4j-core-tests only takes a little over 4 minutes now 
on my new MacBook Pro and the entire build completed in 13 minutes. 


MacBook Pro 16-inch, 2023
ChipApple M2 Max
Memory.  96GB
MacOS.   Ventura 13.6

I also ran the build on my Intel MacBool Pro, which is where many of the 
previous releases were performed. It successfully completed in 15 minutes.

Verified the sha512 and the signatures of the bin and src archives.

The staged web site looks OK to me.

Note: I deleted the log4j-perf folder from the staging repo as it should not be 
deployed to Maven Central.

Ralph



> On Oct 13, 2023, at 2:08 AM, Christian Grobmeier  wrote:
> 
> This is a vote to release the Apache Log4j 2.21.0.
> 
> Website: https://logging-log4j.staged.apache.org/log4j/2.x/
> GitHub: https://github.com/apache/logging-log4j2
> Commit: 493d9a9daabc72d10582c4682538baa93a2a
> Distribution: https://dist.apache.org/repos/dist/dev/logging/log4j
> Nexus: 
> https://repository.apache.org/content/repositories/orgapachelogging-1202
> Signing key: 0x077e8893a6dcc33dd4a4d5b256e73ba9a0b592d0
> 
> Please download, test, and cast your votes on this mailing list.
> 
> [ ] +1, release the artifacts
> [ ] -1, don't release, because...
> 
> This vote is open for 72 hours and will pass unless getting a
> net negative vote count. All votes are welcome and we encourage
> everyone to test the release, but only the Logging Services PMC
> votes are officially counted.
> 
> == Release Notes
> 
> This release primarily focuses on enhancements to our OSGi and JPMS support 
> and contains several bug fixes.
> It will be the first release built and signed by the CI using the 
> https://keyserver.ubuntu.com/pks/lookup?search=077E8893A6DCC33DD4A4D5B256E73BA9A0B592D0&op=index[ASF
>  Logging Services Release Manager GPG key], which is shared in 
> https://www.apache.org/dist/logging/KEYS[KEYS].
> 
> The Log4j 2.21.0 API, as well as the other artifacts, maintains binary 
> compatibility with the previous release.
> 
> Apache Log4j 2.21.0 requires Java 8 to run.
> The build requires JDK 11 and generates reproducible binaries.
> 
> For complete information on Apache Log4j 2, including instructions on how to 
> submit bug reports, patches, get support, or suggestions for improvement, see 
> http://logging.apache.org/log4j/2.x/[the Apache Log4j 2 website].
> 
> === OSGi changes
> 
> All the published artifacts are OSGi bundles or fragments.
> 
> This release introduces a change in the bundle symbolic names to allow them 
> to function as JPMS module name: all hyphens `-` present in the bundle names 
> of previous releases were replaced by dots `.`.
> 
> === JPMS changes
> 
> All the published artifacts have been migrated from automatic modules to 
> named JPMS modules.
> All packages marked as private in the Javadoc are not exported.
> 
> The module name of four bridges (`log4j-slf4j-impl`, `log4j-slf4j2-impl`, 
> `log4j-to-jul` and `log4j-to-slf4j`) have been changed to adhere to the same 
> convention as the OSGi bundle names.
> 
> 
> === Added
> 
> * Added marker parent support to `JsonTemplateLayout` (#1381)
> * Added https://facebook.github.io/zstd/[ZStandard compression] support 
> (#1508, #1514)
> * Added a warning for incorrect syntax of highlighting styles (#1545, #1637)
> 
> === Changed
> 
> * Open `FileExtension` methods to allow their usage in custom 
> ``RolloverStrategy``s (#1365, #1683)
> * Bumped the minimum Java version required for the build to JDK 11. Runtime 
> requirements remain unchanged. (#1369)
> * Set the default `minLevel` and `maxLevel` of `LevelRangeFilter` to `OFF` 
> and `ALL`, respectively (#1503)
> * Removed additional `isFiltered` checks in `AsyncLoggerConfig` (#1550)
> * Use Java version-specific warnings in `StackLocator` (#1760)
> * Started logging a status error event instead of an NPE in 
> `OsgiServiceLocator.loadServices(Class, Lookup, boolean)` when a bundle has 
> no valid `BundleContext` for a service type
> * Implemented a CI-based release process
> * Update Eclipse Angus Activation to version 
> https://github.com/eclipse-ee4j/angus-activation/releases/tag/2.0.1[2.0.1] 
> (#1591)
> * Update Eclipse Angus Mail to version 
> https://github.com/eclipse-ee4j/angus-mail/releases/tag/2.0.2[2.0.2] (#1591)
> * Update `com.datastax.cassandra:cassandra-driver-core` to version 3.11.5 
> (#1591)
> * Update Apache Cassandra to version 
> ht