Re: Spotless is annoying

2023-09-04 Thread Gary Gregory
Or git does it on check out and I need to re-checkout the whole thing.

Gaty

On Mon, Sep 4, 2023, 1:18 AM Ralph Goers  wrote:

> I suspect the problem here is the settings being used in Gary’s IDE. I
> know IntelliJ has a similar feature to convert line endings to what is
> appropriate for the environment.
>
> Ralph
>
> > On Sep 1, 2023, at 8:21 AM, Piotr P. Karwasz 
> wrote:
> >
> > Hi Gary,
> >
> > On Fri, 1 Sept 2023 at 14:19, Gary D. Gregory 
> wrote:
> >>
> >> How is this possible now that we use spotless in 2.x:
> >
> > It's a CRLF vs LF problem. About 6 months ago[1] I added a
> > `.gitattributes` file[2] that forces line endings as LF also on
> > Windows. This should solve two problems:
> > * approach the goal of reproducibility on **any** OS with an OpenJDK
> > compiler; some Maven plugins may still use system-dependent line
> > endings, but most of the files should be Ok,
> > * allow Spotless to work without Git (line endings are configured as
> > UNIX instead of the default "ask Git").
> >
> > Git should take care of line endings after the file "is touched by
> > Git" (whatever that means). Usually a:
> >
> > git add --renormalize *
> >
> > helps. Another possibility is that Eclipse reconverts the line endings
> to CRLF.
> >
> > Piotr
> >
> > [1] https://lists.apache.org/thread/bvt8s71gf2k2g5lhy5sbf20xtcpvvbbo
> > [2] https://github.com/apache/logging-log4j2/blob/2.x/.gitattributes
>
>


[VOTE] Release Apache Logging Parent 1.10.0

2023-09-04 Thread Volkan Yazıcı
This is a vote to release the Apache Logging Parent 1.10.0.

Source repository: https://github.com/apache/logging-parent
Commit: 3dd83461faa058690a5ed821ee81dfc2d744ec7c
Distribution: https://dist.apache.org/repos/dist/dev/logging
Nexus: https://repository.apache.org/content/repositories/orgapachelogging-1113
Signing key: 0x077e8893a6dcc33dd4a4d5b256e73ba9a0b592d0

Please download, test, and cast your votes on this mailing list.

[ ] +1, release the artifacts
[ ] -1, don't release, because...

This vote is open for 72 hours and will pass unless getting a
net negative vote count. All votes are welcome and we encourage
everyone to test the release, but only the Logging Services PMC
votes are officially counted. At least 3 +1 votes and more
positive than negative votes are required.

# Release Notes

This minor release contains various improvements that we expect to
relieve the load on `pom.xml` and GitHub Actions workflows of
Maven-based projects we parent. This is of particular importance while
managing and cutting releases from multiple repositories.
See `README.adoc` for the complete list of features and their usage.

See [this `logging-log4j-tools` GitHub Actions workflow
run](https://github.com/apache/logging-log4j-tools/actions/runs/6070379396)
demonstrating a successful release cut using a SNAPSHOT version of
this `logging-parent` release. All preparations (release notes,
distribution ZIP, vote & announcement emails, etc.) are staged to both
Nexus and SVN and waiting the release manager to proceed. As a matter
of fact, this very release of `logging-parent` is cut by the very same
reusables too.

## Changes

### Added

* Added `changelog-export` profile to easily export changelogs to Markdown files
* Added `changelog-release` profile to easily move
`src/changelog/.?.x.x` contents to their associated release directory
* Added `deploy` profile to ease the Maven `deploy` goal
* Added `distribution` profile to easily create a distribution file
containing Git-tracked sources, release notes, binary attachments,
`NOTICE.txt`, etc.
* Documented release instructions (i.e., `RELEASING.md`)
* Added `release` profile to share common release-specific Maven configuration
* Added reusable GitHub Actions workflows to share CI boilerplate for
other repositories
* Switched to using `log4j-changelog-maven-plugin` for managing
changelog and release notes


Re: [VOTE] Release Apache Logging Parent 1.10.0

2023-09-04 Thread Piotr P. Karwasz
Hi Volkan,

On Mon, 4 Sept 2023 at 21:33, Volkan Yazıcı  wrote:
> Nexus: 
> https://repository.apache.org/content/repositories/orgapachelogging-1113

Congratulations on the totally automatic release. Unfortunately there
are still some glitches:
 * orgapachelogging-1113 does **not** exist,
 * orgapachelogging-1153 is "open".

Could you also add a "release-verify" profile so that running:

./mvnw -P release-verify
-Dreference.repo=https://repository.apache.org/content/repositories/orgapachelogging-1113

verifies that:
 1. builds are reproducible,
 2. signatures match.

Piotr