Re: [VOTE] Release Apache Log4j Tools 0.3.0

2023-03-16 Thread Benoit Lacelle
We may also tweak the lineEndings parameter based on a profile (
https://github.com/diffplug/spotless/tree/main/plugin-gradle#line-endings-and-encodings-invisible-stuff
)
(instead of dropping the whole plugin)

Benoit

Le jeu. 16 mars 2023 à 10:48, Piotr P. Karwasz  a
écrit :

> Hi Ralph,
>
> On Wed, 15 Mar 2023 at 23:59, Ralph Goers 
> wrote:
> >
> > Just require the build to run on a Unix-like variant. Nobody is going to
> give a crap that the tools don’t build on Windows.
>
> At least Gary does.
>
> On the other hand nobody gives a crap that Spotless does not work on
> the source distribution. we could move it to a profile (activated by
> the presence of a `.git` folder?).
>
> Piotr
>


[log4net] About the language of comments in the code

2023-03-16 Thread 夏月 梨幸
Hello.

I do not speak English, so please excuse the machine translation.
I would like to propose and provide code for MaxDateRollBackups in 
RollingFileAppender, but have concerns due to my lack of English speaking 
ability.
Is it permissible to list native language and English (machine translated) 
side-by-side for C# comments and documentation comments?

> https://logging.apache.org/log4net/release/faq.html
In the URL above, I did not see any restrictions on the language used in the 
comments.

> apache-log4net-source-2.0.15.zip
However, as far as the source is concerned, all comments are written in English.

Thank you for reading.

夏月 梨幸(Natsuki Rikou)



Re: [log4net] About the language of comments in the code

2023-03-16 Thread Gary Gregory
Based on this email, your English is great!

I'd say any documentation is better than none.

Gary

On Thu, Mar 16, 2023 at 11:07 AM 夏月 梨幸  wrote:
>
> Hello.
>
> I do not speak English, so please excuse the machine translation.
> I would like to propose and provide code for MaxDateRollBackups in 
> RollingFileAppender, but have concerns due to my lack of English speaking 
> ability.
> Is it permissible to list native language and English (machine translated) 
> side-by-side for C# comments and documentation comments?
>
> > https://logging.apache.org/log4net/release/faq.html
> In the URL above, I did not see any restrictions on the language used in the 
> comments.
>
> > apache-log4net-source-2.0.15.zip
> However, as far as the source is concerned, all comments are written in 
> English.
>
> Thank you for reading.
>
> 夏月 梨幸(Natsuki Rikou)
>


RE: [log4net] About the language of comments in the code

2023-03-16 Thread 夏月 梨幸
Thanks for the quick response.
I am relieved.

DeepL is awesome!

夏月 梨幸(Natsuki Rikou)