Re: Review Request: LOG4J2-3628 Migrate from maven-changes-plugin to a merge-conflict-free Markdown-based solution

[Matt Sicker]

It’s manual work that makes merging PRs non-trivial.

> On Nov 9, 2022, at 10:58 PM, Ralph Goers  wrote:
> 
> It is, but it isn’t one of the items that I personally consider broken.
> 
> Ralph
> 
>> On Nov 9, 2022, at 3:50 PM, Matt Sicker  wrote:
>> 
>> The changelog is an important aspect of the website, too.
>> 
>>> On Nov 9, 2022, at 1:43 PM, Ralph Goers  wrote:
>>> 
>>> See my comments in the issue. I’d rather focus on web site changes that 
>>> provide real value.
>>> 
>>> Ralph
>>> 
 On Nov 8, 2022, at 3:41 PM, Gary Gregory  wrote:
 
 I do like all the details in the Jira ticket! :-)
 
 Gary
 
 On Mon, Nov 7, 2022, 16:03 Volkan Yazıcı  wrote:
 
> In the context of migrating away from JIRA to GitHub Issues, I want to
> replace the current maven-changes-plugin setup with a merge-conflict-free
> Markdown-based solution. I have elaborated the details in LOG4J2-3628
> .
> 
> Since this will change the behaviour of how we introduce changes and make
> releases, I would appreciate it if committers could skim through it and
> share their feedback.
> 
>>> 
>> 
> 

Re: Review Request: LOG4J2-3628 Migrate from maven-changes-plugin to a merge-conflict-free Markdown-based solution

[Ralph Goers]

I’ve suggested to Volkan that he look to see if the changes plugin supports 
XIncludes in changes.xml and if it doesn’t how much work it would be to add it.

Ralph

> On Nov 10, 2022, at 10:36 AM, Matt Sicker  wrote:
> 
> It’s manual work that makes merging PRs non-trivial.
> 
>> On Nov 9, 2022, at 10:58 PM, Ralph Goers  wrote:
>> 
>> It is, but it isn’t one of the items that I personally consider broken.
>> 
>> Ralph
>> 
>>> On Nov 9, 2022, at 3:50 PM, Matt Sicker  wrote:
>>> 
>>> The changelog is an important aspect of the website, too.
>>> 
 On Nov 9, 2022, at 1:43 PM, Ralph Goers  wrote:
 
 See my comments in the issue. I’d rather focus on web site changes that 
 provide real value.
 
 Ralph
 
> On Nov 8, 2022, at 3:41 PM, Gary Gregory  wrote:
> 
> I do like all the details in the Jira ticket! :-)
> 
> Gary
> 
> On Mon, Nov 7, 2022, 16:03 Volkan Yazıcı  wrote:
> 
>> In the context of migrating away from JIRA to GitHub Issues, I want to
>> replace the current maven-changes-plugin setup with a merge-conflict-free
>> Markdown-based solution. I have elaborated the details in LOG4J2-3628
>> .
>> 
>> Since this will change the behaviour of how we introduce changes and make
>> releases, I would appreciate it if committers could skim through it and
>> share their feedback.
>> 
 
>>> 
>> 
> 

Re: Review Request: LOG4J2-3628 Migrate from maven-changes-plugin to a merge-conflict-free Markdown-based solution

[Gary Gregory]

I've used XInclude in the past at work and in some FOSS projects and it
works great.

The wrinkle is to guard against what is included to avoid CVEs. Same issue
with DTDs.

Gary


On Thu, Nov 10, 2022, 13:40 Ralph Goers  wrote:

> I’ve suggested to Volkan that he look to see if the changes plugin
> supports XIncludes in changes.xml and if it doesn’t how much work it would
> be to add it.
>
> Ralph
>
> > On Nov 10, 2022, at 10:36 AM, Matt Sicker  wrote:
> >
> > It’s manual work that makes merging PRs non-trivial.
> >
> >> On Nov 9, 2022, at 10:58 PM, Ralph Goers 
> wrote:
> >>
> >> It is, but it isn’t one of the items that I personally consider broken.
> >>
> >> Ralph
> >>
> >>> On Nov 9, 2022, at 3:50 PM, Matt Sicker  wrote:
> >>>
> >>> The changelog is an important aspect of the website, too.
> >>>
>  On Nov 9, 2022, at 1:43 PM, Ralph Goers 
> wrote:
> 
>  See my comments in the issue. I’d rather focus on web site changes
> that provide real value.
> 
>  Ralph
> 
> > On Nov 8, 2022, at 3:41 PM, Gary Gregory 
> wrote:
> >
> > I do like all the details in the Jira ticket! :-)
> >
> > Gary
> >
> > On Mon, Nov 7, 2022, 16:03 Volkan Yazıcı  wrote:
> >
> >> In the context of migrating away from JIRA to GitHub Issues, I want
> to
> >> replace the current maven-changes-plugin setup with a
> merge-conflict-free
> >> Markdown-based solution. I have elaborated the details in
> LOG4J2-3628
> >> .
> >>
> >> Since this will change the behaviour of how we introduce changes
> and make
> >> releases, I would appreciate it if committers could skim through it
> and
> >> share their feedback.
> >>
> 
> >>>
> >>
> >
>
>