Re: Log4j 2.19.0

2022-09-08 Thread Piotr P. Karwasz
Hi,

On Thu, 8 Sept 2022 at 08:28, Ralph Goers  wrote:
> Please let me know if there is something I need to wait for.

I wanted to merge https://github.com/apache/logging-log4j2/pull/959 .
The fix is a one-liner, but I need to debug the Windows-only tests I
added.

Piotr


Re: Structured concurrency in Java 19+

2022-09-08 Thread Ralph Goers
The brief read of https://openjdk.org/jeps/425 I did suggested that the major 
difference between Virtual Threads and Platform Threads is that Virtual Threads 
should not be pooled. So the only changes we would need to make would be to use 
a Virtual Thread Executor. However, it probably will simplify the logic a bit 
as we now determine how big the pool size should be and now we won’t have to - 
every request will just get its own.

Ralph

> On Sep 7, 2022, at 11:40 AM, Matt Sicker  wrote:
> 
> Java 19 is coming out soon, and that includes a preview version of virtual 
> threads and structured concurrency APIs. While I’m not that familiar with the 
> Java implementation, I’d imagine it’ll have some similarities with Kotlin 
> coroutines and other similar structured concurrency libraries.
> 
> I’ve played around with the general concept myself, particularly an 
> interesting Python library for the same. I think some sort of structured 
> concurrency architecture would be useful for making some async aspects of 
> Log4j easier to understand (mostly the areas where we spawn threads for 
> things, not for async logging). While the API isn’t stable, we can abstract 
> it well enough with multi version jars. What I’m more curious about is how 
> we’d interact (if at all) with virtual threads, coroutines, or structured 
> concurrency APIs in general. If an app uses structured concurrency 
> throughout, it might want the logging system to participate in the same flow 
> for clean shutdowns.
> 
> Does anyone have any more concrete use cases that might be relevant for us? 
> Or does this seem more relevant for networking libraries and frameworks?
> 
> —
> Matt Sicker



Re: Log4j 2.19.0

2022-09-08 Thread Piotr P. Karwasz
Hi,

On Thu, 8 Sept 2022 at 09:29, Piotr P. Karwasz  wrote:
> I wanted to merge https://github.com/apache/logging-log4j2/pull/959 .
> The fix is a one-liner, but I need to debug the Windows-only tests I
> added.

As far as I am concerned, 2.19.0 is ready.

Piotr


Re: Sync `master` and `release-2.x` test structure

2022-09-08 Thread Volkan Yazıcı
+1
I liked the idea.
I have been bitten by this a lot while working on JsonTemplateLayout.

On Tue, Sep 6, 2022 at 10:40 PM Piotr P. Karwasz 
wrote:

> Hi,
>
> Due to the difference in the project structure between `master` and
> `release-2.x`, most cherry-picks between the two lines fail.
>
> What do you think about adding the `log4j-api-test` and
> `log4j-core-test` modules also in `release-2.x`? This should limit the
> number of conflicts to the differences that matter.
>
> Piotr
>