Sync `master` and `release-2.x` test structure
Hi, Due to the difference in the project structure between `master` and `release-2.x`, most cherry-picks between the two lines fail. What do you think about adding the `log4j-api-test` and `log4j-core-test` modules also in `release-2.x`? This should limit the number of conflicts to the differences that matter. Piotr
Re: Sync `master` and `release-2.x` test structure
I don’t have an issue with that but Spring has requested a release from us that supports SLF4J 2.0 this week. So I am going through Jira issues looking for those that warrant my attention before the release. So I would ask we save this until after the release. Ralph > On Sep 6, 2022, at 1:40 PM, Piotr P. Karwasz wrote: > > Hi, > > Due to the difference in the project structure between `master` and > `release-2.x`, most cherry-picks between the two lines fail. > > What do you think about adding the `log4j-api-test` and > `log4j-core-test` modules also in `release-2.x`? This should limit the > number of conflicts to the differences that matter. > > Piotr
Re: Sync `master` and `release-2.x` test structure
The structure was a limitation due to testing modules. I suppose this would depend on how relevant the tests form master will be in 2.x over time. — Matt Sicker > On Sep 6, 2022, at 13:40, Piotr P. Karwasz wrote: > > Hi, > > Due to the difference in the project structure between `master` and > `release-2.x`, most cherry-picks between the two lines fail. > > What do you think about adding the `log4j-api-test` and > `log4j-core-test` modules also in `release-2.x`? This should limit the > number of conflicts to the differences that matter. > > Piotr
Re: Sync `master` and `release-2.x` test structure
On Tue, 6 Sept 2022 at 22:53, Ralph Goers wrote: > I don’t have an issue with that but Spring has requested a release from us > that supports > SLF4J 2.0 this week. So I am going through Jira issues looking for those that > warrant > my attention before the release. What about: https://github.com/apache/logging-log4j2/pull/1033 ? I remove `log4j-slf4j18-impl` and rename `log4j-slf4j20-impl` to `log4j-slf4j2-impl`. As far as I am concerned we just need to update the docs and SLF4J2 is done. Piotr
Re: Sync `master` and `release-2.x` test structure
I am fine with this but please create a Jira issue for removing support for 1.8. It needs to show up in the changelog. Ralph > On Sep 6, 2022, at 1:57 PM, Piotr P. Karwasz wrote: > > On Tue, 6 Sept 2022 at 22:53, Ralph Goers wrote: >> I don’t have an issue with that but Spring has requested a release from us >> that supports >> SLF4J 2.0 this week. So I am going through Jira issues looking for those >> that warrant >> my attention before the release. > > What about: https://github.com/apache/logging-log4j2/pull/1033 ? > > I remove `log4j-slf4j18-impl` and rename `log4j-slf4j20-impl` to > `log4j-slf4j2-impl`. > > As far as I am concerned we just need to update the docs and SLF4J2 is done. > > Piotr
