[GitHub] geode-native pull request #104: Develop
GitHub user fdaniel7 opened a pull request: https://github.com/apache/geode-native/pull/104 Develop Closing socket before deleting it. You can merge this pull request into a Git repository by running: $ git pull https://github.com/fdaniel7/geode-native develop Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode-native/pull/104.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #104 commit 5554c8a37cdcea874ba823e134f9b5bb586c3fba Author: fdaniel7 Date: 2017-06-28T07:33:14Z Close socket before deleting it. commit 25255eb3ab8afc161f26dd35ed96bd46b1805505 Author: fdaniel7 Date: 2017-06-28T08:00:29Z Revert "Close socket before deleting it." This reverts commit 5554c8a37cdcea874ba823e134f9b5bb586c3fba. commit 1896744d6f6d0fa25ca62b8b9b060c28398e1f02 Author: fdaniel7 Date: 2017-06-28T08:04:24Z Close ACE_SOCK_Stream before deleting it GF_SAFE_DELETE will delete the ACE_SOCK_Stream but the socket will still be open. commit 0b31ccc12382ed4cd365c77f4dc89437abf3449b Author: fdaniel7 Date: 2017-06-28T08:08:29Z Revert "Close ACE_SOCK_Stream before deleting it" This reverts commit 1896744d6f6d0fa25ca62b8b9b060c28398e1f02. commit 9ca823f889c53d5603d3e3ecf866a8fe085fc012 Author: fdaniel7 Date: 2017-06-28T08:10:34Z Close ACE_SOCK_Stream before deleting it GF_SAFE_DELETE will delete the ACE_SOCK_Stream object but the socket will still be open. commit 4fe58136309737f2d3ca8a17b1c3e7c21a04a0a6 Author: fdaniel7 Date: 2017-06-28T08:11:58Z Revert "Close ACE_SOCK_Stream before deleting it" This reverts commit 9ca823f889c53d5603d3e3ecf866a8fe085fc012. commit 97c265eef15f17deb312cda051c20a62bbb4c30b Author: fdaniel7 Date: 2017-06-28T08:13:53Z Close socket before deleting it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-native issue #104: Develop
Github user fdaniel7 commented on the issue: https://github.com/apache/geode-native/pull/104 Hi I'm still new with github, it is indeed a small change. On next contributions I'll pay more attention. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-native issue #104: Develop
Github user fdaniel7 commented on the issue: https://github.com/apache/geode-native/pull/104 There's no ticket for this as far as I know. I'm fixing this as part of reviewing geode client code --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-native issue #104: GEODE-3143 : close socket before deteting
Github user fdaniel7 commented on the issue: https://github.com/apache/geode-native/pull/104 When connect() is invoked from one of TcpConn::TcpConn the TcpConn object is not created since the exception is thrown from the constructor, so ~TcpConn will not be invoked. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-native pull request #104: GEODE-3143 : close socket before deteting
Github user fdaniel7 closed the pull request at: https://github.com/apache/geode-native/pull/104 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
