[GitHub] geode pull request #717: Feature/geode 3411

2017-08-17 Thread aravindmusigumpula
GitHub user aravindmusigumpula opened a pull request:

https://github.com/apache/geode/pull/717

Feature/geode 3411

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [X ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [X ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [X ] Is your initial contribution a single, squashed commit?

- [X ] Does `gradlew build` run cleanly?

- [X ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/aravindmusigumpula/geode feature/GEODE-3411

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/717.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #717


commit e711eb395b2dd09428cb3ffdfc3eef2e101d66be
Author: aravindmusigumpula 
Date:   2017-08-17T09:40:05Z

modified:   
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/InternalDistributedMember.java
modified:   
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/fd/GMSHealthMonitor.java
modified:   
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java
modified:   
geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/fd/GMSHealthMonitorJUnitTest.java

commit 457b0da3d6480a228ebbdd26bcc4880d1a2b844c
Author: aravindmusigumpula 
Date:   2017-08-17T09:42:04Z

modified:   gradlew.bat




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode issue #717: Feature/geode 3411 Monitor the neighbour JVM using neihbou...

2017-08-28 Thread aravindmusigumpula
Github user aravindmusigumpula commented on the issue:

https://github.com/apache/geode/pull/717
  
thanks @upthewaterspout for pointing out these issues ,
I have added this new parameter in two methods toDataPre_GFE_7_1_0_0, 
toDataPre_GFE_9_0_0_0.
And I understand that adding a field to toDataPre_GFE_7_1_0_0 breaks 
compatibility with client/peers, so should I remove it from this method?
I don't see any method toDataPre_GEODE_1_3_0_0, should I create one?
I am new here, please help me understand how to make this correct without 
breaking compatibility issues.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---