[GitHub] geode pull request #525: GEODE-2962: Add more messages for compact disk-stor...
GitHub user AkihiroKitada opened a pull request: https://github.com/apache/geode/pull/525 GEODE-2962: Add more messages for compact disk-store Added a message in the case that notExecutedMembers variable is null. Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [x] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to dev@geode.apache.org. You can merge this pull request into a Git repository by running: $ git pull https://github.com/AkihiroKitada/geode feature/GEODE-2962 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/525.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #525 commit 12c83b5f6838ec720fd7e67db4f95b8b868cb896 Author: Akihiro Kitada Date: 2017-05-22T10:20:02Z GEODE-2962: Add more messages for compact disk-store Added a message in the case that notExecutedMembers variable is null. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #525: GEODE-2962: Add more messages for compact disk-store
Github user AkihiroKitada commented on the issue: https://github.com/apache/geode/pull/525 Do I need write test code for this minor change? If so, please let me know. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #525: GEODE-2962: Add more messages for compact disk-stor...
Github user AkihiroKitada commented on a diff in the pull request: https://github.com/apache/geode/pull/525#discussion_r118150229 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommands.java --- @@ -485,9 +485,14 @@ public Result compactDiskStore( memberCompactInfo.clear(); } String notExecutedMembers = CompactRequest.getNotExecutedMembers(); +if (notExecutedMembers != null && !notExecutedMembers.isEmpty()) { + notExecutedMembers = "but was not send to " + notExecutedMembers; +} else { + notExecutedMembers = "all the members"; --- End diff -- Hello Darrel, I remove redundant log message according to your suggestion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #525: GEODE-2962: Add more messages for compact disk-store
Github user AkihiroKitada commented on the issue: https://github.com/apache/geode/pull/525 Hello Darrel, I'm sorry to make this PR confused. I updated this PR from other environment and it made this PR cause some differences in terms of my fork. I'll close this PR and create other one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #525: GEODE-2962: Add more messages for compact disk-stor...
Github user AkihiroKitada closed the pull request at: https://github.com/apache/geode/pull/525 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #534: GEODE-2962: Added null check to log message
GitHub user AkihiroKitada opened a pull request: https://github.com/apache/geode/pull/534 GEODE-2962: Added null check to log message Just log message if "notExecutedMembers" is not null and not empty. Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [x] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to dev@geode.apache.org. You can merge this pull request into a Git repository by running: $ git pull https://github.com/AkihiroKitada/geode feature/GEODE-2986 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/534.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #534 commit 03e15324fe97db08395250261a9cacaced16b816 Author: Akihiro Kitada Date: 2017-05-25T01:48:14Z GEODE-2962: Added null check to log message Just log message if "notExecutedMembers" is not null and not empty. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #534: GEODE-2986: Added null check to log message
Github user AkihiroKitada commented on the issue: https://github.com/apache/geode/pull/534 Create by mistake. Close this one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #534: GEODE-2986: Added null check to log message
Github user AkihiroKitada closed the pull request at: https://github.com/apache/geode/pull/534 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #534: GEODE-2986: Added null check to log message
Github user AkihiroKitada commented on the issue: https://github.com/apache/geode/pull/534 I create this PR by mistake. Close this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #535: GEODE-2986: Remove redundant log message
GitHub user AkihiroKitada opened a pull request: https://github.com/apache/geode/pull/535 GEODE-2986: Remove redundant log message Just log message if "notExecutedMembers" is not null and not empty. Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [x] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to dev@geode.apache.org. You can merge this pull request into a Git repository by running: $ git pull https://github.com/AkihiroKitada/geode feature/GEODE-2986 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/535.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #535 commit 28face3833cb33bc6e23ef5f872a68bfc0917bcc Author: Akihiro Kitada Date: 2017-05-25T02:16:08Z GEODE-2986: Remove redundant log message Just log message if "notExecutedMembers" is not null and not empty. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #535: GEODE-2986: Remove redundant log message
Github user AkihiroKitada commented on the issue: https://github.com/apache/geode/pull/535 Hello folks, In terms of proceeding this PR, what should do? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #535: GEODE-2986: Remove redundant log message
Github user AkihiroKitada commented on the issue: https://github.com/apache/geode/pull/535 Hello folks, Thank you for paying your attention to this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---