Re: geode gradle build failing

[Arnout Engelen]

On Wed, Feb 12, 2025 at 11:28 PM William Hodges
 wrote:

> I can resolve the "spotlessGroovyGradleCheck" errors by running
> ./gradlew.bat ::spotlessApply individually for each project
> but this is extremely time consuming.
>

Interesting, I don't get any spotlessGroovyGradleCheck errors. I'm on Linux
myself, not sure if that should make a difference. When you do a
"spotlessApply", can you share what actually changes?


> The rat failure looks like:
>
> * What went wrong:
> Execution failed for task ':rat'.
> > A failure occurred while executing org.nosphere.apache.rat.RatWork
>> Apache Rat audit failure - 3 unapproved licenses
> See file:///C:/Users/wihodg/git/geode/build/reports/rat/index.html
>

This happens to me as well when I have 'temporary' files anywhere in the
'geode' directory tree. It seems like the best way is to work on a 'clean'
tree. As Sai mentioned, build/reports/rat/index.html should indicate which
files it is triggering on - are those indeed your own temporary files?
Would it be possible to move those away?


Kind regards,

Arnout


> I expected the develop branch to build without any changes. Am I missing
> something?
>
> Thanks in advance!
>
> First part of Gradle output
>
> $ ./gradlew build -Dskip.tests=true
> > Task :geode-logging:spotlessGroovyGradleCheck FAILED
> > Task :geode-membership:spotlessGroovyGradleCheck FAILED
> > Task :geode-serialization:spotlessGroovyGradleCheck FAILED
> > Task :geode-common:spotlessGroovyGradleCheck FAILED
> > Task :geode-management:spotlessGroovyGradleCheck FAILED
> > Task :geode-connectors:spotlessGroovyGradleCheck FAILED
> > Task :geode-assembly:spotlessGroovyGradleCheck FAILED
> > Task :geode-unsafe:spotlessGroovyGradleCheck FAILED
> > Task :geode-tcp-server:spotlessGroovyGradleCheck FAILED
> > Task :geode-cq:spotlessGroovyGradleCheck FAILED
> > Task :geode-gfsh:spotlessGroovyGradleCheck FAILED
> > Task :geode-dunit:spotlessGroovyGradleCheck FAILED
> > Task :geode-log4j:spotlessGroovyGradleCheck FAILED
> > Task :geode-rebalancer:spotlessGroovyGradleCheck FAILED
> > Task :geode-core:spotlessGroovyGradleCheck FAILED
> > Task :geode-junit:spotlessGroovyGradleCheck FAILED
> > Task :geode-server-all:spotlessGroovyGradleCheck FAILED
> > Task :geode-assembly:geode-assembly-test:spotlessGroovyGradleCheck FAILED
> > Task :geode-lucene:spotlessGroovyGradleCheck FAILED
> > Task :geode-pulse:spotlessGroovyGradleCheck FAILED
> > Task :extensions:geode-modules-test:spotlessGroovyGradleCheck FAILED
> > Task :extensions:geode-modules:spotlessGroovyGradleCheck FAILED
> > Task :geode-web-management:spotlessGroovyGradleCheck FAILED
> > Task :extensions:session-testing-war:spotlessGroovyGradleCheck FAILED
> > Task :geode-deployment:geode-deployment-legacy:spotlessGroovyGradleCheck
> FAILED
> > Task :geode-http-service:spotlessGroovyGradleCheck FAILED
> > Task :geode-pulse:geode-pulse-test:spotlessGroovyGradleCheck FAILED
> > Task :geode-old-client-support:spotlessGroovyGradleCheck FAILED
> > Task :geode-memcached:spotlessGroovyGradleCheck FAILED
> > Task :extensions:geode-modules-session:spotlessGroovyGradleCheck FAILED
> > Task
> :extensions:geode-modules-session-internal:spotlessGroovyGradleCheck FAILED
> > Task :extensions:geode-modules-tomcat9:spotlessGroovyGradleCheck FAILED
> > Task :extensions:geode-modules-tomcat7:spotlessGroovyGradleCheck FAILED
> > Task :geode-wan:spotlessGroovyGradleCheck FAILED
> > Task :extensions:geode-modules-tomcat8:spotlessGroovyGradleCheck FAILED
> > Task :geode-web:spotlessGroovyGradleCheck FAILED
> > Task :geode-web-api:spotlessGroovyGradleCheck FAILED
> > Task :geode-concurrency-test:spotlessGroovyGradleCheck FAILED
> > Task :geode-jmh:spotlessGroovyGradleCheck FAILED
> > Task :geode-lucene:geode-lucene-test:spotlessGroovyGradleCheck FAILED
> > Task :static-analysis:spotlessGroovyGradleCheck FAILED
> > Task :static-analysis:pmd-rules:spotlessGroovyGradleCheck FAILED
> > Task :extensions:geode-modules-assembly:spotlessGroovyGradleCheck FAILED
>
> > Task :boms:geode-client-bom:spotlessGroovyGradle UP-TO-DATE
> Errors occurred while build effective model from
> C:\Users\wihodg\.gradle\caches\modules-2\files-2.1\org.eclipse.platform\org.eclipse.swt\3.128.0\4041f111bfb2ccc008c18bc4095e1add06a7688d\org.eclipse.swt-3.128.0
> .pom:
> 'dependencies.dependency.artifactId' for
> org.eclipse.platform:org.eclipse.swt.${osgi.platform}:jar with value
> 'org.eclipse.swt.${osgi.platform}' does not match a valid id pattern. in
> org.eclipse.platform:o
> rg.eclipse.swt:3.128.0
>
> > Task :boms:geode-client-bom:spotlessGroovyGradleCheck FAILED
>
> > Task :geode-core:compileJmhJava
> Note:
> C:\Users\wihodg\git\geode\geode-core\src\jmh\java\org\apache\geode\cache\query\internal\PartitionedIndexGetBucketIndexBenchmark.java
> uses or overrides a deprecated API.
> Note: Recompile with -Xlint:deprecation for details.
> Note: Some input files use unchecked or unsafe operations.
> Note: Recompile with -Xlint:unchecked for details.
>

RE: geode gradle build failing

[William Hodges]

Thanks Arnout and Sai,

After running ./gradlew spotlessApply, many of the build.gradle files get 
reformatted with different line endings. I haven’t made any changes so the 
wrong line endings must have been committed somewhere down the line. See below 
output for a list of changed files.

As for the rat failure, the following 3 files report as having no license:

extensions/geode-modules/bin/main/modules-version.properties
extensions/geode-modules/bin/test/org/apache/geode/modules/Event.hbm.xml
extensions/geode-modules/bin/test/org/apache/geode/modules/Person.hbm.xml

After manually adding the Apache license header to each of these files, and 
running spotlessApply, the build succeeds.

Changes not staged for commit:
  (use "git add ..." to update what will be committed)
  (use "git restore ..." to discard changes in working directory)
modified:   boms/geode-client-bom/build.gradle
modified:   extensions/geode-modules-assembly/build.gradle
modified:   extensions/geode-modules-session-internal/build.gradle
modified:   extensions/geode-modules-session/build.gradle
modified:   extensions/geode-modules-test/build.gradle
modified:   extensions/geode-modules-tomcat7/build.gradle
modified:   extensions/geode-modules-tomcat8/build.gradle
modified:   extensions/geode-modules-tomcat9/build.gradle
modified:   extensions/geode-modules/build.gradle
modified:   extensions/session-testing-war/build.gradle
modified:   geode-assembly/build.gradle
modified:   geode-assembly/geode-assembly-test/build.gradle
modified:   
geode-assembly/src/acceptanceTest/resources/gradle-test-projects/management/build.gradle
modified:   geode-common/build.gradle
modified:   geode-concurrency-test/build.gradle
modified:   geode-connectors/build.gradle
modified:   geode-core/build.gradle
modified:   geode-cq/build.gradle
modified:   geode-deployment/geode-deployment-legacy/build.gradle
modified:   geode-dunit/build.gradle
modified:   geode-gfsh/build.gradle
modified:   geode-http-service/build.gradle
modified:   geode-jmh/build.gradle
modified:   geode-junit/build.gradle
modified:   geode-log4j/build.gradle
modified:   geode-logging/build.gradle
modified:   geode-lucene/build.gradle
modified:   geode-lucene/geode-lucene-test/build.gradle
modified:   geode-management/build.gradle
modified:   geode-membership/build.gradle
modified:   geode-memcached/build.gradle
modified:   geode-old-client-support/build.gradle
modified:   geode-pulse/build.gradle
modified:   geode-pulse/geode-pulse-test/build.gradle
modified:   geode-rebalancer/build.gradle
modified:   geode-serialization/build.gradle
modified:   geode-server-all/build.gradle
modified:   geode-tcp-server/build.gradle
modified:   geode-unsafe/build.gradle
modified:   geode-wan/build.gradle
modified:   geode-web-api/build.gradle
modified:   geode-web-management/build.gradle
modified:   geode-web/build.gradle
modified:   static-analysis/build.gradle
modified:   static-analysis/pmd-rules/build.gradle

William Hodges
Research & Development
william.hod...@sas.com
(919)531-4739 x14739

From: Arnout Engelen 
Sent: Thursday, February 13, 2025 8:54 AM
To: William Hodges 
Cc: dev@geode.apache.org
Subject: Re: geode gradle build failing


EXTERNAL
On Wed, Feb 12, 2025 at 11:28 PM William Hodges 
mailto:william.hod...@sas.com.invalid>> wrote:
I can resolve the "spotlessGroovyGradleCheck" errors by running ./gradlew.bat 
::spotlessApply individually for each project but this is 
extremely time consuming.

Interesting, I don't get any spotlessGroovyGradleCheck errors. I'm on Linux 
myself, not sure if that should make a difference. When you do a 
"spotlessApply", can you share what actually changes?

The rat failure looks like:

* What went wrong:
Execution failed for task ':rat'.
> A failure occurred while executing org.nosphere.apache.rat.RatWork
   > Apache Rat audit failure - 3 unapproved licenses
See file:///C:/Users/wihodg/git/geode/build/reports/rat/index.html

This happens to me as well when I have 'temporary' files anywhere in the 
'geode' directory tree. It seems like the best way is to work on a 'clean' 
tree. As Sai mentioned, build/reports/rat/index.html should indicate which 
files it is triggering on - are those indeed your own temporary files? Would it 
be possible to move those away?


Kind regards,

Arnout

I expected the develop branch to build without any changes. Am I missing 
something?

Thanks in advance!

First part of Gradle output

$ ./gradlew build -Dskip.tests=true
> Task :geode-logging:spotlessGroovyGradleCheck FAILED
> Task :geode-membership:spotlessGroovyGradleCheck FAILED
> Task :g