Review for "C++ native client Function.execute() with onServers does not throw exception if one of the servers goes down while executing the function."

2020-11-16 Thread Alberto Gomez
Hi,

Could somebody review PR https://github.com/apache/geode-native/pull/690  
(https://issues.apache.org/jira/browse/GEODE-8693?filter=-2).

Thanks,

/Alberto G.


Re: Review for "C++ native client Function.execute() with onServers does not throw exception if one of the servers goes down while executing the function."

2020-11-16 Thread Blake Bender
Hi Alberto,

I’m back from a week’s vacation this morning, and will have a look.

Thanks,

Blake


From: Alberto Gomez 
Date: Monday, November 16, 2020 at 7:11 AM
To: dev@geode.apache.org 
Subject: Review for "C++ native client Function.execute() with onServers does 
not throw exception if one of the servers goes down while executing the 
function."
Hi,

Could somebody review PR 
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fgeode-native%2Fpull%2F690&data=04%7C01%7Cbblake%40vmware.com%7C0d61027c99b94ee727a908d88a41d68d%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C1%7C637411362666288996%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=WRcP9qOVyDZub2NitRhtEh0ujxCZkm%2F4nx8OMl4cjg4%3D&reserved=0
  
(https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FGEODE-8693%3Ffilter%3D-2&data=04%7C01%7Cbblake%40vmware.com%7C0d61027c99b94ee727a908d88a41d68d%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C1%7C637411362666288996%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=9WFHdNc3p1A4hdnG3a0%2FxgM1YLR4BFQtyWX7Tzf90gc%3D&reserved=0).

Thanks,

/Alberto G.


Re: [VOTE] Apache Geode 1.13.1.RC2

2020-11-16 Thread Dan Smith
+1

Looks good to me! I ran the geode-release-check against it, looked for binary 
artifacts, checked the pipeline.

-Dan

From: Dick Cavender 
Sent: Thursday, November 12, 2020 5:00 PM
To: dev@geode.apache.org 
Subject: [VOTE] Apache Geode 1.13.1.RC2

Hello Geode Dev Community,

This is a release candidate for Apache Geode version 1.13.1.RC2.
Issues with creation of RC1 forced moving to RC2.
Thanks to all the community members for their contributions to this release!

Please do a review and give your feedback, including the checks you performed.

Voting deadline:
3PM PST Tue, November 17 2020.

Please note that we are voting upon the source tag:
rel/v1.13.1.RC2

Release notes:
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcwiki.apache.org%2Fconfluence%2Fdisplay%2FGEODE%2FRelease%2BNotes%23ReleaseNotes-1.13.1&data=04%7C01%7Cdasmith%40vmware.com%7Cd50c5cb12cba485293d708d8876f8993%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637408260404370999%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=4vRYefr%2Bx9Lz18%2BZFO3x%2FSYMdz8%2B%2FCSccrXiuSPiGt8%3D&reserved=0

Source and binary distributions:
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdist.apache.org%2Frepos%2Fdist%2Fdev%2Fgeode%2F1.13.1.RC2%2F&data=04%7C01%7Cdasmith%40vmware.com%7Cd50c5cb12cba485293d708d8876f8993%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637408260404370999%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=N9mFEBqWyWqp8CI9zI9KX831oMzPQnJGWuTMuORG964%3D&reserved=0

Maven staging repo:
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Frepository.apache.org%2Fcontent%2Frepositories%2Forgapachegeode-1071&data=04%7C01%7Cdasmith%40vmware.com%7Cd50c5cb12cba485293d708d8876f8993%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637408260404370999%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=O36mwKeH8GDQhpShsTVkK%2B3GYt5gJC1cuLg8fHQzyQY%3D&reserved=0

GitHub:
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fgeode%2Ftree%2Frel%2Fv1.13.1.RC2&data=04%7C01%7Cdasmith%40vmware.com%7Cd50c5cb12cba485293d708d8876f8993%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637408260404370999%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=%2Fy%2BxHFK%2BDPWRp1k10fpdnJjXFg5W%2F8pOoFq6viPUFT8%3D&reserved=0
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fgeode-examples%2Ftree%2Frel%2Fv1.13.1.RC2&data=04%7C01%7Cdasmith%40vmware.com%7Cd50c5cb12cba485293d708d8876f8993%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637408260404370999%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=y4eQqpwIIgpmdRsKb%2FqBWIM7eLZ9d0PBwi0bf%2BxfNvg%3D&reserved=0
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fgeode-native%2Ftree%2Frel%2Fv1.13.1.RC2&data=04%7C01%7Cdasmith%40vmware.com%7Cd50c5cb12cba485293d708d8876f8993%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637408260404370999%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=zqt9W4tOlg23Yjv%2FPsz%2FrKOIq%2BK%2FRkbgd7tY%2BUcgG3s%3D&reserved=0
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fgeode-benchmarks%2Ftree%2Frel%2Fv1.13.1.RC2&data=04%7C01%7Cdasmith%40vmware.com%7Cd50c5cb12cba485293d708d8876f8993%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637408260404380998%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=PycDQbMPFNz4JOVAHu7g0U2NFjZdyc6II2kU52%2BWaPE%3D&reserved=0

Pipelines:
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fconcourse.apachegeode-ci.info%2Fteams%2Fmain%2Fpipelines%2Fapache-support-1-13-main&data=04%7C01%7Cdasmith%40vmware.com%7Cd50c5cb12cba485293d708d8876f8993%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637408260404380998%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=SubE%2Fnkqr2Qkzagg%2FB5CkSwoH3f6aLTSDWwcCHp9xbY%3D&reserved=0
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fconcourse.apachegeode-ci.info%2Fteams%2Fmain%2Fpipelines%2Fapache-support-1-13-rc&data=04%7C01%7Cdasmith%40vmware.com%7Cd50c5cb12cba485293d708d8876f8993%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637408260404380998%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=T6Bh3LoGelScH9mrjpybv9%2FdFNgzX6IvQwY%2FHJ0TyXo%3D&reserved=0

Geode's KEYS file containing PGP keys we use to sign the release:
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fgeode%2Fblob%2Fdevelop%2FKEYS&data=04%7C01%7Cdasmith%40vmware.com%7Cd50c5cb12cba485293d708d8876f8993%7Cb391