Re: Odg: Certificate Based Authorization

[Jakov Varenina]

Hi Anthony and all,

I have been working with Mario on this feature. Let me first answer the 
questions:


1) Multi-user authentication will not be supported when using this new 
kind of SecurityManager implementation.


2) The idea was to use only CN for principal, and ignore SAN (this would 
be documented). But we could as you suggested forward both, or even 
whole certificate, and let the user to decide which one to use. 
According to RFC 6125 
, SAN is not 
replacement for CN but they complement each other.


In order to completely remove the need for username/password, it is 
required that we implement this new kind of authorization on *all* geode 
interfaces/components (cluster, gateway, web, jmx, locator, server). The 
reason why we didn't have any progress is because we faced major 
obstacle during development when we tried to retrieve clients 
certificate from RMI connections (e.g. jmx connections). It seems there 
are no easy/nice way to retrieve it, and what we came up so far is 
following:


1) We have found some possible "hack solution" that could be implemented 
and it is described in the following paper 
(http://citeseerx.ist.psu.edu/viewdoc/download?doi=10.1.1.224.2915&rep=rep1&type=pdf). 
We have started to work on the prototype that will implement this solution.


2) Second idea is that client reads CN (principal) from certificate and 
sends it towards server in a same way as Username/Password is sent now 
over RMI connections. The downside of this solution is that server 
doesn't verify the originator identity, that is, will not compare 
received principal with one received within the client certificate. With 
this solution, client's that uses certificates signed by geode trusted 
Certificate Authority and with lower authorization privileges, can 
"hack" client implementation and send principal with higher ( then which 
was given to them with a certificate) authorization privileges over RMI 
connection, since that principal will not compared with one received in 
the certificate.


We would be really grateful if community would give us feedback if any 
of this is acceptable? Any new solution proposal or hint would be really 
appreciated. We have already sent a question to @dev@geode regarding 
this issue: https://www.mail-archive.com/dev@geode.apache.org/msg24083.html


BRs,

Jakov


On 16. 06. 2020. 19:36, Anthony Baker wrote:

Hi Mario, just curious if you’ve made any progress on this as of yet.  I have a 
few questions:

1) What is the implication for multi-user auth? Would this just become a no-op 
for this kind of SecurityManager implementation?  See [1][2].

2) I’m not sure that the CN is sufficiently general.  What if I want to use the 
SAN for the Principal?  Can we forward the entire certificate to the the 
authenticate [3] callback?


Anthony

[1] 
https://geode.apache.org/docs/guide/19/basic_config/the_cache/managing_a_multiuser_cache.html
[2] 
https://geode.apache.org/releases/latest/javadoc/org/apache/geode/cache/client/ClientCache.html#createAuthenticatedView-java.util.Properties-
[3] 
https://geode.apache.org/releases/latest/javadoc/org/apache/geode/security/SecurityManager.html#authenticate-java.util.Properties-


On Dec 6, 2019, at 9:06 AM, Jens Deppe (Pivotal) 
mailto:jde...@pivotal.io>> wrote:

Thanks for the write-up. I think it does require a bit of clarification
around how the functionality is enabled.

You've stated:

For client connections, we could presume that certificate based
authorization should be used if both features are enabled, but the client
cache properties don’t provide credentials
(security-username/security-password).


Currently, the presence of any '*auth-init' parameters, does not
necessarily require setting *security-username/password* (although almost
all implementations of AuthInitialize probably do use them). So this
condition will not be sufficient to enable this new functionality.

Although we already have so many parameters I think that having an explicit
parameter, to enable this feature, will avoid any possible confusion.

I'm wondering whether, for an initial deliverable, we should require
*ssl-enabled-components=all*. This would not allow a mix of different forms
of authentication for different endpoints. Perhaps this might simplify the
implementation but would not preclude us from adding that capability in the
future.

--Jens

On Fri, Dec 6, 2019 at 1:13 AM Mario Kevo 
mailto:mario.k...@est.tech>> wrote:

Hi all,

I wrote up a proposal for Certificate Based Authorization.
Please review and comment on the below proposal.


https://cwiki.apache.org/confluence/display/GEODE/Certificate+Based+Authorization

BR,
Mario

Šalje: Udo Kohlmeyer 
Poslano: 2. prosinca 2019. 20:10
Prima: dev@geode.apache.org 
Predmet: Re: Certificate Based Authorization

+1

On 12/2/19 1:29 AM, Mario Kevo wrote:
Hi,



There is another potential functionality we would like to discu

Heap memory used by gateway sender queues way above configured limit after server restart

[Alberto Gomez]

Hi,

I have found an issue with heap memory consumed by gateway sender queues way 
above the configured limit after a server is restarted (on the restarted 
server).

The problem is described in the following ticket:

https://issues.apache.org/jira/browse/GEODE-8278

I would highly appreciate some help from the community on where to look in the 
code (or any other hint) in order to implement a solution.

Thanks in advance,

Alberto G.

Re: Setting your commit email address

[Kirk Lund]

I guess my main point is that I don't like private emails in OSS commit
messages.

Author: John Doe 

If there's a problem with a commit made by John Doe and he doesn't work for
Pivotal, then I have no idea how to contact him directly to discuss the
commit. If I visit github.com/johndoe, there's no way to send a message to
Mr. Doe. If Mr. Doe is a committer, then I know john...@apache.org exists.

Is there really a privacy problem with having "john...@apache.org" in the
commit message? Hiding it makes it very difficult for the rest of us in the
same community to contact that person which is why I don't like private
emails.

Are you getting lots of spam from git commits??


On Wed, Jun 17, 2020 at 1:20 PM Nabarun Nag  wrote:

> Hi Kirk,
>
> I think it is also now in the privacy setting in GitHub for anyone who
> wants to keep emails private. [https://github.com/settings/emails :
> https://github.com/settings/emails ]
>
> This setting is needed for web based git operations like squash merging
> PRs etc.
>
> In GitHub:
> "Keep my email addresses private
> We’ll remove your public profile email and use
> nabarun...@users.noreply.github.com when performing web-based Git
> operations (e.g. edits and merges) and sending email on your behalf. If you
> want command line Git operations to use your private email you must set
> your email in Git."
>
> Regards
> Nabarun
>
> -Original Message-
> From: Kirk Lund 
> Sent: Wednesday, June 17, 2020 1:12 PM
> To: dev@geode.apache.org
> Subject: Setting your commit email address
>
> Please make sure you've setup your commit email address. It makes it much
> easier to find out who committed something and how to contact them if
> there's a problem.
>
> You typically use the following to set your email address globally in git:
>
> $ git config --global user.email "em...@example.com"
>
> You can also setup different repos with different email addresses by using:
>
> $ git config user.email "em...@example.com"
>
> In the below example, it's much easier to follow up with the author of the
> 1st commit than the author of the 2nd commit:
>
> commit b1107d2e403404337c22830a4964eefc2490ef50
> Author: John Doe 
> Date:   Tue Jun 16 12:25:30 2020 -0700
>
> GEODE-: add something new
>
> commit e159238175766b46cbb6fe1e3459aa2da68db756
> Author: John Doe 
> Date:   Tue Jun 16 10:55:16 2020 -0700
>
> GEODE-: fix something bad
>
> For more info, see:
>
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fhelp.github.com%2Fen%2Fgithub%2Fsetting-up-and-managing-your-github-user-account%2Fsetting-your-commit-email-address&data=02%7C01%7Cnnag%40vmware.com%7C52882c4b78a34fd2ddfe08d812faa8f2%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637280215074685835&sdata=898w3f4jbFyTyQl8GAy1cFboW28VHCZAbl5ycwO8vX8%3D&reserved=0
>
> Thanks,
> Kirk
>

[PROPOSAL] backport GEODE-8277 to support/1.13

[Bruce Schuchardt]

Several keystores used by a test have expired, which will cause acceptance 
tests to fail in support/1.13.  I’d like to cherry-pick the new keystores into 
that branch.  The new keystores have a 5/2120 expiration date.

Re: [PROPOSAL] backport GEODE-8277 to support/1.13

[Ernie Burghardt]

+100 

On 6/18/20, 10:46 AM, "Bruce Schuchardt"  wrote:

Several keystores used by a test have expired, which will cause acceptance 
tests to fail in support/1.13.  I’d like to cherry-pick the new keystores into 
that branch.  The new keystores have a 5/2120 expiration date.

Re: Setting your commit email address

[Mark Hanson]

Hi All,

Just my opinion here, but I think that if you commit something that breaks CI, 
I should be able e-mail you at the email address on your commit.

Thanks,
Mark


On 6/18/20, 10:31 AM, "Kirk Lund"  wrote:

I guess my main point is that I don't like private emails in OSS commit
messages.

Author: John Doe 

If there's a problem with a commit made by John Doe and he doesn't work for
Pivotal, then I have no idea how to contact him directly to discuss the
commit. If I visit github.com/johndoe, there's no way to send a message to
Mr. Doe. If Mr. Doe is a committer, then I know john...@apache.org exists.

Is there really a privacy problem with having "john...@apache.org" in the
commit message? Hiding it makes it very difficult for the rest of us in the
same community to contact that person which is why I don't like private
emails.

Are you getting lots of spam from git commits??


On Wed, Jun 17, 2020 at 1:20 PM Nabarun Nag  wrote:

> Hi Kirk,
>
> I think it is also now in the privacy setting in GitHub for anyone who
> wants to keep emails private. 
[https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fsettings%2Femails&data=02%7C01%7Chansonm%40vmware.com%7Cf1ba6c653770490084e108d813ad6a22%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637280982818745590&sdata=uhBB1QBCvmXKY5EQlXYuneTZGOOMnxdd4qpFE2bonbo%3D&reserved=0
 :
> 
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fsettings%2Femails&data=02%7C01%7Chansonm%40vmware.com%7Cf1ba6c653770490084e108d813ad6a22%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637280982818745590&sdata=uhBB1QBCvmXKY5EQlXYuneTZGOOMnxdd4qpFE2bonbo%3D&reserved=0
 ]
>
> This setting is needed for web based git operations like squash merging
> PRs etc.
>
> In GitHub:
> "Keep my email addresses private
> We’ll remove your public profile email and use
> nabarun...@users.noreply.github.com when performing web-based Git
> operations (e.g. edits and merges) and sending email on your behalf. If 
you
> want command line Git operations to use your private email you must set
> your email in Git."
>
> Regards
> Nabarun
>
> -Original Message-
> From: Kirk Lund 
> Sent: Wednesday, June 17, 2020 1:12 PM
> To: dev@geode.apache.org
> Subject: Setting your commit email address
>
> Please make sure you've setup your commit email address. It makes it much
> easier to find out who committed something and how to contact them if
> there's a problem.
>
> You typically use the following to set your email address globally in git:
>
> $ git config --global user.email "em...@example.com"
>
> You can also setup different repos with different email addresses by 
using:
>
> $ git config user.email "em...@example.com"
>
> In the below example, it's much easier to follow up with the author of the
> 1st commit than the author of the 2nd commit:
>
> commit b1107d2e403404337c22830a4964eefc2490ef50
> Author: John Doe 
> Date:   Tue Jun 16 12:25:30 2020 -0700
>
> GEODE-: add something new
>
> commit e159238175766b46cbb6fe1e3459aa2da68db756
> Author: John Doe 
> Date:   Tue Jun 16 10:55:16 2020 -0700
>
> GEODE-: fix something bad
>
> For more info, see:
>
> 
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fhelp.github.com%2Fen%2Fgithub%2Fsetting-up-and-managing-your-github-user-account%2Fsetting-your-commit-email-address&data=02%7C01%7Chansonm%40vmware.com%7Cf1ba6c653770490084e108d813ad6a22%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637280982818745590&sdata=4%2Fq8B%2B7yNYzwS2PcVP1YpHC3SMkZbK0RtqLWjPbLw3s%3D&reserved=0
>
> Thanks,
> Kirk
>

RE: [PROPOSAL] backport GEODE-8277 to support/1.13

[Dick Cavender]

+1

-Original Message-
From: Ernie Burghardt  
Sent: Thursday, June 18, 2020 10:49 AM
To: dev@geode.apache.org
Subject: Re: [PROPOSAL] backport GEODE-8277 to support/1.13

+100 

On 6/18/20, 10:46 AM, "Bruce Schuchardt"  wrote:

Several keystores used by a test have expired, which will cause acceptance 
tests to fail in support/1.13.  I’d like to cherry-pick the new keystores into 
that branch.  The new keystores have a 5/2120 expiration date.

Re: [PROPOSAL] backport GEODE-8277 to support/1.13

[Owen Nichols]

+1

On 6/18/20, 12:15 PM, "Dick Cavender"  wrote:

+1

-Original Message-
From: Ernie Burghardt  
Sent: Thursday, June 18, 2020 10:49 AM
To: dev@geode.apache.org
Subject: Re: [PROPOSAL] backport GEODE-8277 to support/1.13

+100 

On 6/18/20, 10:46 AM, "Bruce Schuchardt"  wrote:

Several keystores used by a test have expired, which will cause 
acceptance tests to fail in support/1.13.  I’d like to cherry-pick the new 
keystores into that branch.  The new keystores have a 5/2120 expiration date.

Re: [PROPOSAL] backport GEODE-8277 to support/1.13

[Dave Barnes]

Wow, +103! Sounds like an endorsement.

On Thu, Jun 18, 2020 at 12:44 PM Owen Nichols  wrote:

> +1
>
> On 6/18/20, 12:15 PM, "Dick Cavender"  wrote:
>
> +1
>
> -Original Message-
> From: Ernie Burghardt 
> Sent: Thursday, June 18, 2020 10:49 AM
> To: dev@geode.apache.org
> Subject: Re: [PROPOSAL] backport GEODE-8277 to support/1.13
>
> +100
>
> On 6/18/20, 10:46 AM, "Bruce Schuchardt"  wrote:
>
> Several keystores used by a test have expired, which will cause
> acceptance tests to fail in support/1.13.  I’d like to cherry-pick the new
> keystores into that branch.  The new keystores have a 5/2120 expiration
> date.
>
>
>

[PROPOSAL] back port fix for GEODE-8251 to support branches

[Jinmei Liao]

The fix for this issue https://issues.apache.org/jira/browse/GEODE-8251 is 
needed on support 1.13 branch in order for rolling upgrade to work from 1.12 to 
1.13.

Thanks!

Jinmei

Re: [PROPOSAL] back port fix for GEODE-8251 to support branches

[Owen Nichols]

+1

On 6/18/20, 3:24 PM, "Jinmei Liao"  wrote:

The fix for this issue 
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FGEODE-8251&data=02%7C01%7Conichols%40vmware.com%7C610a0f946ca4451254a008d813d66241%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637281158794251882&sdata=I3tOJVCLHQZkzsaLVYg5Dd2i5oM7eZRfCQHwev41L0w%3D&reserved=0
 is needed on support 1.13 branch in order for rolling upgrade to work from 
1.12 to 1.13.

Thanks!

Jinmei

Re: Setting your commit email address

[Jacob Barrett]

Regardless of the email address issue, you can go to the commit and make 
comments and @johndoe and they will get a notification. 

-Jake


> On Jun 18, 2020, at 10:31 AM, Kirk Lund  wrote:
> 
> I guess my main point is that I don't like private emails in OSS commit
> messages.
> 
> Author: John Doe 
> 
> If there's a problem with a commit made by John Doe and he doesn't work for
> Pivotal, then I have no idea how to contact him directly to discuss the
> commit. If I visit github.com/johndoe, there's no way to send a message to
> Mr. Doe. If Mr. Doe is a committer, then I know john...@apache.org exists.
> 
> Is there really a privacy problem with having "john...@apache.org" in the
> commit message? Hiding it makes it very difficult for the rest of us in the
> same community to contact that person which is why I don't like private
> emails.
> 
> Are you getting lots of spam from git commits??
> 
> 
> On Wed, Jun 17, 2020 at 1:20 PM Nabarun Nag  wrote:
> 
>> Hi Kirk,
>> 
>> I think it is also now in the privacy setting in GitHub for anyone who
>> wants to keep emails private. 
>> [https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fsettings%2Femails&data=02%7C01%7Cjabarrett%40vmware.com%7C46ffcf6c885b4b17242608d813ad6a39%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637280982817747880&sdata=pW5U2q9CXMKxV4gaw%2FF9OVrZVqDJI4WGKEe9Rh7CahU%3D&reserved=0
>>  :
>> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fsettings%2Femails&data=02%7C01%7Cjabarrett%40vmware.com%7C46ffcf6c885b4b17242608d813ad6a39%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637280982817747880&sdata=pW5U2q9CXMKxV4gaw%2FF9OVrZVqDJI4WGKEe9Rh7CahU%3D&reserved=0
>>  ]
>> 
>> This setting is needed for web based git operations like squash merging
>> PRs etc.
>> 
>> In GitHub:
>> "Keep my email addresses private
>> We’ll remove your public profile email and use
>> nabarun...@users.noreply.github.com when performing web-based Git
>> operations (e.g. edits and merges) and sending email on your behalf. If you
>> want command line Git operations to use your private email you must set
>> your email in Git."
>> 
>> Regards
>> Nabarun
>> 
>> -Original Message-
>> From: Kirk Lund 
>> Sent: Wednesday, June 17, 2020 1:12 PM
>> To: dev@geode.apache.org
>> Subject: Setting your commit email address
>> 
>> Please make sure you've setup your commit email address. It makes it much
>> easier to find out who committed something and how to contact them if
>> there's a problem.
>> 
>> You typically use the following to set your email address globally in git:
>> 
>> $ git config --global user.email "em...@example.com"
>> 
>> You can also setup different repos with different email addresses by using:
>> 
>> $ git config user.email "em...@example.com"
>> 
>> In the below example, it's much easier to follow up with the author of the
>> 1st commit than the author of the 2nd commit:
>> 
>> commit b1107d2e403404337c22830a4964eefc2490ef50
>> Author: John Doe 
>> Date:   Tue Jun 16 12:25:30 2020 -0700
>> 
>>GEODE-: add something new
>> 
>> commit e159238175766b46cbb6fe1e3459aa2da68db756
>> Author: John Doe 
>> Date:   Tue Jun 16 10:55:16 2020 -0700
>> 
>>GEODE-: fix something bad
>> 
>> For more info, see:
>> 
>> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fhelp.github.com%2Fen%2Fgithub%2Fsetting-up-and-managing-your-github-user-account%2Fsetting-your-commit-email-address&data=02%7C01%7Cjabarrett%40vmware.com%7C46ffcf6c885b4b17242608d813ad6a39%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637280982817757873&sdata=gHaNqt9QpQXDJlLQe7iAFWxbylcRgZCxEYM469y%2F%2FZQ%3D&reserved=0
>> 
>> Thanks,
>> Kirk
>> 

Re: [PROPOSAL] back port fix for GEODE-8251 to support branches

[Bruce Schuchardt]

+1

On 6/18/20, 3:24 PM, "Jinmei Liao"  wrote:

The fix for this issue 
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FGEODE-8251&data=02%7C01%7Cbruces%40vmware.com%7Cf8e5df909b5d4460244208d813d66245%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637281158780878901&sdata=mWrGprzThZ4mnDbIOHwx%2FY4OENdbBIM2YWDUJUH3HuY%3D&reserved=0
 is needed on support 1.13 branch in order for rolling upgrade to work from 
1.12 to 1.13.

Thanks!

Jinmei

Re: Setting your commit email address

[Mark Hanson]

I think that is a fair point.

On 6/18/20, 3:43 PM, "Jacob Barrett"  wrote:

Regardless of the email address issue, you can go to the commit and make 
comments and @johndoe and they will get a notification. 

-Jake


> On Jun 18, 2020, at 10:31 AM, Kirk Lund  wrote:
> 
> I guess my main point is that I don't like private emails in OSS commit
> messages.
> 
> Author: John Doe 
> 
> If there's a problem with a commit made by John Doe and he doesn't work 
for
> Pivotal, then I have no idea how to contact him directly to discuss the
> commit. If I visit github.com/johndoe, there's no way to send a message to
> Mr. Doe. If Mr. Doe is a committer, then I know john...@apache.org exists.
> 
> Is there really a privacy problem with having "john...@apache.org" in the
> commit message? Hiding it makes it very difficult for the rest of us in 
the
> same community to contact that person which is why I don't like private
> emails.
> 
> Are you getting lots of spam from git commits??
> 
> 
> On Wed, Jun 17, 2020 at 1:20 PM Nabarun Nag  wrote:
> 
>> Hi Kirk,
>> 
>> I think it is also now in the privacy setting in GitHub for anyone who
>> wants to keep emails private. 
[https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fsettings%2Femails&data=02%7C01%7Chansonm%40vmware.com%7C65458f873bd24f38514908d813d90c57%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637281170244761838&sdata=Q0ar18fz6Hu51i1TyM1PEW92o6SbBY%2FBnYSJlIgiCXE%3D&reserved=0
 :
>> 
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fsettings%2Femails&data=02%7C01%7Chansonm%40vmware.com%7C65458f873bd24f38514908d813d90c57%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637281170244761838&sdata=Q0ar18fz6Hu51i1TyM1PEW92o6SbBY%2FBnYSJlIgiCXE%3D&reserved=0
 ]
>> 
>> This setting is needed for web based git operations like squash merging
>> PRs etc.
>> 
>> In GitHub:
>> "Keep my email addresses private
>> We’ll remove your public profile email and use
>> nabarun...@users.noreply.github.com when performing web-based Git
>> operations (e.g. edits and merges) and sending email on your behalf. If 
you
>> want command line Git operations to use your private email you must set
>> your email in Git."
>> 
>> Regards
>> Nabarun
>> 
>> -Original Message-
>> From: Kirk Lund 
>> Sent: Wednesday, June 17, 2020 1:12 PM
>> To: dev@geode.apache.org
>> Subject: Setting your commit email address
>> 
>> Please make sure you've setup your commit email address. It makes it much
>> easier to find out who committed something and how to contact them if
>> there's a problem.
>> 
>> You typically use the following to set your email address globally in 
git:
>> 
>> $ git config --global user.email "em...@example.com"
>> 
>> You can also setup different repos with different email addresses by 
using:
>> 
>> $ git config user.email "em...@example.com"
>> 
>> In the below example, it's much easier to follow up with the author of 
the
>> 1st commit than the author of the 2nd commit:
>> 
>> commit b1107d2e403404337c22830a4964eefc2490ef50
>> Author: John Doe 
>> Date:   Tue Jun 16 12:25:30 2020 -0700
>> 
>>GEODE-: add something new
>> 
>> commit e159238175766b46cbb6fe1e3459aa2da68db756
>> Author: John Doe 
>> Date:   Tue Jun 16 10:55:16 2020 -0700
>> 
>>GEODE-: fix something bad
>> 
>> For more info, see:
>> 
>> 
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fhelp.github.com%2Fen%2Fgithub%2Fsetting-up-and-managing-your-github-user-account%2Fsetting-your-commit-email-address&data=02%7C01%7Chansonm%40vmware.com%7C65458f873bd24f38514908d813d90c57%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637281170244761838&sdata=RWMweOgxyRgIVd%2Bei1rpRdfL2j%2F%2FIogBRjZzJ%2FQlhLw%3D&reserved=0
>> 
>> Thanks,
>> Kirk
>> 

Re: Setting your commit email address

[Kirk Lund]

I'm not sure what you're talking about Jake (PRs?). I'm talking about
commits that are already on develop.

For example, if someone adds a new dunit test that turns out to be very
flaky, I'd like to find out from the git log who authored it and send them
an email directly (privately) and I have no way to do that if they're
hiding their email address.

Thanks though,
Kirk

On Thu, Jun 18, 2020 at 3:43 PM Jacob Barrett  wrote:

> Regardless of the email address issue, you can go to the commit and make
> comments and @johndoe and they will get a notification.
>
> -Jake
>
>
> > On Jun 18, 2020, at 10:31 AM, Kirk Lund  wrote:
> >
> > I guess my main point is that I don't like private emails in OSS commit
> > messages.
> >
> > Author: John Doe 
> >
> > If there's a problem with a commit made by John Doe and he doesn't work
> for
> > Pivotal, then I have no idea how to contact him directly to discuss the
> > commit. If I visit github.com/johndoe, there's no way to send a message
> to
> > Mr. Doe. If Mr. Doe is a committer, then I know john...@apache.org
> exists.
> >
> > Is there really a privacy problem with having "john...@apache.org" in
> the
> > commit message? Hiding it makes it very difficult for the rest of us in
> the
> > same community to contact that person which is why I don't like private
> > emails.
> >
> > Are you getting lots of spam from git commits??
> >
> >
> > On Wed, Jun 17, 2020 at 1:20 PM Nabarun Nag  wrote:
> >
> >> Hi Kirk,
> >>
> >> I think it is also now in the privacy setting in GitHub for anyone who
> >> wants to keep emails private. [
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fsettings%2Femails&data=02%7C01%7Cjabarrett%40vmware.com%7C46ffcf6c885b4b17242608d813ad6a39%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637280982817747880&sdata=pW5U2q9CXMKxV4gaw%2FF9OVrZVqDJI4WGKEe9Rh7CahU%3D&reserved=0
> :
> >>
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fsettings%2Femails&data=02%7C01%7Cjabarrett%40vmware.com%7C46ffcf6c885b4b17242608d813ad6a39%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637280982817747880&sdata=pW5U2q9CXMKxV4gaw%2FF9OVrZVqDJI4WGKEe9Rh7CahU%3D&reserved=0
> ]
> >>
> >> This setting is needed for web based git operations like squash merging
> >> PRs etc.
> >>
> >> In GitHub:
> >> "Keep my email addresses private
> >> We’ll remove your public profile email and use
> >> nabarun...@users.noreply.github.com when performing web-based Git
> >> operations (e.g. edits and merges) and sending email on your behalf. If
> you
> >> want command line Git operations to use your private email you must set
> >> your email in Git."
> >>
> >> Regards
> >> Nabarun
> >>
> >> -Original Message-
> >> From: Kirk Lund 
> >> Sent: Wednesday, June 17, 2020 1:12 PM
> >> To: dev@geode.apache.org
> >> Subject: Setting your commit email address
> >>
> >> Please make sure you've setup your commit email address. It makes it
> much
> >> easier to find out who committed something and how to contact them if
> >> there's a problem.
> >>
> >> You typically use the following to set your email address globally in
> git:
> >>
> >> $ git config --global user.email "em...@example.com"
> >>
> >> You can also setup different repos with different email addresses by
> using:
> >>
> >> $ git config user.email "em...@example.com"
> >>
> >> In the below example, it's much easier to follow up with the author of
> the
> >> 1st commit than the author of the 2nd commit:
> >>
> >> commit b1107d2e403404337c22830a4964eefc2490ef50
> >> Author: John Doe 
> >> Date:   Tue Jun 16 12:25:30 2020 -0700
> >>
> >>GEODE-: add something new
> >>
> >> commit e159238175766b46cbb6fe1e3459aa2da68db756
> >> Author: John Doe 
> >> Date:   Tue Jun 16 10:55:16 2020 -0700
> >>
> >>GEODE-: fix something bad
> >>
> >> For more info, see:
> >>
> >>
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fhelp.github.com%2Fen%2Fgithub%2Fsetting-up-and-managing-your-github-user-account%2Fsetting-your-commit-email-address&data=02%7C01%7Cjabarrett%40vmware.com%7C46ffcf6c885b4b17242608d813ad6a39%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637280982817757873&sdata=gHaNqt9QpQXDJlLQe7iAFWxbylcRgZCxEYM469y%2F%2FZQ%3D&reserved=0
> >>
> >> Thanks,
> >> Kirk
> >>
>
>

Re: Setting your commit email address

[Owen Nichols]

Perhaps a little-known feature of GitHub: you can comment on commits too, not 
just on PRs.  For example: 
https://github.com/apache/geode/commit/d82e30d3dd50e3983c332063c41915e97aca721a

On 6/18/20, 3:48 PM, "Kirk Lund"  wrote:

I'm not sure what you're talking about Jake (PRs?). I'm talking about
commits that are already on develop.

For example, if someone adds a new dunit test that turns out to be very
flaky, I'd like to find out from the git log who authored it and send them
an email directly (privately) and I have no way to do that if they're
hiding their email address.

Thanks though,
Kirk

On Thu, Jun 18, 2020 at 3:43 PM Jacob Barrett  wrote:

> Regardless of the email address issue, you can go to the commit and make
> comments and @johndoe and they will get a notification.
>
> -Jake
>
>
> > On Jun 18, 2020, at 10:31 AM, Kirk Lund  wrote:
> >
> > I guess my main point is that I don't like private emails in OSS commit
> > messages.
> >
> > Author: John Doe 
> >
> > If there's a problem with a commit made by John Doe and he doesn't work
> for
> > Pivotal, then I have no idea how to contact him directly to discuss the
> > commit. If I visit github.com/johndoe, there's no way to send a message
> to
> > Mr. Doe. If Mr. Doe is a committer, then I know john...@apache.org
> exists.
> >
> > Is there really a privacy problem with having "john...@apache.org" in
> the
> > commit message? Hiding it makes it very difficult for the rest of us in
> the
> > same community to contact that person which is why I don't like private
> > emails.
> >
> > Are you getting lots of spam from git commits??
> >
> >
> > On Wed, Jun 17, 2020 at 1:20 PM Nabarun Nag  wrote:
> >
> >> Hi Kirk,
> >>
> >> I think it is also now in the privacy setting in GitHub for anyone who
> >> wants to keep emails private. [
> 
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fsettings%2Femails&data=02%7C01%7Conichols%40vmware.com%7C7ac9167a37b54c070d7e08d813d9aa6e%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637281172880655331&sdata=QrtQe4ftMGNQIaf1KOXMuQXDQQAnL4x09Cpa1gW47%2Bs%3D&reserved=0
> :
> >>
> 
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fsettings%2Femails&data=02%7C01%7Conichols%40vmware.com%7C7ac9167a37b54c070d7e08d813d9aa6e%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637281172880655331&sdata=QrtQe4ftMGNQIaf1KOXMuQXDQQAnL4x09Cpa1gW47%2Bs%3D&reserved=0
> ]
> >>
> >> This setting is needed for web based git operations like squash merging
> >> PRs etc.
> >>
> >> In GitHub:
> >> "Keep my email addresses private
> >> We’ll remove your public profile email and use
> >> nabarun...@users.noreply.github.com when performing web-based Git
> >> operations (e.g. edits and merges) and sending email on your behalf. If
> you
> >> want command line Git operations to use your private email you must set
> >> your email in Git."
> >>
> >> Regards
> >> Nabarun
> >>
> >> -Original Message-
> >> From: Kirk Lund 
> >> Sent: Wednesday, June 17, 2020 1:12 PM
> >> To: dev@geode.apache.org
> >> Subject: Setting your commit email address
> >>
> >> Please make sure you've setup your commit email address. It makes it
> much
> >> easier to find out who committed something and how to contact them if
> >> there's a problem.
> >>
> >> You typically use the following to set your email address globally in
> git:
> >>
> >> $ git config --global user.email "em...@example.com"
> >>
> >> You can also setup different repos with different email addresses by
> using:
> >>
> >> $ git config user.email "em...@example.com"
> >>
> >> In the below example, it's much easier to follow up with the author of
> the
> >> 1st commit than the author of the 2nd commit:
> >>
> >> commit b1107d2e403404337c22830a4964eefc2490ef50
> >> Author: John Doe 
> >> Date:   Tue Jun 16 12:25:30 2020 -0700
> >>
> >>GEODE-: add something new
> >>
> >> commit e159238175766b46cbb6fe1e3459aa2da68db756
> >> Author: John Doe 
> >> Date:   Tue Jun 16 10:55:16 2020 -0700
> >>
> >>GEODE-: fix something bad
> >>
> >> For more info, see:
> >>
> >>
> 
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fhelp.github.com%2Fen%2Fgithub%2Fsetting-up-and-managing-your-github-user-account%2Fsetting-your-commit-email-address&data=02%7C01%7Conichols%40vmware.com%7C7ac9167a37b54c070d7e08d813d9aa6e%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637281172880655331&sdata=%2B7D0UrWpNAJeonQ%2Fuu%2F0Em7NTmOfqjBP%2FLP27%2B0Fqzw%3D&reserved=0
> >>
> >> Thanks,
> >> Kirk
> >>
>
>

[INFO] Latest test run of 200 DistributedTestOpenJDK8 passes

[Mark Hanson]

FYI, the build success rate was around 90% or so about two months ago.

Here are the DUnit tests that are currently failing in our tests, most likely 
in CI, and PR pipelines.

Please let me know if you have any questions.

Thanks,
Mark


***

 Overall build success rate: 78.0% (156 of 200)

***



The following test methods see failures in more than one class.  There may be a 
failing *TestBase class



*.testReplicatedRegionPersistentWanGateway_restartSenderWithCleanQueues_expectNoEventsReceived:
  12 failures :

  SerialWANPersistenceEnabledGatewaySenderDUnitTest:  8 failures (96.000% 
success rate)

  SerialWANPersistenceEnabledGatewaySenderOffHeapDUnitTest:  4 failures 
(98.000% success rate)



*.testpersistentWanGateway_restartSenderWithCleanQueues_expectNoEventsReceived: 
 12 failures :

  ParallelWANPersistenceEnabledGatewaySenderOffHeapDUnitTest:  5 failures 
(97.500% success rate)

  ParallelWANPersistenceEnabledGatewaySenderDUnitTest:  7 failures (96.500% 
success rate)



*.testPingWrongServer:  4 failures :

  ClientServerMiscSelectorDUnitTest:  3 failures (98.500% success rate)

  ClientServerMiscDUnitTest:  1 failures (99.500% success rate)



***





org.apache.geode.internal.cache.wan.serial.SerialWANPersistenceEnabledGatewaySenderDUnitTest:
  8 failures (96.000% success rate)



 
testReplicatedRegionPersistentWanGateway_restartSenderWithCleanQueues_expectNoEventsReceived
   
https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-mass-test-run-main/jobs/DistributedTestOpenJDK8/builds/3539

 
testReplicatedRegionPersistentWanGateway_restartSenderWithCleanQueues_expectNoEventsReceived
   
https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-mass-test-run-main/jobs/DistributedTestOpenJDK8/builds/3526

 
testReplicatedRegionPersistentWanGateway_restartSenderWithCleanQueues_expectNoEventsReceived
   
https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-mass-test-run-main/jobs/DistributedTestOpenJDK8/builds/3505

 
testReplicatedRegionPersistentWanGateway_restartSenderWithCleanQueues_expectNoEventsReceived
   
https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-mass-test-run-main/jobs/DistributedTestOpenJDK8/builds/3435

 
testReplicatedRegionPersistentWanGateway_restartSenderWithCleanQueues_expectNoEventsReceived
   
https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-mass-test-run-main/jobs/DistributedTestOpenJDK8/builds/3414

 
testReplicatedRegionPersistentWanGateway_restartSenderWithCleanQueues_expectNoEventsReceived
   
https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-mass-test-run-main/jobs/DistributedTestOpenJDK8/builds/3391

 
testReplicatedRegionPersistentWanGateway_restartSenderWithCleanQueues_expectNoEventsReceived
   
https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-mass-test-run-main/jobs/DistributedTestOpenJDK8/builds/3363

 
testReplicatedRegionPersistentWanGateway_restartSenderWithCleanQueues_expectNoEventsReceived
   
https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-mass-test-run-main/jobs/DistributedTestOpenJDK8/builds/3359



org.apache.geode.management.MemberMXBeanDistributedTest:  2 failures (99.000% 
success rate)



 testBucketCount   
https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-mass-test-run-main/jobs/DistributedTestOpenJDK8/builds/3463

 testBucketCount   
https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-mass-test-run-main/jobs/DistributedTestOpenJDK8/builds/3411



org.apache.geode.internal.cache.tier.sockets.RedundancyLevelPart3DUnitTest:  1 
failures (99.500% success rate)



 testRegisterInterestAndMakePrimaryWithFullRedundancy   
https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-mass-test-run-main/jobs/DistributedTestOpenJDK8/builds/3381



org.apache.geode.management.internal.cli.commands.QueryCommandOverHttpDUnitTest:
  1 failures (99.500% success rate)



 testSimpleQueryOnLocator   
https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-mass-test-run-main/jobs/DistributedTestOpenJDK8/builds/3516



org.apache.geode.internal.cache.tier.sockets.ClientServerMiscDUnitTest:  1 
failures (99.500% success rate)



 testPingWrongServer   
https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-mass-test-run-main/jobs/DistributedTestOpenJDK8/builds/3400



org.apache.geode.internal.cache.wan.serial.SerialWANStatsDUnitTest:  3 failures 
(98.500% success rate)



 
testReplicatedSerialPropagationWithGroupTransactionEventsSendsBatchesWithCompleteTransactions
   
https://concour