Re: [PROPOSAL] backport PR #5250 to support/1.13
Looks good, Bruce. Please backport. On Tue, Jun 16, 2020 at 4:01 PM Owen Nichols wrote: > +1 > > On 6/16/20, 3:54 PM, "Jianxia Chen" wrote: > > +1 > > On Tue, Jun 16, 2020 at 3:24 PM Bruce Schuchardt > wrote: > > > This PR has been merged to develop. It fixes a problem with the > previous > > commit for GEODE-8144 that caused performance degradation when TLS is > > enabled between servers. I have run perf tests and verified that it > fixes > > the problem. > > > > It’s a small change that makes a big difference… > > > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fgeode%2Fpull%2F5250&data=02%7C01%7Conichols%40vmware.com%7Ce2ec5e282bb240a6406d08d812484504%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637279448892893348&sdata=1qOm9MNcOb0JbWE8PTtLJEicYXbO8QglFaPk18VhRss%3D&reserved=0 > > > > > >
Setting your commit email address
Please make sure you've setup your commit email address. It makes it much easier to find out who committed something and how to contact them if there's a problem. You typically use the following to set your email address globally in git: $ git config --global user.email "em...@example.com" You can also setup different repos with different email addresses by using: $ git config user.email "em...@example.com" In the below example, it's much easier to follow up with the author of the 1st commit than the author of the 2nd commit: commit b1107d2e403404337c22830a4964eefc2490ef50 Author: John Doe Date: Tue Jun 16 12:25:30 2020 -0700 GEODE-: add something new commit e159238175766b46cbb6fe1e3459aa2da68db756 Author: John Doe Date: Tue Jun 16 10:55:16 2020 -0700 GEODE-: fix something bad For more info, see: https://help.github.com/en/github/setting-up-and-managing-your-github-user-account/setting-your-commit-email-address Thanks, Kirk
RE: Setting your commit email address
Hi Kirk, I think it is also now in the privacy setting in GitHub for anyone who wants to keep emails private. [https://github.com/settings/emails : https://github.com/settings/emails ] This setting is needed for web based git operations like squash merging PRs etc. In GitHub: "Keep my email addresses private We’ll remove your public profile email and use nabarun...@users.noreply.github.com when performing web-based Git operations (e.g. edits and merges) and sending email on your behalf. If you want command line Git operations to use your private email you must set your email in Git." Regards Nabarun -Original Message- From: Kirk Lund Sent: Wednesday, June 17, 2020 1:12 PM To: dev@geode.apache.org Subject: Setting your commit email address Please make sure you've setup your commit email address. It makes it much easier to find out who committed something and how to contact them if there's a problem. You typically use the following to set your email address globally in git: $ git config --global user.email "em...@example.com" You can also setup different repos with different email addresses by using: $ git config user.email "em...@example.com" In the below example, it's much easier to follow up with the author of the 1st commit than the author of the 2nd commit: commit b1107d2e403404337c22830a4964eefc2490ef50 Author: John Doe Date: Tue Jun 16 12:25:30 2020 -0700 GEODE-: add something new commit e159238175766b46cbb6fe1e3459aa2da68db756 Author: John Doe Date: Tue Jun 16 10:55:16 2020 -0700 GEODE-: fix something bad For more info, see: https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fhelp.github.com%2Fen%2Fgithub%2Fsetting-up-and-managing-your-github-user-account%2Fsetting-your-commit-email-address&data=02%7C01%7Cnnag%40vmware.com%7C52882c4b78a34fd2ddfe08d812faa8f2%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637280215074685835&sdata=898w3f4jbFyTyQl8GAy1cFboW28VHCZAbl5ycwO8vX8%3D&reserved=0 Thanks, Kirk
