RE: [DISCUSS] RFC: New option for serial gw sender dispatcher threads start
Hi, Kind reminder. The extended deadline for the RFC review is next Thursday 4th June. BR/ Alberto B. De: Udo Kohlmeyer Enviado: sábado, 30 de mayo de 2020 2:37 Para: dev@geode.apache.org Asunto: RE: [DISCUSS] RFC: New option for serial gw sender dispatcher threads start Hi there Alberto, There is no explicit requirement to receive any “+1” messages. I think a good rule of thumb is to: a) To provide a little more time to review any RFC. One week might be a little short, given that we cannot assume that everyone has time to review/work on the project in a full-time capacity. I always think 2-3 weeks is safe. b) If no explicit “+1”s are received after 50% of the allotted review time, maybe a nudge in the DEV list to review the RFC. After those steps have been followed, it would be safe to assume that “consensus by lack of objection” is reached if the deadline has been reached. Thank you for extending. —Udo On May 29, 2020, 12:02 PM -0700, Alberto Bustamante Reyes , wrote: Hi Udo, Thanks for your message, I was not sure if I had to receive explicit +1 messages or not. Of course I prefer to have some feedback before continue so I will extend the deadline until end of next Thursday (4th June), I hope its fine. BR/ Alberto B. De: Udo Kohlmeyer Enviado: viernes, 29 de mayo de 2020 19:30 Para: dev@geode.apache.org Asunto: RE: [DISCUSS] RFC: New option for serial gw sender dispatcher threads start Hi there Alberto, Thank you for the RFC. Tbh, I don’t know if there should some guidance around the period that we invite comments on. I personally had a really busy week and could not get to the RFC review in the 1 week that I was given. I would like to request that this RFC is extended by 1 more week, to invite comments. I understand that without comments it is reasonable to assume that everyone agrees, but I would prefer that, in this case, we need to get some amount of “+1” comments on this RFC. I fear that we might fall under a false-positive mentality here, if we assume that everyone has read the RFC, had time to think and consider its repercussions, within the 1 week dead line. Hope you can accommodate the extra 1 week extension request. —Udo On May 29, 2020, 1:56 AM -0700, Alberto Bustamante Reyes , wrote: Hi, No comments have been received so far. I have moved the RFC to "in development" state and I will continue with the code implementation. BR/ Alberto B. De: Alberto Bustamante Reyes Enviado: sábado, 23 de mayo de 2020 0:26 Para: dev@geode.apache.org Asunto: [DISCUSS] RFC: New option for serial gw sender dispatcher threads start Hi Geode community, I have posted on the wiki a new RFC about implementing a new option for serial gateway sender creation related with how the dispatcher threads are started. This option will be used only when gateway receivers are configured to share same host and port. This configuration was already discussed on a previous RFC. Please send your comments by Thursday 28th May. https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcwiki.apache.org%2Fconfluence%2Fdisplay%2FGEODE%2FNew%2Boption%2Bfor%2Bserial%2Bgw%2Bsender%2Bdispatcher%2Bthreads%2Bstart&data=02%7C01%7Cudo%40vmware.com%7C286cd3ccd1c544f2e50308d80402cc16%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637263757351787094&sdata=ij1HPHVvJQKZMnrfv%2Fj147ULRhyYtDrDX2StQyD3WKM%3D&reserved=0 Thanks, Alberto B.
Native client - PdxType change in "<" operator impacts performance
Hi all, I have reported a performance problem of the c++ native client, which appeared after the modification of the "<" operator of the PdxType class: https://issues.apache.org/jira/browse/GEODE-8212 I just want to highlight it, just in case someone is facing the same issue. BR/ Alberto B.
[DISCUSSION] Stop using the Geode Repository for Feature/WIP Branches
I know this has been brought up multiple times without resolution. I want us resolve to ban the use of Geode repository for work in progress, feature branches, or any other branches that are not release or support branches. There is no reason given the nature of GitHub why you can’t fork the repository to contribute. * Work done on these branches results in the ASF bots updating the associated JIRAs and email blasting all of us with your work. * People don’t clean up these branches, which leads to a mess of branches on everyones clones and in the UI. * All your intermediate commits get synced to the repo, which bloats the repo for everyone else. Even your commits you rebase over and force push are left in the repo. When you delete your branch these commits are not removed. There is no way for us to prune unreferenced commits. Nobody else needs your commits outside of what was merged to a production branch. If anyone has a use case for working directly from Geode repo that can’t work from a fork please post it here so we can resolve. Thanks, Jake
Re: [DISCUSSION] Stop using the Geode Repository for Feature/WIP Branches
I prefer to share a fork among multiple developers instead of using the Apache Geode repository. On Tue, Jun 2, 2020 at 3:42 PM Jacob Barrett wrote: > I know this has been brought up multiple times without resolution. I want > us resolve to ban the use of Geode repository for work in progress, feature > branches, or any other branches that are not release or support branches. > There is no reason given the nature of GitHub why you can’t fork the > repository to contribute. > > * Work done on these branches results in the ASF bots updating the > associated JIRAs and email blasting all of us with your work. > > * People don’t clean up these branches, which leads to a mess of branches > on everyones clones and in the UI. > > * All your intermediate commits get synced to the repo, which bloats the > repo for everyone else. Even your commits you rebase over and force push > are left in the repo. When you delete your branch these commits are not > removed. There is no way for us to prune unreferenced commits. Nobody else > needs your commits outside of what was merged to a production branch. > > If anyone has a use case for working directly from Geode repo that can’t > work from a fork please post it here so we can resolve. > > Thanks, > Jake > > > >
Re: [DISCUSSION] Stop using the Geode Repository for Feature/WIP Branches
+1 to avoiding clutter by not using feature branches on the Geode repo. Sharing your own repo, as Kirk suggests, also works better when collaborating with folks who aren't committers. On Tue, Jun 2, 2020 at 4:16 PM Kirk Lund wrote: > I prefer to share a fork among multiple developers instead of using the > Apache Geode repository. > > On Tue, Jun 2, 2020 at 3:42 PM Jacob Barrett wrote: > > > I know this has been brought up multiple times without resolution. I want > > us resolve to ban the use of Geode repository for work in progress, > feature > > branches, or any other branches that are not release or support branches. > > There is no reason given the nature of GitHub why you can’t fork the > > repository to contribute. > > > > * Work done on these branches results in the ASF bots updating the > > associated JIRAs and email blasting all of us with your work. > > > > * People don’t clean up these branches, which leads to a mess of branches > > on everyones clones and in the UI. > > > > * All your intermediate commits get synced to the repo, which bloats the > > repo for everyone else. Even your commits you rebase over and force push > > are left in the repo. When you delete your branch these commits are not > > removed. There is no way for us to prune unreferenced commits. Nobody > else > > needs your commits outside of what was merged to a production branch. > > > > If anyone has a use case for working directly from Geode repo that can’t > > work from a fork please post it here so we can resolve. > > > > Thanks, > > Jake > > > > > > > > >
RE: [DISCUSSION] Stop using the Geode Repository for Feature/WIP Branches
- We are maintaining feature/GEODE-7665 which is the feature branch for PR clear work on which multiple developers are working on. - We are maintaining this in Geode repository. - All sub-tasks of GEODE-7665 are merged into this feature branch. - Anyone in the Geode community can work on any subtask - This is a long running, and a massive feature development which is manipulating core code on Apache Geode. Hence all work is pushed to the feature branch to keep develop isolated from a regression introduced in PR clear work. - We have previously used release flags for Lucene work which we found to be inefficient and unnecessary extra work. We vote that PR clear feature branch be maintained in the Geode Repository as this is a long running, massive effort involving everyone from the community. When the PR clear tasks are completed, the branch will be rigorously tested and then squash merged into develop and the feature branch will be deleted. Regards Naba -Original Message- From: Jacob Barrett Sent: Tuesday, June 2, 2020 3:43 PM To: dev@geode.apache.org Subject: [DISCUSSION] Stop using the Geode Repository for Feature/WIP Branches I know this has been brought up multiple times without resolution. I want us resolve to ban the use of Geode repository for work in progress, feature branches, or any other branches that are not release or support branches. There is no reason given the nature of GitHub why you can’t fork the repository to contribute. * Work done on these branches results in the ASF bots updating the associated JIRAs and email blasting all of us with your work. * People don’t clean up these branches, which leads to a mess of branches on everyones clones and in the UI. * All your intermediate commits get synced to the repo, which bloats the repo for everyone else. Even your commits you rebase over and force push are left in the repo. When you delete your branch these commits are not removed. There is no way for us to prune unreferenced commits. Nobody else needs your commits outside of what was merged to a production branch. If anyone has a use case for working directly from Geode repo that can’t work from a fork please post it here so we can resolve. Thanks, Jake
Re: [DISCUSSION] Stop using the Geode Repository for Feature/WIP Branches
While I am not 100% sure, I understand your thoughts here, I am pretty sure I do. We have already done such work in a branch in a fork (Micrometer work). The only real gotcha was that there needed to be one person at least as a collaborator, in case of vacations and such. All of the things you have specified are possible within the confines of a fork. Thanks, Mark On 6/2/20, 4:29 PM, "Nabarun Nag" wrote: - We are maintaining feature/GEODE-7665 which is the feature branch for PR clear work on which multiple developers are working on. - We are maintaining this in Geode repository. - All sub-tasks of GEODE-7665 are merged into this feature branch. - Anyone in the Geode community can work on any subtask - This is a long running, and a massive feature development which is manipulating core code on Apache Geode. Hence all work is pushed to the feature branch to keep develop isolated from a regression introduced in PR clear work. - We have previously used release flags for Lucene work which we found to be inefficient and unnecessary extra work. We vote that PR clear feature branch be maintained in the Geode Repository as this is a long running, massive effort involving everyone from the community. When the PR clear tasks are completed, the branch will be rigorously tested and then squash merged into develop and the feature branch will be deleted. Regards Naba -Original Message- From: Jacob Barrett Sent: Tuesday, June 2, 2020 3:43 PM To: dev@geode.apache.org Subject: [DISCUSSION] Stop using the Geode Repository for Feature/WIP Branches I know this has been brought up multiple times without resolution. I want us resolve to ban the use of Geode repository for work in progress, feature branches, or any other branches that are not release or support branches. There is no reason given the nature of GitHub why you can’t fork the repository to contribute. * Work done on these branches results in the ASF bots updating the associated JIRAs and email blasting all of us with your work. * People don’t clean up these branches, which leads to a mess of branches on everyones clones and in the UI. * All your intermediate commits get synced to the repo, which bloats the repo for everyone else. Even your commits you rebase over and force push are left in the repo. When you delete your branch these commits are not removed. There is no way for us to prune unreferenced commits. Nobody else needs your commits outside of what was merged to a production branch. If anyone has a use case for working directly from Geode repo that can’t work from a fork please post it here so we can resolve. Thanks, Jake
RE: [DISCUSSION] Stop using the Geode Repository for Feature/WIP Branches
I don’t think it is right to make the open source Geode Community to work on my personal fork Regards Naba -Original Message- From: Mark Hanson Sent: Tuesday, June 2, 2020 4:35 PM To: dev@geode.apache.org Subject: Re: [DISCUSSION] Stop using the Geode Repository for Feature/WIP Branches While I am not 100% sure, I understand your thoughts here, I am pretty sure I do. We have already done such work in a branch in a fork (Micrometer work). The only real gotcha was that there needed to be one person at least as a collaborator, in case of vacations and such. All of the things you have specified are possible within the confines of a fork. Thanks, Mark On 6/2/20, 4:29 PM, "Nabarun Nag" wrote: - We are maintaining feature/GEODE-7665 which is the feature branch for PR clear work on which multiple developers are working on. - We are maintaining this in Geode repository. - All sub-tasks of GEODE-7665 are merged into this feature branch. - Anyone in the Geode community can work on any subtask - This is a long running, and a massive feature development which is manipulating core code on Apache Geode. Hence all work is pushed to the feature branch to keep develop isolated from a regression introduced in PR clear work. - We have previously used release flags for Lucene work which we found to be inefficient and unnecessary extra work. We vote that PR clear feature branch be maintained in the Geode Repository as this is a long running, massive effort involving everyone from the community. When the PR clear tasks are completed, the branch will be rigorously tested and then squash merged into develop and the feature branch will be deleted. Regards Naba -Original Message- From: Jacob Barrett Sent: Tuesday, June 2, 2020 3:43 PM To: dev@geode.apache.org Subject: [DISCUSSION] Stop using the Geode Repository for Feature/WIP Branches I know this has been brought up multiple times without resolution. I want us resolve to ban the use of Geode repository for work in progress, feature branches, or any other branches that are not release or support branches. There is no reason given the nature of GitHub why you can’t fork the repository to contribute. * Work done on these branches results in the ASF bots updating the associated JIRAs and email blasting all of us with your work. * People don’t clean up these branches, which leads to a mess of branches on everyones clones and in the UI. * All your intermediate commits get synced to the repo, which bloats the repo for everyone else. Even your commits you rebase over and force push are left in the repo. When you delete your branch these commits are not removed. There is no way for us to prune unreferenced commits. Nobody else needs your commits outside of what was merged to a production branch. If anyone has a use case for working directly from Geode repo that can’t work from a fork please post it here so we can resolve. Thanks, Jake
Re: [DISCUSSION] Stop using the Geode Repository for Feature/WIP Branches
> On Jun 2, 2020, at 4:40 PM, Nabarun Nag wrote: > > I don’t think it is right to make the open source Geode Community to work on > my personal fork Why not? I can fork your fork. I can PR to your fork. Its sort of what Git was made for, no single source repository. Can you elaborate on why you feel it isn’t right? -Jake
Re: [DISCUSSION] Stop using the Geode Repository for Feature/WIP Branches
> On Jun 2, 2020, at 4:29 PM, Nabarun Nag wrote: > > - We are maintaining feature/GEODE-7665 which is the feature branch for PR > clear work on which multiple developers are working on. > - We are maintaining this in Geode repository. > - All sub-tasks of GEODE-7665 are merged into this feature branch. > - Anyone in the Geode community can work on any subtask > - This is a long running, and a massive feature development which is > manipulating core code on Apache Geode. Hence all work is pushed to the > feature branch to keep develop isolated from a regression introduced in PR > clear work. > - We have previously used release flags for Lucene work which we found to be > inefficient and unnecessary extra work. > > We vote that PR clear feature branch be maintained in the Geode Repository as > this is a long running, massive effort involving everyone from the community. > > When the PR clear tasks are completed, the branch will be rigorously tested > and then squash merged into develop and the feature branch will be deleted. I think there can always be exceptions for any rule. I can even understand the desire to have long running branches for large scale refactors or features maintained centrally. The issue is the most of the branches are not of this exceptional scale. I want to eliminate this clutter and consider exceptions where it makes sense. Perhaps which we could ask the ASF to have its bots ignore specifically prefixed branches to future reduce the noise produced by using the Geode repo in these exceptional cases. -Jake
RE: [DISCUSSION] Stop using the Geode Repository for Feature/WIP Branches
- Unified location, where anyone who wants to work on the feature can find the feature branch on the geode-repository - Visibility, the PRs to the geode repository can be viewed by everyone in the Geode community. Which will not happen if they are raised to my fork. - Long running feature development happens in feature branches in Apache projects Eg: Lucene and Kafka. Regards Naba -Original Message- From: Jacob Barrett Sent: Tuesday, June 2, 2020 4:45 PM To: dev@geode.apache.org Subject: Re: [DISCUSSION] Stop using the Geode Repository for Feature/WIP Branches > On Jun 2, 2020, at 4:40 PM, Nabarun Nag wrote: > > I don’t think it is right to make the open source Geode Community to work on > my personal fork Why not? I can fork your fork. I can PR to your fork. Its sort of what Git was made for, no single source repository. Can you elaborate on why you feel it isn’t right? -Jake
RE: [DISCUSSION] Stop using the Geode Repository for Feature/WIP Branches
I agree, I am not justifying the use of repository for small bug fixes etc. or short term individual tasks I am justifying why PR clear has a feature branch in the geode repository. Regards Naba -Original Message- From: Jacob Barrett Sent: Tuesday, June 2, 2020 4:48 PM To: dev@geode.apache.org Subject: Re: [DISCUSSION] Stop using the Geode Repository for Feature/WIP Branches > On Jun 2, 2020, at 4:29 PM, Nabarun Nag wrote: > > - We are maintaining feature/GEODE-7665 which is the feature branch for PR > clear work on which multiple developers are working on. > - We are maintaining this in Geode repository. > - All sub-tasks of GEODE-7665 are merged into this feature branch. > - Anyone in the Geode community can work on any subtask > - This is a long running, and a massive feature development which is > manipulating core code on Apache Geode. Hence all work is pushed to the > feature branch to keep develop isolated from a regression introduced in PR > clear work. > - We have previously used release flags for Lucene work which we found to be > inefficient and unnecessary extra work. > > We vote that PR clear feature branch be maintained in the Geode Repository as > this is a long running, massive effort involving everyone from the community. > > When the PR clear tasks are completed, the branch will be rigorously tested > and then squash merged into develop and the feature branch will be deleted. I think there can always be exceptions for any rule. I can even understand the desire to have long running branches for large scale refactors or features maintained centrally. The issue is the most of the branches are not of this exceptional scale. I want to eliminate this clutter and consider exceptions where it makes sense. Perhaps which we could ask the ASF to have its bots ignore specifically prefixed branches to future reduce the noise produced by using the Geode repo in these exceptional cases. -Jake
Re: [DISCUSSION] Stop using the Geode Repository for Feature/WIP Branches
> On Jun 2, 2020, at 4:50 PM, Nabarun Nag wrote: > > - Unified location, where anyone who wants to work on the feature can find > the feature branch on the geode-repository > - Visibility, the PRs to the geode repository can be viewed by everyone in > the Geode community. Which will not happen if they are raised to my fork. > - Long running feature development happens in feature branches in Apache > projects Eg: Lucene and Kafka. > Great rational for long running feature work being centralized. While all of these can be addressed in forks by subscribing to that fork, I would be amenable to amend the proposal to allow for long running features, as defined likely by their RFC, to be conducted in the main repository.
Re: [DISCUSSION] Stop using the Geode Repository for Feature/WIP Branches
I'm a fan of features on forks! It's fairly simple to make forks accessible to other folks. I know this isn't a vote, but I'm a +1 for the concept... EB On 6/2/20, 3:42 PM, "Jacob Barrett" wrote: I know this has been brought up multiple times without resolution. I want us resolve to ban the use of Geode repository for work in progress, feature branches, or any other branches that are not release or support branches. There is no reason given the nature of GitHub why you can’t fork the repository to contribute. * Work done on these branches results in the ASF bots updating the associated JIRAs and email blasting all of us with your work. * People don’t clean up these branches, which leads to a mess of branches on everyones clones and in the UI. * All your intermediate commits get synced to the repo, which bloats the repo for everyone else. Even your commits you rebase over and force push are left in the repo. When you delete your branch these commits are not removed. There is no way for us to prune unreferenced commits. Nobody else needs your commits outside of what was merged to a production branch. If anyone has a use case for working directly from Geode repo that can’t work from a fork please post it here so we can resolve. Thanks, Jake
