DiskStoreImpl.waitForBackgroundTasks hang during Cache.close

2020-05-26 Thread Kirk Lund
We have a handful of Jira tickets filed against various off-heap tests that
are intermittently hanging in DiskStoreImpl.waitForBackgroundTasks during
Cache.close:

"Test worker" #25 prio=5 os_prio=0 tid=0x7f1a7cb13800 nid=0x5e in
Object.wait() [0x7f18ff6bd000]
   java.lang.Thread.State: TIMED_WAITING (on object monitor)
at java.lang.Object.wait(Native Method)
at 
org.apache.geode.internal.cache.DiskStoreImpl.waitForBackgroundTasks(DiskStoreImpl.java:2631)
- locked <0xfb920030> (a
java.util.concurrent.atomic.AtomicInteger)
at 
org.apache.geode.internal.cache.DiskStoreImpl.close(DiskStoreImpl.java:2387)
at 
org.apache.geode.internal.cache.DiskStoreImpl.close(DiskStoreImpl.java:2297)
at 
org.apache.geode.internal.cache.GemFireCacheImpl.closeDiskStores(GemFireCacheImpl.java:2571)
at 
org.apache.geode.internal.cache.GemFireCacheImpl.doClose(GemFireCacheImpl.java:2300)
- locked <0xd00bfd38> (a java.lang.Class for
org.apache.geode.internal.cache.GemFireCacheImpl)
at 
org.apache.geode.internal.cache.GemFireCacheImpl.close(GemFireCacheImpl.java:2119)
at 
org.apache.geode.internal.cache.GemFireCacheImpl.close(GemFireCacheImpl.java:1987)
at 
org.apache.geode.internal.cache.GemFireCacheImpl.close(GemFireCacheImpl.java:1977)
at 
org.apache.geode.internal.offheap.OffHeapRegionBase.closeCache(OffHeapRegionBase.java:106)
at 
org.apache.geode.internal.offheap.OffHeapRegionBase.testPersistentCompressorChange(OffHeapRegionBase.java:709)


Bruce did some analysis and found that the background tasks in
DiskStoreImpl is empty when the hang occurs.

1) GEODE-7524 CI failure: hang in
FreeListOffHeapRegionJUnitTest.testPersistentCompressorChange

2) GEODE-7876 OldFreeListOffHeapRegionJUnitTest
testPersistentChangeFromHeapToOffHeap

3) GEODE-8187
OldFreeListOffHeapRegionJUnitTest.testPersistentCompressorChange hangs in
DiskStoreImpl.waitForBackgroundTasks


Does anyone with deeper DiskStoreImpl knowledge want to take a look at this
hang?


[PROPOSAL] backport GEODE-8174 to 1.13 and 1.12

2020-05-26 Thread Udo Kohlmeyer
Hi there Geode Dev,

I would like to request a back port of a critical issue in the 
JCAConnectionManager. This issue manifests itself as a 
ConcurrentModificationException when trying to close a connection.

SHA: bef07b34131abddb8c0f04e0ab6a48f1daac991d

—Udo


Re: [PROPOSAL] backport GEODE-8174 to 1.13 and 1.12

2020-05-26 Thread Eric Shu
+1


From: Udo Kohlmeyer 
Sent: Tuesday, May 26, 2020 2:12 PM
To: geode 
Subject: [PROPOSAL] backport GEODE-8174 to 1.13 and 1.12

Hi there Geode Dev,

I would like to request a back port of a critical issue in the 
JCAConnectionManager. This issue manifests itself as a 
ConcurrentModificationException when trying to close a connection.

SHA: bef07b34131abddb8c0f04e0ab6a48f1daac991d

—Udo


Re: [PROPOSAL] backport GEODE-8174 to 1.13 and 1.12

2020-05-26 Thread Owen Nichols
+1

On 5/26/20, 4:04 PM, "Eric Shu"  wrote:

+1


From: Udo Kohlmeyer 
Sent: Tuesday, May 26, 2020 2:12 PM
To: geode 
Subject: [PROPOSAL] backport GEODE-8174 to 1.13 and 1.12

Hi there Geode Dev,

I would like to request a back port of a critical issue in the 
JCAConnectionManager. This issue manifests itself as a 
ConcurrentModificationException when trying to close a connection.

SHA: bef07b34131abddb8c0f04e0ab6a48f1daac991d

—Udo



RE: [PROPOSAL] backport GEODE-8174 to 1.13 and 1.12

2020-05-26 Thread Dick Cavender
+1

-Original Message-
From: Owen Nichols  
Sent: Tuesday, May 26, 2020 4:09 PM
To: dev@geode.apache.org
Subject: Re: [PROPOSAL] backport GEODE-8174 to 1.13 and 1.12

+1

On 5/26/20, 4:04 PM, "Eric Shu"  wrote:

+1


From: Udo Kohlmeyer 
Sent: Tuesday, May 26, 2020 2:12 PM
To: geode 
Subject: [PROPOSAL] backport GEODE-8174 to 1.13 and 1.12

Hi there Geode Dev,

I would like to request a back port of a critical issue in the 
JCAConnectionManager. This issue manifests itself as a 
ConcurrentModificationException when trying to close a connection.

SHA: bef07b34131abddb8c0f04e0ab6a48f1daac991d

—Udo