Re: Discussion - Change Public API Before Initial Release

2020-05-09 Thread Darrel Schneider
+1

On Fri, May 8, 2020 at 11:03 PM Dick Cavender  wrote:

> +1
>
> On Fri, May 8, 2020 at 7:59 PM Owen Nichols  wrote:
>
> > +1
> >
> > > On May 8, 2020, at 7:57 PM, Robert Houghton 
> > wrote:
> > >
> > > +1
> > >
> > > On Fri, May 8, 2020, 18:26 Jacob Barrett  wrote:
> > >
> > >> Hey Ya’ll,
> > >>
> > >> We have a new API going into 1.13 that has an inconsistency I want to
> > >> address before we are stuck with it. The class SniSocketFactory should
> > be
> > >> renamed SniProxySocketFactory. The class in question produces objects
> of
> > >> type SniProxySocket. An "SNI socket" isn’t a thing but an SNI proxy
> is a
> > >> thing. The factory class that produces proxy socket factories (yes a
> > meta
> > >> factory) ProxySocketFactories uses the “ProxySocket” name as well. It
> > fells
> > >> very inconsistent with all the other classes that make up with API for
> > >> SniSocketFactory to not have a proxy in it and be called
> > >> SniProxySocketFactory.
> > >>
> > >> To be very clear, this API has not made it out of development yet but
> is
> > >> in the 1.13 release branch. Can I get a few thumbs up to open an
> ticket
> > and
> > >> pick it into the 1.13 release branch before it goes out?
> > >>
> > >> Thanks,
> > >> Jake
> > >>
> > >>
> >
> >
>


Proposal to bring GEODE-8016 to support branches

2020-05-09 Thread Owen Nichols
Last week develop was successfully migrated from publishing -SNAPSHOT to 
publishing -build.nnn, as discussed on the dev list.

I propose that we bring the same change to support/1.13 and support/1.12 for 
consistency.  This will allow downstream projects to change over the new model 
“everywhere" rather than having to maintain support for both ways and 
constantly try to remember which branches do it which way.

The specific changes to be cherry-picked from develop are a4c8b 

 and 39c52 
.
  I have prepared PR #5089  for 
support/1.13 and PR #5090  for 
support/1.12 due to the version number differences on each branch.