[PROPOSAL] include GEODE-7796 in Release 1.12.0

2020-02-18 Thread Bruce Schuchardt
This fix addresses the inability of a Locator to properly reconnect to the 
cluster after being kicked out.  Instead of rejoining or shutting down the 
Locator gets into a state where it no longer tries to reboot location services 
and hangs.



Re: [PROPOSAL] include GEODE-7796 in Release 1.12.0

2020-02-18 Thread Owen Nichols
+1

> On Feb 18, 2020, at 12:48 PM, Bruce Schuchardt  wrote:
> 
> This fix addresses the inability of a Locator to properly reconnect to the 
> cluster after being kicked out.  Instead of rejoining or shutting down the 
> Locator gets into a state where it no longer tries to reboot location 
> services and hangs.
> 



Re: [PROPOSAL] include GEODE-7796 in Release 1.12.0

2020-02-18 Thread Robert Houghton
+1

On Tue, Feb 18, 2020, 12:49 Bruce Schuchardt  wrote:

> This fix addresses the inability of a Locator to properly reconnect to the
> cluster after being kicked out.  Instead of rejoining or shutting down the
> Locator gets into a state where it no longer tries to reboot location
> services and hangs.
>
>


Re: [PROPOSAL] include GEODE-7796 in Release 1.12.0

2020-02-18 Thread Dick Cavender
+1

On Tue, Feb 18, 2020 at 1:16 PM Robert Houghton 
wrote:

> +1
>
> On Tue, Feb 18, 2020, 12:49 Bruce Schuchardt 
> wrote:
>
> > This fix addresses the inability of a Locator to properly reconnect to
> the
> > cluster after being kicked out.  Instead of rejoining or shutting down
> the
> > Locator gets into a state where it no longer tries to reboot location
> > services and hangs.
> >
> >
>


Redis PubSubTest started failing

2020-02-18 Thread Kirk Lund
I just started seeing the Redis PubSubTest fail in IntegrationTest after
rebasing on develop this afternoon. Looks like I have Jens' latest commit
for this test:







*commit 1befce17eaae2403828769840f86639e13fce81f (origin/develop,
origin/HEAD, develop)Author: Jens Deppe >Date:   Tue Feb 18 13:03:19 2020 -0800GEODE-7798:
Fix flaky PubSub test (#4714)*

*Authored-by: Jens Deppe >> Task
:geode-redis:integrationTest*

Here's the stack traces:

org.apache.geode.redis.PubSubTest > testPatternWithoutAGlob FAILED
redis.clients.jedis.exceptions.JedisConnectionException:
java.net.SocketTimeoutException: Read timed out
at
redis.clients.util.RedisInputStream.ensureFill(RedisInputStream.java:202)
at
redis.clients.util.RedisInputStream.readByte(RedisInputStream.java:40)
at redis.clients.jedis.Protocol.process(Protocol.java:151)
at redis.clients.jedis.Protocol.read(Protocol.java:215)
at
redis.clients.jedis.Connection.readProtocolWithCheckingBroken(Connection.java:340)
at
redis.clients.jedis.Connection.getIntegerReply(Connection.java:265)
at redis.clients.jedis.Jedis.publish(Jedis.java:2690)
at
org.apache.geode.redis.PubSubTest.testPatternWithoutAGlob(PubSubTest.java:279)

Caused by:
java.net.SocketTimeoutException: Read timed out
at java.net.SocketInputStream.socketRead0(Native Method)
at
java.net.SocketInputStream.socketRead(SocketInputStream.java:115)
at java.net.SocketInputStream.read(SocketInputStream.java:168)
at java.net.SocketInputStream.read(SocketInputStream.java:140)
at java.net.SocketInputStream.read(SocketInputStream.java:126)
at
redis.clients.util.RedisInputStream.ensureFill(RedisInputStream.java:196)
... 7 more

org.apache.geode.redis.PubSubTest > testTwoSubscribersOneChannel FAILED
org.awaitility.core.ConditionTimeoutException: Condition with lambda
expression in org.apache.geode.redis.PubSubTest that uses
org.apache.geode.redis.mocks.MockSubscriber was not fulfilled within 1
seconds.
at
org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:145)
at
org.awaitility.core.CallableCondition.await(CallableCondition.java:79)
at
org.awaitility.core.CallableCondition.await(CallableCondition.java:27)
at
org.awaitility.core.ConditionFactory.until(ConditionFactory.java:902)
at
org.awaitility.core.ConditionFactory.until(ConditionFactory.java:860)
at org.apache.geode.redis.PubSubTest.waitFor(PubSubTest.java:296)
at
org.apache.geode.redis.PubSubTest.testTwoSubscribersOneChannel(PubSubTest.java:140)

org.apache.geode.redis.PubSubTest >
testOneSubscriberSubscribingToTwoChannels FAILED
org.awaitility.core.ConditionTimeoutException: Condition with lambda
expression in org.apache.geode.redis.PubSubTest that uses
org.apache.geode.redis.mocks.MockSubscriber was not fulfilled within 1
seconds.
at
org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:145)
at
org.awaitility.core.CallableCondition.await(CallableCondition.java:79)
at
org.awaitility.core.CallableCondition.await(CallableCondition.java:27)
at
org.awaitility.core.ConditionFactory.until(ConditionFactory.java:902)
at
org.awaitility.core.ConditionFactory.until(ConditionFactory.java:860)
at org.apache.geode.redis.PubSubTest.waitFor(PubSubTest.java:296)
at
org.apache.geode.redis.PubSubTest.testOneSubscriberSubscribingToTwoChannels(PubSubTest.java:110)

org.apache.geode.redis.PubSubTest > testPatternAndRegularSubscribe FAILED
org.awaitility.core.ConditionTimeoutException: Condition with lambda
expression in org.apache.geode.redis.PubSubTest that uses
org.apache.geode.redis.mocks.MockSubscriber was not fulfilled within 1
seconds.
at
org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:145)
at
org.awaitility.core.CallableCondition.await(CallableCondition.java:79)
at
org.awaitility.core.CallableCondition.await(CallableCondition.java:27)
at
org.awaitility.core.ConditionFactory.until(ConditionFactory.java:902)
at
org.awaitility.core.ConditionFactory.until(ConditionFactory.java:860)
at org.apache.geode.redis.PubSubTest.waitFor(PubSubTest.java:296)
at
org.apache.geode.redis.PubSubTest.testPatternAndRegularSubscribe(PubSubTest.java:245)

org.apache.geode.redis.PubSubTest > testDeadSubscriber FAILED
org.junit.ComparisonFailure: expected:<[0]L> but was:<[2]L>
at
jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native
Method)
at
jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
at
jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at
org.apache.geode.redis.PubSubTest.testDeadSubscriber(PubSubTest.java:207)

org.apache.geode.redis.PubSubT

Re: [PROPOSAL] include GEODE-7796 in Release 1.12.0

2020-02-18 Thread Ernest Burghardt
There appears to be consensus that this is a critical fix.

The following commit has been brought into release/1.12.0 as the
critical fix for GEODE-7796:

git cherry-pick -x 71fafc83844d3c13a228c705d32df374e5630651

GEODE-7796 has been marked as 'resolved in' 1.12.0.

Regards
EB


On Tue, Feb 18, 2020 at 2:50 PM Dick Cavender  wrote:

> +1
>
> On Tue, Feb 18, 2020 at 1:16 PM Robert Houghton 
> wrote:
>
> > +1
> >
> > On Tue, Feb 18, 2020, 12:49 Bruce Schuchardt 
> > wrote:
> >
> > > This fix addresses the inability of a Locator to properly reconnect to
> > the
> > > cluster after being kicked out.  Instead of rejoining or shutting down
> > the
> > > Locator gets into a state where it no longer tries to reboot location
> > > services and hangs.
> > >
> > >
> >
>


[GitHub] [geode-kafka-connector] nabarunnag opened a new pull request #1: Feature/restructuring

2020-02-18 Thread GitBox
nabarunnag opened a new pull request #1: Feature/restructuring
URL: https://github.com/apache/geode-kafka-connector/pull/1
 
 
   Cosmetic modification and new test runner for writing tests 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [geode-kafka-connector] nabarunnag merged pull request #1: Feature/restructuring

2020-02-18 Thread GitBox
nabarunnag merged pull request #1: Feature/restructuring
URL: https://github.com/apache/geode-kafka-connector/pull/1
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services