Re: Propose including GEODE-7178 in 1.10
+1, IMO this really needs to go in. Thanks, Blake On Thu, Sep 12, 2019 at 3:30 PM Anthony Baker wrote: > My understanding is that this portion of the protocol is determined by > instanceof checks, not the ordinal version. The messages from the java > client went through a different code path than messages from the native > client. So java clients using ordinal 45 still work (that’s why our > backwards compatibility tests don’t fail). > > Anthony > > > > On Sep 12, 2019, at 2:34 PM, Dan Smith wrote: > > > > +1 for getting this in 1.10. > > > > I am curious though - is the native client behaving like an older > versions > > of the java client, or is this totally unique behavior for the native > > client? Is there some integration test that we are missing here? > > > > -Dan > > > > On Thu, Sep 12, 2019 at 11:52 AM Michael Oleske > wrote: > > > >> Here is the Pull Request for the cherry pick as requested > >> https://github.com/apache/geode/pull/4049 > >> > >> -michael > >> > >> On Thu, Sep 12, 2019 at 10:28 AM Dick Cavender > >> wrote: > >> > >>> Hi Michael, thank you for bringing your concern and fixing this issue. > >>> > >>> Geode's release process dictates a time-based schedule < > >>> https://cwiki.apache.org/confluence/display/GEODE/Release+Schedule> to > >> cut > >>> release branches. The “critical fixes” rule does allow critical fixes > to > >>> be brought to the release branch by proposal on the dev list, as you > have > >>> done here. > >>> > >>> If there is consensus from the Geode community that your proposed > change > >>> satisfies the “critical fixes” rule, I will be happy to bring it to the > >>> 1.10.0 release branch. > >>> > >>> Due to the complexity of this change, could please open a PR against > >>> release/1.10.0 containing the exact changes you want to merge? > >>> > >>> Regards > >>> > >>> -Dick > >>> > >>> > >>> On Thu, Sep 12, 2019 at 10:23 AM Anthony Baker > >> wrote: > >>> > +1 yes please! > > > On Sep 12, 2019, at 10:11 AM, Michael Oleske > >>> wrote: > > > > Hi Geode Devs! > > > > I'd like to propose including the fix for GEODE-7178. This resolves > >> an > > issue that Ivan (https://markmail.org/message/dwwac42xmpo4xb2e) ran > into in > > 1.10 RC1. > > > > SHA: 91176d61df64bf1390cdba7b1cdc2b40cdfaba3a > > Link to GitHub: > > > > >>> > >> > https://github.com/apache/geode/commit/91176d61df64bf1390cdba7b1cdc2b40cdfaba3a > > > > Thanks! > > -michael > > > >>> > >> > >
Re: Propose including GEODE-7178 in 1.10
We have 3 plus one votes so we'll merge this as soon as the PR checks complete. -Dick On Fri, Sep 13, 2019 at 10:25 AM Blake Bender wrote: > +1, IMO this really needs to go in. > > Thanks, > > Blake > > > On Thu, Sep 12, 2019 at 3:30 PM Anthony Baker wrote: > > > My understanding is that this portion of the protocol is determined by > > instanceof checks, not the ordinal version. The messages from the java > > client went through a different code path than messages from the native > > client. So java clients using ordinal 45 still work (that’s why our > > backwards compatibility tests don’t fail). > > > > Anthony > > > > > > > On Sep 12, 2019, at 2:34 PM, Dan Smith wrote: > > > > > > +1 for getting this in 1.10. > > > > > > I am curious though - is the native client behaving like an older > > versions > > > of the java client, or is this totally unique behavior for the native > > > client? Is there some integration test that we are missing here? > > > > > > -Dan > > > > > > On Thu, Sep 12, 2019 at 11:52 AM Michael Oleske > > wrote: > > > > > >> Here is the Pull Request for the cherry pick as requested > > >> https://github.com/apache/geode/pull/4049 > > >> > > >> -michael > > >> > > >> On Thu, Sep 12, 2019 at 10:28 AM Dick Cavender > > >> wrote: > > >> > > >>> Hi Michael, thank you for bringing your concern and fixing this > issue. > > >>> > > >>> Geode's release process dictates a time-based schedule < > > >>> https://cwiki.apache.org/confluence/display/GEODE/Release+Schedule> > to > > >> cut > > >>> release branches. The “critical fixes” rule does allow critical > fixes > > to > > >>> be brought to the release branch by proposal on the dev list, as you > > have > > >>> done here. > > >>> > > >>> If there is consensus from the Geode community that your proposed > > change > > >>> satisfies the “critical fixes” rule, I will be happy to bring it to > the > > >>> 1.10.0 release branch. > > >>> > > >>> Due to the complexity of this change, could please open a PR against > > >>> release/1.10.0 containing the exact changes you want to merge? > > >>> > > >>> Regards > > >>> > > >>> -Dick > > >>> > > >>> > > >>> On Thu, Sep 12, 2019 at 10:23 AM Anthony Baker > > >> wrote: > > >>> > > +1 yes please! > > > > > On Sep 12, 2019, at 10:11 AM, Michael Oleske > > >>> wrote: > > > > > > Hi Geode Devs! > > > > > > I'd like to propose including the fix for GEODE-7178. This > resolves > > >> an > > > issue that Ivan (https://markmail.org/message/dwwac42xmpo4xb2e) > ran > > into in > > > 1.10 RC1. > > > > > > SHA: 91176d61df64bf1390cdba7b1cdc2b40cdfaba3a > > > Link to GitHub: > > > > > > > >>> > > >> > > > https://github.com/apache/geode/commit/91176d61df64bf1390cdba7b1cdc2b40cdfaba3a > > > > > > Thanks! > > > -michael > > > > > > >>> > > >> > > > > >
[VOTE] Adding new AEQ feature to release/1.10.0
Hi Geode Community , [GEODE-7121] I would like to include the new feature of creating AEQs with a paused event processor to the release 1.10 branch. This also includes the feature to resume the AEQ at a later point in time. This feature includes addition of new/modified APIs and gfsh commands. [All details about this feature has been discussed in a previous discuss thread] These are the commits that needs to be in release 1.10.0 branch. f6e11084daa30791f7bbf9a8187f6d1bc9c4b91a 615d3399d24810126a6d57b5163f7afcd06366f7 1440a95e266e671679a623f93865c5e7e683244f 42e07dc9054794657acb40c292f3af74b79a1ea6 e1f200e2f9e77e986d250fde3848dc004b26a7c2 5f70160fba08a06c7e1fc48c7099e63dd1a0502b 0645446ec626bc351a2c881e4df6a4ae2e75fbfc 575c6bac115112df1e84455b052566c75764b0be 3d9627ff16443f4aa513a67bcc284e68953aff8a ea22e72916f8e34455800d347690e483727f9bf5 8d26d595f5fb94ff703116eb91bb747e9ba7f536 Will create a PR ASAP. Regards Nabarun Nag
Re: [VOTE] Adding new AEQ feature to release/1.10.0
+1. This is needed for spring data-geode; whose upcoming release is based on older geode version. -Anil. On Fri, Sep 13, 2019 at 3:23 PM Nabarun Nag wrote: > Hi Geode Community , > > [GEODE-7121] > > I would like to include the new feature of creating AEQs with a paused > event processor to the release 1.10 branch. This also includes the feature > to resume the AEQ at a later point in time. > This feature includes addition of new/modified APIs and gfsh commands. > > [All details about this feature has been discussed in a previous discuss > thread] > > These are the commits that needs to be in release 1.10.0 branch. > f6e11084daa30791f7bbf9a8187f6d1bc9c4b91a > 615d3399d24810126a6d57b5163f7afcd06366f7 > 1440a95e266e671679a623f93865c5e7e683244f > 42e07dc9054794657acb40c292f3af74b79a1ea6 > e1f200e2f9e77e986d250fde3848dc004b26a7c2 > 5f70160fba08a06c7e1fc48c7099e63dd1a0502b > 0645446ec626bc351a2c881e4df6a4ae2e75fbfc > 575c6bac115112df1e84455b052566c75764b0be > 3d9627ff16443f4aa513a67bcc284e68953aff8a > ea22e72916f8e34455800d347690e483727f9bf5 > 8d26d595f5fb94ff703116eb91bb747e9ba7f536 > > Will create a PR ASAP. > > Regards > Nabarun Nag >
Re: [VOTE] Adding new AEQ feature to release/1.10.0
+1 On Fri, Sep 13, 2019 at 3:23 PM Nabarun Nag wrote: > Hi Geode Community , > > [GEODE-7121] > > I would like to include the new feature of creating AEQs with a paused > event processor to the release 1.10 branch. This also includes the feature > to resume the AEQ at a later point in time. > This feature includes addition of new/modified APIs and gfsh commands. > > [All details about this feature has been discussed in a previous discuss > thread] > > These are the commits that needs to be in release 1.10.0 branch. > f6e11084daa30791f7bbf9a8187f6d1bc9c4b91a > 615d3399d24810126a6d57b5163f7afcd06366f7 > 1440a95e266e671679a623f93865c5e7e683244f > 42e07dc9054794657acb40c292f3af74b79a1ea6 > e1f200e2f9e77e986d250fde3848dc004b26a7c2 > 5f70160fba08a06c7e1fc48c7099e63dd1a0502b > 0645446ec626bc351a2c881e4df6a4ae2e75fbfc > 575c6bac115112df1e84455b052566c75764b0be > 3d9627ff16443f4aa513a67bcc284e68953aff8a > ea22e72916f8e34455800d347690e483727f9bf5 > 8d26d595f5fb94ff703116eb91bb747e9ba7f536 > > Will create a PR ASAP. > > Regards > Nabarun Nag >
Re: [VOTE] Adding new AEQ feature to release/1.10.0
+1 On Fri, Sep 13, 2019 at 3:25 PM Anilkumar Gingade wrote: > +1. This is needed for spring data-geode; whose upcoming release is based > on older geode version. > > -Anil. > > > On Fri, Sep 13, 2019 at 3:23 PM Nabarun Nag wrote: > > > Hi Geode Community , > > > > [GEODE-7121] > > > > I would like to include the new feature of creating AEQs with a paused > > event processor to the release 1.10 branch. This also includes the > feature > > to resume the AEQ at a later point in time. > > This feature includes addition of new/modified APIs and gfsh commands. > > > > [All details about this feature has been discussed in a previous discuss > > thread] > > > > These are the commits that needs to be in release 1.10.0 branch. > > f6e11084daa30791f7bbf9a8187f6d1bc9c4b91a > > 615d3399d24810126a6d57b5163f7afcd06366f7 > > 1440a95e266e671679a623f93865c5e7e683244f > > 42e07dc9054794657acb40c292f3af74b79a1ea6 > > e1f200e2f9e77e986d250fde3848dc004b26a7c2 > > 5f70160fba08a06c7e1fc48c7099e63dd1a0502b > > 0645446ec626bc351a2c881e4df6a4ae2e75fbfc > > 575c6bac115112df1e84455b052566c75764b0be > > 3d9627ff16443f4aa513a67bcc284e68953aff8a > > ea22e72916f8e34455800d347690e483727f9bf5 > > 8d26d595f5fb94ff703116eb91bb747e9ba7f536 > > > > Will create a PR ASAP. > > > > Regards > > Nabarun Nag > > >
Re: Propose including GEODE-7178 in 1.10
This has been merged to release/1.10.0. On Fri, Sep 13, 2019 at 11:14 AM Dick Cavender wrote: > We have 3 plus one votes so we'll merge this as soon as the PR checks > complete. > > -Dick > > > On Fri, Sep 13, 2019 at 10:25 AM Blake Bender wrote: > >> +1, IMO this really needs to go in. >> >> Thanks, >> >> Blake >> >> >> On Thu, Sep 12, 2019 at 3:30 PM Anthony Baker wrote: >> >> > My understanding is that this portion of the protocol is determined by >> > instanceof checks, not the ordinal version. The messages from the java >> > client went through a different code path than messages from the native >> > client. So java clients using ordinal 45 still work (that’s why our >> > backwards compatibility tests don’t fail). >> > >> > Anthony >> > >> > >> > > On Sep 12, 2019, at 2:34 PM, Dan Smith wrote: >> > > >> > > +1 for getting this in 1.10. >> > > >> > > I am curious though - is the native client behaving like an older >> > versions >> > > of the java client, or is this totally unique behavior for the native >> > > client? Is there some integration test that we are missing here? >> > > >> > > -Dan >> > > >> > > On Thu, Sep 12, 2019 at 11:52 AM Michael Oleske >> > wrote: >> > > >> > >> Here is the Pull Request for the cherry pick as requested >> > >> https://github.com/apache/geode/pull/4049 >> > >> >> > >> -michael >> > >> >> > >> On Thu, Sep 12, 2019 at 10:28 AM Dick Cavender > > >> > >> wrote: >> > >> >> > >>> Hi Michael, thank you for bringing your concern and fixing this >> issue. >> > >>> >> > >>> Geode's release process dictates a time-based schedule < >> > >>> https://cwiki.apache.org/confluence/display/GEODE/Release+Schedule> >> to >> > >> cut >> > >>> release branches. The “critical fixes” rule does allow critical >> fixes >> > to >> > >>> be brought to the release branch by proposal on the dev list, as you >> > have >> > >>> done here. >> > >>> >> > >>> If there is consensus from the Geode community that your proposed >> > change >> > >>> satisfies the “critical fixes” rule, I will be happy to bring it to >> the >> > >>> 1.10.0 release branch. >> > >>> >> > >>> Due to the complexity of this change, could please open a PR against >> > >>> release/1.10.0 containing the exact changes you want to merge? >> > >>> >> > >>> Regards >> > >>> >> > >>> -Dick >> > >>> >> > >>> >> > >>> On Thu, Sep 12, 2019 at 10:23 AM Anthony Baker >> > >> wrote: >> > >>> >> > +1 yes please! >> > >> > > On Sep 12, 2019, at 10:11 AM, Michael Oleske >> > >>> wrote: >> > > >> > > Hi Geode Devs! >> > > >> > > I'd like to propose including the fix for GEODE-7178. This >> resolves >> > >> an >> > > issue that Ivan (https://markmail.org/message/dwwac42xmpo4xb2e) >> ran >> > into in >> > > 1.10 RC1. >> > > >> > > SHA: 91176d61df64bf1390cdba7b1cdc2b40cdfaba3a >> > > Link to GitHub: >> > > >> > >> > >>> >> > >> >> > >> https://github.com/apache/geode/commit/91176d61df64bf1390cdba7b1cdc2b40cdfaba3a >> > > >> > > Thanks! >> > > -michael >> > >> > >> > >>> >> > >> >> > >> > >> >
Re: [VOTE] Adding new AEQ feature to release/1.10.0
+1 On Fri, Sep 13, 2019 at 3:37 PM Benjamin Ross wrote: > +1 > > On Fri, Sep 13, 2019 at 3:25 PM Anilkumar Gingade > wrote: > > > +1. This is needed for spring data-geode; whose upcoming release is based > > on older geode version. > > > > -Anil. > > > > > > On Fri, Sep 13, 2019 at 3:23 PM Nabarun Nag wrote: > > > > > Hi Geode Community , > > > > > > [GEODE-7121] > > > > > > I would like to include the new feature of creating AEQs with a paused > > > event processor to the release 1.10 branch. This also includes the > > feature > > > to resume the AEQ at a later point in time. > > > This feature includes addition of new/modified APIs and gfsh commands. > > > > > > [All details about this feature has been discussed in a previous > discuss > > > thread] > > > > > > These are the commits that needs to be in release 1.10.0 branch. > > > f6e11084daa30791f7bbf9a8187f6d1bc9c4b91a > > > 615d3399d24810126a6d57b5163f7afcd06366f7 > > > 1440a95e266e671679a623f93865c5e7e683244f > > > 42e07dc9054794657acb40c292f3af74b79a1ea6 > > > e1f200e2f9e77e986d250fde3848dc004b26a7c2 > > > 5f70160fba08a06c7e1fc48c7099e63dd1a0502b > > > 0645446ec626bc351a2c881e4df6a4ae2e75fbfc > > > 575c6bac115112df1e84455b052566c75764b0be > > > 3d9627ff16443f4aa513a67bcc284e68953aff8a > > > ea22e72916f8e34455800d347690e483727f9bf5 > > > 8d26d595f5fb94ff703116eb91bb747e9ba7f536 > > > > > > Will create a PR ASAP. > > > > > > Regards > > > Nabarun Nag > > > > > >
Re: [VOTE] Adding new AEQ feature to release/1.10.0
+1 On Fri, Sep 13, 2019 at 3:58 PM Donal Evans wrote: > +1 > > On Fri, Sep 13, 2019 at 3:37 PM Benjamin Ross wrote: > > > +1 > > > > On Fri, Sep 13, 2019 at 3:25 PM Anilkumar Gingade > > wrote: > > > > > +1. This is needed for spring data-geode; whose upcoming release is > based > > > on older geode version. > > > > > > -Anil. > > > > > > > > > On Fri, Sep 13, 2019 at 3:23 PM Nabarun Nag wrote: > > > > > > > Hi Geode Community , > > > > > > > > [GEODE-7121] > > > > > > > > I would like to include the new feature of creating AEQs with a > paused > > > > event processor to the release 1.10 branch. This also includes the > > > feature > > > > to resume the AEQ at a later point in time. > > > > This feature includes addition of new/modified APIs and gfsh > commands. > > > > > > > > [All details about this feature has been discussed in a previous > > discuss > > > > thread] > > > > > > > > These are the commits that needs to be in release 1.10.0 branch. > > > > f6e11084daa30791f7bbf9a8187f6d1bc9c4b91a > > > > 615d3399d24810126a6d57b5163f7afcd06366f7 > > > > 1440a95e266e671679a623f93865c5e7e683244f > > > > 42e07dc9054794657acb40c292f3af74b79a1ea6 > > > > e1f200e2f9e77e986d250fde3848dc004b26a7c2 > > > > 5f70160fba08a06c7e1fc48c7099e63dd1a0502b > > > > 0645446ec626bc351a2c881e4df6a4ae2e75fbfc > > > > 575c6bac115112df1e84455b052566c75764b0be > > > > 3d9627ff16443f4aa513a67bcc284e68953aff8a > > > > ea22e72916f8e34455800d347690e483727f9bf5 > > > > 8d26d595f5fb94ff703116eb91bb747e9ba7f536 > > > > > > > > Will create a PR ASAP. > > > > > > > > Regards > > > > Nabarun Nag > > > > > > > > > >
