Build failed in Jenkins: Geode-release #94

2017-10-19 Thread Apache Jenkins Server 
See 


Changes:

[jstewart] GEODE-3859: Simplify API for reading output from a GfshScript

--
[...truncated 169.33 KB...]
:geode-common:build
:geode-common:distributedTest
:geode-common:integrationTest
:geode-concurrency-test:jar
:geode-concurrency-test:javadoc
:geode-concurrency-test:javadocJar
:geode-concurrency-test:sourcesJar
:geode-concurrency-test:signArchives SKIPPED
:geode-concurrency-test:assemble
:geode-concurrency-test:generateJpfProperties
:geode-concurrency-test:compileTestJava NO-SOURCE
:geode-concurrency-test:processTestResources NO-SOURCE
:geode-concurrency-test:testClasses UP-TO-DATE
:geode-concurrency-test:checkMissedTests NO-SOURCE
:geode-concurrency-test:spotlessJavaCheck
:geode-concurrency-test:spotlessCheck
:geode-concurrency-test:test NO-SOURCE
:geode-concurrency-test:check
:geode-concurrency-test:build
:geode-concurrency-test:distributedTest NO-SOURCE
:geode-concurrency-test:integrationTest NO-SOURCE
:geode-core:assemble
:geode-core:checkMissedTests
:geode-core:spotlessJavaCheck
:geode-core:spotlessCheck
:geode-core:test
:geode-core:check
:geode-core:build
:geode-core:distributedTest
:geode-core:integrationTest
:geode-cq:assemble
:geode-cq:compileTestJavaNote: Some input files use or override a deprecated 
API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-cq:processTestResources
:geode-cq:testClasses
:geode-cq:checkMissedTests
:geode-cq:spotlessJavaCheck
:geode-cq:spotlessCheck
:geode-cq:test
:geode-cq:check
:geode-cq:build
:geode-cq:distributedTest
:geode-cq:integrationTest
:geode-json:assemble
:geode-json:compileTestJava NO-SOURCE
:geode-json:processTestResources
:geode-json:testClasses
:geode-json:checkMissedTests NO-SOURCE
:geode-json:spotlessJavaCheck
:geode-json:spotlessCheck
:geode-json:test NO-SOURCE
:geode-json:check
:geode-json:build
:geode-json:distributedTest NO-SOURCE
:geode-json:integrationTest NO-SOURCE
:geode-junit:javadoc
:geode-junit:javadocJar
:geode-junit:sourcesJar
:geode-junit:signArchives SKIPPED
:geode-junit:assemble
:geode-junit:compileTestJavaNote: 

 uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: 

 uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-junit:processTestResources
:geode-junit:testClasses
:geode-junit:checkMissedTests
:geode-junit:spotlessJavaCheck
:geode-junit:spotlessCheck
:geode-junit:test
:geode-junit:check
:geode-junit:build
:geode-junit:distributedTest
:geode-junit:integrationTest
:geode-lucene:assemble
:geode-lucene:compileTestJava
Download 
https://repo1.maven.org/maven2/org/apache/lucene/lucene-test-framework/6.4.1/lucene-test-framework-6.4.1.pom
Download 
https://repo1.maven.org/maven2/org/apache/lucene/lucene-codecs/6.4.1/lucene-codecs-6.4.1.pom
Download 
https://repo1.maven.org/maven2/com/carrotsearch/randomizedtesting/randomizedtesting-runner/2.4.0/randomizedtesting-runner-2.4.0.pom
Download 
https://repo1.maven.org/maven2/com/carrotsearch/randomizedtesting/randomizedtesting-parent/2.4.0/randomizedtesting-parent-2.4.0.pom
Download 
https://repo1.maven.org/maven2/org/apache/lucene/lucene-test-framework/6.4.1/lucene-test-framework-6.4.1.jar
Download 
https://repo1.maven.org/maven2/org/apache/lucene/lucene-codecs/6.4.1/lucene-codecs-6.4.1.jar
Download 
https://repo1.maven.org/maven2/com/carrotsearch/randomizedtesting/randomizedtesting-runner/2.4.0/randomizedtesting-runner-2.4.0.jar
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
:geode-lucene:processTestResources
:geode-lucene:testClasses
:geode-lucene:checkMissedTests
:geode-lucene:spotlessJavaCheck
:geode-lucene:spotlessCheck
:geode-lucene:test
:geode-lucene:check
:geode-lucene:build
:geode-lucene:distributedTest
:geode-lucene:integrationTest
:geode-old-client-support:assemble
:geode-old-client-support:compileTestJavaNote: 

 uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.

:geode-old-client-support:processTestResources NO-SOURCE
:geode-old-client-support:testClasses
:geode-old-client-support:checkMissedTests
:geode-old-client-support:spotlessJavaCheck
:geode-old-client-support:spotlessCheck
:geode-old-client-support:test
:geode-old-client-supp

Build failed in Jenkins: Geode-nightly #989

2017-10-19 Thread Apache Jenkins Server 
See 


Changes:

[github] GEODE-2563: fix flaky test (#942)

[github] GEODE-3819: correctly set the result status code when building the re…

[khowe] GEODE-3299: refactor functions to get Cache from FunctionContext

[khowe] GEODE-3299: Remove unneeded constructor

[dbarnes] GEODE-2405 Update docs with changes to export cluster-configuration

[bschuchardt] GEODE-3841 CI Failure :

[dsmith] Parameterizing LuceneSerializer with a type

[gosullivan] GEODE-3614 remove JUnit3CacheTestCase, cleanup JUnit4CacheTestCase

[nabarunnag] GEODE-3708: Added a separate iterator for MemoryIndexStore which 
doesn't

[github] GEODE-3857: Pulse login fails after second login (#939)

[github] GEODE-3538 Update doc section Running Geode Server Processes (#945)

[github] GEODE-3701 Emphasize performance penalty of hash indexes in docs (#949)

[github] GEODE-3026: Removed the AsyncEventQueue for the Lucene index if the

--
[...truncated 1.72 MB...]
at 
io.netty.channel.epoll.EpollEventLoop.processReady(EpollEventLoop.java:386)
at io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:302)
at 
io.netty.util.concurrent.SingleThreadEventExecutor$5.run(SingleThreadEventExecutor.java:877)
at 
io.netty.util.concurrent.DefaultThreadFactory$DefaultRunnableDecorator.run(DefaultThreadFactory.java:144)
at java.lang.Thread.run(Thread.java:748)
Error during callback
com.github.dockerjava.api.exception.NotFoundException: {"message":"No such 
image: apachegeode/geode-build:latest"}

at 
com.github.dockerjava.netty.handler.HttpResponseHandler.channelRead0(HttpResponseHandler.java:103)
at 
com.github.dockerjava.netty.handler.HttpResponseHandler.channelRead0(HttpResponseHandler.java:33)
at 
io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:105)
at 
io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:372)
at 
io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:358)
at 
io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:350)
at 
io.netty.handler.logging.LoggingHandler.channelRead(LoggingHandler.java:233)
at 
io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:372)
at 
io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:358)
at 
io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:350)
at 
io.netty.channel.CombinedChannelDuplexHandler$DelegatingChannelHandlerContext.fireChannelRead(CombinedChannelDuplexHandler.java:435)
at 
io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:293)
at 
io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:267)
at 
io.netty.channel.CombinedChannelDuplexHandler.channelRead(CombinedChannelDuplexHandler.java:250)
at 
io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:372)
at 
io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:358)
at 
io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:350)
at 
io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1334)
at 
io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:372)
at 
io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:358)
at 
io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:926)
at 
io.netty.channel.epoll.AbstractEpollStreamChannel$EpollStreamUnsafe.epollInReady(AbstractEpollStreamChannel.java:961)
at 
io.netty.channel.epoll.EpollDomainSocketChannel$EpollDomainUnsafe.epollInReady(EpollDomainSocketChannel.java:140)
at 
io.netty.channel.epoll.EpollEventLoop.processReady(EpollEventLoop.java:386)
at io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:302)
at 
io.netty.util.concurrent.SingleThreadEventExecutor$5.run(SingleThreadEventExecutor.java:877)
at 
io.netty.util.concurrent.DefaultThreadFactory$DefaultRunnableDecorator.run(DefaultThreadFactory.java:144)
at java.lang.Thread.run(Thread.java:748)
com.github.dockerjava.api.exception.NotFoundException: {"message":"No such 
image: apachegeode/geode-build:latest"}

at 
com.github.dockerjava.netty.handler.HttpResponseHandler.channelRead0(HttpResponseHandler.java:103)
at 
com.github.dockerjava.netty.handler.HttpResponseHandler.channelRe

Re: [VOTE] Apache Geode release - 1.3.0 RC3

2017-10-19 Thread Dan Smith 
+1

Build passed, release check passed, examples are present, I don't see us
shipping jars we shouldn't. Looks good to me!

BTW, even though the actual build passed, the jenkins job failed with the
below error about archiving results. Who has access to fix this?

BUILD SUCCESSFUL
>
> Total time: 15 hrs 58 mins 25.622 secs
> Build step 'Invoke Gradle script' changed build result to SUCCESS
> Archiving artifacts
> [Fast Archiver] Compressed 225.42 MB of artifacts by 16.4% relative to #90
> Recording test results
> ERROR: Step ?Publish JUnit test result report? failed: No test report
> files were found. Configuration error?
>

-Dan

On Wed, Oct 18, 2017 at 1:51 PM, Swapnil Bawaskar 
wrote:

> This is the third release candidate for Apache Geode, version 1.3.0.
> Thanks to all the community members for their contributions to this
> release!
>
> *** Please download, test and vote by Monday, October 23, 0800 hrs
> US Pacific. ***
>
> It fixes 376 issues. release notes can be found at:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> projectId=12318420&version=12340669
>
> Note that we are voting upon the source tags:  rel/v1.3.0.RC3
> https://github.com/apache/geode/tree/rel/v1.3.0.RC3
> https://github.com/apache/geode-examples/tree/rel/v1.3.0.RC3
>
> Commit ID:
> 9e076738fc2ae40f95bd179b5c1624e664a28d61 (geode)
> 4ff8f8eafd0927888e711ee45d283ab07d345000   (geode-examples)
>
> Source and binary files:
>  https://dist.apache.org/repos/dist/dev/geode/1.3.0.RC3
>
> Maven staging repo:
> https://repository.apache.org/content/repositories/orgapachegeode-1034
>
>
> Geode's KEYS file containing PGP keys we use to sign the release:
>  https://github.com/apache/geode/blob/develop/KEYS
>
> Release Signed with Key: pub 4096R/18F902DB 2016-04-07
> Fingerprint: E1B1 ABE3 4753 E7BA 8097 4285 8F8F 2BCC 18F9 02DB
>

Build failed in Jenkins: Geode-nightly-flaky #154

2017-10-19 Thread Apache Jenkins Server 
See 

--
[...truncated 110.60 KB...]
Download 
https://repo1.maven.org/maven2/io/swagger/swagger-annotations/1.5.10/swagger-annotations-1.5.10.jar
Download 
https://repo1.maven.org/maven2/io/swagger/swagger-models/1.5.10/swagger-models-1.5.10.jar
Download 
https://repo1.maven.org/maven2/io/springfox/springfox-spi/2.6.1/springfox-spi-2.6.1.jar
Download 
https://repo1.maven.org/maven2/io/springfox/springfox-schema/2.6.1/springfox-schema-2.6.1.jar
Download 
https://repo1.maven.org/maven2/io/springfox/springfox-swagger-common/2.6.1/springfox-swagger-common-2.6.1.jar
Download 
https://repo1.maven.org/maven2/io/springfox/springfox-spring-web/2.6.1/springfox-spring-web-2.6.1.jar
Download 
https://repo1.maven.org/maven2/org/springframework/plugin/spring-plugin-core/1.2.0.RELEASE/spring-plugin-core-1.2.0.RELEASE.jar
Download 
https://repo1.maven.org/maven2/org/springframework/plugin/spring-plugin-metadata/1.2.0.RELEASE/spring-plugin-metadata-1.2.0.RELEASE.jar
Download 
https://repo1.maven.org/maven2/org/mapstruct/mapstruct/1.0.0.Final/mapstruct-1.0.0.Final.jar
Download 
https://repo1.maven.org/maven2/io/springfox/springfox-core/2.6.1/springfox-core-2.6.1.jar
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
:geode-web-api:processResources
:geode-web-api:classes
:geode-assembly:docs:44:
 warning - Tag @link: reference not found: Field.Store#NO
:44:
 warning - Tag @link: reference not found: Field.Store#NO
:44:
 warning - Tag @link: reference not found: Field.Store#NO

3 warnings
:geode-assembly:gfshDepsJar
:geode-common:javadocJar
:geode-common:sourcesJar
:geode-common:signArchives SKIPPED
:geode-core:javadocJar
:geode-core:raJar
:geode-core:jcaJar
:geode-core:sourcesJar
:geode-core:signArchives SKIPPED
:geode-core:webJar
:geode-cq:jar
:geode-cq:javadoc
:geode-cq:javadocJar
:geode-cq:sourcesJar
:geode-cq:signArchives SKIPPED
:geode-json:javadocJar
:geode-json:sourcesJar
:geode-json:signArchives SKIPPED
:geode-lucene:jar
:geode-lucene:javadoc:44:
 warning - Tag @link: reference not found: Field.Store#NO
:44:
 warning - Tag @link: reference not found: Field.Store#NO
:44:
 warning - Tag @link: reference not found: Field.Store#NO
:44:
 warning - Tag @link: reference not found: Field.Store#NO
:44:
 warning - Tag @link: reference not found: Field.Store#NO
:44:
 warning - Tag @link: reference not found: Field.Store#NO
:44:
 warning - Tag @link: reference not found: Field.Store#NO

7 warnings
:geode-lucene:javadocJar
:geode-lucene:sourcesJar
:geode-lucene:signArchives SKIPPED
:geode-old-client-support:jar
:geode-old-client-support:javadoc
:geode-old-client-support:javadocJar
:geode-old-client-support:sourcesJar
:geode-old-client-support:signArchives SKIPPED
:geode-protobuf:jar
:geode-protobuf:javadoc
:geode-protobuf:javadocJar
:geode-protobuf:sourcesJar
:geode-protobuf:signArchives SKIPPED
:geode-pulse:javadoc
:geode-pulse:javadocJar
:geode-pulse:sourcesJar
:geode-pulse:war
:geode-pulse:signArchives SKIPPED
:geode-rebalancer:jar
:geode-rebalancer:javadoc
:geode-rebalancer:javadocJar
:geode-rebalancer:sourcesJar
:geode-rebalancer:signArchives SKIPPED
:geode-wan:jar
:geode-wan:javadoc
:geode-wan:javadocJar
:geode-wan:sourcesJar
:geode-wan:signArchives SKIPPED
:geode-web:javadoc NO-SOURCE
:geode-web:javadocJar
:geode-web:sourcesJar
:geode-web:war
:geode-web:signArchives SKIPPED
:geode-web-api:javadoc
:geode-web-api:javadocJar
:geode-web-api:sourcesJar
:geode-web-api:war
:geode-web-api:signArchives SKIPPED
:geode-assembly:installDist
:geode-pulse:jar
:geo

Re: [VOTE] Apache Geode release - 1.3.0 RC3

2017-10-19 Thread Dick Cavender 
We'll look at the Jenkins config Dan.

-Dick

On Thu, Oct 19, 2017 at 9:03 AM, Dan Smith  wrote:

> +1
>
> Build passed, release check passed, examples are present, I don't see us
> shipping jars we shouldn't. Looks good to me!
>
> BTW, even though the actual build passed, the jenkins job failed with the
> below error about archiving results. Who has access to fix this?
>
> BUILD SUCCESSFUL
> >
> > Total time: 15 hrs 58 mins 25.622 secs
> > Build step 'Invoke Gradle script' changed build result to SUCCESS
> > Archiving artifacts
> > [Fast Archiver] Compressed 225.42 MB of artifacts by 16.4% relative to
> #90
> > Recording test results
> > ERROR: Step ?Publish JUnit test result report? failed: No test report
> > files were found. Configuration error?
> >
>
> -Dan
>
> On Wed, Oct 18, 2017 at 1:51 PM, Swapnil Bawaskar 
> wrote:
>
> > This is the third release candidate for Apache Geode, version 1.3.0.
> > Thanks to all the community members for their contributions to this
> > release!
> >
> > *** Please download, test and vote by Monday, October 23, 0800 hrs
> > US Pacific. ***
> >
> > It fixes 376 issues. release notes can be found at:
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> > projectId=12318420&version=12340669
> >
> > Note that we are voting upon the source tags:  rel/v1.3.0.RC3
> > https://github.com/apache/geode/tree/rel/v1.3.0.RC3
> > https://github.com/apache/geode-examples/tree/rel/v1.3.0.RC3
> >
> > Commit ID:
> > 9e076738fc2ae40f95bd179b5c1624e664a28d61 (geode)
> > 4ff8f8eafd0927888e711ee45d283ab07d345000   (geode-examples)
> >
> > Source and binary files:
> >  https://dist.apache.org/repos/dist/dev/geode/1.3.0.RC3
> >
> > Maven staging repo:
> > https://repository.apache.org/content/repositories/orgapachegeode-1034
> >
> >
> > Geode's KEYS file containing PGP keys we use to sign the release:
> >  https://github.com/apache/geode/blob/develop/KEYS
> >
> > Release Signed with Key: pub 4096R/18F902DB 2016-04-07
> > Fingerprint: E1B1 ABE3 4753 E7BA 8097 4285 8F8F 2BCC 18F9 02DB
> >
>

Commits without Jira tickets

2017-10-19 Thread Kirk Lund 
Sorry I keep hitting "rebase and merge" on github instead of squashing PRs.
I'm trying to remember to squash them!

Because of this you'll see some crappy commits like this which should've
been squashed:

commit 674d4aed0cabc69e51aec3e3ba815bb170288484 (HEAD -> develop,
origin/develop)
Author: Kirk Lund 
Date:   Wed Oct 18 15:30:45 2017 -0700

Fix format with spotless

commit 674fd88cc3501c32f1d8b560c31fdfb19bba5a82
Author: Kirk Lund 
Date:   Wed Oct 18 13:00:16 2017 -0700

Isolate new methods accepting workingDirectory to only require
workingDirectory

commit 97ff1ae82551660271b1858ed25d9f3634b105e4
Author: Kirk Lund 
Date:   Wed Oct 18 12:57:54 2017 -0700

Change DeprecatedAgentLauncherIntegrationTest to use TemporaryFolder

commit bbcfb832f32f97f58a4417686f3d6787a8fda136
Author: Kirk Lund 
Date:   Wed Oct 18 12:31:08 2017 -0700

GEODE-3866: add integration tests for deprecated launchers

Re: [VOTE] Apache Geode release - 1.3.0 RC3

2017-10-19 Thread Dick Cavender 
Made the config changes to Geode-release and triggered rebuilding last
again to confirm.

-Dick

On Thu, Oct 19, 2017 at 9:53 AM, Dick Cavender  wrote:

> We'll look at the Jenkins config Dan.
>
> -Dick
>
> On Thu, Oct 19, 2017 at 9:03 AM, Dan Smith  wrote:
>
>> +1
>>
>> Build passed, release check passed, examples are present, I don't see us
>> shipping jars we shouldn't. Looks good to me!
>>
>> BTW, even though the actual build passed, the jenkins job failed with the
>> below error about archiving results. Who has access to fix this?
>>
>> BUILD SUCCESSFUL
>> >
>> > Total time: 15 hrs 58 mins 25.622 secs
>> > Build step 'Invoke Gradle script' changed build result to SUCCESS
>> > Archiving artifacts
>> > [Fast Archiver] Compressed 225.42 MB of artifacts by 16.4% relative to
>> #90
>> > Recording test results
>> > ERROR: Step ?Publish JUnit test result report? failed: No test report
>> > files were found. Configuration error?
>> >
>>
>> -Dan
>>
>> On Wed, Oct 18, 2017 at 1:51 PM, Swapnil Bawaskar 
>> wrote:
>>
>> > This is the third release candidate for Apache Geode, version 1.3.0.
>> > Thanks to all the community members for their contributions to this
>> > release!
>> >
>> > *** Please download, test and vote by Monday, October 23, 0800 hrs
>> > US Pacific. ***
>> >
>> > It fixes 376 issues. release notes can be found at:
>> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?
>> > projectId=12318420&version=12340669
>> >
>> > Note that we are voting upon the source tags:  rel/v1.3.0.RC3
>> > https://github.com/apache/geode/tree/rel/v1.3.0.RC3
>> > https://github.com/apache/geode-examples/tree/rel/v1.3.0.RC3
>> >
>> > Commit ID:
>> > 9e076738fc2ae40f95bd179b5c1624e664a28d61 (geode)
>> > 4ff8f8eafd0927888e711ee45d283ab07d345000   (geode-examples)
>> >
>> > Source and binary files:
>> >  https://dist.apache.org/repos/dist/dev/geode/1.3.0.RC3
>> >
>> > Maven staging repo:
>> > https://repository.apache.org/content/repositories/orgapachegeode-1034
>> >
>> >
>> > Geode's KEYS file containing PGP keys we use to sign the release:
>> >  https://github.com/apache/geode/blob/develop/KEYS
>> >
>> > Release Signed with Key: pub 4096R/18F902DB 2016-04-07
>> > Fingerprint: E1B1 ABE3 4753 E7BA 8097 4285 8F8F 2BCC 18F9 02DB
>> >
>>
>
>

[Discuss] CliStrings

2017-10-19 Thread Jared Stewart 
I wanted to kick off a discussion about the usage of CliStrings.  For those 
unfamiliar, it’s a java class that contains about ~3000 lines of String 
constants and has a javadoc explaining that it is an attempt at i18n 
localization.  Does anyone know if this localization is actually implemented in 
practice?  

If not, I would like suggest that we try to move away from this pattern going 
forward.  We have ended up with many constants in CliStrings like this: 
CliStrings.CREATE_REGION__MSG__ONLY_ONE_OF_REGIONSHORTCUT_AND_USEATTRIBUESFROM_CAN_BE_SPECIFIED
The constant is only used in CreateRegionCommand, so I would be happier to see 
it as a member of CreateRegionCommand (where there would be no need for the 
unwieldy "CREATE_REGION__MSG__” prefix) unless there is localization being done 
which I am unaware of.

Thoughts?

Thanks,
Jared

Re: [Discuss] CliStrings

2017-10-19 Thread Kirk Lund 
I'm all for getting rid of CliStrings. That constant (or the raw string)
belongs in CreateRegionCommand instead of in CliStrings.

On Thu, Oct 19, 2017 at 3:05 PM, Jared Stewart  wrote:

> I wanted to kick off a discussion about the usage of CliStrings.  For
> those unfamiliar, it’s a java class that contains about ~3000 lines of
> String constants and has a javadoc explaining that it is an attempt at i18n
> localization.  Does anyone know if this localization is actually
> implemented in practice?
>
> If not, I would like suggest that we try to move away from this pattern
> going forward.  We have ended up with many constants in CliStrings like
> this:
> CliStrings.CREATE_REGION__MSG__ONLY_ONE_OF_REGIONSHORTCUT_
> AND_USEATTRIBUESFROM_CAN_BE_SPECIFIED
> The constant is only used in CreateRegionCommand, so I would be happier to
> see it as a member of CreateRegionCommand (where there would be no need for
> the unwieldy "CREATE_REGION__MSG__” prefix) unless there is localization
> being done which I am unaware of.
>
> Thoughts?
>
> Thanks,
> Jared

Re: [Discuss] CliStrings

2017-10-19 Thread Nick Reich 
+1 for moving those messages out of CliStrings if at all possible and
placing them where they are used. In my experiences with those strings, I
have rarely if ever seen them reused across classes, so they really should
belong in the class they are used by.

On Thu, Oct 19, 2017 at 3:05 PM, Jared Stewart  wrote:

> I wanted to kick off a discussion about the usage of CliStrings.  For
> those unfamiliar, it’s a java class that contains about ~3000 lines of
> String constants and has a javadoc explaining that it is an attempt at i18n
> localization.  Does anyone know if this localization is actually
> implemented in practice?
>
> If not, I would like suggest that we try to move away from this pattern
> going forward.  We have ended up with many constants in CliStrings like
> this:
> CliStrings.CREATE_REGION__MSG__ONLY_ONE_OF_REGIONSHORTCUT_
> AND_USEATTRIBUESFROM_CAN_BE_SPECIFIED
> The constant is only used in CreateRegionCommand, so I would be happier to
> see it as a member of CreateRegionCommand (where there would be no need for
> the unwieldy "CREATE_REGION__MSG__” prefix) unless there is localization
> being done which I am unaware of.
>
> Thoughts?
>
> Thanks,
> Jared

Re: [Discuss] CliStrings

2017-10-19 Thread Bruce Schuchardt 
+1 I thought we decided long ago to do this.  We also have 
LocalizedStrings.java and it looks like some folks are still adding new 
StringIDs to it as well.



On 10/19/17 3:13 PM, Nick Reich wrote:

+1 for moving those messages out of CliStrings if at all possible and
placing them where they are used. In my experiences with those strings, I
have rarely if ever seen them reused across classes, so they really should
belong in the class they are used by.

On Thu, Oct 19, 2017 at 3:05 PM, Jared Stewart  wrote:


I wanted to kick off a discussion about the usage of CliStrings.  For
those unfamiliar, it’s a java class that contains about ~3000 lines of
String constants and has a javadoc explaining that it is an attempt at i18n
localization.  Does anyone know if this localization is actually
implemented in practice?

If not, I would like suggest that we try to move away from this pattern
going forward.  We have ended up with many constants in CliStrings like
this:
CliStrings.CREATE_REGION__MSG__ONLY_ONE_OF_REGIONSHORTCUT_
AND_USEATTRIBUESFROM_CAN_BE_SPECIFIED
The constant is only used in CreateRegionCommand, so I would be happier to
see it as a member of CreateRegionCommand (where there would be no need for
the unwieldy "CREATE_REGION__MSG__” prefix) unless there is localization
being done which I am unaware of.

Thoughts?

Thanks,
Jared

Re: [Discuss] CliStrings

2017-10-19 Thread Michael Stolz 
I know we did at one time go through the exercise to collect all of the
strings and put them in one place and have them translated to at least
Japanese.

I don't know where the Japanese version of the file is though.

--
Mike Stolz
Principal Engineer, GemFire Product Lead
Mobile: +1-631-835-4771

On Thu, Oct 19, 2017 at 6:05 PM, Jared Stewart  wrote:

> I wanted to kick off a discussion about the usage of CliStrings.  For
> those unfamiliar, it’s a java class that contains about ~3000 lines of
> String constants and has a javadoc explaining that it is an attempt at i18n
> localization.  Does anyone know if this localization is actually
> implemented in practice?
>
> If not, I would like suggest that we try to move away from this pattern
> going forward.  We have ended up with many constants in CliStrings like
> this:
> CliStrings.CREATE_REGION__MSG__ONLY_ONE_OF_REGIONSHORTCUT_
> AND_USEATTRIBUESFROM_CAN_BE_SPECIFIED
> The constant is only used in CreateRegionCommand, so I would be happier to
> see it as a member of CreateRegionCommand (where there would be no need for
> the unwieldy "CREATE_REGION__MSG__” prefix) unless there is localization
> being done which I am unaware of.
>
> Thoughts?
>
> Thanks,
> Jared

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #714 was SUCCESSFUL (with 2182 tests)

2017-10-19 Thread Spring CI 

---
Spring Data GemFire > Nightly-ApacheGeode > #714 was successful.
---
Scheduled
2184 tests in total.

https://build.spring.io/browse/SGF-NAG-714/





--
This message is automatically generated by Atlassian Bamboo

Re: [Discuss] CliStrings

2017-10-19 Thread Mark Hanson 
From my product background, maintaining a single file is often preferred for 
localization as mentioned by Mike, the big question, I would ask is how 
important is localization? If localization is important, then keeping a single 
or few file(s) will dramatically ease the localization process. So following 
Jared’s approach might make more work in the future, but it is certainly sound 
if there is no localization. This may also be an opportune time to review 
localization strategies within the code.

Thanks,
Mark
> On Oct 19, 2017, at 3:28 PM, Bruce Schuchardt  wrote:
> 
> +1 I thought we decided long ago to do this.  We also have 
> LocalizedStrings.java and it looks like some folks are still adding new 
> StringIDs to it as well.
> 
> 
> On 10/19/17 3:13 PM, Nick Reich wrote:
>> +1 for moving those messages out of CliStrings if at all possible and
>> placing them where they are used. In my experiences with those strings, I
>> have rarely if ever seen them reused across classes, so they really should
>> belong in the class they are used by.
>> 
>> On Thu, Oct 19, 2017 at 3:05 PM, Jared Stewart  wrote:
>> 
>>> I wanted to kick off a discussion about the usage of CliStrings.  For
>>> those unfamiliar, it’s a java class that contains about ~3000 lines of
>>> String constants and has a javadoc explaining that it is an attempt at i18n
>>> localization.  Does anyone know if this localization is actually
>>> implemented in practice?
>>> 
>>> If not, I would like suggest that we try to move away from this pattern
>>> going forward.  We have ended up with many constants in CliStrings like
>>> this:
>>> CliStrings.CREATE_REGION__MSG__ONLY_ONE_OF_REGIONSHORTCUT_
>>> AND_USEATTRIBUESFROM_CAN_BE_SPECIFIED
>>> The constant is only used in CreateRegionCommand, so I would be happier to
>>> see it as a member of CreateRegionCommand (where there would be no need for
>>> the unwieldy "CREATE_REGION__MSG__” prefix) unless there is localization
>>> being done which I am unaware of.
>>> 
>>> Thoughts?
>>> 
>>> Thanks,
>>> Jared
>

Broken: apache/geode#4470 (develop - 2cb5fed)

2017-10-19 Thread Travis CI 
Build Update for apache/geode
-

Build: #4470
Status: Broken

Duration: 12 minutes and 24 seconds
Commit: 2cb5fed (develop)
Author: Barry Oglesby
Message: GEODE-3810: Incremented test timestamp by 1 in case it is the same as 
the previous event

View the changeset: 
https://github.com/apache/geode/compare/dc9acd2873c1...2cb5fed2d677

View the full build log and details: 
https://travis-ci.org/apache/geode/builds/290259178?utm_source=email&utm_medium=notification

--

You can configure recipients for build notifications in your .travis.yml file. 
See https://docs.travis-ci.com/user/notifications