Re: Need Help on understanding vsd files

[Barry Oglesby]

Interesting. I can see them, but here they are again. I dragged/dropped
them this time.

[image: Inline image 1][image: Inline image 2][image: Inline image 3][image:
Inline image 4][image: Inline image 5]

Thanks,
Barry Oglesby


On Thu, Sep 21, 2017 at 10:23 PM, Avinash Dongre  wrote:

> Thanks Barry for your help and explanation.
> Could you please re-attach the charts for the steps. I do not see them in
> the email.
>
> Thanks
> Avinash
>
>
> On Fri, Sep 22, 2017 at 2:30 AM, Barry Oglesby 
> wrote:
>
> > You probably need more than just the getTime stat to see whats going on
> > there. That stat is basically telling you how much time per second get
> > operations are occurring. You probably need to also know how many gets
> are
> > occurring.
> >
> > What I generally do is:
> >
> > - plot time stat (getTime in this case)
> > - divide time stat by 100 to get milliseconds (top right in vsd)
> > - plot operation stat (getsCompleted in this case)
> > - change both to 'No Filter' (top right drop down in vsd). This tells you
> > total time and number of operations.
> > - Divide time stat by operations stat to get average time per operation.
> > You can do this with either vsd or a calculator. I generally use a
> > calculator and divide the maximum of each stat, but with vsd:
> >   - select time stat line
> >   - select 'Line' -> 'Divide Lines' menu option
> >   - select operation stat line
> >   - the last sample of the resulting line is the average for the entire
> run
> >
> > I attached charts for each step.
> >
> >
> > Thanks,
> > Barry Oglesby
> >
> >
> > On Thu, Sep 21, 2017 at 10:29 AM, Anilkumar Gingade  >
> > wrote:
> >
> >> At a high level, you can find stat descriptions by "selecting a stat"
> and
> >> then clicking (in vsd) main->"Show Statistic Info".
> >>
> >> -Anil.
> >>
> >>
> >> On Thu, Sep 21, 2017 at 2:24 AM, Avinash Dongre 
> >> wrote:
> >>
> >>> Attaching the graph.
> >>>
> >>> On Thu, Sep 21, 2017 at 2:45 PM, Avinash Dongre 
> >>> wrote:
> >>>
>  Hi All,
> >
> > I am looking at  getTime-PartitionedRegionStats using vsd tools. I
> > need some help on how to interpret following graph.
> > If there is a document which helps to explain please let me know.
> >
> >
> > [image: Inline image 1]
> >
> >
> > Thanks
> > Avinash
> >
> >
> 
> >>>
> >>
> >
>

Correct Geode REST API cipher

[Rupert St John Webster]

Hi,

Please can someone advise which cipher to use for ssl-enabled-components=web 
and ssl-ciphers=any

After starting Geode with web security then when we run up Swagger using https 
all we see is ERR_SSL_VERSION_OR_CIPHER_MISMATCH

I also asked on StackOverflow 
https://stackoverflow.com/questions/46349116/get-geode-rest-api-going-with-ssl

Thanks in advance...


Kind regards

Rupert St John Webster
FX Consultant | Tel: 01708 759 760 | Fax: 01708 759 761 |
3 Holgate Court, 4-10 Western Road, Romford, Essex, RM1 3JS | 
rup...@impress-solutions.com

Re: Need Help on understanding vsd files

[Avinash Dongre]

Hi Barry,
Still cannot see them.

Thanks
Avinash


On Fri, Sep 22, 2017 at 2:18 PM, Barry Oglesby  wrote:

> Interesting. I can see them, but here they are again. I dragged/dropped
> them this time.
>
> [image: Inline image 1][image: Inline image 2][image: Inline image 3][image:
> Inline image 4][image: Inline image 5]
>
> Thanks,
> Barry Oglesby
>
>
> On Thu, Sep 21, 2017 at 10:23 PM, Avinash Dongre 
> wrote:
>
>> Thanks Barry for your help and explanation.
>> Could you please re-attach the charts for the steps. I do not see them in
>> the email.
>>
>> Thanks
>> Avinash
>>
>>
>> On Fri, Sep 22, 2017 at 2:30 AM, Barry Oglesby 
>> wrote:
>>
>> > You probably need more than just the getTime stat to see whats going on
>> > there. That stat is basically telling you how much time per second get
>> > operations are occurring. You probably need to also know how many gets
>> are
>> > occurring.
>> >
>> > What I generally do is:
>> >
>> > - plot time stat (getTime in this case)
>> > - divide time stat by 100 to get milliseconds (top right in vsd)
>> > - plot operation stat (getsCompleted in this case)
>> > - change both to 'No Filter' (top right drop down in vsd). This tells
>> you
>> > total time and number of operations.
>> > - Divide time stat by operations stat to get average time per operation.
>> > You can do this with either vsd or a calculator. I generally use a
>> > calculator and divide the maximum of each stat, but with vsd:
>> >   - select time stat line
>> >   - select 'Line' -> 'Divide Lines' menu option
>> >   - select operation stat line
>> >   - the last sample of the resulting line is the average for the entire
>> run
>> >
>> > I attached charts for each step.
>> >
>> >
>> > Thanks,
>> > Barry Oglesby
>> >
>> >
>> > On Thu, Sep 21, 2017 at 10:29 AM, Anilkumar Gingade <
>> aging...@pivotal.io>
>> > wrote:
>> >
>> >> At a high level, you can find stat descriptions by "selecting a stat"
>> and
>> >> then clicking (in vsd) main->"Show Statistic Info".
>> >>
>> >> -Anil.
>> >>
>> >>
>> >> On Thu, Sep 21, 2017 at 2:24 AM, Avinash Dongre 
>> >> wrote:
>> >>
>> >>> Attaching the graph.
>> >>>
>> >>> On Thu, Sep 21, 2017 at 2:45 PM, Avinash Dongre 
>> >>> wrote:
>> >>>
>>  Hi All,
>> >
>> > I am looking at  getTime-PartitionedRegionStats using vsd tools. I
>> > need some help on how to interpret following graph.
>> > If there is a document which helps to explain please let me know.
>> >
>> >
>> > [image: Inline image 1]
>> >
>> >
>> > Thanks
>> > Avinash
>> >
>> >
>> 
>> >>>
>> >>
>> >
>>
>
>

Build failed in Jenkins: Geode-nightly #962

[Apache Jenkins Server]

See 


Changes:

[abaker] Update dockerfile for 1.2.1

[github] GEODE-2788 Document defn of pool attr socket-connect-timeout (#798)

[klund] GEODE-3205: add FlakyTest category

[klund] GEODE-3552: delete TestSuite that does not belong in package

[klund] GEODE-3552: delete unused testing classes

[klund] GEODE-3552: move and rename TypedJson tests

[klund] GEODE-3552: cleanup more MXBean tests

[dbarnes] GEODE-3378: Document Snapshot Improvements

[dbarnes] Incorporate reviewer corrections (jmcallister)

[dbarnes] Incorporate reviewer corrections (kmiller)

--
[...truncated 21.88 MB...]
at 
io.netty.util.concurrent.DefaultThreadFactory$DefaultRunnableDecorator.run(DefaultThreadFactory.java:144)
at java.lang.Thread.run(Thread.java:748)
at 
io.netty.channel.epoll.AbstractEpollStreamChannel$EpollStreamUnsafe.epollInReady(AbstractEpollStreamChannel.java:961)
at 
io.netty.channel.epoll.EpollDomainSocketChannel$EpollDomainUnsafe.epollInReady(EpollDomainSocketChannel.java:140)
at 
io.netty.channel.epoll.EpollEventLoop.processReady(EpollEventLoop.java:386)
at io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:302)
at 
io.netty.util.concurrent.SingleThreadEventExecutor$5.run(SingleThreadEventExecutor.java:877)
at 
io.netty.util.concurrent.DefaultThreadFactory$DefaultRunnableDecorator.run(DefaultThreadFactory.java:144)
at java.lang.Thread.run(Thread.java:748)
com.github.dockerjava.api.exception.NotFoundException: {"message":"No such 
image: apachegeode/geode-build:latest"}

at 
com.github.dockerjava.netty.handler.HttpResponseHandler.channelRead0(HttpResponseHandler.java:103)
at 
com.github.dockerjava.netty.handler.HttpResponseHandler.channelRead0(HttpResponseHandler.java:33)
at 
io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:105)
at 
io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:372)
at 
io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:358)
at 
io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:350)
at 
io.netty.handler.logging.LoggingHandler.channelRead(LoggingHandler.java:233)
at 
io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:372)
at 
io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:358)
at 
io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:350)
at 
io.netty.channel.CombinedChannelDuplexHandler$DelegatingChannelHandlerContext.fireChannelRead(CombinedChannelDuplexHandler.java:435)
at 
io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:293)
at 
io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:267)
at 
io.netty.channel.CombinedChannelDuplexHandler.channelRead(CombinedChannelDuplexHandler.java:250)
at 
io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:372)
at 
io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:358)
at 
io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:350)
at 
io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1334)
at 
io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:372)
at 
io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:358)
at 
io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:926)
at 
io.netty.channel.epoll.AbstractEpollStreamChannel$EpollStreamUnsafe.epollInReady(AbstractEpollStreamChannel.java:961)
at 
io.netty.channel.epoll.EpollDomainSocketChannel$EpollDomainUnsafe.epollInReady(EpollDomainSocketChannel.java:140)
at 
io.netty.channel.epoll.EpollEventLoop.processReady(EpollEventLoop.java:386)
at io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:302)
at 
io.netty.util.concurrent.SingleThreadEventExecutor$5.run(SingleThreadEventExecutor.java:877)
at 
io.netty.util.concurrent.DefaultThreadFactory$DefaultRunnableDecorator.run(DefaultThreadFactory.java:144)
at java.lang.Thread.run(Thread.java:748)
Could not stop 
org.gradle.internal.actor.internal.DefaultActorFactory$NonBlockingActor@31af983d.
org.gradle.internal.dispatch.DispatchException: Could not dispatch message 
[MethodInvocation method: 
processTestClass(org.gradle.api.internal.tasks.t

Build failed in Jenkins: Geode-nightly-flaky #129

[Apache Jenkins Server]

See 


Changes:

[abaker] Update dockerfile for 1.2.1

[github] GEODE-2788 Document defn of pool attr socket-connect-timeout (#798)

[klund] GEODE-3205: add FlakyTest category

[klund] GEODE-3552: delete TestSuite that does not belong in package

[klund] GEODE-3552: delete unused testing classes

[klund] GEODE-3552: move and rename TypedJson tests

[klund] GEODE-3552: cleanup more MXBean tests

[dbarnes] GEODE-3378: Document Snapshot Improvements

[dbarnes] Incorporate reviewer corrections (jmcallister)

[dbarnes] Incorporate reviewer corrections (kmiller)

--
[...truncated 115.08 KB...]
:geode-json:sourcesJar
:geode-json:signArchives SKIPPED
:geode-lucene:jar
:geode-lucene:javadoc
:geode-lucene:javadocJar
:geode-lucene:sourcesJar
:geode-lucene:signArchives SKIPPED
:geode-old-client-support:jar
:geode-old-client-support:javadoc
:geode-old-client-support:javadocJar
:geode-old-client-support:sourcesJar
:geode-old-client-support:signArchives SKIPPED
:geode-protobuf:jar
:geode-protobuf:javadoc:101:
 warning - Tag @link: reference not found: BasicTypes.Entry

1 warning
:geode-protobuf:javadocJar
:geode-protobuf:sourcesJar
:geode-protobuf:signArchives SKIPPED
:geode-pulse:javadoc
:geode-pulse:javadocJar
:geode-pulse:sourcesJar
:geode-pulse:war
:geode-pulse:signArchives SKIPPED
:geode-rebalancer:jar
:geode-rebalancer:javadoc
:geode-rebalancer:javadocJar
:geode-rebalancer:sourcesJar
:geode-rebalancer:signArchives SKIPPED
:geode-wan:jar
:geode-wan:javadoc
:geode-wan:javadocJar
:geode-wan:sourcesJar
:geode-wan:signArchives SKIPPED
:geode-web:javadoc NO-SOURCE
:geode-web:javadocJar
:geode-web:sourcesJar
:geode-web:war
:geode-web:signArchives SKIPPED
:geode-web-api:javadoc
:geode-web-api:javadocJar
:geode-web-api:sourcesJar
:geode-web-api:war
:geode-web-api:signArchives SKIPPED
:geode-assembly:installDist
:geode-pulse:jar
:geode-assembly:compileTestJava
Download 
https://repo1.maven.org/maven2/org/codehaus/cargo/cargo-core-uberjar/1.6.3/cargo-core-uberjar-1.6.3.pom
Download 
https://repo1.maven.org/maven2/org/codehaus/cargo/cargo-core/1.6.3/cargo-core-1.6.3.pom
Download 
https://repo1.maven.org/maven2/org/codehaus/cargo/codehaus-cargo/1.6.3/codehaus-cargo-1.6.3.pom
Download 
https://repo1.maven.org/maven2/org/codehaus/cargo/cargo-core-uberjar/1.6.3/cargo-core-uberjar-1.6.3.jar
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
:geode-assembly:processTestResources
:geode-assembly:testClasses
:geode-assembly:flakyTest
:geode-benchmarks:compileTestJava NO-SOURCE
:geode-benchmarks:processTestResources NO-SOURCE
:geode-benchmarks:testClasses UP-TO-DATE
:geode-benchmarks:flakyTest NO-SOURCE
:geode-common:compileTestJava
:geode-common:processTestResources NO-SOURCE
:geode-common:testClasses
:geode-common:flakyTest
:geode-core:flakyTest

org.apache.geode.management.RegionManagementDUnitTest > testNavigationAPIS 
FAILED
org.apache.geode.test.dunit.RMIException: While invoking 
org.apache.geode.test.dunit.NamedRunnable.run in VM 0 running on Host 
asf914.gq1.ygridcore.net with 4 VMs
at org.apache.geode.test.dunit.VM.invoke(VM.java:387)
at org.apache.geode.test.dunit.VM.invoke(VM.java:357)
at org.apache.geode.test.dunit.VM.invoke(VM.java:290)
at 
org.apache.geode.management.RegionManagementDUnitTest.verifyNavigationApis(RegionManagementDUnitTest.java:406)
at 
org.apache.geode.management.RegionManagementDUnitTest.testNavigationAPIS(RegionManagementDUnitTest.java:267)

Caused by:
org.awaitility.core.ConditionTimeoutException: Condition defined as a 
lambda expression in org.apache.geode.management.RegionManagementDUnitTest that 
uses org.apache.geode.management.DistributedSystemMXBean, 
org.apache.geode.management.DistributedSystemMXBeanint expected:<[4]> but 
was:<[5]> within 2 minutes.
at 
org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:104)
at 
org.awaitility.core.AssertionCondition.await(AssertionCondition.java:117)
at 
org.awaitility.core.AssertionCondition.await(AssertionCondition.java:32)
at 
org.awaitility.core.ConditionFactory.until(ConditionFactory.java:809)
at 
org.awaitility.core.ConditionFactory.until(ConditionFactory.java:648)
at 
org.apache.geode.management.RegionManagementDUnitTest.awaitMemberCount(RegionManagementDUnitTest.java:1049)
at 
org.apache.geode.management.RegionManagementDUnitTest.lambda$verifyNavigationApis$8ec4a763$1(RegionManagementDUnitTest.java:410)

342 tests completed, 1 failed, 9 skipped
:geode-core:fl

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #686 was SUCCESSFUL (with 2042 tests)

[Spring CI]

---
Spring Data GemFire > Nightly-ApacheGeode > #686 was successful.
---
This was manually triggered by John Blum.
2044 tests in total.

https://build.spring.io/browse/SGF-NAG-686/




--
Code Changes
--
Mark Paluch (8abbfda619bf747c00dffd01f4ef70b2182270de):

>DATAGEODE-42 - Downgrade to CDI 1.0.
>We now build against CDI 1.0 again while using CDI 2.0 for testing.



--
Tests
--
Fixed Tests (1)
   - GemfireRepositoryExtensionTest: After bean discovery registers repository 
bean

--
This message is automatically generated by Atlassian Bamboo

Minor dunit cleanup being merged to develop

[Kirk Lund]

GEODE-3638: cleanup minor issues found while prepping dunit talk

My precheckin for PR #802 (GEODE-3638) is GREEN except for
*org.apache.geode.internal.cache.tier.sockets.ClientHealthMonitorJUnitTest*
which is still failing.

#802 introduces DistributedTestRule and fixes DistributedDisconnectRule
along with some other minor cleanup of the dunit framework

Thanks,
Kirk

Review Request 62506: GEODE-3679: Original client member Id in the transaction should be set in the PartitionMessage

[Eric Shu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62506/
---

Review request for geode, anilkumar gingade, Darrel Schneider, Kirk Lund, Lynn 
Gallinat, and Nick Reich.


Bugs: GEODE-3679
https://issues.apache.org/jira/browse/GEODE-3679


Repository: geode


Description
---

Sets the originating member id from client transaction in partition message 
when a server needs to perform operaton and send to other peers.


Diffs
-

  
geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/PartitionMessage.java
 8c27107 
  
geode-core/src/test/java/org/apache/geode/internal/cache/ClientServerTransactionDUnitTest.java
 96b89b9 


Diff: https://reviews.apache.org/r/62506/diff/1/


Testing
---

precheckin.


Thanks,

Eric Shu

Re: Review Request 62506: GEODE-3679: Original client member Id in the transaction should be set in the PartitionMessage

[Nick Reich]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62506/#review186003
---




geode-core/src/test/java/org/apache/geode/internal/cache/ClientServerTransactionDUnitTest.java
Lines 4109 (patched)


This is actually "doTransactionOnServer", as there is nothing about the 
method which is tied to server1.



geode-core/src/test/java/org/apache/geode/internal/cache/ClientServerTransactionDUnitTest.java
Lines 4114 (patched)


Avoid single character variable names



geode-core/src/test/java/org/apache/geode/internal/cache/ClientServerTransactionDUnitTest.java
Lines 4120 (patched)


Can this have a generic type like above method? Would remove casting to 
Integer below.



geode-core/src/test/java/org/apache/geode/internal/cache/ClientServerTransactionDUnitTest.java
Lines 4125 (patched)


Do not need to hold onto the set:
for (Object key : region.keySet())


- Nick Reich


On Sept. 22, 2017, 5:01 p.m., Eric Shu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62506/
> ---
> 
> (Updated Sept. 22, 2017, 5:01 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Darrel Schneider, Kirk Lund, 
> Lynn Gallinat, and Nick Reich.
> 
> 
> Bugs: GEODE-3679
> https://issues.apache.org/jira/browse/GEODE-3679
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Sets the originating member id from client transaction in partition message 
> when a server needs to perform operaton and send to other peers.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/PartitionMessage.java
>  8c27107 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/ClientServerTransactionDUnitTest.java
>  96b89b9 
> 
> 
> Diff: https://reviews.apache.org/r/62506/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin.
> 
> 
> Thanks,
> 
> Eric Shu
> 
>

Re: Review Request 62506: GEODE-3679: Original client member Id in the transaction should be set in the PartitionMessage

[anilkumar gingade]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62506/#review186005
---




geode-core/src/test/java/org/apache/geode/internal/cache/ClientServerTransactionDUnitTest.java
Lines 4111 (patched)


Do we need to check for expected trasaction id here...



geode-core/src/test/java/org/apache/geode/internal/cache/ClientServerTransactionDUnitTest.java
Lines 4115 (patched)


Do we need sleep...


- anilkumar gingade


On Sept. 22, 2017, 5:01 p.m., Eric Shu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62506/
> ---
> 
> (Updated Sept. 22, 2017, 5:01 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Darrel Schneider, Kirk Lund, 
> Lynn Gallinat, and Nick Reich.
> 
> 
> Bugs: GEODE-3679
> https://issues.apache.org/jira/browse/GEODE-3679
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Sets the originating member id from client transaction in partition message 
> when a server needs to perform operaton and send to other peers.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/PartitionMessage.java
>  8c27107 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/ClientServerTransactionDUnitTest.java
>  96b89b9 
> 
> 
> Diff: https://reviews.apache.org/r/62506/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin.
> 
> 
> Thanks,
> 
> Eric Shu
> 
>

Re: Review Request 62506: GEODE-3679: Original client member Id in the transaction should be set in the PartitionMessage

[Eric Shu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62506/
---

(Updated Sept. 22, 2017, 7:12 p.m.)


Review request for geode, anilkumar gingade, Darrel Schneider, Kirk Lund, Lynn 
Gallinat, and Nick Reich.


Changes
---

Update review comments.


Bugs: GEODE-3679
https://issues.apache.org/jira/browse/GEODE-3679


Repository: geode


Description
---

Sets the originating member id from client transaction in partition message 
when a server needs to perform operaton and send to other peers.


Diffs (updated)
-

  
geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/PartitionMessage.java
 8c27107 
  
geode-core/src/test/java/org/apache/geode/internal/cache/ClientServerTransactionDUnitTest.java
 96b89b9 


Diff: https://reviews.apache.org/r/62506/diff/2/

Changes: https://reviews.apache.org/r/62506/diff/1-2/


Testing
---

precheckin.


Thanks,

Eric Shu

Re: Review Request 62506: GEODE-3679: Original client member Id in the transaction should be set in the PartitionMessage

[Eric Shu]

> On Sept. 22, 2017, 6:27 p.m., Nick Reich wrote:
> > geode-core/src/test/java/org/apache/geode/internal/cache/ClientServerTransactionDUnitTest.java
> > Lines 4109 (patched)
> > 
> >
> > This is actually "doTransactionOnServer", as there is nothing about the 
> > method which is tied to server1.

client is connect to server1, tx should be on server1.


- Eric


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62506/#review186003
---


On Sept. 22, 2017, 7:12 p.m., Eric Shu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62506/
> ---
> 
> (Updated Sept. 22, 2017, 7:12 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Darrel Schneider, Kirk Lund, 
> Lynn Gallinat, and Nick Reich.
> 
> 
> Bugs: GEODE-3679
> https://issues.apache.org/jira/browse/GEODE-3679
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Sets the originating member id from client transaction in partition message 
> when a server needs to perform operaton and send to other peers.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/PartitionMessage.java
>  8c27107 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/ClientServerTransactionDUnitTest.java
>  96b89b9 
> 
> 
> Diff: https://reviews.apache.org/r/62506/diff/2/
> 
> 
> Testing
> ---
> 
> precheckin.
> 
> 
> Thanks,
> 
> Eric Shu
> 
>

Re: Review Request 62506: GEODE-3679: Original client member Id in the transaction should be set in the PartitionMessage

[Eric Shu]

> On Sept. 22, 2017, 6:55 p.m., anilkumar gingade wrote:
> > geode-core/src/test/java/org/apache/geode/internal/cache/ClientServerTransactionDUnitTest.java
> > Lines 4111 (patched)
> > 
> >
> > Do we need to check for expected trasaction id here...

The server1 transaction id does not have issue and does not change. The issue 
is that server2 receives the keySet op from server1 and will start a 
TXStateProxy there. There is nothing in the test could get hold of it, however, 
the test would fail without this fix.


> On Sept. 22, 2017, 6:55 p.m., anilkumar gingade wrote:
> > geode-core/src/test/java/org/apache/geode/internal/cache/ClientServerTransactionDUnitTest.java
> > Lines 4115 (patched)
> > 
> >
> > Do we need sleep...

Needed to make sure the race could occur -- keySet op executed during this 
transactions commit.


- Eric


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62506/#review186005
---


On Sept. 22, 2017, 7:12 p.m., Eric Shu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62506/
> ---
> 
> (Updated Sept. 22, 2017, 7:12 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Darrel Schneider, Kirk Lund, 
> Lynn Gallinat, and Nick Reich.
> 
> 
> Bugs: GEODE-3679
> https://issues.apache.org/jira/browse/GEODE-3679
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Sets the originating member id from client transaction in partition message 
> when a server needs to perform operaton and send to other peers.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/PartitionMessage.java
>  8c27107 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/ClientServerTransactionDUnitTest.java
>  96b89b9 
> 
> 
> Diff: https://reviews.apache.org/r/62506/diff/2/
> 
> 
> Testing
> ---
> 
> precheckin.
> 
> 
> Thanks,
> 
> Eric Shu
> 
>

Please don't commit broken javadocs

[Kirk Lund]

I'm seeing newly broken javadocs being committed.

:geode-core:javadoc
/Users/klund/dev/gemfire/open/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/MessageExecutionContext.java:91:
warning - @return tag has no arguments.
1 warning

:geode-protobuf:javadoc/tmp/build/ae3c03f4/geode/geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufUtilities.java:101:
warning - Tag @link: reference not found: BasicTypes.Entry

:geode-assembly:docs
/Users/klund/dev/gemfire/open/geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufUtilities.java:101:
warning - Tag @link: reference not found: BasicTypes.Entry
1 warning

(The assembly module seem to duplicate javadocs -- I have no idea why but
that could be contributing to our stupidly long build time)

My personal IntelliJ configuration is setup to NOT automatically create
javadoc stubs for me -- if you enable that but don't fill those in then
they generate build warnings like the above.

You can also enable IntelliJ inspections to mark broken javadocs with RED
or YELLOW which can help avoid committing broken javadocs.

Thanks,
Kirk

Re: Please don't commit broken javadocs

[Dan Smith]

Regarding the duplicate javadocs from geode-assembly - geode-assembly
builds the public javadocs for all of geode. Each module also builds it's
own javadocs which includes all of the internal methods.

That does point out that everything in geode-protobuf seems to be in non
internal packages, meaning that it's technically part of the public API. I
think this came up before that this stuff should be part of an internal
package. Is anyone working on fixing that?

-Dan

On Fri, Sep 22, 2017 at 2:11 PM, Kirk Lund  wrote:

> I'm seeing newly broken javadocs being committed.
>
> :geode-core:javadoc
> /Users/klund/dev/gemfire/open/geode-core/src/main/java/org/
> apache/geode/internal/cache/tier/sockets/MessageExecutionContext.java:91:
> warning - @return tag has no arguments.
> 1 warning
>
> :geode-protobuf:javadoc/tmp/build/ae3c03f4/geode/geode-
> protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/
> ProtobufUtilities.java:101:
> warning - Tag @link: reference not found: BasicTypes.Entry
>
> :geode-assembly:docs
> /Users/klund/dev/gemfire/open/geode-protobuf/src/main/java/
> org/apache/geode/protocol/protobuf/utilities/ProtobufUtilities.java:101:
> warning - Tag @link: reference not found: BasicTypes.Entry
> 1 warning
>
> (The assembly module seem to duplicate javadocs -- I have no idea why but
> that could be contributing to our stupidly long build time)
>
> My personal IntelliJ configuration is setup to NOT automatically create
> javadoc stubs for me -- if you enable that but don't fill those in then
> they generate build warnings like the above.
>
> You can also enable IntelliJ inspections to mark broken javadocs with RED
> or YELLOW which can help avoid committing broken javadocs.
>
> Thanks,
> Kirk
>

Re: []DISCUSS] Using package names to identify public API's

[Dan Smith]

I found bug GEODE-3473 which was created based on this discussion. I marked
that as requiring a fix for 1.3.0, so we don't ship these protobuf related
internal classes as part of the public API.

-Dan

On Sat, Aug 12, 2017 at 9:42 AM, John Blum  wrote:

> On the flip side of internal vs. external APIs, I definitely feel there are
> many classes under "*.internal" packages that should be reviewed and made
> public.  I realize it increases the surface area of maintainability and
> support for backwards compatibility, but anytime an application needs
> access to the functionality the "internal" API provides, those are good
> candidates.  Keep in mind that there is a huge disparity between the public
> API and cache.xml at the moment and applications coded to the API (rather
> than XML) are going to suffer.
>
> On Fri, Aug 11, 2017 at 11:46 AM, Ernest Burghardt 
> wrote:
>
> > +1 for protobuf being internal as they are not intended to be first class
> > OO citizens you can read more about there here
> >  (the
> > same warning exists for all supported languages btw)
> >
> > On Fri, Aug 11, 2017 at 12:34 PM, Michael William Dodge <
> mdo...@pivotal.io
> > >
> > wrote:
> >
> > > The user shouldn't need to access any of the protobuf classes directly.
> > > I'm in favor of making all of the protobuf-related packages internal,
> > > including any classes generated from .proto files.
> > >
> > > Sarge
> > >
> > > > On 11 Aug, 2017, at 11:30, Anthony Baker  wrote:
> > > >
> > > > We have policies in place for versioning [1] and backwards
> > compatibility
> > > [2].  How do we identify which API’s need to be controlled?
> > > >
> > > > In many cases we use the *.internal.* package naming format to signal
> > > API’s that aren’t subject to backwards compatibility requirements.
> API’s
> > > within these internal packages can change and do change even within
> minor
> > > or patch releases.  If a user creates an application that relies on an
> > > internal API, it may need to be changed during an upgrade.
> > > >
> > > > I’ve noticed that we haven’t been following this convention for some
> > > newer changes (such as in geode-protobuf).  Should we review and modify
> > the
> > > packages names continue using the *.internal.* format?
> > > >
> > > >
> > > > Anthony
> > > >
> > > > [1] https://cwiki.apache.org/confluence/pages/viewpage.
> > > action?pageId=57311457
> > > > [1] https://cwiki.apache.org/confluence/display/GEODE/
> > Managing+Backward+
> > > Compatibility
> > > >
> > >
> > >
> >
>
>
>
> --
> -John
> john.blum10101 (skype)
>

Re: Please don't commit broken javadocs

[Galen O'Sullivan]

We'll move everything to internal soon, before public release.

We have a ticket to fix the Javadocs and the links will be removed soon as
well. The broken links are for generated files that don't seem to have been
created when the javadoc task runs.

On Fri, Sep 22, 2017 at 2:27 PM, Dan Smith  wrote:

> Regarding the duplicate javadocs from geode-assembly - geode-assembly
> builds the public javadocs for all of geode. Each module also builds it's
> own javadocs which includes all of the internal methods.
>
> That does point out that everything in geode-protobuf seems to be in non
> internal packages, meaning that it's technically part of the public API. I
> think this came up before that this stuff should be part of an internal
> package. Is anyone working on fixing that?
>
> -Dan
>
> On Fri, Sep 22, 2017 at 2:11 PM, Kirk Lund  wrote:
>
> > I'm seeing newly broken javadocs being committed.
> >
> > :geode-core:javadoc
> > /Users/klund/dev/gemfire/open/geode-core/src/main/java/org/
> > apache/geode/internal/cache/tier/sockets/MessageExecutionContext.java:
> 91:
> > warning - @return tag has no arguments.
> > 1 warning
> >
> > :geode-protobuf:javadoc/tmp/build/ae3c03f4/geode/geode-
> > protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/
> > ProtobufUtilities.java:101:
> > warning - Tag @link: reference not found: BasicTypes.Entry
> >
> > :geode-assembly:docs
> > /Users/klund/dev/gemfire/open/geode-protobuf/src/main/java/
> > org/apache/geode/protocol/protobuf/utilities/ProtobufUtilities.java:101:
> > warning - Tag @link: reference not found: BasicTypes.Entry
> > 1 warning
> >
> > (The assembly module seem to duplicate javadocs -- I have no idea why but
> > that could be contributing to our stupidly long build time)
> >
> > My personal IntelliJ configuration is setup to NOT automatically create
> > javadoc stubs for me -- if you enable that but don't fill those in then
> > they generate build warnings like the above.
> >
> > You can also enable IntelliJ inspections to mark broken javadocs with RED
> > or YELLOW which can help avoid committing broken javadocs.
> >
> > Thanks,
> > Kirk
> >
>

Re: []DISCUSS] Using package names to identify public API's

[Brian Baynes]

Yep, GEODE-3473 will make it in -- have been waiting for a good moment when
there aren't other items in flight that would need to be rebased.


On Fri, Sep 22, 2017 at 2:31 PM, Dan Smith  wrote:

> I found bug GEODE-3473 which was created based on this discussion. I marked
> that as requiring a fix for 1.3.0, so we don't ship these protobuf related
> internal classes as part of the public API.
>
> -Dan
>
> On Sat, Aug 12, 2017 at 9:42 AM, John Blum  wrote:
>
> > On the flip side of internal vs. external APIs, I definitely feel there
> are
> > many classes under "*.internal" packages that should be reviewed and made
> > public.  I realize it increases the surface area of maintainability and
> > support for backwards compatibility, but anytime an application needs
> > access to the functionality the "internal" API provides, those are good
> > candidates.  Keep in mind that there is a huge disparity between the
> public
> > API and cache.xml at the moment and applications coded to the API (rather
> > than XML) are going to suffer.
> >
> > On Fri, Aug 11, 2017 at 11:46 AM, Ernest Burghardt <
> eburgha...@pivotal.io>
> > wrote:
> >
> > > +1 for protobuf being internal as they are not intended to be first
> class
> > > OO citizens you can read more about there here
> > > 
> (the
> > > same warning exists for all supported languages btw)
> > >
> > > On Fri, Aug 11, 2017 at 12:34 PM, Michael William Dodge <
> > mdo...@pivotal.io
> > > >
> > > wrote:
> > >
> > > > The user shouldn't need to access any of the protobuf classes
> directly.
> > > > I'm in favor of making all of the protobuf-related packages internal,
> > > > including any classes generated from .proto files.
> > > >
> > > > Sarge
> > > >
> > > > > On 11 Aug, 2017, at 11:30, Anthony Baker 
> wrote:
> > > > >
> > > > > We have policies in place for versioning [1] and backwards
> > > compatibility
> > > > [2].  How do we identify which API’s need to be controlled?
> > > > >
> > > > > In many cases we use the *.internal.* package naming format to
> signal
> > > > API’s that aren’t subject to backwards compatibility requirements.
> > API’s
> > > > within these internal packages can change and do change even within
> > minor
> > > > or patch releases.  If a user creates an application that relies on
> an
> > > > internal API, it may need to be changed during an upgrade.
> > > > >
> > > > > I’ve noticed that we haven’t been following this convention for
> some
> > > > newer changes (such as in geode-protobuf).  Should we review and
> modify
> > > the
> > > > packages names continue using the *.internal.* format?
> > > > >
> > > > >
> > > > > Anthony
> > > > >
> > > > > [1] https://cwiki.apache.org/confluence/pages/viewpage.
> > > > action?pageId=57311457
> > > > > [1] https://cwiki.apache.org/confluence/display/GEODE/
> > > Managing+Backward+
> > > > Compatibility
> > > > >
> > > >
> > > >
> > >
> >
> >
> >
> > --
> > -John
> > john.blum10101 (skype)
> >
>

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #687 was SUCCESSFUL (with 2042 tests)

[Spring CI]

---
Spring Data GemFire > Nightly-ApacheGeode > #687 was successful.
---
Scheduled
2044 tests in total.

https://build.spring.io/browse/SGF-NAG-687/





--
This message is automatically generated by Atlassian Bamboo

Broken: apache/geode-native#436 (develop - aa997cd)

[Travis CI]

Build Update for apache/geode-native
-

Build: #436
Status: Broken

Duration: 12 minutes and 41 seconds
Commit: aa997cd (develop)
Author: Jacob Barrett
Message: GEODE-3630: Change to void Serializable::fromData(...)

 - Change .NET to void Serializable::FromData(...)
 - Fixes deserialization of PDX on .NET.

View the changeset: 
https://github.com/apache/geode-native/compare/b0545b7d9739...aa997cd3d372

View the full build log and details: 
https://travis-ci.org/apache/geode-native/builds/278760638?utm_source=email&utm_medium=notification

--

You can configure recipients for build notifications in your .travis.yml file. 
See https://docs.travis-ci.com/user/notifications

Broken: apache/geode#3961 (develop - 1de8b77)

[Travis CI]

Build Update for apache/geode
-

Build: #3961
Status: Broken

Duration: 13 minutes and 11 seconds
Commit: 1de8b77 (develop)
Author: Patrick Rhomberg
Message: GEODE-3539: Add missing test coverage for 'describe config' command.

This closes #800.

View the changeset: 
https://github.com/apache/geode/compare/2cb5f92b1764...1de8b77fbf32

View the full build log and details: 
https://travis-ci.org/apache/geode/builds/278788803?utm_source=email&utm_medium=notification

--

You can configure recipients for build notifications in your .travis.yml file. 
See https://docs.travis-ci.com/user/notifications

Broken: apache/geode#3959 (develop - 2cb5f92)

[Travis CI]

Build Update for apache/geode
-

Build: #3959
Status: Broken

Duration: 13 minutes and 37 seconds
Commit: 2cb5f92 (develop)
Author: Jared Stewart
Message: GEODE-3618: Move GfshRule into geode-junit

This closes #781.

View the changeset: 
https://github.com/apache/geode/compare/2fc6f523379e...2cb5f92b1764

View the full build log and details: 
https://travis-ci.org/apache/geode/builds/278785434?utm_source=email&utm_medium=notification

--

You can configure recipients for build notifications in your .travis.yml file. 
See https://docs.travis-ci.com/user/notifications

Fixed: apache/geode#3962 (develop - 1779a94)

[Travis CI]

Build Update for apache/geode
-

Build: #3962
Status: Fixed

Duration: 13 minutes and 48 seconds
Commit: 1779a94 (develop)
Author: Jared Stewart
Message: Fix compilation failures from rebase conflict

View the changeset: 
https://github.com/apache/geode/compare/1de8b77fbf32...1779a942d70f

View the full build log and details: 
https://travis-ci.org/apache/geode/builds/278795984?utm_source=email&utm_medium=notification

--

You can configure recipients for build notifications in your .travis.yml file. 
See https://docs.travis-ci.com/user/notifications

Fixed: apache/geode#3963 (develop - bbfdb06)

[Travis CI]

Build Update for apache/geode
-

Build: #3963
Status: Fixed

Duration: 12 minutes and 20 seconds
Commit: bbfdb06 (develop)
Author: Dan Smith
Message: Adding a new framework for concurrency testing in geode (#787)

* Adding a new framework for concurrency testing in geode

Added a new junit runner, ConcurrentTestRunner, for running a test that
has parallel threads.

The runner currently runs the test using Java PathFinder, which will
run the test with all interleavings of the threads.

Added an example test to geode-core for the FilterProfile serialization
logic.

* Adding configuration options for TestRunners and removing warmup

Adding options to configure which concurrent test runner to use, and
adding configuration for the JPF runner to pass jpf properties.

Adding an alternative runner which just runs the test in a loop.

Removing the warmup from the FilterProfileTest. It turns out most of the
work was in calling static initializers, especially for logging classes.
Disabling choice generation in static final initialization, and
disabling the logger entirely.

View the changeset: 
https://github.com/apache/geode/compare/1779a942d70f...bbfdb06fc919

View the full build log and details: 
https://travis-ci.org/apache/geode/builds/278797452?utm_source=email&utm_medium=notification

--

You can configure recipients for build notifications in your .travis.yml file. 
See https://docs.travis-ci.com/user/notifications