[GitHub] geode pull request #664: Fix for GEODE-3292

[jujoramos]

GitHub user jujoramos opened a pull request:

https://github.com/apache/geode/pull/664

Fix for GEODE-3292

Embedded PULSE Connection Failure When jmx-manager-bind-address != localhost

- ManagementAgent sets the 'pulse.host' system property whenever a 
'jmx-manager-bind-address' is configured.
- PULSE gets the hostname of the local JMX Manager through the 'pulse.host' 
system property, reverting to 'localhost' by default.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [X] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [X] Is your initial contribution a single, squashed commit?

- [X] Does `gradlew build` run cleanly?

- [X] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jujoramos/geode feature/GEODE-3292

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/664.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #664


commit 0c3e15f619ddd08f02ba8e2a8818f22d308c8bde
Author: Juan Jose Ramos Cassella 
Date:   2017-07-28T09:55:20Z

GEODE-3292: Embedded PULSE Connection Failure When jmx-manager-bind-address 
!= localhost

- ManagementAgent sets the 'pulse.host' system property whenever a 
'jmx-manager-bind-address' is configured.
- PULSE gets the hostname of the local JMX Manager through the 'pulse.host' 
system property, reverting to 'localhost' by default.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 61196: GEODE-3326: Fix intermittent ConcurrentDeployDUnitTest failure

[Ken Howe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61196/#review181674
---


Ship it!




Ship It!

- Ken Howe


On July 27, 2017, 10:22 p.m., Jared Stewart wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61196/
> ---
> 
> (Updated July 27, 2017, 10:22 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
> Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-3326: Fix intermittent ConcurrentDeployDUnitTest failure
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ConcurrentDeployDUnitTest.java
>  559440c8a2f227de092e52979d9db1f959a5d75f 
> 
> 
> Diff: https://reviews.apache.org/r/61196/diff/1/
> 
> 
> Testing
> ---
> 
> Precheckin running
> 
> 
> Thanks,
> 
> Jared Stewart
> 
>

[GitHub] geode issue #663: GEODE-3314: Fix DLockService token leak.

[pivotal-amurmann]

Github user pivotal-amurmann commented on the issue:

https://github.com/apache/geode/pull/663
  
I am sure it would be hard, but could we please write a unit test for the 
change that was made to `DLockService#unlock`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #660: GEODE-2924 Revise authorization permissions

[PurelyApplied]

Github user PurelyApplied commented on the issue:

https://github.com/apache/geode/pull/660
  
+1.  For future reference, tickets GEODE-2920 through GEODE-2926 were 
committed under the overarching ticket 
[GEODE-2919](https://issues.apache.org/jira/browse/GEODE-2919) in commit 
`451d12e8...`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #663: GEODE-3314: Fix DLockService token leak.

[galen-pivotal]

Github user galen-pivotal commented on the issue:

https://github.com/apache/geode/pull/663
  
We probably can write a unit test. In particular, it would be nice if we 
could test this bug without starting a whole `Cache`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #660: GEODE-2924 Revise authorization permissions

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/660


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 61196: GEODE-3326: Fix intermittent ConcurrentDeployDUnitTest failure

[Jinmei Liao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61196/#review181685
---


Ship it!




Ship It!

- Jinmei Liao


On July 27, 2017, 10:22 p.m., Jared Stewart wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61196/
> ---
> 
> (Updated July 27, 2017, 10:22 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
> Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-3326: Fix intermittent ConcurrentDeployDUnitTest failure
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ConcurrentDeployDUnitTest.java
>  559440c8a2f227de092e52979d9db1f959a5d75f 
> 
> 
> Diff: https://reviews.apache.org/r/61196/diff/1/
> 
> 
> Testing
> ---
> 
> Precheckin running
> 
> 
> Thanks,
> 
> Jared Stewart
> 
>

Re: Review Request 61166: GEODE-3313: Test utility supports building jar files with multiple classes

[Jinmei Liao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61166/#review181686
---


Ship it!




Some javadoc on how to use thes test utilities would be helpful.

- Jinmei Liao


On July 27, 2017, 11:29 p.m., Jared Stewart wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61166/
> ---
> 
> (Updated July 27, 2017, 11:29 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
> Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-3313: Test utility supports building jar files with multiple classes
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/ClassNameExtractor.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/ClassNameExtractorTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/CompiledSourceCode.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/JarBuilder.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/JarBuilderTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/JavaCompiler.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/JavaCompilerTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/UncompiledSourceCode.java
>  PRE-CREATION 
>   
> geode-core/src/test/resources/org/apache/geode/management/internal/deployment/compiler/AbstractExtendsFunctionAdapter.java
>  PRE-CREATION 
>   
> geode-core/src/test/resources/org/apache/geode/management/internal/deployment/compiler/AbstractFunction.java
>  PRE-CREATION 
>   
> geode-core/src/test/resources/org/apache/geode/management/internal/deployment/compiler/ConcreteExtendsAbstractExtendsFunctionAdapter.java
>  PRE-CREATION 
>   
> geode-core/src/test/resources/org/apache/geode/management/internal/deployment/compiler/ExtendsAbstractFunction.java
>  PRE-CREATION 
>   
> geode-core/src/test/resources/org/apache/geode/management/internal/deployment/compiler/ExtendsFunctionAdapter.java
>  PRE-CREATION 
>   
> geode-core/src/test/resources/org/apache/geode/management/internal/deployment/compiler/ImplementsFunction.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/61166/diff/3/
> 
> 
> Testing
> ---
> 
> Precheckin running
> 
> 
> Thanks,
> 
> Jared Stewart
> 
>

[GitHub] geode pull request #665: GEODE-3254: Refactoring ConfigCommands and ConfigCo...

[YehEmily]

GitHub user YehEmily opened a pull request:

https://github.com/apache/geode/pull/665

GEODE-3254: Refactoring ConfigCommands and ConfigCommandsDUnitTest

[View the JIRA ticket 
here.](https://issues.apache.org/jira/browse/GEODE-3254)

`ConfigCommands.java` was a large class that contained multiple commands. 
Each command was refactored into a separate class. 
`ConfigCommandsDUnitTest.java` was also split into separate test classes.

- [x] JIRA ticket referenced

- [x] PR rebased

- [x] Single squashed commit

- [x] Builds cleanly

- [x] Tests updated

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/YehEmily/geode GEODE-3254

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/665.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #665


commit 11c88b725eee219e5ec90e546d6e6fa1709a1b16
Author: YehEmily 
Date:   2017-07-26T18:07:09Z

GEODE-3254: Refactoring ConfigCommands and ConfigCommandsDUnitTest




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: Geode-nightly #909

[Apache Jenkins Server]

See 


Changes:

[ukohlmeyer] GEODE-3192,GEODE-3229: Change API and implementation of protobuf 
PutAll.

[jiliao] GEODE-3231: use tempWorkingFolder to avoid test log file contamination

[nnag] GEODE-3301: Cargo installs now delete left over directories

[dschneider] GEODE-231: Remove deprecated AttributesMutator.setCacheListener

[eshu] GEODE-3310: Set target node in TXStateProxy during TXFailover

[eshu] GEODE-3310: Avoid running a test case in distributed transaction.

--
[...truncated 112.50 KB...]
Note: Recompile with -Xlint:unchecked for details.

:geode-cq:processTestResources
:geode-cq:testClasses
:geode-cq:checkMissedTests
:geode-cq:spotlessJavaCheck
:geode-cq:spotlessCheck
:geode-cq:test
:geode-cq:check
:geode-cq:build
:geode-cq:distributedTest
:geode-cq:integrationTest
:geode-json:assemble
:geode-json:compileTestJava UP-TO-DATE
:geode-json:processTestResources
:geode-json:testClasses
:geode-json:checkMissedTests UP-TO-DATE
:geode-json:spotlessJavaCheck
:geode-json:spotlessCheck
:geode-json:test UP-TO-DATE
:geode-json:check
:geode-json:build
:geode-json:distributedTest UP-TO-DATE
:geode-json:integrationTest UP-TO-DATE
:geode-junit:javadoc
:geode-junit:javadocJar
:geode-junit:sourcesJar
:geode-junit:signArchives SKIPPED
:geode-junit:assemble
:geode-junit:compileTestJava
:geode-junit:processTestResources UP-TO-DATE
:geode-junit:testClasses
:geode-junit:checkMissedTests
:geode-junit:spotlessJavaCheck
:geode-junit:spotlessCheck
:geode-junit:test
:geode-junit:check
:geode-junit:build
:geode-junit:distributedTest
:geode-junit:integrationTest
:geode-lucene:assemble
:geode-lucene:compileTestJavaNote: Some input files use or override a 
deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-lucene:processTestResources
:geode-lucene:testClasses
:geode-lucene:checkMissedTests
:geode-lucene:spotlessJavaCheck
:geode-lucene:spotlessCheck
:geode-lucene:test
:geode-lucene:check
:geode-lucene:build
:geode-lucene:distributedTest
:geode-lucene:integrationTest
:geode-old-client-support:assemble
:geode-old-client-support:compileTestJavaNote: 

 uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.

:geode-old-client-support:processTestResources UP-TO-DATE
:geode-old-client-support:testClasses
:geode-old-client-support:checkMissedTests
:geode-old-client-support:spotlessJavaCheck
:geode-old-client-support:spotlessCheck
:geode-old-client-support:test
:geode-old-client-support:check
:geode-old-client-support:build
:geode-old-client-support:distributedTest
:geode-old-client-support:integrationTest
:geode-old-versions:javadoc UP-TO-DATE
:geode-old-versions:javadocJar
:geode-old-versions:sourcesJar
:geode-old-versions:signArchives SKIPPED
:geode-old-versions:assemble
:geode-old-versions:compileTestJava UP-TO-DATE
:geode-old-versions:processTestResources UP-TO-DATE
:geode-old-versions:testClasses UP-TO-DATE
:geode-old-versions:checkMissedTests UP-TO-DATE
:geode-old-versions:spotlessJavaCheck
:geode-old-versions:spotlessCheck
:geode-old-versions:test UP-TO-DATE
:geode-old-versions:check
:geode-old-versions:build
:geode-old-versions:distributedTest UP-TO-DATE
:geode-old-versions:integrationTest UP-TO-DATE
:geode-protobuf:assemble
:geode-protobuf:extractIncludeTestProto
:geode-protobuf:extractTestProto UP-TO-DATE
:geode-protobuf:generateTestProto UP-TO-DATE
:geode-protobuf:compileTestJavaNote: Some input files use unchecked or unsafe 
operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-protobuf:processTestResources
:geode-protobuf:testClasses
:geode-protobuf:checkMissedTests
:geode-protobuf:spotlessJavaCheck
:geode-protobuf:spotlessCheck
:geode-protobuf:test
:geode-protobuf:check
:geode-protobuf:build
:geode-protobuf:distributedTest
:geode-protobuf:integrationTest
:geode-pulse:assemble
:geode-pulse:compileTestJavaNote: Some input files use or override a deprecated 
API.
Note: Recompile with -Xlint:deprecation for details.
Note: 

 uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-pulse:processTestResources
:geode-pulse:testClasses
:geode-pulse:checkMissedTests
:geode-pulse:spotlessJavaCheck
:geode-pulse:spotlessCheck
:geode-pulse:test
:geode-pulse:check
:geode-pulse:build
:geode-pulse:distributedTest
:geode-pulse:integrationTest
:geode-rebalancer:assemble
:geode-rebalancer:compileTestJava
:geode-rebalancer:processTestResources UP-TO-DATE
:geode-rebalancer:testClasses
:geode-rebalancer:checkMissed

[GitHub] geode pull request #666: GEODE-3329: Changed logging output of modify_war sc...

[DivineEnder]

GitHub user DivineEnder opened a pull request:

https://github.com/apache/geode/pull/666

GEODE-3329: Changed logging output of modify_war script

Changed the modify_war script so that its output and error streams write to 
a log file instead of to standard out.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/DivineEnder/geode feature/GEODE-3329

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/666.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #666


commit 0fb270a5916d32e00847b48a7fd9de2bc2b566af
Author: David Anuta 
Date:   2017-07-28T17:49:36Z

GEODE-3329: Changed logging output of modify_war script

Changed the modify_war script so that its output and error streams write to 
a log file instead of to standard out.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #666: GEODE-3329: Changed logging output of modify_war script

[DivineEnder]

Github user DivineEnder commented on the issue:

https://github.com/apache/geode/pull/666
  
@ladyVader @nabarunnag @boglesby @jhuynh1 @upthewaterspout @gesterzhou 
@PurelyApplied


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Review Request 61224: GEODE-3318: Fix UniversalMembershipListenerAdapterDUnitTest

[Jared Stewart]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61224/
---

Review request for geode, Emily Yeh, Galen O'Sullivan, Jared Stewart, Ken Howe, 
Kirk Lund, and Patrick Rhomberg.


Repository: geode


Description
---

GEODE-3318: Fix UniversalMembershipListenerAdapterDUnitTest


Diffs
-

  
geode-core/src/test/java/org/apache/geode/management/UniversalMembershipListenerAdapterDUnitTest.java
 d6f25792ce3a0f540b5722c4dfe3ad7de2d142a9 


Diff: https://reviews.apache.org/r/61224/diff/1/


Testing
---


Thanks,

Jared Stewart

[GitHub] geode issue #591: GEODE-3073: Renamed OrderByComparatorUnmapped to OrderByCo...

[YehEmily]

Github user YehEmily commented on the issue:

https://github.com/apache/geode/pull/591
  
@kirklund The conflicts have been fixed! Thanks for looking over this!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 61224: GEODE-3318: Fix UniversalMembershipListenerAdapterDUnitTest

[Jinmei Liao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61224/#review181715
---


Ship it!




Ship It!

- Jinmei Liao


On July 28, 2017, 6:23 p.m., Jared Stewart wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61224/
> ---
> 
> (Updated July 28, 2017, 6:23 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Galen O'Sullivan, Jared Stewart, Ken 
> Howe, Kirk Lund, and Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-3318: Fix UniversalMembershipListenerAdapterDUnitTest
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/test/java/org/apache/geode/management/UniversalMembershipListenerAdapterDUnitTest.java
>  d6f25792ce3a0f540b5722c4dfe3ad7de2d142a9 
> 
> 
> Diff: https://reviews.apache.org/r/61224/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jared Stewart
> 
>

Review Request 61231: GEODE-3328: simply extract connect command from ShellCommand

[Jinmei Liao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61231/
---

Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
Patrick Rhomberg.


Repository: geode


Description
---

I am working on GEM-1575 which involves prompting for ssl configuration 
properties when connecting to the cluster. So I refactoring the ConnectCommand 
before doing that.
This is the first step: simply extracting the command to its separate class 
without any refactor at all

GEODE-3328: simply extract connect command from ShellCommand


Diffs
-

  geode-core/src/main/java/org/apache/geode/internal/util/PasswordUtil.java 
ac0b8459e1cd8f399eed5e98bd9d5fbd4953f9c3 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ConnectCommand.java
 PRE-CREATION 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ShellCommands.java
 d5e1b27715420818e9a63c9bd467d771e5ee20e3 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/StartLocatorCommand.java
 10dc0db871898b4fe95027baeacfc72f0e16d4a3 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/util/GfshConsoleReader.java
 80a20e6d075f2b7c9202df96f36aa4c99c445e04 
  
geode-core/src/test/java/org/apache/geode/internal/util/PasswordUtilJUnitTest.java
 8051c5671650ad4f4756f9f614778d1ae1387fa7 


Diff: https://reviews.apache.org/r/61231/diff/1/


Testing
---

precheckin running


Thanks,

Jinmei Liao

[GitHub] geode issue #666: GEODE-3329: Changed logging output of modify_war script

[PurelyApplied]

Github user PurelyApplied commented on the issue:

https://github.com/apache/geode/pull/666
  
Thanks for the quick turn around on this!  +0.5, since I don't really know 
this corner of the code, but it looks good to me!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 61166: GEODE-3313: Test utility supports building jar files with multiple classes

[Jared Stewart]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61166/
---

(Updated July 28, 2017, 10:46 p.m.)


Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
Patrick Rhomberg.


Changes
---

Added javadoc to explain usage. 
Fixed flaky test.


Repository: geode


Description
---

GEODE-3313: Test utility supports building jar files with multiple classes


Diffs (updated)
-

  
geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/ClassNameExtractor.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/ClassNameExtractorTest.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/CompiledSourceCode.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/JarBuilder.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/JarBuilderTest.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/JavaCompiler.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/JavaCompilerTest.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/UncompiledSourceCode.java
 PRE-CREATION 
  
geode-core/src/test/resources/org/apache/geode/management/internal/deployment/compiler/AbstractExtendsFunctionAdapter.java
 PRE-CREATION 
  
geode-core/src/test/resources/org/apache/geode/management/internal/deployment/compiler/AbstractFunction.java
 PRE-CREATION 
  
geode-core/src/test/resources/org/apache/geode/management/internal/deployment/compiler/ConcreteExtendsAbstractExtendsFunctionAdapter.java
 PRE-CREATION 
  
geode-core/src/test/resources/org/apache/geode/management/internal/deployment/compiler/ExtendsAbstractFunction.java
 PRE-CREATION 
  
geode-core/src/test/resources/org/apache/geode/management/internal/deployment/compiler/ExtendsFunctionAdapter.java
 PRE-CREATION 
  
geode-core/src/test/resources/org/apache/geode/management/internal/deployment/compiler/ImplementsFunction.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/61166/diff/4/

Changes: https://reviews.apache.org/r/61166/diff/3-4/


Testing
---

Precheckin running


Thanks,

Jared Stewart

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #630 was SUCCESSFUL (with 1987 tests). Change made by John Blum.

[Spring CI]

---
Spring Data GemFire > Nightly-ApacheGeode > #630 was successful.
---
Scheduled with changes by John Blum.
1989 tests in total.

https://build.spring.io/browse/SGF-NAG-630/




--
Code Changes
--
John Blum (61257ce010d3a5e1b137d39f77e6db95753435da):

>DATAGEODE-30 - Fix Reference Guide formatting.
>Fix typo in region.adoc involving the Local Region example.



--
This message is automatically generated by Atlassian Bamboo

[GitHub] geode pull request #667: GEODE-3324 Document finer-grained security permissi...

[karensmolermiller]

GitHub user karensmolermiller opened a pull request:

https://github.com/apache/geode/pull/667

GEODE-3324 Document finer-grained security permissions

@jinmeiliao @PurelyApplied @jaredjstewart @joeymcallister @davebarnes97  
Please review.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/karensmolermiller/geode feature/GEODE-3324

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/667.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #667


commit a15607152384e43ad16b495850596ee389cf1903
Author: Karen Miller 
Date:   2017-07-28T22:59:55Z

GEODE-3324 Document finer-grained security permissions




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

new Wiki page on Locator internals

[Bruce Schuchardt]

Ever wonder what's in a Geode Locator?

https://cwiki.apache.org/confluence/display/GEODE/Locator+Architecture

Re: GMSJoinLeaveJUnitTest failing on develop

[Bruce Schuchardt]

(GEODE-3155) GMSJoinLeaveJUnitTest.testCoordinatorFindRequestSuccess 
failing in CI


This was caused by a checkin from Hitesh on 7/14


On 7/27/17 4:43 PM, Patrick Rhomberg wrote:

I don't see a JIRA for it, but it's been failing sporadically for me on my
precheckins.

On Tue, Jul 25, 2017 at 10:41 AM, Kirk Lund  wrote:


Is someone working on this test? It fails consistently for me on develop...

./gradlew -DintegrationTest.single=GMSJoinLeaveJUnitTest
geode-core:integrationTest

org.apache.geode.distributed.internal.membership.gms.membership.
GMSJoinLeaveJUnitTest

testViewNotSentWhenShuttingDown FAILED

 java.lang.AssertionError
 at org.junit.Assert.fail(Assert.java:86)
 at org.junit.Assert.assertTrue(Assert.java:41)
 at org.junit.Assert.assertTrue(Assert.java:52)
 at
org.apache.geode.distributed.internal.membership.gms.membership.
GMSJoinLeaveJUnitTest.testViewNotSentWhenShuttingDow
n(GMSJoinLeaveJUnitTest.java:1157)

Re: GMSJoinLeaveJUnitTest failing on develop

[Galen O'Sullivan]

I just filed GEODE- for GMSJoinLeaveJUnitTest.
testViewNotSentWhenShuttingDown . I've gotten a failure from the command
line, but not when I run it from within IntelliJ (even repeatedly).

On Fri, Jul 28, 2017 at 4:12 PM, Bruce Schuchardt 
wrote:

> (GEODE-3155) GMSJoinLeaveJUnitTest.testCoordinatorFindRequestSuccess
> failing in CI
>
> This was caused by a checkin from Hitesh on 7/14
>
>
>
> On 7/27/17 4:43 PM, Patrick Rhomberg wrote:
>
>> I don't see a JIRA for it, but it's been failing sporadically for me on my
>> precheckins.
>>
>> On Tue, Jul 25, 2017 at 10:41 AM, Kirk Lund  wrote:
>>
>> Is someone working on this test? It fails consistently for me on
>>> develop...
>>>
>>> ./gradlew -DintegrationTest.single=GMSJoinLeaveJUnitTest
>>> geode-core:integrationTest
>>>
>>> org.apache.geode.distributed.internal.membership.gms.membership.
>>> GMSJoinLeaveJUnitTest
>>>
 testViewNotSentWhenShuttingDown FAILED

>>>  java.lang.AssertionError
>>>  at org.junit.Assert.fail(Assert.java:86)
>>>  at org.junit.Assert.assertTrue(Assert.java:41)
>>>  at org.junit.Assert.assertTrue(Assert.java:52)
>>>  at
>>> org.apache.geode.distributed.internal.membership.gms.membership.
>>> GMSJoinLeaveJUnitTest.testViewNotSentWhenShuttingDow
>>> n(GMSJoinLeaveJUnitTest.java:1157)
>>>
>>>
>