Re: Review Request 60550: GEODE-3154: add geode-protobuf to expected_jars.txt

2017-06-30 Thread Brian Rowe 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60550/#review179374
---


Ship it!




Ship It!

- Brian Rowe


On June 29, 2017, 9:39 p.m., Galen O'Sullivan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60550/
> ---
> 
> (Updated June 29, 2017, 9:39 p.m.)
> 
> 
> Review request for geode, Alexander Murmann, Barry Oglesby, Bruce Schuchardt, 
> Hitesh Khamesra, Udo Kohlmeyer, and Brian Rowe.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Currently BundledJarsJUnitTest is failing because we added geode-protobuf to 
> geode-assembly but not to the `expected_jars.txt` file, which tells us which 
> jars we expect. This one-liner adds it. This should keep builds from failing.
> 
> 
> Diffs
> -
> 
>   geode-assembly/src/test/resources/expected_jars.txt 62601677f 
> 
> 
> Diff: https://reviews.apache.org/r/60550/diff/1/
> 
> 
> Testing
> ---
> 
> Built on my machine, verified that the test passes.
> 
> 
> Thanks,
> 
> Galen O'Sullivan
> 
>

Review Request 60570: GEODE-3072 Events do not get removed from the client queue when 1.0 clients connect to 1.2 servers

2017-06-30 Thread Bruce Schuchardt 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60570/
---

Review request for geode and Barry Oglesby.


Bugs: GEODE-3072
https://issues.apache.org/jira/browse/GEODE-3072


Repository: geode


Description
---

Another problem was found in backward-compatibility testing.  If a 1.0.0 client 
was receiving subscription events generated by a 1.0.0 peer "feeder" member and 
the events were routed through a 1.0.0 server the client might see duplicate 
events when the server is stopped and the client fails over to a 1.2.0 server 
holding its redundant subscription queue.  This is especially possible if a 
large "ack" period is established in the client.

The problem stems from the EventID deserialization/reserialization of the 
memberID bytes when sending to a 1.0 client.  It was deserializing using 
Version.CURRENT, which ignores the UUID bytes in the serialized ID.  Then it 
serialized the identifier using the client's version, which includes the UUID 
bytes but which are zero due to the version used in deserialization.


Diffs
-

  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java
 bc3d708da2ae9a8e386accb8d15e2ed49123241e 
  geode-core/src/main/java/org/apache/geode/internal/cache/EventID.java 
55c89f1f2e0800371dd4a30c4312c44f942a45ea 
  
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscBCDUnitTest.java
 bc48d976096fafe2545e707da68dab5120ddca51 
  
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscDUnitTest.java
 bfe4646b9abdf6075e8d30fab3d79924faade2aa 
  
geode-core/src/test/resources/org/apache/geode/codeAnalysis/sanctionedDataSerializables.txt
 b69e004d63d74eccd5cd562ea269363ba3f2782e 


Diff: https://reviews.apache.org/r/60570/diff/1/


Testing
---

new unit tests, precheckin


Thanks,

Bruce Schuchardt

Build failed in Jenkins: Geode-nightly #882

2017-06-30 Thread Apache Jenkins Server 
See 


Changes:

[upthewaterspout] GEODE-393: Providing cache for FunctionContext

[upthewaterspout] GEODE-2018: Added instantiators to SessionCachingFilter init 
method

[upthewaterspout] GEODE-3140: Removed DiskDirRule and replaced use with 
TemporaryFolder

[hkhamesra] GEODE-3154 Add geode-protobuf to expected_jars

[eshu] GEODE-3147: Set commBuffer for threads performing TXSynchronization

--
[...truncated 109.17 KB...]
:geode-json:compileTestJava UP-TO-DATE
:geode-json:processTestResources
:geode-json:testClasses
:geode-json:checkMissedTests UP-TO-DATE
:geode-json:spotlessJavaCheck
:geode-json:spotlessCheck
:geode-json:test UP-TO-DATE
:geode-json:check
:geode-json:build
:geode-json:distributedTest UP-TO-DATE
:geode-json:integrationTest UP-TO-DATE
:geode-junit:javadoc
:geode-junit:javadocJar
:geode-junit:sourcesJar
:geode-junit:signArchives SKIPPED
:geode-junit:assemble
:geode-junit:compileTestJava
:geode-junit:processTestResources UP-TO-DATE
:geode-junit:testClasses
:geode-junit:checkMissedTests
:geode-junit:spotlessJavaCheck
:geode-junit:spotlessCheck
:geode-junit:test
:geode-junit:check
:geode-junit:build
:geode-junit:distributedTest
:geode-junit:integrationTest
:geode-lucene:assemble
:geode-lucene:compileTestJavaNote: Some input files use or override a 
deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-lucene:processTestResources
:geode-lucene:testClasses
:geode-lucene:checkMissedTests
:geode-lucene:spotlessJavaCheck
:geode-lucene:spotlessCheck
:geode-lucene:test
:geode-lucene:check
:geode-lucene:build
:geode-lucene:distributedTest
:geode-lucene:integrationTest
:geode-old-client-support:assemble
:geode-old-client-support:compileTestJavaNote: 

 uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.

:geode-old-client-support:processTestResources UP-TO-DATE
:geode-old-client-support:testClasses
:geode-old-client-support:checkMissedTests
:geode-old-client-support:spotlessJavaCheck
:geode-old-client-support:spotlessCheck
:geode-old-client-support:test
:geode-old-client-support:check
:geode-old-client-support:build
:geode-old-client-support:distributedTest
:geode-old-client-support:integrationTest
:geode-old-versions:javadoc UP-TO-DATE
:geode-old-versions:javadocJar
:geode-old-versions:sourcesJar
:geode-old-versions:signArchives SKIPPED
:geode-old-versions:assemble
:geode-old-versions:compileTestJava UP-TO-DATE
:geode-old-versions:processTestResources UP-TO-DATE
:geode-old-versions:testClasses UP-TO-DATE
:geode-old-versions:checkMissedTests UP-TO-DATE
:geode-old-versions:spotlessJavaCheck
:geode-old-versions:spotlessCheck
:geode-old-versions:test UP-TO-DATE
:geode-old-versions:check
:geode-old-versions:build
:geode-old-versions:distributedTest UP-TO-DATE
:geode-old-versions:integrationTest UP-TO-DATE
:geode-protobuf:assemble
:geode-protobuf:extractIncludeTestProto
Download 
https://repo1.maven.org/maven2/org/powermock/powermock-api-mockito/1.7.0RC4/powermock-api-mockito-1.7.0RC4.pom
Download 
https://repo1.maven.org/maven2/org/powermock/powermock-api-mockito/1.7.0RC4/powermock-api-mockito-1.7.0RC4.jar
:geode-protobuf:extractTestProto
:geode-protobuf:generateTestProto UP-TO-DATE
:geode-protobuf:compileTestJavaNote: Some input files use or override a 
deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-protobuf:processTestResources UP-TO-DATE
:geode-protobuf:testClasses
:geode-protobuf:checkMissedTests
:geode-protobuf:spotlessJavaCheck
:geode-protobuf:spotlessCheck
:geode-protobuf:test
:geode-protobuf:check
:geode-protobuf:build
:geode-protobuf:distributedTest
:geode-protobuf:integrationTest
:geode-pulse:assemble
:geode-pulse:compileTestJavaNote: Some input files use or override a deprecated 
API.
Note: Recompile with -Xlint:deprecation for details.
Note: 

 uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-pulse:processTestResources
:geode-pulse:testClasses
:geode-pulse:checkMissedTests
:geode-pulse:spotlessJavaCheck
:geode-pulse:spotlessCheck
:geode-pulse:test
:geode-pulse:check
:geode-pulse:build
:geode-pulse:distributedTest
:geode-pulse:integrationTest
:geode-rebalancer:assemble
:geode-rebalancer:compileTestJava
:geode-rebalancer:processTestResources UP-TO-DATE
:geode-rebalancer:testClasses
:geode-rebalancer:checkMissedTests
:geode-rebalancer:spotles

Re: Review Request 60570: GEODE-3153 Client receives duplicate events during rolling upgrade

2017-06-30 Thread Bruce Schuchardt 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60570/
---

(Updated June 30, 2017, 9:33 a.m.)


Review request for geode, Alexander Murmann, Barry Oglesby, Galen O'Sullivan, 
Hitesh Khamesra, and Brian Rowe.


Summary (updated)
-

GEODE-3153 Client receives duplicate events during rolling upgrade


Bugs: GEODE-3153
https://issues.apache.org/jira/browse/GEODE-3153


Repository: geode


Description
---

Another problem was found in backward-compatibility testing.  If a 1.0.0 client 
was receiving subscription events generated by a 1.0.0 peer "feeder" member and 
the events were routed through a 1.0.0 server the client might see duplicate 
events when the server is stopped and the client fails over to a 1.2.0 server 
holding its redundant subscription queue.  This is especially possible if a 
large "ack" period is established in the client.

The problem stems from the EventID deserialization/reserialization of the 
memberID bytes when sending to a 1.0 client.  It was deserializing using 
Version.CURRENT, which ignores the UUID bytes in the serialized ID.  Then it 
serialized the identifier using the client's version, which includes the UUID 
bytes but which are zero due to the version used in deserialization.


Diffs
-

  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java
 bc3d708da2ae9a8e386accb8d15e2ed49123241e 
  geode-core/src/main/java/org/apache/geode/internal/cache/EventID.java 
55c89f1f2e0800371dd4a30c4312c44f942a45ea 
  
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscBCDUnitTest.java
 bc48d976096fafe2545e707da68dab5120ddca51 
  
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscDUnitTest.java
 bfe4646b9abdf6075e8d30fab3d79924faade2aa 
  
geode-core/src/test/resources/org/apache/geode/codeAnalysis/sanctionedDataSerializables.txt
 b69e004d63d74eccd5cd562ea269363ba3f2782e 


Diff: https://reviews.apache.org/r/60570/diff/1/


Testing
---

new unit tests, precheckin


Thanks,

Bruce Schuchardt

Re: Review Request 60312: GEODE-2804 Cache InetAddress if configure host as ip string.

2017-06-30 Thread Bruce Schuchardt 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60312/#review179382
---


Ship it!




Ship It!

- Bruce Schuchardt


On June 29, 2017, 3:27 p.m., Hitesh Khamesra wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60312/
> ---
> 
> (Updated June 29, 2017, 3:27 p.m.)
> 
> 
> Review request for geode, Alexander Murmann, Bruce Schuchardt, and Galen 
> O'Sullivan.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2804 Cache InetAddress if configure host as ip string.
> 
> 1. We keep configure host string in HostAddress class
> 2. We reuse InetsocketAddress if it is ipString.
> 3. Client has logic to retry thus we keep InetsocketAddress even if 
>it is not ip string.
> 
> GEODE-3017 IPv6 issue on windows. Above changes fixed this issue.
> 
> GEODE-2940 Now we don't validate configure host string on start. As
> there is possibility that host may not available.
> 
> 1. Earlier wan config were failing because of that. Now we just keep
> those configure host string. And try this later.
> 
> Added unit tests for it.
> 
> 
> Diffs
> -
> 
>   geode-assembly/build.gradle 39bb542 
>   geode-assembly/src/test/resources/expected_jars.txt 6260167 
>   geode-core/build.gradle 7f34b4a 
>   
> geode-core/src/main/java/org/apache/geode/admin/internal/DistributionLocatorImpl.java
>  c1bfc93 
>   
> geode-core/src/main/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImpl.java
>  53d401a 
>   
> geode-core/src/main/java/org/apache/geode/cache/client/internal/PoolImpl.java 
> 3ded54a 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/AbstractDistributionConfig.java
>  01c6157 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java
>  a4b3a50 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/GMSUtil.java
>  da295ab 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/locator/GMSLocator.java
>  aff1938 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java
>  bc3d708 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpClient.java
>  6b54170 
>   
> geode-core/src/main/java/org/apache/geode/internal/admin/remote/DistributionLocatorId.java
>  5ab1bed 
>   
> geode-core/src/main/java/org/apache/geode/internal/admin/remote/RemoteTransportConfig.java
>  1dc2fd1 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/ClusterConfigurationLoader.java
>  92cfd96 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/PoolFactoryImpl.java 
> d4fdbd0 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/JmxManagerLocatorRequest.java
>  0efba01 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java
>  88832ba 
>   
> geode-core/src/test/java/org/apache/geode/cache/client/internal/AutoConnectionSourceDUnitTest.java
>  789d326 
>   
> geode-core/src/test/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImplJUnitTest.java
>  3cc3cfc 
>   
> geode-core/src/test/java/org/apache/geode/distributed/internal/DistributionConfigJUnitTest.java
>  9f6c5fb 
>   
> geode-core/src/test/java/org/apache/geode/distributed/internal/StartupMessageDataJUnitTest.java
>  9d63050 
>   
> geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java
>  a31fa8d 
>   
> geode-core/src/test/resources/org/apache/geode/codeAnalysis/excludedClasses.txt
>  6a6e0c1 
>   
> geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/LocatorDiscovery.java
>  f5a8fcf 
>   
> geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/LocatorMembershipListenerImpl.java
>  d6d5d7c 
>   
> geode-wan/src/main/java/org/apache/geode/internal/cache/wan/AbstractRemoteGatewaySender.java
>  dbc2cc6 
>   
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/misc/WanAutoDiscoveryDUnitTest.java
>  6d75064 
>   gradle/dependency-versions.properties 6a730a4 
> 
> 
> Diff: https://reviews.apache.org/r/60312/diff/3/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Latest diff
>   
> https://reviews.apache.org/media/uploaded/files/2017/06/29/45369a6d-34d0-42dd-96bc-a1c009d00824__GEODE-2804v2.patch
> 
> 
> Thanks,
> 
> Hitesh Khamesra
> 
>

Re: Review Request 60570: GEODE-3153 Client receives duplicate events during rolling upgrade

2017-06-30 Thread Dan Smith 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60570/#review179390
---




geode-core/src/main/java/org/apache/geode/internal/cache/EventID.java
Lines 301 (patched)


I think this needs at least some comments that explain what's going on 
here. Normally we should always be deserializing something using the version of 
the SENDER.

In this case, we have no idea what version the membershipID bytes were 
serialized with. We're just deserializing them with the version of the TARGET 
and hoping that this will preserve information if the membershipID was 
serialized with 1.0, and not fail if the membershipID was serialized with 1.2.


- Dan Smith


On June 30, 2017, 4:33 p.m., Bruce Schuchardt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60570/
> ---
> 
> (Updated June 30, 2017, 4:33 p.m.)
> 
> 
> Review request for geode, Alexander Murmann, Barry Oglesby, Galen O'Sullivan, 
> Hitesh Khamesra, and Brian Rowe.
> 
> 
> Bugs: GEODE-3153
> https://issues.apache.org/jira/browse/GEODE-3153
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Another problem was found in backward-compatibility testing.  If a 1.0.0 
> client was receiving subscription events generated by a 1.0.0 peer "feeder" 
> member and the events were routed through a 1.0.0 server the client might see 
> duplicate events when the server is stopped and the client fails over to a 
> 1.2.0 server holding its redundant subscription queue.  This is especially 
> possible if a large "ack" period is established in the client.
> 
> The problem stems from the EventID deserialization/reserialization of the 
> memberID bytes when sending to a 1.0 client.  It was deserializing using 
> Version.CURRENT, which ignores the UUID bytes in the serialized ID.  Then it 
> serialized the identifier using the client's version, which includes the UUID 
> bytes but which are zero due to the version used in deserialization.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java
>  bc3d708da2ae9a8e386accb8d15e2ed49123241e 
>   geode-core/src/main/java/org/apache/geode/internal/cache/EventID.java 
> 55c89f1f2e0800371dd4a30c4312c44f942a45ea 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscBCDUnitTest.java
>  bc48d976096fafe2545e707da68dab5120ddca51 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscDUnitTest.java
>  bfe4646b9abdf6075e8d30fab3d79924faade2aa 
>   
> geode-core/src/test/resources/org/apache/geode/codeAnalysis/sanctionedDataSerializables.txt
>  b69e004d63d74eccd5cd562ea269363ba3f2782e 
> 
> 
> Diff: https://reviews.apache.org/r/60570/diff/1/
> 
> 
> Testing
> ---
> 
> new unit tests, precheckin
> 
> 
> Thanks,
> 
> Bruce Schuchardt
> 
>

[GitHub] geode pull request #603: GEODE-3128: Changed the batch size to 1000 when cre...

2017-06-30 Thread upthewaterspout 
Github user upthewaterspout commented on a diff in the pull request:

https://github.com/apache/geode/pull/603#discussion_r125094490
  
--- Diff: 
geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesIntegrationTest.java
 ---
@@ -59,7 +64,7 @@
   @Rule
   public ExpectedException thrown = ExpectedException.none();
   private static final String INDEX_NAME = "index";
-  protected static final String REGION_NAME = "index";
+  public static final String REGION_NAME = "index";
--- End diff --

I don't think this needed to be made public - I think maybe the new test is 
importing the wrong static REGION_NAME?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #584: GEODE-2901: Adding integration tests of session rep...

2017-06-30 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/584


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #613: GEODE-3151: Internal Region Registration in JMX as per con...

2017-06-30 Thread PurelyApplied 
Github user PurelyApplied commented on the issue:

https://github.com/apache/geode/pull/613
  
If you are using IntelliJ as your IDE, please remember to update your style 
file to that located in `geode/etc/intellij-java-modified-google-style.xml` to 
be consistent with Geode's established style guide.  This file was updated June 
13 with commit `a561bd12` to be consistent with documented expectations.

After having done so, please optimize the imports to the correct order and 
to eliminate the use of the wildcard imports. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #612: GEODE-3121: ensure that the protobuf protocol works over S...

2017-06-30 Thread PurelyApplied 
Github user PurelyApplied commented on the issue:

https://github.com/apache/geode/pull/612
  
If you are using IntelliJ as your IDE, please remember to update your style 
file to that located in `geode/etc/intellij-java-modified-google-style.xml` to 
be consistent with Geode's established style guide.  This file was updated June 
13 with commit `a561bd12` to be consistent with documented expectations.

After having done so, please optimize the imports to the correct order and 
to eliminate the use of the wildcard imports. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #609: GEODE-2886 : sent IllegalStateException instead of throwin...

2017-06-30 Thread PurelyApplied 
Github user PurelyApplied commented on the issue:

https://github.com/apache/geode/pull/609
  
If you are using IntelliJ as your IDE, please remember to update your style 
file to that located in `geode/etc/intellij-java-modified-google-style.xml` to 
be consistent with Geode's established style guide.  This file was updated June 
13 with commit `a561bd12` to be consistent with documented expectations.

After having done so, please optimize the imports to the correct order and 
to eliminate the use of the wildcard imports. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #603: GEODE-3128: Changed the batch size to 1000 when creating A...

2017-06-30 Thread PurelyApplied 
Github user PurelyApplied commented on the issue:

https://github.com/apache/geode/pull/603
  
If you are using IntelliJ as your IDE and have not already done so, please 
remember to update your style file to that located in 
`geode/etc/intellij-java-modified-google-style.xml` to be consistent with 
Geode's established style guide.  This file was updated June 13 with commit 
`a561bd12` to be consistent with documented expectations.

After having done so, please optimize the imports to the correct order of 
imports in 
`geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/filesystem/FileSystem.java`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #601: GEODE-3117: fix Gateway authentication with legacy securit...

2017-06-30 Thread PurelyApplied 
Github user PurelyApplied commented on the issue:

https://github.com/apache/geode/pull/601
  
If you are using IntelliJ as your IDE, please remember to update your style 
file to that located in `geode/etc/intellij-java-modified-google-style.xml` to 
be consistent with Geode's established style guide.  This file was updated June 
13 with commit `a561bd12` to be consistent with documented expectations.

After having done so, please optimize the imports to the correct order and 
to eliminate the use of the wildcard imports. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 60570: GEODE-3153 Client receives duplicate events during rolling upgrade

2017-06-30 Thread Galen O'Sullivan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60570/#review179384
---



I've been looking at this with @WireBaron, and we're wondering whether a client 
membership ID can still get sent with a zeroed UUID if it's passed between two 
Gemfire 9.1 servers as a result of client queue replication failover. We tried 
to write a test and failed.

The basic idea is something like this:
* start two servers, an interested client and an event-creating client.
  One server is running 9.0 and the other 9.1 .
* put a couple of events in the system via the 9.0 server (should be fine with 
either).
* kill the 9.0 server and add a new 9.1 server to the system.
  At this point, if we're understanding client queue replication correctly, the 
new server should receive a copy of the queue from the other 9.1 server.
* Check the same events on the new server to see if they've lost the UUID.

Does that sound reasonable to you?

I'm not sure how to trigger failures in the right order to verify this isn't an 
issue, but I think it's reasonably plausible that during rolling upgrades 
someone could encounter the issue. It would require an old client to get a 
queue from a new version server that has been passed that queue by another new 
version server.

If that's not possible to trigger, or you can't test it and are confident that 
the scenario we described won't happen, then go ahead and ship it.


geode-core/src/main/java/org/apache/geode/internal/cache/EventID.java
Lines 301 (patched)


Maybe declare `dis` and then set it based on the version number?

If you're feeling charitable, you could rename `dis` to `dataInputStream`.



geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscBCDUnitTest.java
Lines 105 (patched)


I'm not all that familiar with backwards compatibility tests, but do we 
want to be testing agains current version and testing version or current and 
9.0? Will backwards compatibility set `testVersion` to 9.0 among other versions?


- Galen O'Sullivan


On June 30, 2017, 4:33 p.m., Bruce Schuchardt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60570/
> ---
> 
> (Updated June 30, 2017, 4:33 p.m.)
> 
> 
> Review request for geode, Alexander Murmann, Barry Oglesby, Galen O'Sullivan, 
> Hitesh Khamesra, and Brian Rowe.
> 
> 
> Bugs: GEODE-3153
> https://issues.apache.org/jira/browse/GEODE-3153
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Another problem was found in backward-compatibility testing.  If a 1.0.0 
> client was receiving subscription events generated by a 1.0.0 peer "feeder" 
> member and the events were routed through a 1.0.0 server the client might see 
> duplicate events when the server is stopped and the client fails over to a 
> 1.2.0 server holding its redundant subscription queue.  This is especially 
> possible if a large "ack" period is established in the client.
> 
> The problem stems from the EventID deserialization/reserialization of the 
> memberID bytes when sending to a 1.0 client.  It was deserializing using 
> Version.CURRENT, which ignores the UUID bytes in the serialized ID.  Then it 
> serialized the identifier using the client's version, which includes the UUID 
> bytes but which are zero due to the version used in deserialization.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java
>  bc3d708da2ae9a8e386accb8d15e2ed49123241e 
>   geode-core/src/main/java/org/apache/geode/internal/cache/EventID.java 
> 55c89f1f2e0800371dd4a30c4312c44f942a45ea 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscBCDUnitTest.java
>  bc48d976096fafe2545e707da68dab5120ddca51 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscDUnitTest.java
>  bfe4646b9abdf6075e8d30fab3d79924faade2aa 
>   
> geode-core/src/test/resources/org/apache/geode/codeAnalysis/sanctionedDataSerializables.txt
>  b69e004d63d74eccd5cd562ea269363ba3f2782e 
> 
> 
> Diff: https://reviews.apache.org/r/60570/diff/1/
> 
> 
> Testing
> ---
> 
> new unit tests, precheckin
> 
> 
> Thanks,
> 
> Bruce Schuchardt
> 
>

Re: Review Request 60570: GEODE-3153 Client receives duplicate events during rolling upgrade

2017-06-30 Thread Bruce Schuchardt 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60570/
---

(Updated June 30, 2017, 3:02 p.m.)


Review request for geode, Alexander Murmann, Barry Oglesby, Galen O'Sullivan, 
Hitesh Khamesra, and Brian Rowe.


Changes
---

addressing review issues and failure with old GFE 8.2.x client that Barry 
encountered


Bugs: GEODE-3153
https://issues.apache.org/jira/browse/GEODE-3153


Repository: geode


Description
---

Another problem was found in backward-compatibility testing.  If a 1.0.0 client 
was receiving subscription events generated by a 1.0.0 peer "feeder" member and 
the events were routed through a 1.0.0 server the client might see duplicate 
events when the server is stopped and the client fails over to a 1.2.0 server 
holding its redundant subscription queue.  This is especially possible if a 
large "ack" period is established in the client.

The problem stems from the EventID deserialization/reserialization of the 
memberID bytes when sending to a 1.0 client.  It was deserializing using 
Version.CURRENT, which ignores the UUID bytes in the serialized ID.  Then it 
serialized the identifier using the client's version, which includes the UUID 
bytes but which are zero due to the version used in deserialization.


Diffs (updated)
-

  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java
 bc3d708da2ae9a8e386accb8d15e2ed49123241e 
  geode-core/src/main/java/org/apache/geode/internal/Version.java 
557697159da644915e4ffe2405cdddc9ef37c5ac 
  geode-core/src/main/java/org/apache/geode/internal/cache/EventID.java 
55c89f1f2e0800371dd4a30c4312c44f942a45ea 
  
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscBCDUnitTest.java
 bc48d976096fafe2545e707da68dab5120ddca51 
  
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscDUnitTest.java
 bfe4646b9abdf6075e8d30fab3d79924faade2aa 
  
geode-core/src/test/resources/org/apache/geode/codeAnalysis/sanctionedDataSerializables.txt
 b69e004d63d74eccd5cd562ea269363ba3f2782e 


Diff: https://reviews.apache.org/r/60570/diff/2/

Changes: https://reviews.apache.org/r/60570/diff/1-2/


Testing
---

new unit tests, precheckin


Thanks,

Bruce Schuchardt

Re: Review Request 60570: GEODE-3153 Client receives duplicate events during rolling upgrade

2017-06-30 Thread Bruce Schuchardt 


> On June 30, 2017, 2:56 p.m., Galen O'Sullivan wrote:
> > geode-core/src/main/java/org/apache/geode/internal/cache/EventID.java
> > Lines 301 (patched)
> > 
> >
> > Maybe declare `dis` and then set it based on the version number?
> > 
> > If you're feeling charitable, you could rename `dis` to 
> > `dataInputStream`.

A versioned stream needs to wrap a real DataInputStream, I think.


> On June 30, 2017, 2:56 p.m., Galen O'Sullivan wrote:
> > geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscBCDUnitTest.java
> > Lines 105 (patched)
> > 
> >
> > I'm not all that familiar with backwards compatibility tests, but do we 
> > want to be testing agains current version and testing version or current 
> > and 9.0? Will backwards compatibility set `testVersion` to 9.0 among other 
> > versions?

the framework will cycle through 1.0.0-incubating, 1.1.0 and 1.1.1.  Pivotal's 
9.0 releases were based on 1.0.0-incubating


- Bruce


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60570/#review179384
---


On June 30, 2017, 3:02 p.m., Bruce Schuchardt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60570/
> ---
> 
> (Updated June 30, 2017, 3:02 p.m.)
> 
> 
> Review request for geode, Alexander Murmann, Barry Oglesby, Galen O'Sullivan, 
> Hitesh Khamesra, and Brian Rowe.
> 
> 
> Bugs: GEODE-3153
> https://issues.apache.org/jira/browse/GEODE-3153
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Another problem was found in backward-compatibility testing.  If a 1.0.0 
> client was receiving subscription events generated by a 1.0.0 peer "feeder" 
> member and the events were routed through a 1.0.0 server the client might see 
> duplicate events when the server is stopped and the client fails over to a 
> 1.2.0 server holding its redundant subscription queue.  This is especially 
> possible if a large "ack" period is established in the client.
> 
> The problem stems from the EventID deserialization/reserialization of the 
> memberID bytes when sending to a 1.0 client.  It was deserializing using 
> Version.CURRENT, which ignores the UUID bytes in the serialized ID.  Then it 
> serialized the identifier using the client's version, which includes the UUID 
> bytes but which are zero due to the version used in deserialization.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java
>  bc3d708da2ae9a8e386accb8d15e2ed49123241e 
>   geode-core/src/main/java/org/apache/geode/internal/Version.java 
> 557697159da644915e4ffe2405cdddc9ef37c5ac 
>   geode-core/src/main/java/org/apache/geode/internal/cache/EventID.java 
> 55c89f1f2e0800371dd4a30c4312c44f942a45ea 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscBCDUnitTest.java
>  bc48d976096fafe2545e707da68dab5120ddca51 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscDUnitTest.java
>  bfe4646b9abdf6075e8d30fab3d79924faade2aa 
>   
> geode-core/src/test/resources/org/apache/geode/codeAnalysis/sanctionedDataSerializables.txt
>  b69e004d63d74eccd5cd562ea269363ba3f2782e 
> 
> 
> Diff: https://reviews.apache.org/r/60570/diff/2/
> 
> 
> Testing
> ---
> 
> new unit tests, precheckin
> 
> 
> Thanks,
> 
> Bruce Schuchardt
> 
>

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #602 was SUCCESSFUL (with 1908 tests)

2017-06-30 Thread Spring CI 

---
Spring Data GemFire > Nightly-ApacheGeode > #602 was successful.
---
Scheduled
1910 tests in total.

https://build.spring.io/browse/SGF-NAG-602/





--
This message is automatically generated by Atlassian Bamboo

Re: Review Request 60570: GEODE-3153 Client receives duplicate events during rolling upgrade

2017-06-30 Thread Bruce Schuchardt 


> On June 30, 2017, 2:56 p.m., Galen O'Sullivan wrote:
> > I've been looking at this with @WireBaron, and we're wondering whether a 
> > client membership ID can still get sent with a zeroed UUID if it's passed 
> > between two Gemfire 9.1 servers as a result of client queue replication 
> > failover. We tried to write a test and failed.
> > 
> > The basic idea is something like this:
> > * start two servers, an interested client and an event-creating client.
> >   One server is running 9.0 and the other 9.1 .
> > * put a couple of events in the system via the 9.0 server (should be fine 
> > with either).
> > * kill the 9.0 server and add a new 9.1 server to the system.
> >   At this point, if we're understanding client queue replication correctly, 
> > the new server should receive a copy of the queue from the other 9.1 server.
> > * Check the same events on the new server to see if they've lost the UUID.
> > 
> > Does that sound reasonable to you?
> > 
> > I'm not sure how to trigger failures in the right order to verify this 
> > isn't an issue, but I think it's reasonably plausible that during rolling 
> > upgrades someone could encounter the issue. It would require an old client 
> > to get a queue from a new version server that has been passed that queue by 
> > another new version server.
> > 
> > If that's not possible to trigger, or you can't test it and are confident 
> > that the scenario we described won't happen, then go ahead and ship it.

Please use Geode version numbers.

I modified my new test to do as you described and it passed, as I expected it 
to.  During image transfer the first 1.2.0 server would just transmit the 
membershipID bytes in its toData method since the target is a 1.2.0 server.  
The second server would preserve the UUID bytes when sending the eventID to the 
1.0.0 client.


- Bruce


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60570/#review179384
---


On June 30, 2017, 3:02 p.m., Bruce Schuchardt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60570/
> ---
> 
> (Updated June 30, 2017, 3:02 p.m.)
> 
> 
> Review request for geode, Alexander Murmann, Barry Oglesby, Galen O'Sullivan, 
> Hitesh Khamesra, and Brian Rowe.
> 
> 
> Bugs: GEODE-3153
> https://issues.apache.org/jira/browse/GEODE-3153
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Another problem was found in backward-compatibility testing.  If a 1.0.0 
> client was receiving subscription events generated by a 1.0.0 peer "feeder" 
> member and the events were routed through a 1.0.0 server the client might see 
> duplicate events when the server is stopped and the client fails over to a 
> 1.2.0 server holding its redundant subscription queue.  This is especially 
> possible if a large "ack" period is established in the client.
> 
> The problem stems from the EventID deserialization/reserialization of the 
> memberID bytes when sending to a 1.0 client.  It was deserializing using 
> Version.CURRENT, which ignores the UUID bytes in the serialized ID.  Then it 
> serialized the identifier using the client's version, which includes the UUID 
> bytes but which are zero due to the version used in deserialization.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java
>  bc3d708da2ae9a8e386accb8d15e2ed49123241e 
>   geode-core/src/main/java/org/apache/geode/internal/Version.java 
> 557697159da644915e4ffe2405cdddc9ef37c5ac 
>   geode-core/src/main/java/org/apache/geode/internal/cache/EventID.java 
> 55c89f1f2e0800371dd4a30c4312c44f942a45ea 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscBCDUnitTest.java
>  bc48d976096fafe2545e707da68dab5120ddca51 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscDUnitTest.java
>  bfe4646b9abdf6075e8d30fab3d79924faade2aa 
>   
> geode-core/src/test/resources/org/apache/geode/codeAnalysis/sanctionedDataSerializables.txt
>  b69e004d63d74eccd5cd562ea269363ba3f2782e 
> 
> 
> Diff: https://reviews.apache.org/r/60570/diff/2/
> 
> 
> Testing
> ---
> 
> new unit tests, precheckin
> 
> 
> Thanks,
> 
> Bruce Schuchardt
> 
>

Re: Review Request 60570: GEODE-3153 Client receives duplicate events during rolling upgrade

2017-06-30 Thread Bruce Schuchardt 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60570/
---

(Updated June 30, 2017, 4:17 p.m.)


Review request for geode, Alexander Murmann, Barry Oglesby, Galen O'Sullivan, 
Hitesh Khamesra, and Brian Rowe.


Changes
---

adding a second current-version server to the test, as suggested by Galen and 
Brian


Bugs: GEODE-3153
https://issues.apache.org/jira/browse/GEODE-3153


Repository: geode


Description
---

Another problem was found in backward-compatibility testing.  If a 1.0.0 client 
was receiving subscription events generated by a 1.0.0 peer "feeder" member and 
the events were routed through a 1.0.0 server the client might see duplicate 
events when the server is stopped and the client fails over to a 1.2.0 server 
holding its redundant subscription queue.  This is especially possible if a 
large "ack" period is established in the client.

The problem stems from the EventID deserialization/reserialization of the 
memberID bytes when sending to a 1.0 client.  It was deserializing using 
Version.CURRENT, which ignores the UUID bytes in the serialized ID.  Then it 
serialized the identifier using the client's version, which includes the UUID 
bytes but which are zero due to the version used in deserialization.


Diffs (updated)
-

  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java
 bc3d708da2ae9a8e386accb8d15e2ed49123241e 
  geode-core/src/main/java/org/apache/geode/internal/Version.java 
557697159da644915e4ffe2405cdddc9ef37c5ac 
  geode-core/src/main/java/org/apache/geode/internal/cache/EventID.java 
55c89f1f2e0800371dd4a30c4312c44f942a45ea 
  
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscBCDUnitTest.java
 bc48d976096fafe2545e707da68dab5120ddca51 
  
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscDUnitTest.java
 bfe4646b9abdf6075e8d30fab3d79924faade2aa 
  
geode-core/src/test/resources/org/apache/geode/codeAnalysis/sanctionedDataSerializables.txt
 b69e004d63d74eccd5cd562ea269363ba3f2782e 


Diff: https://reviews.apache.org/r/60570/diff/3/

Changes: https://reviews.apache.org/r/60570/diff/2-3/


Testing
---

new unit tests, precheckin


Thanks,

Bruce Schuchardt

Build failed in Jenkins: Geode-nightly-flaky #51

2017-06-30 Thread Apache Jenkins Server 
See 


Changes:

[bschuchardt] GEODE-3139 remove current artifacts from classpath of

[dschneider] GEODE-3098: fix flaky test failure

[boglesby] GEODE-3152: Changed to create a region name appropriate to the client

[upthewaterspout] GEODE-3157: Updating modify_war script to include shiro, 
commons-lang

[upthewaterspout] GEODE-2901: Adding integration tests of session replication

--
[...truncated 101.64 KB...]
:geode-web-api:processResources
:geode-web-api:classes
:geode-assembly:docs
:geode-assembly:gfshDepsJar
:geode-common:javadocJar
:geode-common:sourcesJar
:geode-common:signArchives SKIPPED
:geode-core:javadocJar
:geode-core:raJar
:geode-core:jcaJar
:geode-core:sourcesJar
:geode-core:signArchives SKIPPED
:geode-core:webJar
:geode-cq:jar
:geode-cq:javadoc
:geode-cq:javadocJar
:geode-cq:sourcesJar
:geode-cq:signArchives SKIPPED
:geode-json:javadocJar
:geode-json:sourcesJar
:geode-json:signArchives SKIPPED
:geode-lucene:jar
:geode-lucene:javadoc
:geode-lucene:javadocJar
:geode-lucene:sourcesJar
:geode-lucene:signArchives SKIPPED
:geode-old-client-support:jar
:geode-old-client-support:javadoc
:geode-old-client-support:javadocJar
:geode-old-client-support:sourcesJar
:geode-old-client-support:signArchives SKIPPED
:geode-protobuf:jar
:geode-protobuf:javadoc
:geode-protobuf:javadocJar
:geode-protobuf:sourcesJar
:geode-protobuf:signArchives SKIPPED
:geode-pulse:javadoc
:geode-pulse:javadocJar
:geode-pulse:sourcesJar
:geode-pulse:war
:geode-pulse:signArchives SKIPPED
:geode-rebalancer:jar
:geode-rebalancer:javadoc
:geode-rebalancer:javadocJar
:geode-rebalancer:sourcesJar
:geode-rebalancer:signArchives SKIPPED
:geode-wan:jar
:geode-wan:javadoc
:geode-wan:javadocJar
:geode-wan:sourcesJar
:geode-wan:signArchives SKIPPED
:geode-web:javadoc UP-TO-DATE
:geode-web:javadocJar
:geode-web:sourcesJar
:geode-web:war
:geode-web:signArchives SKIPPED
:geode-web-api:javadoc
:geode-web-api:javadocJar
:geode-web-api:sourcesJar
:geode-web-api:war
:geode-web-api:signArchives SKIPPED
:geode-assembly:installDist
:geode-pulse:jar
:geode-assembly:compileTestJava
Download 
https://repo1.maven.org/maven2/org/codehaus/cargo/cargo-core-uberjar/1.6.3/cargo-core-uberjar-1.6.3.pom
Download 
https://repo1.maven.org/maven2/org/codehaus/cargo/cargo-core/1.6.3/cargo-core-1.6.3.pom
Download 
https://repo1.maven.org/maven2/org/codehaus/cargo/codehaus-cargo/1.6.3/codehaus-cargo-1.6.3.pom
Download 
https://repo1.maven.org/maven2/org/codehaus/cargo/cargo-core-uberjar/1.6.3/cargo-core-uberjar-1.6.3.jar
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
:geode-assembly:processTestResources
:geode-assembly:testClasses
:geode-assembly:flakyTest

org.apache.geode.management.internal.configuration.ClusterConfigurationServiceEndToEndDUnitTest
 > testStartServerAndExecuteCommands FAILED
java.lang.AssertionError: Suspicious strings were written to the log during 
this run.
Fix the strings or use IgnoredException.addIgnoredException to ignore.
---
Found suspect string in log4j at line 1767

[error 2017/06/30 22:04:34.938 UTC  tid=62] The disk 
volume ds1 for disk store ds1 has exceeded the critical usage threshold and is 
92% full

---
Found suspect string in log4j at line 1769

[error 2017/06/30 22:04:34.939 UTC  tid=62] A 
DiskAccessException has occurred while writing to the disk for disk store ds1. 
The cache will be closed.
org.apache.geode.cache.DiskAccessException: For DiskStore: ds1: Critical 
disk usage threshold exceeded for volume 
:
 92% full
at 
org.apache.geode.internal.cache.DiskStoreMonitor$DirectoryHolderUsage.handleStateChange(DiskStoreMonitor.java:388)
at 
org.apache.geode.internal.cache.DiskStoreMonitor$DiskUsage.update(DiskStoreMonitor.java:297)
at 
org.apache.geode.internal.cache.DiskStoreMonitor.checkUsage(DiskStoreMonitor.java:201)
at 
org.apache.geode.internal.cache.DiskStoreMonitor.access$000(DiskStoreMonitor.java:39)
at 
org.apache.geode.internal.cache.DiskStoreMonitor$2.run(DiskStoreMonitor.java:135)
at 
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
at 
java.util.concurrent