Re: Review Request 58484: GEODE-2632: refactoring part 2

[Udo Kohlmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58484/#review172210
---


Ship it!




Ship It!

- Udo Kohlmeyer


On April 17, 2017, 10:27 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58484/
> ---
> 
> (Updated April 17, 2017, 10:27 p.m.)
> 
> 
> Review request for geode, Bruce Schuchardt, Darrel Schneider, Jinmei Liao, 
> Jared Stewart, Ken Howe, Udo Kohlmeyer, and Dan Smith.
> 
> 
> Bugs: GEODE-2632
> https://issues.apache.org/jira/browse/GEODE-2632
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Purpose: Refactoring code in steps to eventually fix security/client-server 
> performance
> Part 1: https://reviews.apache.org/r/58460/
> 
> Refactor code to use internal interfaces
> 
> * refactor code to use InternalCache instead of GemFireCacheImpl
> * refactor code to use getInternalDistributedSystem
> * delete dead code, unused code, unused imports, extra whitespace,
> useless javadocs and comments, fix typos
> 
> The end goals of multiple iterations of refactoring: 1) write high-level 
> benchmark for client put to server [done], 2) change internal dependencies 
> from impl class to interface (including GemFireCacheImpl to InternalCache), 
> 3) fix constructors and invert dependencies of internal classes (including 
> AcceptorImpl and client Command classes), 4) write low-level benchmark(s) for 
> client commands, 5) fix any performance issues involving SecurityService.
> 
> I'd like to commit each iteration of refactoring as I go to keep the number 
> of merge conflicts and number of modified files lower.
> 
> 
> Diffs
> -
> 
>   
> geode-assembly/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigurationServiceEndToEndDUnitTest.java
>  0103cf6d8d6f088b4bd3ffc30f8e52b977a82621 
>   
> geode-core/src/main/java/org/apache/geode/cache/asyncqueue/internal/AsyncEventQueueFactoryImpl.java
>  b2881082278bdb53a8553a7fd31c47c304eb1ef6 
>   
> geode-core/src/main/java/org/apache/geode/cache/asyncqueue/internal/ParallelAsyncEventQueueImpl.java
>  03f079964c5e12c1ba44ba240f12025a5b098a09 
>   
> geode-core/src/main/java/org/apache/geode/cache/asyncqueue/internal/SerialAsyncEventQueueImpl.java
>  08a5b003d6e3c5cdec8ad22b74153f2c31cde9f7 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/AbstractRegion.java 
> e69f801d4f307c3ce98c105d6d2e38460d0d4a67 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/CacheServerImpl.java 
> a3c4a931b95fb3a8ea6463bb027aadd1bc8fdd32 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/DiskStoreFactoryImpl.java
>  71be7ec00deb6dc774f84e0fcca291a310ba09e4 
>   geode-core/src/main/java/org/apache/geode/internal/cache/DiskStoreImpl.java 
> b97f4286b6e2352a4ec5637477641d868cb05a6c 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/DiskStoreMonitor.java
>  2bb510720f2374ae1159095bff293f88465e600c 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/DistTXStateProxyImplOnCoordinator.java
>  52d155f5eebff2dd6eb50fbada159aca6629c1ec 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/DistributedRegion.java
>  68fdbebac6a50efb7092717d56243c7b88a47ec5 
>   geode-core/src/main/java/org/apache/geode/internal/cache/ExpiryTask.java 
> e12622d070b932979a6ca400d47eeff36c142f21 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java
>  869181432a64c2683e1b606e621cb5dbd1b42589 
>   geode-core/src/main/java/org/apache/geode/internal/cache/InternalCache.java 
> ee80014b393ba5d625cb78cf12a2a6e2c2fc24b3 
>   geode-core/src/main/java/org/apache/geode/internal/cache/LocalRegion.java 
> 55ee6a8e1ba7351c87d6f63f530469699efa8ee2 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegion.java
>  8db89699ceb2e23fd4ae8ce62b0fad76421656b0 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegionHelper.java
>  99ab281052b11e1a1168d99f8e1047fb4f822ca2 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/ProxyBucketRegion.java
>  27f73c7514b3ff6f20041ac6c8ce72d3c1798977 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/SearchLoadAndWriteProcessor.java
>  2a10792a7a26ead58fcf941fe4190117f552a6c5 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/ServerPingMessage.java
>  0e468912614292d23cda0fd32e4126a0e0235a59 
>   geode-core/src/main/java/org/apache/geode/internal/cache/TXMessage.java 
> 08ce99ba1b58d2f80815807a97ab943589b64e5f 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/control/HeapMemoryMonitor.java
>  0de41bf7da6731df146749571bb3e951764a3444 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache

[GitHub] geode issue #458: GEODE-2788: Add official Socket timeout parameter when con...

[bschuchardt]

Github user bschuchardt commented on the issue:

https://github.com/apache/geode/pull/458
  
Yes, I think it could be an attribute of the connection pool.  That would 
be perfect.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2788) Add official Socket timeout parameter when connecting to servers/locators

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972950#comment-15972950
 ] 

ASF GitHub Bot commented on GEODE-2788:
---

Github user bschuchardt commented on the issue:

https://github.com/apache/geode/pull/458
  
Yes, I think it could be an attribute of the connection pool.  That would 
be perfect.


> Add official Socket timeout parameter when connecting to servers/locators
> -
>
> Key: GEODE-2788
> URL: https://issues.apache.org/jira/browse/GEODE-2788
> Project: Geode
>  Issue Type: Improvement
>  Components: client/server, docs
>Reporter: Masaki Yamakawa
>Priority: Minor
>  Labels: patch
>
> When connecting from the client to the servers/locators, if the 
> servers/locators is not started, the connection can not be established and a 
> Socket timeout occurs.
> This timeout value is 59 seconds by default. This timeout value is too long. 
> This timeout value can be changed by specifying the unofficial parameter 
> "gemfire.PoolImpl.HANDSHAKE_TIMEOUT" in java system property, but I 
> corresponded so that it can be specified by official parameters.
> Like the NativeClient, the official parameters should be specified by 
> "connect-timeout" in gemfire.properties.
> Timeout values ​​are determined in the following order of priority.
> 1. java system property:gemfire.PoolImpl.HANDSHAKE_TIMEOUT
> 2. java system property:gemfire.connect-timeout
> 3. gemfire.properties:connect-timeout
> 4. default:59000 milli seconds
> As another idea, there is also an idea to make it possible to specify it as 
> an attribute of Pool. In that case NativeClient needs the same modification.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2766) Only apply patches for dependencies on relevant architectures

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972968#comment-15972968
 ] 

ASF subversion and git services commented on GEODE-2766:


Commit 81c4511552c35c879f644827d29fcc90507234ad in geode-native's branch 
refs/heads/develop from [~eburghardt]
[ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=81c4511 ]

GEODE-2766: fixed unsupported CMake variable


> Only apply patches for dependencies on relevant architectures
> -
>
> Key: GEODE-2766
> URL: https://issues.apache.org/jira/browse/GEODE-2766
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Jens Deppe
>Assignee: Jens Deppe
>
> Currently the patches for openssl and ACE are only required for Solaris but 
> are still applied on all platforms. This can break on Windows if the patching 
> tool cannot correctly convert Windows/Unix line-endings.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2793) Look into reducing the amount of PDX deserializations in OQL query intermediate result sets for indexed OR queries containing PdxInstanceImpls

[Barry Oglesby (JIRA)]

Barry Oglesby created GEODE-2793:


 Summary: Look into reducing the amount of PDX deserializations in 
OQL query intermediate result sets for indexed OR queries containing 
PdxInstanceImpls
 Key: GEODE-2793
 URL: https://issues.apache.org/jira/browse/GEODE-2793
 Project: Geode
  Issue Type: Bug
  Components: querying
Reporter: Barry Oglesby


Intermediate result sets for each of the indexed OR clauses are represented by 
ResultsBags. Each index is sorted and iterated in AbstractGroupOrRangeJunction 
auxFilterEvaluate. When entry in the index is added to a ResultsBag, hashCode 
is invoked. In the case of a PdxInstanceImpl, this causes all of its identity 
fields to be deserialized so that hashCode can be invoked on them.

Then, when each ResultsBag is sorted during QueryUtils union and 
sizeSortedUnion by invoking occurrences on each entry, equals is invoked each 
entry. In the case of a PdxInstanceImpl, this causes all of its identity fields 
to be deserialized so that equals can be invoked on them.

Here is an example query that shows the PDX deserializations:
{noformat}
select * from /region this where ((map['entry1']='value1' OR 
map['entry2']='value2' OR map['entry3']='value3' OR map['entry4']='value4' OR 
map['entry5']='value5' OR map['entry6']='value6' OR map['entry7']='value7' OR 
map['entry8']='value8' OR map['entry9']='value9' OR map['entry10']='value10')) 
...
{noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode pull request #460: Feature/geode 2703

[jhuynh1]

GitHub user jhuynh1 opened a pull request:

https://github.com/apache/geode/pull/460

Feature/geode 2703

Modified transaction exception messaging when executing a lucene query 
within a geode transaction.

The client transactions behave differently in geode depending on whether 
single hop is enabled or not.  If single hop is enabled, the expected 
transaction exception actually never is thrown.

Possible reviewers : @nabarunnag @upthewaterspout @boglesby 


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/geode feature/GEODE-2703

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/460.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #460


commit e7b57b679b1be837f943c34e1d7022b5aa8de583
Author: Jason Huynh 
Date:   2017-04-12T20:54:39Z

GEODE-2703: Improve exception message when executing lucene within a 
transaction

  * Throw a LuceneQueryException instead of a TransactionException

commit 9a93b7acd31d07eeb97af93dc12c817e64f210c2
Author: Jason Huynh 
Date:   2017-04-12T21:42:52Z

Modified Test

commit f408ccad86418626009bf1d0b306b98a84c20b03
Author: Jason Huynh 
Date:   2017-04-14T16:16:21Z

Added catch when executing from client without singlehop

commit 464263967d4a4352760e4d88dddfa734e3cf
Author: Jason Huynh 
Date:   2017-04-14T22:50:15Z

Changes

commit 1bd2b86eecbedfcddb56e2298e49fb14a2cceaf3
Author: Jason Huynh 
Date:   2017-04-18T16:22:03Z

Modified test for client transactions with Lucene queries




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #450: GEODE-2632: create ClientCachePutBench

[galen-pivotal]

Github user galen-pivotal commented on the issue:

https://github.com/apache/geode/pull/450
  
This will set the same keys to the same values each iteration, because. I 
ran a benchmark last night with a benchmark that used only 99 values, but I 
didn't see a significant difference:
```
Result "performPutFromClientDifferentKeys":
  23532.506 ±(99.9%) 576.405 ops/s [Average]
  (min, avg, max) = (23176.421, 23532.506, 24073.672), stdev = 343.009
  CI (99.9%): [22956.101, 24108.911] (assumes normal distribution)
```
```
Result "performPutFromClient":
  23891.204 ±(99.9%) 133.078 ops/s [Average]
  (min, avg, max) = (23797.325, 23891.204, 24013.180), stdev = 79.193
  CI (99.9%): [23758.126, 24024.283] (assumes normal distribution)
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #450: GEODE-2632: create ClientCachePutBench

[galen-pivotal]

Github user galen-pivotal commented on the issue:

https://github.com/apache/geode/pull/450
  
Do you know why I get so many of these messages when I run the benchmark?
```
Encountered duplicate path 
"javassist/bytecode/annotation/ArrayMemberValue.class" during copy operation 
configured with DuplicatesStrategy.WARN
Encountered duplicate path 
"javassist/bytecode/annotation/BooleanMemberValue.class" during copy operation 
configured with DuplicatesStrategy.WARN
Encountered duplicate path 
"javassist/bytecode/annotation/ByteMemberValue.class" during copy operation 
configured with DuplicatesStrategy.WARN
Encountered duplicate path 
"javassist/bytecode/annotation/CharMemberValue.class" during copy operation 
configured with DuplicatesStrategy.WARN
Encountered duplicate path 
"javassist/bytecode/annotation/ClassMemberValue.class" during copy operation 
configured with DuplicatesStrategy.WARN
Encountered duplicate path 
"javassist/bytecode/annotation/DoubleMemberValue.class" during copy operation 
configured with DuplicatesStrategy.WARN
Encountered duplicate path 
"javassist/bytecode/annotation/EnumMemberValue.class" during copy operation 
configured with DuplicatesStrategy.WARN
Encountered duplicate path 
"javassist/bytecode/annotation/FloatMemberValue.class" during copy operation 
configured with DuplicatesStrategy.WARN
Encountered duplicate path 
"javassist/bytecode/annotation/IntegerMemberValue.class" during copy operation 
configured with DuplicatesStrategy.WARN
Encountered duplicate path 
"javassist/bytecode/annotation/LongMemberValue.class" during copy operation 
configured with DuplicatesStrategy.WARN
Encountered duplicate path 
"javassist/bytecode/annotation/MemberValue.class" during copy operation 
configured with DuplicatesStrategy.WARN
Encountered duplicate path 
"javassist/bytecode/annotation/MemberValueVisitor.class" during copy operation 
configured with DuplicatesStrategy.WARN
Encountered duplicate path 
"javassist/bytecode/annotation/ShortMemberValue.class" during copy operation 
configured with DuplicatesStrategy.WARN
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #450: GEODE-2632: create ClientCachePutBench

[galen-pivotal]

Github user galen-pivotal commented on a diff in the pull request:

https://github.com/apache/geode/pull/450#discussion_r112005377
  
--- Diff: 
geode-core/src/jmh/java/org/apache/geode/internal/cache/tier/sockets/command/ClientCachePutBench.java
 ---
@@ -0,0 +1,233 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
+ * or implied. See the License for the specific language governing 
permissions and limitations under
+ * the License.
+ */
+package org.apache.geode.internal.cache.tier.sockets.command;
+
+import static java.lang.System.*;
+import static java.util.concurrent.TimeUnit.*;
+import static org.apache.commons.io.FileUtils.*;
+import static org.apache.commons.lang.StringUtils.*;
+import static org.apache.geode.cache.client.ClientRegionShortcut.*;
+import static org.apache.geode.distributed.AbstractLauncher.Status.*;
+import static org.apache.geode.distributed.ConfigurationProperties.*;
+import static org.apache.geode.distributed.internal.DistributionConfig.*;
+import static org.apache.geode.internal.AvailablePort.*;
+import static org.apache.geode.test.dunit.NetworkUtils.*;
+import static org.assertj.core.api.Assertions.*;
+import static org.awaitility.Awaitility.*;
+
+import org.apache.geode.cache.Region;
+import org.apache.geode.cache.client.ClientCache;
+import org.apache.geode.cache.client.ClientCacheFactory;
+import org.apache.geode.distributed.ServerLauncher;
+import org.apache.geode.internal.process.ProcessStreamReader;
+import org.junit.rules.TemporaryFolder;
+import org.openjdk.jmh.annotations.Benchmark;
+import org.openjdk.jmh.annotations.BenchmarkMode;
+import org.openjdk.jmh.annotations.Fork;
+import org.openjdk.jmh.annotations.Level;
+import org.openjdk.jmh.annotations.Measurement;
+import org.openjdk.jmh.annotations.Mode;
+import org.openjdk.jmh.annotations.OutputTimeUnit;
+import org.openjdk.jmh.annotations.Scope;
+import org.openjdk.jmh.annotations.Setup;
+import org.openjdk.jmh.annotations.State;
+import org.openjdk.jmh.annotations.TearDown;
+import org.openjdk.jmh.annotations.Warmup;
+
+import java.io.File;
+import java.io.IOException;
+import java.net.URL;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Random;
+import java.util.concurrent.TimeUnit;
+
+/**
+ * Benchmark that measures throughput of single-threaded client performing 
puts to a loner server.
+ * 
+ * 100 random keys and values are generated during setup and the client 
reuses these in order,
+ * looping back around after 100 puts.
+ */
+@Measurement(iterations = 3, time = 2, timeUnit = MINUTES)
+@Warmup(iterations = 1, time = 1, timeUnit = MINUTES)
+@Fork(3)
+@BenchmarkMode(Mode.Throughput)
--- End diff --

Any reason not to use `Mode.All`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #450: GEODE-2632: create ClientCachePutBench

[galen-pivotal]

Github user galen-pivotal commented on a diff in the pull request:

https://github.com/apache/geode/pull/450#discussion_r112005541
  
--- Diff: 
geode-core/src/jmh/java/org/apache/geode/internal/cache/tier/sockets/command/ClientCachePutBench.java
 ---
@@ -0,0 +1,233 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
+ * or implied. See the License for the specific language governing 
permissions and limitations under
+ * the License.
+ */
+package org.apache.geode.internal.cache.tier.sockets.command;
+
+import static java.lang.System.*;
+import static java.util.concurrent.TimeUnit.*;
+import static org.apache.commons.io.FileUtils.*;
+import static org.apache.commons.lang.StringUtils.*;
+import static org.apache.geode.cache.client.ClientRegionShortcut.*;
+import static org.apache.geode.distributed.AbstractLauncher.Status.*;
+import static org.apache.geode.distributed.ConfigurationProperties.*;
+import static org.apache.geode.distributed.internal.DistributionConfig.*;
+import static org.apache.geode.internal.AvailablePort.*;
+import static org.apache.geode.test.dunit.NetworkUtils.*;
+import static org.assertj.core.api.Assertions.*;
+import static org.awaitility.Awaitility.*;
+
+import org.apache.geode.cache.Region;
+import org.apache.geode.cache.client.ClientCache;
+import org.apache.geode.cache.client.ClientCacheFactory;
+import org.apache.geode.distributed.ServerLauncher;
+import org.apache.geode.internal.process.ProcessStreamReader;
+import org.junit.rules.TemporaryFolder;
+import org.openjdk.jmh.annotations.Benchmark;
+import org.openjdk.jmh.annotations.BenchmarkMode;
+import org.openjdk.jmh.annotations.Fork;
+import org.openjdk.jmh.annotations.Level;
+import org.openjdk.jmh.annotations.Measurement;
+import org.openjdk.jmh.annotations.Mode;
+import org.openjdk.jmh.annotations.OutputTimeUnit;
+import org.openjdk.jmh.annotations.Scope;
+import org.openjdk.jmh.annotations.Setup;
+import org.openjdk.jmh.annotations.State;
+import org.openjdk.jmh.annotations.TearDown;
+import org.openjdk.jmh.annotations.Warmup;
+
+import java.io.File;
+import java.io.IOException;
+import java.net.URL;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Random;
+import java.util.concurrent.TimeUnit;
+
+/**
+ * Benchmark that measures throughput of single-threaded client performing 
puts to a loner server.
+ * 
+ * 100 random keys and values are generated during setup and the client 
reuses these in order,
+ * looping back around after 100 puts.
+ */
+@Measurement(iterations = 3, time = 2, timeUnit = MINUTES)
+@Warmup(iterations = 1, time = 1, timeUnit = MINUTES)
+@Fork(3)
+@BenchmarkMode(Mode.Throughput)
+@OutputTimeUnit(TimeUnit.SECONDS)
+@State(Scope.Thread)
+@SuppressWarnings("unused")
+public class ClientCachePutBench {
+
+  static final String CLASS_NAME = 
ClientCachePutBench.class.getSimpleName();
+  static final String PACKAGE_NAME =
+  replace(ClientCachePutBench.class.getPackage().getName(), ".", "/");
+  static final String REGION_NAME = CLASS_NAME + "-region";
+  static final String SERVER_XML_NAME = "/" + PACKAGE_NAME + "/" + 
CLASS_NAME + "-server.xml";
+  static final long PROCESS_READER_TIMEOUT = 60 * 1000;
+  static final int NUMBER_OF_KEYS = 100;
+  static final int NUMBER_OF_VALUES = 100;
+
+  @State(Scope.Benchmark)
+  public static class ClientState {
+
+Region region;
+
+String[] keys;
+String[] values;
+
+private int keyIndex = -1;
+private int valueIndex = -1;
+
+private Process process;
+private volatile ProcessStreamReader processOutReader;
+private volatile ProcessStreamReader processErrReader;
+
+private int serverPort;
+private ServerLauncher launcher;
+private File serverDirectory;
+private ClientCache clientCache;
+
+private TemporaryFolder temporaryFolder = new TemporaryFolder();
+
+@Setup(Level.Trial)
+public void startServer() throws Exception {
+  System.out

[jira] [Commented] (GEODE-2632) Integrated Security performance improvements

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973058#comment-15973058
 ] 

ASF GitHub Bot commented on GEODE-2632:
---

Github user galen-pivotal commented on a diff in the pull request:

https://github.com/apache/geode/pull/450#discussion_r112004128
  
--- Diff: 
geode-core/src/jmh/java/org/apache/geode/internal/cache/tier/sockets/command/ClientCachePutBench.java
 ---
@@ -0,0 +1,233 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
+ * or implied. See the License for the specific language governing 
permissions and limitations under
+ * the License.
+ */
+package org.apache.geode.internal.cache.tier.sockets.command;
+
+import static java.lang.System.*;
+import static java.util.concurrent.TimeUnit.*;
+import static org.apache.commons.io.FileUtils.*;
+import static org.apache.commons.lang.StringUtils.*;
+import static org.apache.geode.cache.client.ClientRegionShortcut.*;
+import static org.apache.geode.distributed.AbstractLauncher.Status.*;
+import static org.apache.geode.distributed.ConfigurationProperties.*;
+import static org.apache.geode.distributed.internal.DistributionConfig.*;
+import static org.apache.geode.internal.AvailablePort.*;
+import static org.apache.geode.test.dunit.NetworkUtils.*;
+import static org.assertj.core.api.Assertions.*;
+import static org.awaitility.Awaitility.*;
+
+import org.apache.geode.cache.Region;
+import org.apache.geode.cache.client.ClientCache;
+import org.apache.geode.cache.client.ClientCacheFactory;
+import org.apache.geode.distributed.ServerLauncher;
+import org.apache.geode.internal.process.ProcessStreamReader;
+import org.junit.rules.TemporaryFolder;
+import org.openjdk.jmh.annotations.Benchmark;
+import org.openjdk.jmh.annotations.BenchmarkMode;
+import org.openjdk.jmh.annotations.Fork;
+import org.openjdk.jmh.annotations.Level;
+import org.openjdk.jmh.annotations.Measurement;
+import org.openjdk.jmh.annotations.Mode;
+import org.openjdk.jmh.annotations.OutputTimeUnit;
+import org.openjdk.jmh.annotations.Scope;
+import org.openjdk.jmh.annotations.Setup;
+import org.openjdk.jmh.annotations.State;
+import org.openjdk.jmh.annotations.TearDown;
+import org.openjdk.jmh.annotations.Warmup;
+
+import java.io.File;
+import java.io.IOException;
+import java.net.URL;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Random;
+import java.util.concurrent.TimeUnit;
+
+/**
+ * Benchmark that measures throughput of single-threaded client performing 
puts to a loner server.
+ * 
+ * 100 random keys and values are generated during setup and the client 
reuses these in order,
+ * looping back around after 100 puts.
+ */
+@Measurement(iterations = 3, time = 2, timeUnit = MINUTES)
+@Warmup(iterations = 1, time = 1, timeUnit = MINUTES)
+@Fork(3)
+@BenchmarkMode(Mode.Throughput)
+@OutputTimeUnit(TimeUnit.SECONDS)
+@State(Scope.Thread)
--- End diff --

Does `ClientCachePutBench` need to be `State` when it's only got statics?


> Integrated Security performance improvements
> 
>
> Key: GEODE-2632
> URL: https://issues.apache.org/jira/browse/GEODE-2632
> Project: Geode
>  Issue Type: Improvement
>  Components: security
>Reporter: Jinmei Liao
>Assignee: Kirk Lund
>  Labels: performance
>
> There is a security check in Put65.cmdExecute() that, if removed, improved 
> the performance.
> The expense of this security call needs to be reduced in order to get the 
> performance back.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2632) Integrated Security performance improvements

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973056#comment-15973056
 ] 

ASF GitHub Bot commented on GEODE-2632:
---

Github user galen-pivotal commented on a diff in the pull request:

https://github.com/apache/geode/pull/450#discussion_r112005541
  
--- Diff: 
geode-core/src/jmh/java/org/apache/geode/internal/cache/tier/sockets/command/ClientCachePutBench.java
 ---
@@ -0,0 +1,233 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
+ * or implied. See the License for the specific language governing 
permissions and limitations under
+ * the License.
+ */
+package org.apache.geode.internal.cache.tier.sockets.command;
+
+import static java.lang.System.*;
+import static java.util.concurrent.TimeUnit.*;
+import static org.apache.commons.io.FileUtils.*;
+import static org.apache.commons.lang.StringUtils.*;
+import static org.apache.geode.cache.client.ClientRegionShortcut.*;
+import static org.apache.geode.distributed.AbstractLauncher.Status.*;
+import static org.apache.geode.distributed.ConfigurationProperties.*;
+import static org.apache.geode.distributed.internal.DistributionConfig.*;
+import static org.apache.geode.internal.AvailablePort.*;
+import static org.apache.geode.test.dunit.NetworkUtils.*;
+import static org.assertj.core.api.Assertions.*;
+import static org.awaitility.Awaitility.*;
+
+import org.apache.geode.cache.Region;
+import org.apache.geode.cache.client.ClientCache;
+import org.apache.geode.cache.client.ClientCacheFactory;
+import org.apache.geode.distributed.ServerLauncher;
+import org.apache.geode.internal.process.ProcessStreamReader;
+import org.junit.rules.TemporaryFolder;
+import org.openjdk.jmh.annotations.Benchmark;
+import org.openjdk.jmh.annotations.BenchmarkMode;
+import org.openjdk.jmh.annotations.Fork;
+import org.openjdk.jmh.annotations.Level;
+import org.openjdk.jmh.annotations.Measurement;
+import org.openjdk.jmh.annotations.Mode;
+import org.openjdk.jmh.annotations.OutputTimeUnit;
+import org.openjdk.jmh.annotations.Scope;
+import org.openjdk.jmh.annotations.Setup;
+import org.openjdk.jmh.annotations.State;
+import org.openjdk.jmh.annotations.TearDown;
+import org.openjdk.jmh.annotations.Warmup;
+
+import java.io.File;
+import java.io.IOException;
+import java.net.URL;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Random;
+import java.util.concurrent.TimeUnit;
+
+/**
+ * Benchmark that measures throughput of single-threaded client performing 
puts to a loner server.
+ * 
+ * 100 random keys and values are generated during setup and the client 
reuses these in order,
+ * looping back around after 100 puts.
+ */
+@Measurement(iterations = 3, time = 2, timeUnit = MINUTES)
+@Warmup(iterations = 1, time = 1, timeUnit = MINUTES)
+@Fork(3)
+@BenchmarkMode(Mode.Throughput)
+@OutputTimeUnit(TimeUnit.SECONDS)
+@State(Scope.Thread)
+@SuppressWarnings("unused")
+public class ClientCachePutBench {
+
+  static final String CLASS_NAME = 
ClientCachePutBench.class.getSimpleName();
+  static final String PACKAGE_NAME =
+  replace(ClientCachePutBench.class.getPackage().getName(), ".", "/");
+  static final String REGION_NAME = CLASS_NAME + "-region";
+  static final String SERVER_XML_NAME = "/" + PACKAGE_NAME + "/" + 
CLASS_NAME + "-server.xml";
+  static final long PROCESS_READER_TIMEOUT = 60 * 1000;
+  static final int NUMBER_OF_KEYS = 100;
+  static final int NUMBER_OF_VALUES = 100;
+
+  @State(Scope.Benchmark)
+  public static class ClientState {
+
+Region region;
+
+String[] keys;
+String[] values;
+
+private int keyIndex = -1;
+private int valueIndex = -1;
+
+private Process process;
+private volatile ProcessStreamReader processOutReader;
+private volatile ProcessStreamReader processErrReader;
+
+private int serverPort;
+private ServerLauncher launcher;
+privat

[jira] [Commented] (GEODE-2632) Integrated Security performance improvements

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973054#comment-15973054
 ] 

ASF GitHub Bot commented on GEODE-2632:
---

Github user galen-pivotal commented on the issue:

https://github.com/apache/geode/pull/450
  
This will set the same keys to the same values each iteration, because. I 
ran a benchmark last night with a benchmark that used only 99 values, but I 
didn't see a significant difference:
```
Result "performPutFromClientDifferentKeys":
  23532.506 ±(99.9%) 576.405 ops/s [Average]
  (min, avg, max) = (23176.421, 23532.506, 24073.672), stdev = 343.009
  CI (99.9%): [22956.101, 24108.911] (assumes normal distribution)
```
```
Result "performPutFromClient":
  23891.204 ±(99.9%) 133.078 ops/s [Average]
  (min, avg, max) = (23797.325, 23891.204, 24013.180), stdev = 79.193
  CI (99.9%): [23758.126, 24024.283] (assumes normal distribution)
```


> Integrated Security performance improvements
> 
>
> Key: GEODE-2632
> URL: https://issues.apache.org/jira/browse/GEODE-2632
> Project: Geode
>  Issue Type: Improvement
>  Components: security
>Reporter: Jinmei Liao
>Assignee: Kirk Lund
>  Labels: performance
>
> There is a security check in Put65.cmdExecute() that, if removed, improved 
> the performance.
> The expense of this security call needs to be reduced in order to get the 
> performance back.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2632) Integrated Security performance improvements

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973055#comment-15973055
 ] 

ASF GitHub Bot commented on GEODE-2632:
---

Github user galen-pivotal commented on the issue:

https://github.com/apache/geode/pull/450
  
Do you know why I get so many of these messages when I run the benchmark?
```
Encountered duplicate path 
"javassist/bytecode/annotation/ArrayMemberValue.class" during copy operation 
configured with DuplicatesStrategy.WARN
Encountered duplicate path 
"javassist/bytecode/annotation/BooleanMemberValue.class" during copy operation 
configured with DuplicatesStrategy.WARN
Encountered duplicate path 
"javassist/bytecode/annotation/ByteMemberValue.class" during copy operation 
configured with DuplicatesStrategy.WARN
Encountered duplicate path 
"javassist/bytecode/annotation/CharMemberValue.class" during copy operation 
configured with DuplicatesStrategy.WARN
Encountered duplicate path 
"javassist/bytecode/annotation/ClassMemberValue.class" during copy operation 
configured with DuplicatesStrategy.WARN
Encountered duplicate path 
"javassist/bytecode/annotation/DoubleMemberValue.class" during copy operation 
configured with DuplicatesStrategy.WARN
Encountered duplicate path 
"javassist/bytecode/annotation/EnumMemberValue.class" during copy operation 
configured with DuplicatesStrategy.WARN
Encountered duplicate path 
"javassist/bytecode/annotation/FloatMemberValue.class" during copy operation 
configured with DuplicatesStrategy.WARN
Encountered duplicate path 
"javassist/bytecode/annotation/IntegerMemberValue.class" during copy operation 
configured with DuplicatesStrategy.WARN
Encountered duplicate path 
"javassist/bytecode/annotation/LongMemberValue.class" during copy operation 
configured with DuplicatesStrategy.WARN
Encountered duplicate path 
"javassist/bytecode/annotation/MemberValue.class" during copy operation 
configured with DuplicatesStrategy.WARN
Encountered duplicate path 
"javassist/bytecode/annotation/MemberValueVisitor.class" during copy operation 
configured with DuplicatesStrategy.WARN
Encountered duplicate path 
"javassist/bytecode/annotation/ShortMemberValue.class" during copy operation 
configured with DuplicatesStrategy.WARN
```


> Integrated Security performance improvements
> 
>
> Key: GEODE-2632
> URL: https://issues.apache.org/jira/browse/GEODE-2632
> Project: Geode
>  Issue Type: Improvement
>  Components: security
>Reporter: Jinmei Liao
>Assignee: Kirk Lund
>  Labels: performance
>
> There is a security check in Put65.cmdExecute() that, if removed, improved 
> the performance.
> The expense of this security call needs to be reduced in order to get the 
> performance back.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode pull request #450: GEODE-2632: create ClientCachePutBench

[galen-pivotal]

Github user galen-pivotal commented on a diff in the pull request:

https://github.com/apache/geode/pull/450#discussion_r112004128
  
--- Diff: 
geode-core/src/jmh/java/org/apache/geode/internal/cache/tier/sockets/command/ClientCachePutBench.java
 ---
@@ -0,0 +1,233 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
+ * or implied. See the License for the specific language governing 
permissions and limitations under
+ * the License.
+ */
+package org.apache.geode.internal.cache.tier.sockets.command;
+
+import static java.lang.System.*;
+import static java.util.concurrent.TimeUnit.*;
+import static org.apache.commons.io.FileUtils.*;
+import static org.apache.commons.lang.StringUtils.*;
+import static org.apache.geode.cache.client.ClientRegionShortcut.*;
+import static org.apache.geode.distributed.AbstractLauncher.Status.*;
+import static org.apache.geode.distributed.ConfigurationProperties.*;
+import static org.apache.geode.distributed.internal.DistributionConfig.*;
+import static org.apache.geode.internal.AvailablePort.*;
+import static org.apache.geode.test.dunit.NetworkUtils.*;
+import static org.assertj.core.api.Assertions.*;
+import static org.awaitility.Awaitility.*;
+
+import org.apache.geode.cache.Region;
+import org.apache.geode.cache.client.ClientCache;
+import org.apache.geode.cache.client.ClientCacheFactory;
+import org.apache.geode.distributed.ServerLauncher;
+import org.apache.geode.internal.process.ProcessStreamReader;
+import org.junit.rules.TemporaryFolder;
+import org.openjdk.jmh.annotations.Benchmark;
+import org.openjdk.jmh.annotations.BenchmarkMode;
+import org.openjdk.jmh.annotations.Fork;
+import org.openjdk.jmh.annotations.Level;
+import org.openjdk.jmh.annotations.Measurement;
+import org.openjdk.jmh.annotations.Mode;
+import org.openjdk.jmh.annotations.OutputTimeUnit;
+import org.openjdk.jmh.annotations.Scope;
+import org.openjdk.jmh.annotations.Setup;
+import org.openjdk.jmh.annotations.State;
+import org.openjdk.jmh.annotations.TearDown;
+import org.openjdk.jmh.annotations.Warmup;
+
+import java.io.File;
+import java.io.IOException;
+import java.net.URL;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Random;
+import java.util.concurrent.TimeUnit;
+
+/**
+ * Benchmark that measures throughput of single-threaded client performing 
puts to a loner server.
+ * 
+ * 100 random keys and values are generated during setup and the client 
reuses these in order,
+ * looping back around after 100 puts.
+ */
+@Measurement(iterations = 3, time = 2, timeUnit = MINUTES)
+@Warmup(iterations = 1, time = 1, timeUnit = MINUTES)
+@Fork(3)
+@BenchmarkMode(Mode.Throughput)
+@OutputTimeUnit(TimeUnit.SECONDS)
+@State(Scope.Thread)
--- End diff --

Does `ClientCachePutBench` need to be `State` when it's only got statics?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2632) Integrated Security performance improvements

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973057#comment-15973057
 ] 

ASF GitHub Bot commented on GEODE-2632:
---

Github user galen-pivotal commented on a diff in the pull request:

https://github.com/apache/geode/pull/450#discussion_r112005377
  
--- Diff: 
geode-core/src/jmh/java/org/apache/geode/internal/cache/tier/sockets/command/ClientCachePutBench.java
 ---
@@ -0,0 +1,233 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
+ * or implied. See the License for the specific language governing 
permissions and limitations under
+ * the License.
+ */
+package org.apache.geode.internal.cache.tier.sockets.command;
+
+import static java.lang.System.*;
+import static java.util.concurrent.TimeUnit.*;
+import static org.apache.commons.io.FileUtils.*;
+import static org.apache.commons.lang.StringUtils.*;
+import static org.apache.geode.cache.client.ClientRegionShortcut.*;
+import static org.apache.geode.distributed.AbstractLauncher.Status.*;
+import static org.apache.geode.distributed.ConfigurationProperties.*;
+import static org.apache.geode.distributed.internal.DistributionConfig.*;
+import static org.apache.geode.internal.AvailablePort.*;
+import static org.apache.geode.test.dunit.NetworkUtils.*;
+import static org.assertj.core.api.Assertions.*;
+import static org.awaitility.Awaitility.*;
+
+import org.apache.geode.cache.Region;
+import org.apache.geode.cache.client.ClientCache;
+import org.apache.geode.cache.client.ClientCacheFactory;
+import org.apache.geode.distributed.ServerLauncher;
+import org.apache.geode.internal.process.ProcessStreamReader;
+import org.junit.rules.TemporaryFolder;
+import org.openjdk.jmh.annotations.Benchmark;
+import org.openjdk.jmh.annotations.BenchmarkMode;
+import org.openjdk.jmh.annotations.Fork;
+import org.openjdk.jmh.annotations.Level;
+import org.openjdk.jmh.annotations.Measurement;
+import org.openjdk.jmh.annotations.Mode;
+import org.openjdk.jmh.annotations.OutputTimeUnit;
+import org.openjdk.jmh.annotations.Scope;
+import org.openjdk.jmh.annotations.Setup;
+import org.openjdk.jmh.annotations.State;
+import org.openjdk.jmh.annotations.TearDown;
+import org.openjdk.jmh.annotations.Warmup;
+
+import java.io.File;
+import java.io.IOException;
+import java.net.URL;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Random;
+import java.util.concurrent.TimeUnit;
+
+/**
+ * Benchmark that measures throughput of single-threaded client performing 
puts to a loner server.
+ * 
+ * 100 random keys and values are generated during setup and the client 
reuses these in order,
+ * looping back around after 100 puts.
+ */
+@Measurement(iterations = 3, time = 2, timeUnit = MINUTES)
+@Warmup(iterations = 1, time = 1, timeUnit = MINUTES)
+@Fork(3)
+@BenchmarkMode(Mode.Throughput)
--- End diff --

Any reason not to use `Mode.All`?


> Integrated Security performance improvements
> 
>
> Key: GEODE-2632
> URL: https://issues.apache.org/jira/browse/GEODE-2632
> Project: Geode
>  Issue Type: Improvement
>  Components: security
>Reporter: Jinmei Liao
>Assignee: Kirk Lund
>  Labels: performance
>
> There is a security check in Put65.cmdExecute() that, if removed, improved 
> the performance.
> The expense of this security call needs to be reduced in order to get the 
> performance back.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Build failed in Jenkins: Geode-nightly #811

[Apache Jenkins Server]

See 


Changes:

[jiliao] GEODE-2770 - Move the shutdown of the rest interface to the same place

[jiliao] GEODE-2775: Corrected setting of Pulse SSL Manager flag from System

[jstewart] GEODE-2290: Add license headers to rest resources

[jstewart] GEODE-2290: Fix DeployCommandRedeployDUnitTest

[huynhja] GEODE-2768: Lucene Queries executed before index is fully created 
should

[klund] GEODE-2632: refactor code to use InternalCache and

--
[...truncated 134.55 KB...]
at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:102)
at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:107)
at sun.nio.fs.UnixPath.toRealPath(UnixPath.java:876)
at 
io.github.lukehutch.fastclasspathscanner.scanner.Scanner.call(Scanner.java:215)
... 5 more

6852 tests completed, 2 failed, 603 skipped
:geode-core:distributedTest FAILED
:geode-core:flakyTest
:geode-core:integrationTest
:geode-cq:assemble
:geode-cq:compileTestJavaNote: Some input files use or override a deprecated 
API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-cq:processTestResources
:geode-cq:testClasses
:geode-cq:checkMissedTests
:geode-cq:spotlessJavaCheck
:geode-cq:spotlessCheck
:geode-cq:test
:geode-cq:check
:geode-cq:build
:geode-cq:distributedTest
:geode-cq:flakyTest
:geode-cq:integrationTest
:geode-json:assemble
:geode-json:compileTestJava UP-TO-DATE
:geode-json:processTestResources
:geode-json:testClasses
:geode-json:checkMissedTests UP-TO-DATE
:geode-json:spotlessJavaCheck
:geode-json:spotlessCheck
:geode-json:test UP-TO-DATE
:geode-json:check
:geode-json:build
:geode-json:distributedTest UP-TO-DATE
:geode-json:flakyTest UP-TO-DATE
:geode-json:integrationTest UP-TO-DATE
:geode-junit:javadoc
:geode-junit:javadocJar
:geode-junit:sourcesJar
:geode-junit:signArchives SKIPPED
:geode-junit:assemble
:geode-junit:compileTestJava
:geode-junit:processTestResources UP-TO-DATE
:geode-junit:testClasses
:geode-junit:checkMissedTests
:geode-junit:spotlessJavaCheck
:geode-junit:spotlessCheck
:geode-junit:test
:geode-junit:check
:geode-junit:build
:geode-junit:distributedTest
:geode-junit:flakyTest
:geode-junit:integrationTest
:geode-lucene:assemble
:geode-lucene:compileTestJavaNote: Some input files use or override a 
deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-lucene:processTestResources
:geode-lucene:testClasses
:geode-lucene:checkMissedTests
:geode-lucene:spotlessJavaCheck
:geode-lucene:spotlessCheck
:geode-lucene:test
:geode-lucene:check
:geode-lucene:build
:geode-lucene:distributedTest
:geode-lucene:flakyTest
:geode-lucene:integrationTest
:geode-old-client-support:assemble
:geode-old-client-support:compileTestJava
:geode-old-client-support:processTestResources UP-TO-DATE
:geode-old-client-support:testClasses
:geode-old-client-support:checkMissedTests
:geode-old-client-support:spotlessJavaCheck
:geode-old-client-support:spotlessCheck
:geode-old-client-support:test
:geode-old-client-support:check
:geode-old-client-support:build
:geode-old-client-support:distributedTest
:geode-old-client-support:flakyTest
:geode-old-client-support:integrationTest
:geode-old-versions:javadoc UP-TO-DATE
:geode-old-versions:javadocJar
:geode-old-versions:sourcesJar
:geode-old-versions:signArchives SKIPPED
:geode-old-versions:assemble
:geode-old-versions:compileTestJava UP-TO-DATE
:geode-old-versions:processTestResources UP-TO-DATE
:geode-old-versions:testClasses UP-TO-DATE
:geode-old-versions:checkMissedTests UP-TO-DATE
:geode-old-versions:spotlessJavaCheck
:geode-old-versions:spotlessCheck
:geode-old-versions:test UP-TO-DATE
:geode-old-versions:check
:geode-old-versions:build
:geode-old-versions:distributedTest UP-TO-DATE
:geode-old-versions:flakyTest UP-TO-DATE
:geode-old-versions:integrationTest UP-TO-DATE
:geode-pulse:assemble
:geode-pulse:compileTestJavaNote: 

 uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: 

 uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-pulse:processTestResources
:geode-pulse:testClasses
:geode-pulse:checkMissedTests
:geode-pulse:spotlessJavaCheck
:geode-pulse:spotlessCheck
:geode-pulse:test
:geode-pulse:check
:geode-pulse:build
:geode-pulse:distributedTest
:geode-pulse:flakyTest
:geode-pulse:integrationTest
:geode-rebalancer:assemble
:geode-rebalancer:co

[jira] [Updated] (GEODE-2794) REST API Doesn't Accept Primitive Types as Values

[Michael Martell (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Martell updated GEODE-2794:
---
Description: 
Plain text is valid JSON, but is not supported by the REST API. Same issue for 
all primitive types: bool, number, arrays. Only objects are accepted.

Repro example below. Putting the same value from another client works, and we 
are able to get primitive values.
PUT /gemfire-api/v1/orders/234
Request body:
{{"hello"}}

Response:
HTTP 400
Response body:
```
{
  "cause": "Json doc specified is either not supported or invalid!"
}
```

Wrapping the same request as:
```
{"value":"hello"}
```
succeeds (HTTP 200, and entry is saved).

Experienced on Geode 9.0.2.

  was:
Plain text is valid JSON, but is not supported by the REST API. Same issue for 
all primitive types: bool, number, arrays. Only objects are accepted.

Repro example below. Putting the same value from another client works, and we 
are able to get primitive values.
PUT /gemfire-api/v1/orders/234
Request body:
```
"hello"
```

Response:
HTTP 400
Response body:
```
{
  "cause": "Json doc specified is either not supported or invalid!"
}
```

Wrapping the same request as:
```
{"value":"hello"}
```
succeeds (HTTP 200, and entry is saved).

Experienced on Geode 9.0.2.


> REST API Doesn't Accept Primitive Types as Values
> -
>
> Key: GEODE-2794
> URL: https://issues.apache.org/jira/browse/GEODE-2794
> Project: Geode
>  Issue Type: Bug
>  Components: client/server, rest (dev)
>Reporter: Michael Martell
>
> Plain text is valid JSON, but is not supported by the REST API. Same issue 
> for all primitive types: bool, number, arrays. Only objects are accepted.
> Repro example below. Putting the same value from another client works, and we 
> are able to get primitive values.
> PUT /gemfire-api/v1/orders/234
> Request body:
> {{"hello"}}
> Response:
> HTTP 400
> Response body:
> ```
> {
>   "cause": "Json doc specified is either not supported or invalid!"
> }
> ```
> Wrapping the same request as:
> ```
> {"value":"hello"}
> ```
> succeeds (HTTP 200, and entry is saved).
> Experienced on Geode 9.0.2.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2794) REST API Doesn't Accept Primitive Types as Values

[Michael Martell (JIRA)]

Michael Martell created GEODE-2794:
--

 Summary: REST API Doesn't Accept Primitive Types as Values
 Key: GEODE-2794
 URL: https://issues.apache.org/jira/browse/GEODE-2794
 Project: Geode
  Issue Type: Bug
  Components: client/server, rest (dev)
Reporter: Michael Martell


Plain text is valid JSON, but is not supported by the REST API. Same issue for 
all primitive types: bool, number, arrays. Only objects are accepted.

Repro example below. Putting the same value from another client works, and we 
are able to get primitive values.
PUT /gemfire-api/v1/orders/234
Request body:
```
"hello"
```

Response:
HTTP 400
Response body:
```
{
  "cause": "Json doc specified is either not supported or invalid!"
}
```

Wrapping the same request as:
```
{"value":"hello"}
```
succeeds (HTTP 200, and entry is saved).

Experienced on Geode 9.0.2.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Build failed in Jenkins: Geode-nightly #811

[Jared Stewart]

I’m looking into this failure.

- Jared
> On Apr 18, 2017, at 10:02 AM, Apache Jenkins Server 
>  wrote:
> 
> See 
> 
> 
> Changes:
> 
> [jiliao] GEODE-2770 - Move the shutdown of the rest interface to the same 
> place
> 
> [jiliao] GEODE-2775: Corrected setting of Pulse SSL Manager flag from System
> 
> [jstewart] GEODE-2290: Add license headers to rest resources
> 
> [jstewart] GEODE-2290: Fix DeployCommandRedeployDUnitTest
> 
> [huynhja] GEODE-2768: Lucene Queries executed before index is fully created 
> should
> 
> [klund] GEODE-2632: refactor code to use InternalCache and
> 
> --
> [...truncated 134.55 KB...]
>   at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:102)
>   at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:107)
>   at sun.nio.fs.UnixPath.toRealPath(UnixPath.java:876)
>   at 
> io.github.lukehutch.fastclasspathscanner.scanner.Scanner.call(Scanner.java:215)
>   ... 5 more
> 
> 6852 tests completed, 2 failed, 603 skipped
> :geode-core:distributedTest FAILED
> :geode-core:flakyTest
> :geode-core:integrationTest
> :geode-cq:assemble
> :geode-cq:compileTestJavaNote: Some input files use or override a deprecated 
> API.
> Note: Recompile with -Xlint:deprecation for details.
> Note: Some input files use unchecked or unsafe operations.
> Note: Recompile with -Xlint:unchecked for details.
> 
> :geode-cq:processTestResources
> :geode-cq:testClasses
> :geode-cq:checkMissedTests
> :geode-cq:spotlessJavaCheck
> :geode-cq:spotlessCheck
> :geode-cq:test
> :geode-cq:check
> :geode-cq:build
> :geode-cq:distributedTest
> :geode-cq:flakyTest
> :geode-cq:integrationTest
> :geode-json:assemble
> :geode-json:compileTestJava UP-TO-DATE
> :geode-json:processTestResources
> :geode-json:testClasses
> :geode-json:checkMissedTests UP-TO-DATE
> :geode-json:spotlessJavaCheck
> :geode-json:spotlessCheck
> :geode-json:test UP-TO-DATE
> :geode-json:check
> :geode-json:build
> :geode-json:distributedTest UP-TO-DATE
> :geode-json:flakyTest UP-TO-DATE
> :geode-json:integrationTest UP-TO-DATE
> :geode-junit:javadoc
> :geode-junit:javadocJar
> :geode-junit:sourcesJar
> :geode-junit:signArchives SKIPPED
> :geode-junit:assemble
> :geode-junit:compileTestJava
> :geode-junit:processTestResources UP-TO-DATE
> :geode-junit:testClasses
> :geode-junit:checkMissedTests
> :geode-junit:spotlessJavaCheck
> :geode-junit:spotlessCheck
> :geode-junit:test
> :geode-junit:check
> :geode-junit:build
> :geode-junit:distributedTest
> :geode-junit:flakyTest
> :geode-junit:integrationTest
> :geode-lucene:assemble
> :geode-lucene:compileTestJavaNote: Some input files use or override a 
> deprecated API.
> Note: Recompile with -Xlint:deprecation for details.
> Note: Some input files use unchecked or unsafe operations.
> Note: Recompile with -Xlint:unchecked for details.
> 
> :geode-lucene:processTestResources
> :geode-lucene:testClasses
> :geode-lucene:checkMissedTests
> :geode-lucene:spotlessJavaCheck
> :geode-lucene:spotlessCheck
> :geode-lucene:test
> :geode-lucene:check
> :geode-lucene:build
> :geode-lucene:distributedTest
> :geode-lucene:flakyTest
> :geode-lucene:integrationTest
> :geode-old-client-support:assemble
> :geode-old-client-support:compileTestJava
> :geode-old-client-support:processTestResources UP-TO-DATE
> :geode-old-client-support:testClasses
> :geode-old-client-support:checkMissedTests
> :geode-old-client-support:spotlessJavaCheck
> :geode-old-client-support:spotlessCheck
> :geode-old-client-support:test
> :geode-old-client-support:check
> :geode-old-client-support:build
> :geode-old-client-support:distributedTest
> :geode-old-client-support:flakyTest
> :geode-old-client-support:integrationTest
> :geode-old-versions:javadoc UP-TO-DATE
> :geode-old-versions:javadocJar
> :geode-old-versions:sourcesJar
> :geode-old-versions:signArchives SKIPPED
> :geode-old-versions:assemble
> :geode-old-versions:compileTestJava UP-TO-DATE
> :geode-old-versions:processTestResources UP-TO-DATE
> :geode-old-versions:testClasses UP-TO-DATE
> :geode-old-versions:checkMissedTests UP-TO-DATE
> :geode-old-versions:spotlessJavaCheck
> :geode-old-versions:spotlessCheck
> :geode-old-versions:test UP-TO-DATE
> :geode-old-versions:check
> :geode-old-versions:build
> :geode-old-versions:distributedTest UP-TO-DATE
> :geode-old-versions:flakyTest UP-TO-DATE
> :geode-old-versions:integrationTest UP-TO-DATE
> :geode-pulse:assemble
> :geode-pulse:compileTestJavaNote: 
> 
>  uses or overrides a deprecated API.
> Note: Recompile with -Xlint:deprecation for details.
> Note: 
> 
>  uses unchecked or unsafe operations.
> Note: Reco

[jira] [Updated] (GEODE-2794) REST API Doesn't Accept Primitive Types as Values

[Michael Martell (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Martell updated GEODE-2794:
---
Description: 
Plain text is valid JSON, but is not supported by the REST API. Same issue for 
all primitive types: bool, number, arrays. Only objects are accepted.

Repro example below. Putting the same value from another client works, and we 
are able to get primitive values.
PUT /gemfire-api/v1/orders/234
Request body:
{{"hello"}}

Response:
HTTP 400
Response body:
{{{
  "cause": "Json doc specified is either not supported or invalid!"
}}}

Wrapping the same request as:
{{{"value":"hello"}}}
succeeds (HTTP 200, and entry is saved).

Experienced on Geode 9.0.2.

  was:
Plain text is valid JSON, but is not supported by the REST API. Same issue for 
all primitive types: bool, number, arrays. Only objects are accepted.

Repro example below. Putting the same value from another client works, and we 
are able to get primitive values.
PUT /gemfire-api/v1/orders/234
Request body:
{{"hello"}}

Response:
HTTP 400
Response body:
```
{
  "cause": "Json doc specified is either not supported or invalid!"
}
```

Wrapping the same request as:
```
{"value":"hello"}
```
succeeds (HTTP 200, and entry is saved).

Experienced on Geode 9.0.2.


> REST API Doesn't Accept Primitive Types as Values
> -
>
> Key: GEODE-2794
> URL: https://issues.apache.org/jira/browse/GEODE-2794
> Project: Geode
>  Issue Type: Bug
>  Components: client/server, rest (dev)
>Reporter: Michael Martell
>
> Plain text is valid JSON, but is not supported by the REST API. Same issue 
> for all primitive types: bool, number, arrays. Only objects are accepted.
> Repro example below. Putting the same value from another client works, and we 
> are able to get primitive values.
> PUT /gemfire-api/v1/orders/234
> Request body:
> {{"hello"}}
> Response:
> HTTP 400
> Response body:
> {{{
>   "cause": "Json doc specified is either not supported or invalid!"
> }}}
> Wrapping the same request as:
> {{{"value":"hello"}}}
> succeeds (HTTP 200, and entry is saved).
> Experienced on Geode 9.0.2.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: geode git commit: GEODE-2775: Corrected setting of Pulse SSL Manager flag from System properties instead of pulse.properties when running in embedded mode.

[Bruce Schuchardt]

spotlessCheck is broken by this commit

Le 4/17/2017 à 8:06 AM, jinmeil...@apache.org a écrit :

Repository: geode
Updated Branches:
   refs/heads/develop 3a3077094 -> 3423f6f5a


GEODE-2775: Corrected setting of Pulse SSL Manager flag from System properties 
instead of pulse.properties when running in embedded mode.

* this closes #454


Project: http://git-wip-us.apache.org/repos/asf/geode/repo
Commit: http://git-wip-us.apache.org/repos/asf/geode/commit/3423f6f5
Tree: http://git-wip-us.apache.org/repos/asf/geode/tree/3423f6f5
Diff: http://git-wip-us.apache.org/repos/asf/geode/diff/3423f6f5

Branch: refs/heads/develop
Commit: 3423f6f5a9102859fdae8a95c7715dfd64dacc75
Parents: 3a30770
Author: Patrick Rhomberg 
Authored: Wed Apr 12 11:39:11 2017 -0700
Committer: Jinmei Liao 
Committed: Mon Apr 17 08:06:01 2017 -0700

--
  .../tools/pulse/PulseSecurityWithSSLTest.java   | 83 
  .../management/internal/ManagementAgent.java| 16 ++--
  .../tools/pulse/internal/PulseAppListener.java  |  4 +
  3 files changed, 95 insertions(+), 8 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/geode/blob/3423f6f5/geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseSecurityWithSSLTest.java
--
diff --git 
a/geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseSecurityWithSSLTest.java
 
b/geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseSecurityWithSSLTest.java
new file mode 100644
index 000..3b9cd72
--- /dev/null
+++ 
b/geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseSecurityWithSSLTest.java
@@ -0,0 +1,83 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional 
information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY 
KIND, either express
+ * or implied. See the License for the specific language governing permissions 
and limitations under
+ * the License.
+ */
+
+package org.apache.geode.tools.pulse;
+
+import static org.apache.geode.distributed.ConfigurationProperties.SSL_CIPHERS;
+import static 
org.apache.geode.distributed.ConfigurationProperties.SSL_ENABLED_COMPONENTS;
+import static 
org.apache.geode.distributed.ConfigurationProperties.SSL_KEYSTORE;
+import static 
org.apache.geode.distributed.ConfigurationProperties.SSL_KEYSTORE_PASSWORD;
+import static 
org.apache.geode.distributed.ConfigurationProperties.SSL_PROTOCOLS;
+import static 
org.apache.geode.distributed.ConfigurationProperties.SSL_TRUSTSTORE;
+import static 
org.apache.geode.distributed.ConfigurationProperties.SSL_TRUSTSTORE_PASSWORD;
+import static org.apache.geode.util.test.TestUtil.getResourcePath;
+import static org.assertj.core.api.Assertions.assertThat;
+
+import org.apache.geode.security.SecurableCommunicationChannels;
+import org.apache.geode.security.SimpleTestSecurityManager;
+import org.apache.geode.test.dunit.rules.HttpClientRule;
+import org.apache.geode.test.dunit.rules.LocatorStarterRule;
+import org.apache.geode.test.junit.categories.IntegrationTest;
+import org.apache.http.HttpResponse;
+import org.junit.BeforeClass;
+import org.junit.ClassRule;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+
+import java.io.File;
+import java.util.Properties;
+
+
+@Category(IntegrationTest.class)
+public class PulseSecurityWithSSLTest {
+
+  private static File jks =
+  new File(getResourcePath(PulseSecurityWithSSLTest.class, 
"/ssl/trusted.keystore"));
+
+  @ClassRule
+  public static LocatorStarterRule locator = new LocatorStarterRule();
+
+  @BeforeClass
+  public static void beforeClass() throws Exception {
+Properties securityProps = new Properties();
+securityProps.setProperty(SSL_ENABLED_COMPONENTS, 
SecurableCommunicationChannels.JMX);
+securityProps.setProperty(SSL_KEYSTORE, jks.getCanonicalPath());
+securityProps.setProperty(SSL_KEYSTORE_PASSWORD, "password");
+// securityProps.setProperty(SSL_KEYSTORE_TYPE, "JKS");
+securityProps.setProperty(SSL_TRUSTSTORE, jks.getCanonicalPath());
+securityProps.setProperty(SSL_TRUSTSTORE_PASSWORD, "password");
+securityProps.setProperty(SSL_PROTOCOLS, "TLSv1.2");
+securityProps.setProperty(SSL_CIPHERS, "any");
+
+
locator.withSecurityManager(SimpleTestSecurityManager.class).withProperties(sec

[jira] [Updated] (GEODE-2794) REST API Doesn't Accept Primitive Types as Values

[Michael Martell (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Martell updated GEODE-2794:
---
Description: 
Plain text is valid JSON, but is not supported by the REST API. Same issue for 
all primitive types: bool, number, arrays. Only objects are accepted.

Repro example below. Putting the same value from another client works, and we 
are able to get primitive values.
PUT /gemfire-api/v1/orders/234
Request body:
{code:javascript}"hello"{code}

Response:
HTTP 400
Response body:
{color:red}
{code:javascript}
{
  "cause": "Json doc specified is either not supported or invalid!"
}
{code}
{color}

Wrapping the same request as:
{code:javascript} {"value":"hello"} {code}
succeeds (HTTP 200, and entry is saved).

Experienced on Geode 9.0.2.

  was:
Plain text is valid JSON, but is not supported by the REST API. Same issue for 
all primitive types: bool, number, arrays. Only objects are accepted.

Repro example below. Putting the same value from another client works, and we 
are able to get primitive values.
PUT /gemfire-api/v1/orders/234
Request body:
{{"hello"}}

Response:
HTTP 400
Response body:
{{{
  "cause": "Json doc specified is either not supported or invalid!"
}}}

Wrapping the same request as:
{{{"value":"hello"}}}
succeeds (HTTP 200, and entry is saved).

Experienced on Geode 9.0.2.


> REST API Doesn't Accept Primitive Types as Values
> -
>
> Key: GEODE-2794
> URL: https://issues.apache.org/jira/browse/GEODE-2794
> Project: Geode
>  Issue Type: Bug
>  Components: client/server, rest (dev)
>Reporter: Michael Martell
>
> Plain text is valid JSON, but is not supported by the REST API. Same issue 
> for all primitive types: bool, number, arrays. Only objects are accepted.
> Repro example below. Putting the same value from another client works, and we 
> are able to get primitive values.
> PUT /gemfire-api/v1/orders/234
> Request body:
> {code:javascript}"hello"{code}
> Response:
> HTTP 400
> Response body:
> {color:red}
> {code:javascript}
> {
>   "cause": "Json doc specified is either not supported or invalid!"
> }
> {code}
> {color}
> Wrapping the same request as:
> {code:javascript} {"value":"hello"} {code}
> succeeds (HTTP 200, and entry is saved).
> Experienced on Geode 9.0.2.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2795) Nightly build failure: CreateAlterDestroyRegionCommandsDUnitTest

[Jared Stewart (JIRA)]

Jared Stewart created GEODE-2795:


 Summary: Nightly build failure: 
CreateAlterDestroyRegionCommandsDUnitTest
 Key: GEODE-2795
 URL: https://issues.apache.org/jira/browse/GEODE-2795
 Project: Geode
  Issue Type: Bug
Reporter: Jared Stewart


It looks like the nightly build is failing due to polluted DUnit vms.  
(FastClassPathScanner uses the Path api instead of the File api, and while File 
accepts modified values of System.getProperty("user.dir"), Path does not).

{noformat}
:geode-core:distributedTest

org.apache.geode.management.internal.cli.commands.CreateAlterDestroyRegionCommandsDUnitTest
 > testAlterRegionResetCacheListeners FAILED
java.lang.AssertionError: Suspicious strings were written to the log during 
this run.
Fix the strings or use IgnoredException.addIgnoredException to ignore.
---
Found suspect string in log4j at line 908

[error 2017/04/18 10:12:26.647 UTC  
tid=0x5d9] Could not deploy JAR file java.lang.RuntimeException: 
java.nio.file.NoSuchFileException: /tmp/junit3985345267510453893/server-1
java.lang.RuntimeException: java.lang.RuntimeException: 
java.nio.file.NoSuchFileException: /tmp/junit3985345267510453893/server-1
at 
io.github.lukehutch.fastclasspathscanner.FastClasspathScanner.scan(FastClasspathScanner.java:1115)
at 
io.github.lukehutch.fastclasspathscanner.FastClasspathScanner.scan(FastClasspathScanner.java:1143)
at 
io.github.lukehutch.fastclasspathscanner.FastClasspathScanner.scan(FastClasspathScanner.java:1166)
at 
org.apache.geode.internal.DeployedJar.findFunctionsInThisJar(DeployedJar.java:328)
at 
org.apache.geode.internal.DeployedJar.loadClassesAndRegisterFunctions(DeployedJar.java:175)
at 
org.apache.geode.internal.JarDeployer.registerNewVersions(JarDeployer.java:477)
at org.apache.geode.internal.JarDeployer.deploy(JarDeployer.java:516)
at 
org.apache.geode.management.internal.cli.functions.DeployFunction.execute(DeployFunction.java:68)
at 
org.apache.geode.internal.cache.MemberFunctionStreamingMessage.process(MemberFunctionStreamingMessage.java:191)
at 
org.apache.geode.distributed.internal.DistributionMessage.scheduleAction(DistributionMessage.java:376)
at 
org.apache.geode.distributed.internal.DistributionMessage$1.run(DistributionMessage.java:442)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at 
org.apache.geode.distributed.internal.DistributionManager.runUntilShutdown(DistributionManager.java:621)
at 
org.apache.geode.distributed.internal.DistributionManager$9$1.run(DistributionManager.java:1067)
at java.lang.Thread.run(Thread.java:745)
Caused by: java.lang.RuntimeException: java.nio.file.NoSuchFileException: 
/tmp/junit3985345267510453893/server-1
at 
io.github.lukehutch.fastclasspathscanner.scanner.Scanner.call(Scanner.java:217)
at 
io.github.lukehutch.fastclasspathscanner.scanner.Scanner.call(Scanner.java:61)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
... 1 more
Caused by: java.nio.file.NoSuchFileException: 
/tmp/junit3985345267510453893/server-1
at 
sun.nio.fs.UnixException.translateToIOException(UnixException.java:86)
at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:102)
at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:107)
at sun.nio.fs.UnixPath.toRealPath(UnixPath.java:876)
at 
io.github.lukehutch.fastclasspathscanner.scanner.Scanner.call(Scanner.java:215)
... 5 more

---
Found suspect string in log4j at line 945

[error 2017/04/18 10:12:26.671 UTC  
tid=0x5b1] Could not deploy JAR file java.lang.RuntimeException: 
java.nio.file.NoSuchFileException: /tmp/junit3985345267510453893/locator-0
java.lang.RuntimeException: java.lang.RuntimeException: 
java.nio.file.NoSuchFileException: /tmp/junit3985345267510453893/locator-0
at 
io.github.lukehutch.fastclasspathscanner.FastClasspathScanner.scan(FastClasspathScanner.java:1115)
at 
io.github.lukehutch.fastclasspathscanner.FastClasspathScanner.scan(FastClasspathScanner.java:1143)
at 
io.github.lukehutch.fastclasspathscanner.FastClasspathScanner.scan(FastClasspathScanner.java:1166)
at 
org.apache.geode.internal.DeployedJar.findFunctionsInThisJar(DeployedJar.java:328)
at 
org.apache.geode.internal.DeployedJar.loadClassesAndReg

[jira] [Updated] (GEODE-2487) SSL should not require external security library

[Ernest Burghardt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ernest Burghardt updated GEODE-2487:

Description: 
Geode Native requires that cryptoImpl library be compiled by the end user to 
support SSL. The rational for this has been lost but was likely to avoid either 
export control, which it does not, or to make dynamic loading of OpenSSL 
easier, which I am not sure it does.

Refactor SSL sockets to initialize and use OpenSSL (via ACE_SSL) directly and 
remove it from cryptoImpl library. If there is no other purpose for cryptoImpl 
library then purge it.

  was:
Geode Native requires that securityImpl library be compiled by the end user to 
support SSL. The rational for this has been lost but was likely to avoid either 
export control, which it does not, or to make dynamic loading of OpenSSL 
easier, which I am not sure it does.

Refactor SSL sockets to initialize and use OpenSSL (via ACE_SSL) directly and 
remove it from securityImpl library. If there is no other purpose for 
securityImpl library then purge it.


> SSL should not require external security library
> 
>
> Key: GEODE-2487
> URL: https://issues.apache.org/jira/browse/GEODE-2487
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Jacob S. Barrett
>
> Geode Native requires that cryptoImpl library be compiled by the end user to 
> support SSL. The rational for this has been lost but was likely to avoid 
> either export control, which it does not, or to make dynamic loading of 
> OpenSSL easier, which I am not sure it does.
> Refactor SSL sockets to initialize and use OpenSSL (via ACE_SSL) directly and 
> remove it from cryptoImpl library. If there is no other purpose for 
> cryptoImpl library then purge it.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Conditional bug in LocalRegion.concurrencyConfigurationCheck

[Darrel Schneider]

Bruce is correct that my refactored code is wrong.
I thought this method was called on the server but it is actually only
called on the client when the server pushes a message to the client through
the subscription queue.

So the current code is correct; just a bit hard to understand.


On Mon, Apr 17, 2017 at 10:17 AM, Bruce Schuchardt 
wrote:

> +1
> I think that code makes the method easier to understand but I don't think
> the current message would be incorrect.  The log message is only issued if
> the server's setting doesn't match the client's setting, so
> !clientCCEnabled is going to equal the serverCCEnabled that you've
> introduced.
>
>
> Le 4/17/2017 à 9:58 AM, Darrel Schneider a écrit :
>
>> The first part of the condition "!this.concurrencyMessageIssued" is just
>> simply to make sure we only log this message once.
>> The second part "(tag != null) != this.concurrencyChecksEnabled" could be
>> changed to this:
>>boolean serverCCEnabled = this.concurrencyChecksEnabled;
>>boolean clientCCEnabled = tag != null;
>>if (clientCCEnabled != serverCCEnabled)
>>  log message
>>
>> The only bug I see in this method is in the actual log message.
>> Arg 0 describes how the server has CC configured and arg 1 describes how
>> the client has CC configured.
>> But by passing "!this.concurrencyChecksEnabled" as arg 0 the message will
>> actually tell you how the server is NOT configured.
>> And by passing "this.concurrencyChecksEnabled" as arg 1 the message will
>> actually tell you how the client is NOT configured.
>>
>> If the code was changed to use these two booleans then they could also be
>> passed as the args to the log message and I think this method would be
>> easier to understand.
>>
>> The new code would be this:
>>
>>private void concurrencyConfigurationCheck(VersionTag tag) {
>>>  if (this.concurrencyMessageIssued) {
>>>return;
>>>  }
>>>  boolean serverConcurrencyChecksEnabled =
>>> this.concurrencyChecksEnabled;
>>>  boolean clientConcurrencyChecksEnabled = tag != null;
>>>  if (clientConcurrencyChecksEnabled !=
>>> serverConcurrencyChecksEnabled) {
>>>this.concurrencyMessageIssued = true;
>>>logger.info(LocalizedMessage.create(
>>>
>>> LocalizedStrings.LocalRegion_SERVER_HAS_CONCURRENCY_CHECKS_E
>>> NABLED_0_BUT_CLIENT_HAS_1_FOR_REGION_2,
>>>new Object[] {serverConcurrencyChecksEnabled,
>>> clientConcurrencyChecksEnabled, this}));
>>>  }
>>>}
>>>
>> What do you think?
>>
>>
>> On Fri, Apr 14, 2017 at 6:50 PM, Kirk Lund  wrote:
>>
>> I can't quite make out what the conditional is actually supposed to be
>>> checking in the second half but it definitely looks wrong to me. Anyone
>>> familiar with this method or what it's supposed to be doing?
>>>
>>> private void concurrencyConfigurationCheck(VersionTag tag) {
>>>// TODO: double negative in next line must be a bug
>>>if (!this.concurrencyMessageIssued && *((tag != null) !=
>>> this.concurrencyChecksEnabled)*) {
>>>  this.concurrencyMessageIssued = true;
>>>  logger.info(LocalizedMessage.create(
>>>
>>> LocalizedStrings.LocalRegion_SERVER_HAS_CONCURRENCY_CHECKS_
>>> ENABLED_0_BUT_CLIENT_HAS_1_FOR_REGION_2,
>>>  new Object[] {!this.concurrencyChecksEnabled,
>>> this.concurrencyChecksEnabled, this}));
>>>}
>>> }
>>>
>>>
>

[jira] [Resolved] (GEODE-2792) Server has concurrencyChecksEnabled log message has the booleans switched

[Darrel Schneider (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Darrel Schneider resolved GEODE-2792.
-
Resolution: Not A Problem

I thought this method was called the server.
But it is actually only called on a client when the server pushes messages to 
the client through the subscription queue.

So I am going to resolve this ticked as not being a problem.


> Server has concurrencyChecksEnabled log message has the booleans switched
> -
>
> Key: GEODE-2792
> URL: https://issues.apache.org/jira/browse/GEODE-2792
> Project: Geode
>  Issue Type: Bug
>  Components: regions
>Reporter: Darrel Schneider
>Priority: Trivial
>
> The log message: "Server has concurrencyChecksEnabled {0} but client has {1}" 
> should instead be:  "Server has concurrencyChecksEnabled {1} but client has 
> {0}".



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2796) NPE in ClassPathLoader

[Jared Stewart (JIRA)]

Jared Stewart created GEODE-2796:


 Summary: NPE in ClassPathLoader
 Key: GEODE-2796
 URL: https://issues.apache.org/jira/browse/GEODE-2796
 Project: Geode
  Issue Type: Bug
  Components: management
Reporter: Jared Stewart


It looks like an NPE was introduced by the fix for GEODE-2290:

{noformat}
Caused by: java.lang.NullPointerException
at 
org.apache.geode.internal.ClassPathLoader.getResource(ClassPathLoader.java:130)
at 
org.apache.geode.internal.ClassPathLoader.getResourceAsStream(ClassPathLoader.java:239)
at 
org.apache.geode.internal.ClassPathLoader.getResourceAsStream(ClassPathLoader.java:264)
at 
org.apache.geode.internal.GemFireVersion$VersionDescription.(GemFireVersion.java:191)
at 
org.apache.geode.internal.GemFireVersion.getDescription(GemFireVersion.java:52)
at 
org.apache.geode.internal.GemFireVersion.getGemFireVersion(GemFireVersion.java:66)
at org.apache.geode.cache.CacheFactory.getVersion(CacheFactory.java:305)
...
{noformat}

This is caused by the following method: 
{noformat}
 private List getClassLoaders() {
ArrayList classLoaders = new ArrayList<>();

if (!excludeTCCL) {
  classLoaders.add(Thread.currentThread().getContextClassLoader());
}

classLoaders.add(classLoaderForDeployedJars);

return classLoaders;
  }
{noformat}

According to the JavaDocs, `getContextClassLoader()` actually returns null to 
indicate the system class loader (rather than actually returning the system 
class loader).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (GEODE-2796) NPE in ClassPathLoader

[Jared Stewart (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jared Stewart reassigned GEODE-2796:


Assignee: Jared Stewart

> NPE in ClassPathLoader
> --
>
> Key: GEODE-2796
> URL: https://issues.apache.org/jira/browse/GEODE-2796
> Project: Geode
>  Issue Type: Bug
>  Components: management
>Reporter: Jared Stewart
>Assignee: Jared Stewart
>
> It looks like an NPE was introduced by the fix for GEODE-2290:
> {noformat}
> Caused by: java.lang.NullPointerException
> at 
> org.apache.geode.internal.ClassPathLoader.getResource(ClassPathLoader.java:130)
> at 
> org.apache.geode.internal.ClassPathLoader.getResourceAsStream(ClassPathLoader.java:239)
> at 
> org.apache.geode.internal.ClassPathLoader.getResourceAsStream(ClassPathLoader.java:264)
> at 
> org.apache.geode.internal.GemFireVersion$VersionDescription.(GemFireVersion.java:191)
> at 
> org.apache.geode.internal.GemFireVersion.getDescription(GemFireVersion.java:52)
> at 
> org.apache.geode.internal.GemFireVersion.getGemFireVersion(GemFireVersion.java:66)
> at org.apache.geode.cache.CacheFactory.getVersion(CacheFactory.java:305)
> ...
> {noformat}
> This is caused by the following method: 
> {noformat}
>  private List getClassLoaders() {
> ArrayList classLoaders = new ArrayList<>();
> if (!excludeTCCL) {
>   classLoaders.add(Thread.currentThread().getContextClassLoader());
> }
> classLoaders.add(classLoaderForDeployedJars);
> return classLoaders;
>   }
> {noformat}
> According to the JavaDocs, `getContextClassLoader()` actually returns null to 
> indicate the system class loader (rather than actually returning the system 
> class loader).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (GEODE-2795) Nightly build failure: CreateAlterDestroyRegionCommandsDUnitTest

[Jared Stewart (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jared Stewart reassigned GEODE-2795:


Assignee: Jared Stewart

> Nightly build failure: CreateAlterDestroyRegionCommandsDUnitTest
> 
>
> Key: GEODE-2795
> URL: https://issues.apache.org/jira/browse/GEODE-2795
> Project: Geode
>  Issue Type: Bug
>  Components: management
>Reporter: Jared Stewart
>Assignee: Jared Stewart
>
> It looks like the nightly build is failing due to polluted DUnit vms.  
> (FastClassPathScanner uses the Path api instead of the File api, and while 
> File accepts modified values of System.getProperty("user.dir"), Path does 
> not).
> {noformat}
> :geode-core:distributedTest
> org.apache.geode.management.internal.cli.commands.CreateAlterDestroyRegionCommandsDUnitTest
>  > testAlterRegionResetCacheListeners FAILED
> java.lang.AssertionError: Suspicious strings were written to the log 
> during this run.
> Fix the strings or use IgnoredException.addIgnoredException to ignore.
> ---
> Found suspect string in log4j at line 908
> [error 2017/04/18 10:12:26.647 UTC  
> tid=0x5d9] Could not deploy JAR file java.lang.RuntimeException: 
> java.nio.file.NoSuchFileException: /tmp/junit3985345267510453893/server-1
> java.lang.RuntimeException: java.lang.RuntimeException: 
> java.nio.file.NoSuchFileException: /tmp/junit3985345267510453893/server-1
>   at 
> io.github.lukehutch.fastclasspathscanner.FastClasspathScanner.scan(FastClasspathScanner.java:1115)
>   at 
> io.github.lukehutch.fastclasspathscanner.FastClasspathScanner.scan(FastClasspathScanner.java:1143)
>   at 
> io.github.lukehutch.fastclasspathscanner.FastClasspathScanner.scan(FastClasspathScanner.java:1166)
>   at 
> org.apache.geode.internal.DeployedJar.findFunctionsInThisJar(DeployedJar.java:328)
>   at 
> org.apache.geode.internal.DeployedJar.loadClassesAndRegisterFunctions(DeployedJar.java:175)
>   at 
> org.apache.geode.internal.JarDeployer.registerNewVersions(JarDeployer.java:477)
>   at org.apache.geode.internal.JarDeployer.deploy(JarDeployer.java:516)
>   at 
> org.apache.geode.management.internal.cli.functions.DeployFunction.execute(DeployFunction.java:68)
>   at 
> org.apache.geode.internal.cache.MemberFunctionStreamingMessage.process(MemberFunctionStreamingMessage.java:191)
>   at 
> org.apache.geode.distributed.internal.DistributionMessage.scheduleAction(DistributionMessage.java:376)
>   at 
> org.apache.geode.distributed.internal.DistributionMessage$1.run(DistributionMessage.java:442)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at 
> org.apache.geode.distributed.internal.DistributionManager.runUntilShutdown(DistributionManager.java:621)
>   at 
> org.apache.geode.distributed.internal.DistributionManager$9$1.run(DistributionManager.java:1067)
>   at java.lang.Thread.run(Thread.java:745)
> Caused by: java.lang.RuntimeException: java.nio.file.NoSuchFileException: 
> /tmp/junit3985345267510453893/server-1
>   at 
> io.github.lukehutch.fastclasspathscanner.scanner.Scanner.call(Scanner.java:217)
>   at 
> io.github.lukehutch.fastclasspathscanner.scanner.Scanner.call(Scanner.java:61)
>   at java.util.concurrent.FutureTask.run(FutureTask.java:266)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   ... 1 more
> Caused by: java.nio.file.NoSuchFileException: 
> /tmp/junit3985345267510453893/server-1
>   at 
> sun.nio.fs.UnixException.translateToIOException(UnixException.java:86)
>   at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:102)
>   at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:107)
>   at sun.nio.fs.UnixPath.toRealPath(UnixPath.java:876)
>   at 
> io.github.lukehutch.fastclasspathscanner.scanner.Scanner.call(Scanner.java:215)
>   ... 5 more
> ---
> Found suspect string in log4j at line 945
> [error 2017/04/18 10:12:26.671 UTC  
> tid=0x5b1] Could not deploy JAR file java.lang.RuntimeException: 
> java.nio.file.NoSuchFileException: /tmp/junit3985345267510453893/locator-0
> java.lang.RuntimeException: java.lang.RuntimeException: 
> java.nio.file.NoSuchFileException: /tmp/junit3985345267510453893/locator-0
>   at 
> io.github.lukehutch.fastclasspathscanner.FastClasspathScanner.scan(FastClasspathScanner.java:1115)
>   

[jira] [Updated] (GEODE-2795) Nightly build failure: CreateAlterDestroyRegionCommandsDUnitTest

[Jared Stewart (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jared Stewart updated GEODE-2795:
-
Component/s: management

> Nightly build failure: CreateAlterDestroyRegionCommandsDUnitTest
> 
>
> Key: GEODE-2795
> URL: https://issues.apache.org/jira/browse/GEODE-2795
> Project: Geode
>  Issue Type: Bug
>  Components: management
>Reporter: Jared Stewart
>Assignee: Jared Stewart
>
> It looks like the nightly build is failing due to polluted DUnit vms.  
> (FastClassPathScanner uses the Path api instead of the File api, and while 
> File accepts modified values of System.getProperty("user.dir"), Path does 
> not).
> {noformat}
> :geode-core:distributedTest
> org.apache.geode.management.internal.cli.commands.CreateAlterDestroyRegionCommandsDUnitTest
>  > testAlterRegionResetCacheListeners FAILED
> java.lang.AssertionError: Suspicious strings were written to the log 
> during this run.
> Fix the strings or use IgnoredException.addIgnoredException to ignore.
> ---
> Found suspect string in log4j at line 908
> [error 2017/04/18 10:12:26.647 UTC  
> tid=0x5d9] Could not deploy JAR file java.lang.RuntimeException: 
> java.nio.file.NoSuchFileException: /tmp/junit3985345267510453893/server-1
> java.lang.RuntimeException: java.lang.RuntimeException: 
> java.nio.file.NoSuchFileException: /tmp/junit3985345267510453893/server-1
>   at 
> io.github.lukehutch.fastclasspathscanner.FastClasspathScanner.scan(FastClasspathScanner.java:1115)
>   at 
> io.github.lukehutch.fastclasspathscanner.FastClasspathScanner.scan(FastClasspathScanner.java:1143)
>   at 
> io.github.lukehutch.fastclasspathscanner.FastClasspathScanner.scan(FastClasspathScanner.java:1166)
>   at 
> org.apache.geode.internal.DeployedJar.findFunctionsInThisJar(DeployedJar.java:328)
>   at 
> org.apache.geode.internal.DeployedJar.loadClassesAndRegisterFunctions(DeployedJar.java:175)
>   at 
> org.apache.geode.internal.JarDeployer.registerNewVersions(JarDeployer.java:477)
>   at org.apache.geode.internal.JarDeployer.deploy(JarDeployer.java:516)
>   at 
> org.apache.geode.management.internal.cli.functions.DeployFunction.execute(DeployFunction.java:68)
>   at 
> org.apache.geode.internal.cache.MemberFunctionStreamingMessage.process(MemberFunctionStreamingMessage.java:191)
>   at 
> org.apache.geode.distributed.internal.DistributionMessage.scheduleAction(DistributionMessage.java:376)
>   at 
> org.apache.geode.distributed.internal.DistributionMessage$1.run(DistributionMessage.java:442)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at 
> org.apache.geode.distributed.internal.DistributionManager.runUntilShutdown(DistributionManager.java:621)
>   at 
> org.apache.geode.distributed.internal.DistributionManager$9$1.run(DistributionManager.java:1067)
>   at java.lang.Thread.run(Thread.java:745)
> Caused by: java.lang.RuntimeException: java.nio.file.NoSuchFileException: 
> /tmp/junit3985345267510453893/server-1
>   at 
> io.github.lukehutch.fastclasspathscanner.scanner.Scanner.call(Scanner.java:217)
>   at 
> io.github.lukehutch.fastclasspathscanner.scanner.Scanner.call(Scanner.java:61)
>   at java.util.concurrent.FutureTask.run(FutureTask.java:266)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   ... 1 more
> Caused by: java.nio.file.NoSuchFileException: 
> /tmp/junit3985345267510453893/server-1
>   at 
> sun.nio.fs.UnixException.translateToIOException(UnixException.java:86)
>   at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:102)
>   at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:107)
>   at sun.nio.fs.UnixPath.toRealPath(UnixPath.java:876)
>   at 
> io.github.lukehutch.fastclasspathscanner.scanner.Scanner.call(Scanner.java:215)
>   ... 5 more
> ---
> Found suspect string in log4j at line 945
> [error 2017/04/18 10:12:26.671 UTC  
> tid=0x5b1] Could not deploy JAR file java.lang.RuntimeException: 
> java.nio.file.NoSuchFileException: /tmp/junit3985345267510453893/locator-0
> java.lang.RuntimeException: java.lang.RuntimeException: 
> java.nio.file.NoSuchFileException: /tmp/junit3985345267510453893/locator-0
>   at 
> io.github.lukehutch.fastclasspathscanner.FastClasspathScanner.scan(FastClasspathScanner.java:1115)
>   at 

[jira] [Resolved] (GEODE-2766) Only apply patches for dependencies on relevant architectures

[Ernest Burghardt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ernest Burghardt resolved GEODE-2766.
-
Resolution: Fixed

> Only apply patches for dependencies on relevant architectures
> -
>
> Key: GEODE-2766
> URL: https://issues.apache.org/jira/browse/GEODE-2766
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Jens Deppe
>Assignee: Jens Deppe
>
> Currently the patches for openssl and ACE are only required for Solaris but 
> are still applied on all platforms. This can break on Windows if the patching 
> tool cannot correctly convert Windows/Unix line-endings.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2797) Linq support in Native Client

[Addison (JIRA)]

Addison created GEODE-2797:
--

 Summary: Linq support in Native Client
 Key: GEODE-2797
 URL: https://issues.apache.org/jira/browse/GEODE-2797
 Project: Geode
  Issue Type: Wish
  Components: native client
Reporter: Addison


https://msdn.microsoft.com/en-us/library/bb397933.aspx



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (GEODE-2585) Client can get an object from the server

[Brian Baynes (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Brian Baynes resolved GEODE-2585.
-
Resolution: Implemented

Protocol changing; will be repeated.

> Client can get an object from the server
> 
>
> Key: GEODE-2585
> URL: https://issues.apache.org/jira/browse/GEODE-2585
> Project: Geode
>  Issue Type: Sub-task
>  Components: messaging
>Reporter: Addison
>
> The client should be able to send a message to the server with a region and a 
> key and get the serialized object back.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (GEODE-2103) start locator command should include --http-service-port and --http-service-bind-address

[Karen Smoler Miller (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karen Smoler Miller reassigned GEODE-2103:
--

Assignee: Karen Smoler Miller  (was: Joey McAllister)

> start locator command should include --http-service-port and 
> --http-service-bind-address
> 
>
> Key: GEODE-2103
> URL: https://issues.apache.org/jira/browse/GEODE-2103
> Project: Geode
>  Issue Type: Improvement
>  Components: docs, management
>Affects Versions: 1.0.0-incubating
>Reporter: Kirk Lund
>Assignee: Karen Smoler Miller
> Fix For: 1.2.0
>
>
> To facilitate starting the Admin REST API on a Locator, start locator command 
> should include --http-service-port and --http-service-bind-address.
> Workaround is to specify these configuration properties with --J:
> --J=-Dgemfire.http-service-port=
> --J=-Dgemfire.http-service-bind-address=



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (GEODE-2746) Investigate and Evaluate Existing RPC frameworks.

[Brian Baynes (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Brian Baynes resolved GEODE-2746.
-
Resolution: Duplicate

Superseded by GEODE-2781/2782/2783

> Investigate and Evaluate Existing RPC frameworks.
> -
>
> Key: GEODE-2746
> URL: https://issues.apache.org/jira/browse/GEODE-2746
> Project: Geode
>  Issue Type: Sub-task
>  Components: messaging
>Reporter: Galen O'Sullivan
>Assignee: Galen O'Sullivan
>
> There are several existing RPC frameworks for which you can define the 
> structure of your protocol and the tool will generate code for talking over 
> the wire, generally down to serialization of objects.
> If one of those RPC frameworks does not fit all our requirements, we'll 
> design our own binary protocol. This protocol would define both what kind of 
> messages can be sent and how they are encoded on the wire. How we encode the 
> objects that we are sending in requests, however, could still be pluggable.
> A few contenders:
> * [BERT|http://bert-rpc.org]
> * [thrift|https://thrift.apache.org/]
> * [gRPC|http://www.grpc.io/]
> * [Avro|https://avro.apache.org/]
> These are two not-entirely-common features we will need to have:
> * support for SSL/TLS, ability to connect to a server with IP & port.
> * support for push messages from the server without polling (this is needed 
> for CQs).
> This is one half of GEODE-2734.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode issue #437: GEODE-2653: Fix testRemoveMember and remove FlakyTest.

[galen-pivotal]

Github user galen-pivotal commented on the issue:

https://github.com/apache/geode/pull/437
  
@kohlmu-pivotal 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2653) GMSJoinLeaveJUnitTest.testRemoveMember fails with AssertionError

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973586#comment-15973586
 ] 

ASF GitHub Bot commented on GEODE-2653:
---

Github user galen-pivotal commented on the issue:

https://github.com/apache/geode/pull/437
  
@kohlmu-pivotal 


> GMSJoinLeaveJUnitTest.testRemoveMember fails with AssertionError
> 
>
> Key: GEODE-2653
> URL: https://issues.apache.org/jira/browse/GEODE-2653
> Project: Geode
>  Issue Type: Bug
>  Components: membership, tests
>Reporter: Kirk Lund
>Assignee: Galen O'Sullivan
>  Labels: Flaky
>
> Intermittent failure stack:
> {noformat}
> org.apache.geode.distributed.internal.membership.gms.membership.GMSJoinLeaveJUnitTest
>  > testRemoveMember FAILED
> java.lang.AssertionError
> at org.junit.Assert.fail(Assert.java:86)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at org.junit.Assert.assertTrue(Assert.java:52)
> at 
> org.apache.geode.distributed.internal.membership.gms.membership.GMSJoinLeaveJUnitTest.testRemoveMember(GMSJoinLeaveJUnitTest.java:337)
> {noformat}
> This test looks like it's flaky due to the Thread sleep:
> {noformat}
>   @Test
>   public void testRemoveMember() throws Exception {
> initMocks();
> prepareAndInstallView(mockMembers[0], createMemberList(mockMembers[0], 
> gmsJoinLeaveMemberId));
> MethodExecuted removeMessageSent = new MethodExecuted();
> 
> when(messenger.send(any(RemoveMemberMessage.class))).thenAnswer(removeMessageSent);
> gmsJoinLeave.remove(mockMembers[0], "removing for test");
> Thread.sleep(ServiceConfig.MEMBER_REQUEST_COLLECTION_INTERVAL * 2);
> assertTrue(removeMessageSent.methodExecuted);
>   }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (GEODE-2798) Gfsh show missing-disk-stores command hangs if cahce is initializing

[Kenneth Howe (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kenneth Howe reassigned GEODE-2798:
---

Assignee: Kenneth Howe

> Gfsh show missing-disk-stores command hangs if cahce is initializing
> 
>
> Key: GEODE-2798
> URL: https://issues.apache.org/jira/browse/GEODE-2798
> Project: Geode
>  Issue Type: Bug
>  Components: persistence
>Reporter: Kenneth Howe
>Assignee: Kenneth Howe
>
> To reproduce:
> Use gfsh to create a cluster with a locator and 2 servers, "s0" & "s1".
> Create a disk-store and a PERSISTENT_REPLICATE region.
> Do some region operations.
> Stop "s0".
> Stop "s1".
> Restart "s0" using the existing cluster configuration. It will be in an 
> initializing state, waiting for the disk-store for "s1".
> In Gfsh run 'show missing-disk-stores'
> * The command will hang.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2798) Gfsh show missing-disk-stores command hangs if cahce is initializing

[Kenneth Howe (JIRA)]

Kenneth Howe created GEODE-2798:
---

 Summary: Gfsh show missing-disk-stores command hangs if cahce is 
initializing
 Key: GEODE-2798
 URL: https://issues.apache.org/jira/browse/GEODE-2798
 Project: Geode
  Issue Type: Bug
  Components: persistence
Reporter: Kenneth Howe


To reproduce:

Use gfsh to create a cluster with a locator and 2 servers, "s0" & "s1".
Create a disk-store and a PERSISTENT_REPLICATE region.
Do some region operations.
Stop "s0".
Stop "s1".

Restart "s0" using the existing cluster configuration. It will be in an 
initializing state, waiting for the disk-store for "s1".

In Gfsh run 'show missing-disk-stores'
* The command will hang.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-2798) Gfsh show missing-disk-stores command hangs if cahce is initializing

[Kenneth Howe (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kenneth Howe updated GEODE-2798:

Affects Version/s: 1.0.0-incubating

> Gfsh show missing-disk-stores command hangs if cahce is initializing
> 
>
> Key: GEODE-2798
> URL: https://issues.apache.org/jira/browse/GEODE-2798
> Project: Geode
>  Issue Type: Bug
>  Components: persistence
>Affects Versions: 1.0.0-incubating
>Reporter: Kenneth Howe
>Assignee: Kenneth Howe
>
> To reproduce:
> Use gfsh to create a cluster with a locator and 2 servers, "s0" & "s1".
> Create a disk-store and a PERSISTENT_REPLICATE region.
> Do some region operations.
> Stop "s0".
> Stop "s1".
> Restart "s0" using the existing cluster configuration. It will be in an 
> initializing state, waiting for the disk-store for "s1".
> In Gfsh run 'show missing-disk-stores'
> * The command will hang.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-2798) Gfsh show missing-disk-stores command hangs if cache is initializing

[Kenneth Howe (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kenneth Howe updated GEODE-2798:

Summary: Gfsh show missing-disk-stores command hangs if cache is 
initializing  (was: Gfsh show missing-disk-stores command hangs if cahce is 
initializing)

> Gfsh show missing-disk-stores command hangs if cache is initializing
> 
>
> Key: GEODE-2798
> URL: https://issues.apache.org/jira/browse/GEODE-2798
> Project: Geode
>  Issue Type: Bug
>  Components: persistence
>Affects Versions: 1.0.0-incubating
>Reporter: Kenneth Howe
>Assignee: Kenneth Howe
>
> To reproduce:
> Use gfsh to create a cluster with a locator and 2 servers, "s0" & "s1".
> Create a disk-store and a PERSISTENT_REPLICATE region.
> Do some region operations.
> Stop "s0".
> Stop "s1".
> Restart "s0" using the existing cluster configuration. It will be in an 
> initializing state, waiting for the disk-store for "s1".
> In Gfsh run 'show missing-disk-stores'
> * The command will hang.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Review Request 58518: GEODE-2795: Clean up DUnit VMs after dynamically changing 'user.dir'

[Jared Stewart]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58518/
---

Review request for geode.


Repository: geode


Description
---

GEODE-2795: Clean up DUnit VMs after dynamically changing 'user.dir'

- LocatorServerStarterRule will now always bounce the DUnit VMs in after() to 
prevent corrupted cached values of `System.getProperty('user.dir')` that refer 
to a temporary folder which no longer exists.


Diffs
-

  
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/DeployCommandRedeployDUnitTest.java
 d47b3435a644f21ea28782c458afc6891577b1f4 
  
geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigTestBase.java
 c5aaa743935bd0e5bff771213d111cb2f9b929cb 
  
geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java
 34506c4fa803a1121c29d240ad7d7aa6a55dca99 


Diff: https://reviews.apache.org/r/58518/diff/1/


Testing
---


Thanks,

Jared Stewart

Review Request 58519: GEODE-2796: ClassPathLoader does not blow up with null TCCL

[Jared Stewart]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58519/
---

Review request for geode, Jinmei Liao, Ken Howe, and Kirk Lund.


Repository: geode


Description
---

GEODE-2796: ClassPathLoader does not blow up with null TCCL


Diffs
-

  geode-core/src/main/java/org/apache/geode/internal/ClassPathLoader.java 
41cce05ce8c1cbf559f365d754e1db1b8bc98b3d 
  
geode-core/src/test/java/org/apache/geode/internal/ClassPathLoaderIntegrationTest.java
 c78331895bd33a6b908338af0cec7e60ed56b944 


Diff: https://reviews.apache.org/r/58519/diff/1/


Testing
---

Precheckin started (still running)


Thanks,

Jared Stewart

[GitHub] geode pull request #461: GEODE-2103 Update gfsh start server|locator command

[karensmolermiller]

GitHub user karensmolermiller opened a pull request:

https://github.com/apache/geode/pull/461

GEODE-2103 Update gfsh start server|locator command

reference page.

- the optional http-service-port defaults to 7070
- both http-service-port and http-service-bind-address
are available for gfsh start server and gfsh start locator

@kirklund @davebarnes97 @joeymcallister Please review.  This commit should 
complete the not-quite-done documentation, by correcting/updating the gfsh 
command reference pages.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/karensmolermiller/geode feature/GEODE-2103

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/461.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #461


commit 2693ea901a9a87ca187a2b07b76be1b285282479
Author: Karen Miller 
Date:   2017-04-18T22:11:38Z

GEODE-2103 Update gfsh start server|locator command
reference page.

- the optional http-service-port defaults to 7070
- both http-service-port and http-service-bind-address
are available for gfsh start server and gfsh start locator




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2103) start locator command should include --http-service-port and --http-service-bind-address

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973617#comment-15973617
 ] 

ASF GitHub Bot commented on GEODE-2103:
---

GitHub user karensmolermiller opened a pull request:

https://github.com/apache/geode/pull/461

GEODE-2103 Update gfsh start server|locator command

reference page.

- the optional http-service-port defaults to 7070
- both http-service-port and http-service-bind-address
are available for gfsh start server and gfsh start locator

@kirklund @davebarnes97 @joeymcallister Please review.  This commit should 
complete the not-quite-done documentation, by correcting/updating the gfsh 
command reference pages.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/karensmolermiller/geode feature/GEODE-2103

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/461.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #461


commit 2693ea901a9a87ca187a2b07b76be1b285282479
Author: Karen Miller 
Date:   2017-04-18T22:11:38Z

GEODE-2103 Update gfsh start server|locator command
reference page.

- the optional http-service-port defaults to 7070
- both http-service-port and http-service-bind-address
are available for gfsh start server and gfsh start locator




> start locator command should include --http-service-port and 
> --http-service-bind-address
> 
>
> Key: GEODE-2103
> URL: https://issues.apache.org/jira/browse/GEODE-2103
> Project: Geode
>  Issue Type: Improvement
>  Components: docs, management
>Affects Versions: 1.0.0-incubating
>Reporter: Kirk Lund
>Assignee: Karen Smoler Miller
> Fix For: 1.2.0
>
>
> To facilitate starting the Admin REST API on a Locator, start locator command 
> should include --http-service-port and --http-service-bind-address.
> Workaround is to specify these configuration properties with --J:
> --J=-Dgemfire.http-service-port=
> --J=-Dgemfire.http-service-bind-address=



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2799) ClassCastException: java.lang.Long cannot be cast to org.apache.geode.internal.cache.AbstractRegionEntry could occur in race condition

[Eric Shu (JIRA)]

Eric Shu created GEODE-2799:
---

 Summary: ClassCastException: java.lang.Long cannot be cast to 
org.apache.geode.internal.cache.AbstractRegionEntry could occur in race 
condition
 Key: GEODE-2799
 URL: https://issues.apache.org/jira/browse/GEODE-2799
 Project: Geode
  Issue Type: Bug
  Components: transactions
Reporter: Eric Shu


{noformat}
java.lang.ClassCastException: java.lang.Long cannot be cast to 
org.apache.geode.internal.cache.AbstractRegionEntry
at 
org.apache.geode.internal.cache.LocalRegionDataView.getKeyForIterator(LocalRegionDataView.java:203)
at 
org.apache.geode.internal.cache.TXStateProxyImpl.getKeyForIterator(TXStateProxyImpl.java:766)
at 
org.apache.geode.internal.cache.EntriesSet$EntriesIterator.moveNext(EntriesSet.java:159)
at 
org.apache.geode.internal.cache.EntriesSet$EntriesIterator.(EntriesSet.java:118)
at org.apache.geode.internal.cache.EntriesSet.iterator(EntriesSet.java:83)
at java.util.AbstractCollection.addAll(AbstractCollection.java:343)
at java.util.TreeSet.addAll(TreeSet.java:312)
at java.util.TreeSet.(TreeSet.java:160)
at 
org.apache.geode.internal.cache.BucketRegionQueue.initializeEventSeqNumQueue(BucketRegionQueue.java:145)
at 
org.apache.geode.internal.cache.BucketRegionQueue.cleanUpDestroyedTokensAndMarkGIIComplete(BucketRegionQueue.java:108)
at 
org.apache.geode.internal.cache.DistributedRegion.getInitialImageAndRecovery(DistributedRegion.java:1288)
at 
org.apache.geode.internal.cache.DistributedRegion.initialize(DistributedRegion.java:1080)
at 
org.apache.geode.internal.cache.BucketRegion.initialize(BucketRegion.java:251)
at 
org.apache.geode.internal.cache.LocalRegion.createSubregion(LocalRegion.java:960)
at 
org.apache.geode.internal.cache.PartitionedRegionDataStore.createBucketRegion(PartitionedRegionDataStore.java:736)
at 
org.apache.geode.internal.cache.PartitionedRegionDataStore.grabFreeBucket(PartitionedRegionDataStore.java:424)
at 
org.apache.geode.internal.cache.PartitionedRegionDataStore.grabFreeBucketRecursively(PartitionedRegionDataStore.java:282)
at 
org.apache.geode.internal.cache.PartitionedRegionDataStore.grabBucket(PartitionedRegionDataStore.java:2860)
at 
org.apache.geode.internal.cache.PartitionedRegionDataStore.handleManageBucketRequest(PartitionedRegionDataStore.java:1001)
at 
org.apache.geode.internal.cache.PRHARedundancyProvider.createBucketOnMember(PRHARedundancyProvider.java:1214)
at 
org.apache.geode.internal.cache.PRHARedundancyProvider.createBucketInstance(PRHARedundancyProvider.java:390)
at 
org.apache.geode.internal.cache.PRHARedundancyProvider.createBucketAtomically(PRHARedundancyProvider.java:578)
at 
org.apache.geode.internal.cache.PartitionedRegion.createBucket(PartitionedRegion.java:3257)
at 
org.apache.geode.internal.cache.partitioned.RegionAdvisor$BucketSet$BucketSetIterator.next(RegionAdvisor.java:1422)
at 
org.apache.geode.internal.cache.PartitionedRegion$KeysSet$KeysSetIterator.getNextBucketIter(PartitionedRegion.java:6247)
at 
org.apache.geode.internal.cache.PartitionedRegion$KeysSet$KeysSetIterator.hasNext(PartitionedRegion.java:6220)
at 
org.apache.geode.internal.cache.PartitionedRegion$KeysSet.toArray(PartitionedRegion.java:6322)
at 
org.apache.geode.internal.cache.PartitionedRegion$KeysSet.toArray(PartitionedRegion.java:6316)
at java.util.Collections$UnmodifiableCollection.toArray(Collections.java:1033)
at java.util.ArrayList.addAll(ArrayList.java:577)
{noformat}

KeySet createIterator in transaction always creates keyset(). When a 
transaction accesses the items, it suspends the transaction and assumes the 
items provided by iterator are AbrstractRegionEntry.

private void createIterator(final LocalRegion rgn) {
  // TX iterates over KEYS.
  // NonTX iterates over RegionEntry instances
  this.currRgn = rgn;
  this.currItr = view.getRegionKeysForIteration(rgn).iterator();
  this.additionalKeysFromView = view.getAdditionalKeysForIterator(rgn);
}




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #528 was SUCCESSFUL (with 1843 tests)

[Spring CI]

---
Spring Data GemFire > Nightly-ApacheGeode > #528 was successful.
---
Scheduled
1845 tests in total.

https://build.spring.io/browse/SGF-NAG-528/





--
This message is automatically generated by Atlassian Bamboo

[jira] [Assigned] (GEODE-2799) ClassCastException: java.lang.Long cannot be cast to org.apache.geode.internal.cache.AbstractRegionEntry could occur in race condition

[Eric Shu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Shu reassigned GEODE-2799:
---

Assignee: Eric Shu

> ClassCastException: java.lang.Long cannot be cast to 
> org.apache.geode.internal.cache.AbstractRegionEntry could occur in race 
> condition
> --
>
> Key: GEODE-2799
> URL: https://issues.apache.org/jira/browse/GEODE-2799
> Project: Geode
>  Issue Type: Bug
>  Components: transactions
>Reporter: Eric Shu
>Assignee: Eric Shu
>
> {noformat}
> java.lang.ClassCastException: java.lang.Long cannot be cast to 
> org.apache.geode.internal.cache.AbstractRegionEntry
> at 
> org.apache.geode.internal.cache.LocalRegionDataView.getKeyForIterator(LocalRegionDataView.java:203)
> at 
> org.apache.geode.internal.cache.TXStateProxyImpl.getKeyForIterator(TXStateProxyImpl.java:766)
> at 
> org.apache.geode.internal.cache.EntriesSet$EntriesIterator.moveNext(EntriesSet.java:159)
> at 
> org.apache.geode.internal.cache.EntriesSet$EntriesIterator.(EntriesSet.java:118)
> at org.apache.geode.internal.cache.EntriesSet.iterator(EntriesSet.java:83)
> at java.util.AbstractCollection.addAll(AbstractCollection.java:343)
> at java.util.TreeSet.addAll(TreeSet.java:312)
> at java.util.TreeSet.(TreeSet.java:160)
> at 
> org.apache.geode.internal.cache.BucketRegionQueue.initializeEventSeqNumQueue(BucketRegionQueue.java:145)
> at 
> org.apache.geode.internal.cache.BucketRegionQueue.cleanUpDestroyedTokensAndMarkGIIComplete(BucketRegionQueue.java:108)
> at 
> org.apache.geode.internal.cache.DistributedRegion.getInitialImageAndRecovery(DistributedRegion.java:1288)
> at 
> org.apache.geode.internal.cache.DistributedRegion.initialize(DistributedRegion.java:1080)
> at 
> org.apache.geode.internal.cache.BucketRegion.initialize(BucketRegion.java:251)
> at 
> org.apache.geode.internal.cache.LocalRegion.createSubregion(LocalRegion.java:960)
> at 
> org.apache.geode.internal.cache.PartitionedRegionDataStore.createBucketRegion(PartitionedRegionDataStore.java:736)
> at 
> org.apache.geode.internal.cache.PartitionedRegionDataStore.grabFreeBucket(PartitionedRegionDataStore.java:424)
> at 
> org.apache.geode.internal.cache.PartitionedRegionDataStore.grabFreeBucketRecursively(PartitionedRegionDataStore.java:282)
> at 
> org.apache.geode.internal.cache.PartitionedRegionDataStore.grabBucket(PartitionedRegionDataStore.java:2860)
> at 
> org.apache.geode.internal.cache.PartitionedRegionDataStore.handleManageBucketRequest(PartitionedRegionDataStore.java:1001)
> at 
> org.apache.geode.internal.cache.PRHARedundancyProvider.createBucketOnMember(PRHARedundancyProvider.java:1214)
> at 
> org.apache.geode.internal.cache.PRHARedundancyProvider.createBucketInstance(PRHARedundancyProvider.java:390)
> at 
> org.apache.geode.internal.cache.PRHARedundancyProvider.createBucketAtomically(PRHARedundancyProvider.java:578)
> at 
> org.apache.geode.internal.cache.PartitionedRegion.createBucket(PartitionedRegion.java:3257)
> at 
> org.apache.geode.internal.cache.partitioned.RegionAdvisor$BucketSet$BucketSetIterator.next(RegionAdvisor.java:1422)
> at 
> org.apache.geode.internal.cache.PartitionedRegion$KeysSet$KeysSetIterator.getNextBucketIter(PartitionedRegion.java:6247)
> at 
> org.apache.geode.internal.cache.PartitionedRegion$KeysSet$KeysSetIterator.hasNext(PartitionedRegion.java:6220)
> at 
> org.apache.geode.internal.cache.PartitionedRegion$KeysSet.toArray(PartitionedRegion.java:6322)
> at 
> org.apache.geode.internal.cache.PartitionedRegion$KeysSet.toArray(PartitionedRegion.java:6316)
> at java.util.Collections$UnmodifiableCollection.toArray(Collections.java:1033)
> at java.util.ArrayList.addAll(ArrayList.java:577)
> {noformat}
> KeySet createIterator in transaction always creates keyset(). When a 
> transaction accesses the items, it suspends the transaction and assumes the 
> items provided by iterator are AbrstractRegionEntry.
> private void createIterator(final LocalRegion rgn) {
>   // TX iterates over KEYS.
>   // NonTX iterates over RegionEntry instances
>   this.currRgn = rgn;
>   this.currItr = view.getRegionKeysForIteration(rgn).iterator();
>   this.additionalKeysFromView = view.getAdditionalKeysForIterator(rgn);
> }



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2703) Improve error message that Lucene queries are not supported in the context of a transaction

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973666#comment-15973666
 ] 

ASF subversion and git services commented on GEODE-2703:


Commit 10770973daa3ea2cd9dce2439a90f1242b6129b5 in geode's branch 
refs/heads/develop from [~huynhja]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=1077097 ]

GEODE-2703: Improve exception message when executing lucene within a transaction

  * Throw a LuceneQueryException instead of a TransactionException


> Improve error message that Lucene queries are not supported in the context of 
> a transaction
> ---
>
> Key: GEODE-2703
> URL: https://issues.apache.org/jira/browse/GEODE-2703
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Diane Hardman
>
> We currently do not support Lucene queries in the context of a transaction. 
> The exception thrown, however, may be confusing to the user.
> ERROR org.apache.geode.cache.TransactionException: Function inside a 
> transaction cannot execute on more than one node
> org.apache.geode.cache.TransactionException: Function inside a transaction 
> cannot execute on more than one node
> at 
> org.apache.geode.internal.cache.execute.PartitionedRegionFunctionExecutor.validateExecution(PartitionedRegionFunctionExecutor.java:344)
> at 
> org.apache.geode.internal.cache.PartitionedRegion.executeOnAllBuckets(PartitionedRegion.java:3840)
> at 
> org.apache.geode.internal.cache.PartitionedRegion.executeFunction(PartitionedRegion.java:3353)
> at 
> org.apache.geode.internal.cache.execute.PartitionedRegionFunctionExecutor.executeFunction(PartitionedRegionFunctionExecutor.java:228)
> at 
> org.apache.geode.internal.cache.execute.AbstractExecution.execute(AbstractExecution.java:376)
> at 
> org.apache.geode.cache.lucene.internal.LuceneQueryImpl.findTopEntries(LuceneQueryImpl.java:115)
> at 
> org.apache.geode.cache.lucene.internal.LuceneQueryImpl.findPages(LuceneQueryImpl.java:95)
> at 
> org.apache.geode.cache.lucene.internal.LuceneQueryImpl.findResults(LuceneQueryImpl.java:81)
> at lucene.LuceneTest.executeLuceneQuery(LuceneTest.java:154)
> at parReg.ParRegTest.doEntryOperations(ParRegTest.java:2929)
> at parReg.ParRegTest.doRROpsAndVerify(ParRegTest.java:1709)
> at parReg.ParRegTest.HydraTask_doRROpsAndVerify(ParRegTest.java:958)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at hydra.MethExecutor.execute(MethExecutor.java:182)
> at hydra.MethExecutor.execute(MethExecutor.java:150)
> at hydra.TestTask.execute(TestTask.java:192)
> at hydra.RemoteTestModule$1.run(RemoteTestModule.java:212)
> ```



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (GEODE-2703) Improve error message that Lucene queries are not supported in the context of a transaction

[Jason Huynh (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Huynh reassigned GEODE-2703:
--

Assignee: Jason Huynh

> Improve error message that Lucene queries are not supported in the context of 
> a transaction
> ---
>
> Key: GEODE-2703
> URL: https://issues.apache.org/jira/browse/GEODE-2703
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Diane Hardman
>Assignee: Jason Huynh
> Fix For: 1.2.0
>
>
> We currently do not support Lucene queries in the context of a transaction. 
> The exception thrown, however, may be confusing to the user.
> ERROR org.apache.geode.cache.TransactionException: Function inside a 
> transaction cannot execute on more than one node
> org.apache.geode.cache.TransactionException: Function inside a transaction 
> cannot execute on more than one node
> at 
> org.apache.geode.internal.cache.execute.PartitionedRegionFunctionExecutor.validateExecution(PartitionedRegionFunctionExecutor.java:344)
> at 
> org.apache.geode.internal.cache.PartitionedRegion.executeOnAllBuckets(PartitionedRegion.java:3840)
> at 
> org.apache.geode.internal.cache.PartitionedRegion.executeFunction(PartitionedRegion.java:3353)
> at 
> org.apache.geode.internal.cache.execute.PartitionedRegionFunctionExecutor.executeFunction(PartitionedRegionFunctionExecutor.java:228)
> at 
> org.apache.geode.internal.cache.execute.AbstractExecution.execute(AbstractExecution.java:376)
> at 
> org.apache.geode.cache.lucene.internal.LuceneQueryImpl.findTopEntries(LuceneQueryImpl.java:115)
> at 
> org.apache.geode.cache.lucene.internal.LuceneQueryImpl.findPages(LuceneQueryImpl.java:95)
> at 
> org.apache.geode.cache.lucene.internal.LuceneQueryImpl.findResults(LuceneQueryImpl.java:81)
> at lucene.LuceneTest.executeLuceneQuery(LuceneTest.java:154)
> at parReg.ParRegTest.doEntryOperations(ParRegTest.java:2929)
> at parReg.ParRegTest.doRROpsAndVerify(ParRegTest.java:1709)
> at parReg.ParRegTest.HydraTask_doRROpsAndVerify(ParRegTest.java:958)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at hydra.MethExecutor.execute(MethExecutor.java:182)
> at hydra.MethExecutor.execute(MethExecutor.java:150)
> at hydra.TestTask.execute(TestTask.java:192)
> at hydra.RemoteTestModule$1.run(RemoteTestModule.java:212)
> ```



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (GEODE-2703) Improve error message that Lucene queries are not supported in the context of a transaction

[Jason Huynh (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Huynh resolved GEODE-2703.

   Resolution: Fixed
Fix Version/s: 1.2.0

> Improve error message that Lucene queries are not supported in the context of 
> a transaction
> ---
>
> Key: GEODE-2703
> URL: https://issues.apache.org/jira/browse/GEODE-2703
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Diane Hardman
> Fix For: 1.2.0
>
>
> We currently do not support Lucene queries in the context of a transaction. 
> The exception thrown, however, may be confusing to the user.
> ERROR org.apache.geode.cache.TransactionException: Function inside a 
> transaction cannot execute on more than one node
> org.apache.geode.cache.TransactionException: Function inside a transaction 
> cannot execute on more than one node
> at 
> org.apache.geode.internal.cache.execute.PartitionedRegionFunctionExecutor.validateExecution(PartitionedRegionFunctionExecutor.java:344)
> at 
> org.apache.geode.internal.cache.PartitionedRegion.executeOnAllBuckets(PartitionedRegion.java:3840)
> at 
> org.apache.geode.internal.cache.PartitionedRegion.executeFunction(PartitionedRegion.java:3353)
> at 
> org.apache.geode.internal.cache.execute.PartitionedRegionFunctionExecutor.executeFunction(PartitionedRegionFunctionExecutor.java:228)
> at 
> org.apache.geode.internal.cache.execute.AbstractExecution.execute(AbstractExecution.java:376)
> at 
> org.apache.geode.cache.lucene.internal.LuceneQueryImpl.findTopEntries(LuceneQueryImpl.java:115)
> at 
> org.apache.geode.cache.lucene.internal.LuceneQueryImpl.findPages(LuceneQueryImpl.java:95)
> at 
> org.apache.geode.cache.lucene.internal.LuceneQueryImpl.findResults(LuceneQueryImpl.java:81)
> at lucene.LuceneTest.executeLuceneQuery(LuceneTest.java:154)
> at parReg.ParRegTest.doEntryOperations(ParRegTest.java:2929)
> at parReg.ParRegTest.doRROpsAndVerify(ParRegTest.java:1709)
> at parReg.ParRegTest.HydraTask_doRROpsAndVerify(ParRegTest.java:958)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at hydra.MethExecutor.execute(MethExecutor.java:182)
> at hydra.MethExecutor.execute(MethExecutor.java:150)
> at hydra.TestTask.execute(TestTask.java:192)
> at hydra.RemoteTestModule$1.run(RemoteTestModule.java:212)
> ```



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-2794) REST API Doesn't Accept Primitive Types as Values

[Michael Martell (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Martell updated GEODE-2794:
---
Description: 
Plain text is valid JSON, but is not supported by the REST API. Same issue for 
all primitive types: bool, number, arrays. Only objects are accepted.

Repro example below. Putting the same value from another client works, and we 
are able to get primitive values.
PUT /gemfire-api/v1/orders/234
Request body:
{code:javascript}"hello"{code}

Response:
HTTP 400
Response body:
{color:red}
{code:javascript}
{
  "cause": "Json doc specified is either not supported or invalid!"
}
{code}
{color}

Wrapping the same request as:
{code:javascript} {"value":"hello"} {code}
succeeds (HTTP 200, and entry is saved).

Experienced on Geode 9.0.2.

Possible scenarios:
# Session state info containing binary data could be managed manually by base 
64 encoding the entire session state object into a string (not boxed in another 
object).
# Images are binary data which could also be base 64 encoded to strings.
# If a user is already using Geode for write-through caching, some values may 
be primitive types and it is convenient and consistent to write them through 
Geode rather than stepping around the cache.

  was:
Plain text is valid JSON, but is not supported by the REST API. Same issue for 
all primitive types: bool, number, arrays. Only objects are accepted.

Repro example below. Putting the same value from another client works, and we 
are able to get primitive values.
PUT /gemfire-api/v1/orders/234
Request body:
{code:javascript}"hello"{code}

Response:
HTTP 400
Response body:
{color:red}
{code:javascript}
{
  "cause": "Json doc specified is either not supported or invalid!"
}
{code}
{color}

Wrapping the same request as:
{code:javascript} {"value":"hello"} {code}
succeeds (HTTP 200, and entry is saved).

Experienced on Geode 9.0.2.


> REST API Doesn't Accept Primitive Types as Values
> -
>
> Key: GEODE-2794
> URL: https://issues.apache.org/jira/browse/GEODE-2794
> Project: Geode
>  Issue Type: Bug
>  Components: client/server, rest (dev)
>Reporter: Michael Martell
>
> Plain text is valid JSON, but is not supported by the REST API. Same issue 
> for all primitive types: bool, number, arrays. Only objects are accepted.
> Repro example below. Putting the same value from another client works, and we 
> are able to get primitive values.
> PUT /gemfire-api/v1/orders/234
> Request body:
> {code:javascript}"hello"{code}
> Response:
> HTTP 400
> Response body:
> {color:red}
> {code:javascript}
> {
>   "cause": "Json doc specified is either not supported or invalid!"
> }
> {code}
> {color}
> Wrapping the same request as:
> {code:javascript} {"value":"hello"} {code}
> succeeds (HTTP 200, and entry is saved).
> Experienced on Geode 9.0.2.
> Possible scenarios:
> # Session state info containing binary data could be managed manually by base 
> 64 encoding the entire session state object into a string (not boxed in 
> another object).
> # Images are binary data which could also be base 64 encoded to strings.
> # If a user is already using Geode for write-through caching, some values may 
> be primitive types and it is convenient and consistent to write them through 
> Geode rather than stepping around the cache.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode pull request #461: GEODE-2103 Update gfsh start server|locator command

[karensmolermiller]

Github user karensmolermiller closed the pull request at:

https://github.com/apache/geode/pull/461


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2103) start locator command should include --http-service-port and --http-service-bind-address

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973694#comment-15973694
 ] 

ASF GitHub Bot commented on GEODE-2103:
---

Github user karensmolermiller commented on the issue:

https://github.com/apache/geode/pull/461
  
The default values are still not right for the http-service-bind-address.  
So, I'm closing this PR, and I will open a new one with better values.


> start locator command should include --http-service-port and 
> --http-service-bind-address
> 
>
> Key: GEODE-2103
> URL: https://issues.apache.org/jira/browse/GEODE-2103
> Project: Geode
>  Issue Type: Improvement
>  Components: docs, management
>Affects Versions: 1.0.0-incubating
>Reporter: Kirk Lund
>Assignee: Karen Smoler Miller
> Fix For: 1.2.0
>
>
> To facilitate starting the Admin REST API on a Locator, start locator command 
> should include --http-service-port and --http-service-bind-address.
> Workaround is to specify these configuration properties with --J:
> --J=-Dgemfire.http-service-port=
> --J=-Dgemfire.http-service-bind-address=



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2103) start locator command should include --http-service-port and --http-service-bind-address

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973695#comment-15973695
 ] 

ASF GitHub Bot commented on GEODE-2103:
---

Github user karensmolermiller closed the pull request at:

https://github.com/apache/geode/pull/461


> start locator command should include --http-service-port and 
> --http-service-bind-address
> 
>
> Key: GEODE-2103
> URL: https://issues.apache.org/jira/browse/GEODE-2103
> Project: Geode
>  Issue Type: Improvement
>  Components: docs, management
>Affects Versions: 1.0.0-incubating
>Reporter: Kirk Lund
>Assignee: Karen Smoler Miller
> Fix For: 1.2.0
>
>
> To facilitate starting the Admin REST API on a Locator, start locator command 
> should include --http-service-port and --http-service-bind-address.
> Workaround is to specify these configuration properties with --J:
> --J=-Dgemfire.http-service-port=
> --J=-Dgemfire.http-service-bind-address=



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode issue #461: GEODE-2103 Update gfsh start server|locator command

[karensmolermiller]

Github user karensmolermiller commented on the issue:

https://github.com/apache/geode/pull/461
  
The default values are still not right for the http-service-bind-address.  
So, I'm closing this PR, and I will open a new one with better values.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2653) GMSJoinLeaveJUnitTest.testRemoveMember fails with AssertionError

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973702#comment-15973702
 ] 

ASF subversion and git services commented on GEODE-2653:


Commit c5ee7cd4338a91ab40ee355612057b05b299b6d6 in geode's branch 
refs/heads/develop from [~gosullivan]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=c5ee7cd ]

GEODE-2653: Fix testRemoveMember and remove FlakyTest. This closes #437

Test removed self instead of the other member, and used the `any`
matcher instead of `isA`.

Cleanup GMSJoinLeaveJUnitTest.

* Change Mockito's `any` to `isA`.
* Replace some `Thread.sleep()` calls with Awaitility calls.
* Remove our `MethodExecuted` class -- this can be done with Mockito's
  `verify()`.

Remove a redundant assert.


> GMSJoinLeaveJUnitTest.testRemoveMember fails with AssertionError
> 
>
> Key: GEODE-2653
> URL: https://issues.apache.org/jira/browse/GEODE-2653
> Project: Geode
>  Issue Type: Bug
>  Components: membership, tests
>Reporter: Kirk Lund
>Assignee: Galen O'Sullivan
>  Labels: Flaky
>
> Intermittent failure stack:
> {noformat}
> org.apache.geode.distributed.internal.membership.gms.membership.GMSJoinLeaveJUnitTest
>  > testRemoveMember FAILED
> java.lang.AssertionError
> at org.junit.Assert.fail(Assert.java:86)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at org.junit.Assert.assertTrue(Assert.java:52)
> at 
> org.apache.geode.distributed.internal.membership.gms.membership.GMSJoinLeaveJUnitTest.testRemoveMember(GMSJoinLeaveJUnitTest.java:337)
> {noformat}
> This test looks like it's flaky due to the Thread sleep:
> {noformat}
>   @Test
>   public void testRemoveMember() throws Exception {
> initMocks();
> prepareAndInstallView(mockMembers[0], createMemberList(mockMembers[0], 
> gmsJoinLeaveMemberId));
> MethodExecuted removeMessageSent = new MethodExecuted();
> 
> when(messenger.send(any(RemoveMemberMessage.class))).thenAnswer(removeMessageSent);
> gmsJoinLeave.remove(mockMembers[0], "removing for test");
> Thread.sleep(ServiceConfig.MEMBER_REQUEST_COLLECTION_INTERVAL * 2);
> assertTrue(removeMessageSent.methodExecuted);
>   }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode pull request #437: GEODE-2653: Fix testRemoveMember and remove FlakyTe...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/437


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2653) GMSJoinLeaveJUnitTest.testRemoveMember fails with AssertionError

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973704#comment-15973704
 ] 

ASF GitHub Bot commented on GEODE-2653:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/437


> GMSJoinLeaveJUnitTest.testRemoveMember fails with AssertionError
> 
>
> Key: GEODE-2653
> URL: https://issues.apache.org/jira/browse/GEODE-2653
> Project: Geode
>  Issue Type: Bug
>  Components: membership, tests
>Reporter: Kirk Lund
>Assignee: Galen O'Sullivan
>  Labels: Flaky
>
> Intermittent failure stack:
> {noformat}
> org.apache.geode.distributed.internal.membership.gms.membership.GMSJoinLeaveJUnitTest
>  > testRemoveMember FAILED
> java.lang.AssertionError
> at org.junit.Assert.fail(Assert.java:86)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at org.junit.Assert.assertTrue(Assert.java:52)
> at 
> org.apache.geode.distributed.internal.membership.gms.membership.GMSJoinLeaveJUnitTest.testRemoveMember(GMSJoinLeaveJUnitTest.java:337)
> {noformat}
> This test looks like it's flaky due to the Thread sleep:
> {noformat}
>   @Test
>   public void testRemoveMember() throws Exception {
> initMocks();
> prepareAndInstallView(mockMembers[0], createMemberList(mockMembers[0], 
> gmsJoinLeaveMemberId));
> MethodExecuted removeMessageSent = new MethodExecuted();
> 
> when(messenger.send(any(RemoveMemberMessage.class))).thenAnswer(removeMessageSent);
> gmsJoinLeave.remove(mockMembers[0], "removing for test");
> Thread.sleep(ServiceConfig.MEMBER_REQUEST_COLLECTION_INTERVAL * 2);
> assertTrue(removeMessageSent.methodExecuted);
>   }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 58484: GEODE-2632: refactoring part 2

[Jared Stewart]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58484/#review172284
---


Ship it!




Ship It!

- Jared Stewart


On April 17, 2017, 10:27 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58484/
> ---
> 
> (Updated April 17, 2017, 10:27 p.m.)
> 
> 
> Review request for geode, Bruce Schuchardt, Darrel Schneider, Jinmei Liao, 
> Jared Stewart, Ken Howe, Udo Kohlmeyer, and Dan Smith.
> 
> 
> Bugs: GEODE-2632
> https://issues.apache.org/jira/browse/GEODE-2632
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Purpose: Refactoring code in steps to eventually fix security/client-server 
> performance
> Part 1: https://reviews.apache.org/r/58460/
> 
> Refactor code to use internal interfaces
> 
> * refactor code to use InternalCache instead of GemFireCacheImpl
> * refactor code to use getInternalDistributedSystem
> * delete dead code, unused code, unused imports, extra whitespace,
> useless javadocs and comments, fix typos
> 
> The end goals of multiple iterations of refactoring: 1) write high-level 
> benchmark for client put to server [done], 2) change internal dependencies 
> from impl class to interface (including GemFireCacheImpl to InternalCache), 
> 3) fix constructors and invert dependencies of internal classes (including 
> AcceptorImpl and client Command classes), 4) write low-level benchmark(s) for 
> client commands, 5) fix any performance issues involving SecurityService.
> 
> I'd like to commit each iteration of refactoring as I go to keep the number 
> of merge conflicts and number of modified files lower.
> 
> 
> Diffs
> -
> 
>   
> geode-assembly/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigurationServiceEndToEndDUnitTest.java
>  0103cf6d8d6f088b4bd3ffc30f8e52b977a82621 
>   
> geode-core/src/main/java/org/apache/geode/cache/asyncqueue/internal/AsyncEventQueueFactoryImpl.java
>  b2881082278bdb53a8553a7fd31c47c304eb1ef6 
>   
> geode-core/src/main/java/org/apache/geode/cache/asyncqueue/internal/ParallelAsyncEventQueueImpl.java
>  03f079964c5e12c1ba44ba240f12025a5b098a09 
>   
> geode-core/src/main/java/org/apache/geode/cache/asyncqueue/internal/SerialAsyncEventQueueImpl.java
>  08a5b003d6e3c5cdec8ad22b74153f2c31cde9f7 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/AbstractRegion.java 
> e69f801d4f307c3ce98c105d6d2e38460d0d4a67 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/CacheServerImpl.java 
> a3c4a931b95fb3a8ea6463bb027aadd1bc8fdd32 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/DiskStoreFactoryImpl.java
>  71be7ec00deb6dc774f84e0fcca291a310ba09e4 
>   geode-core/src/main/java/org/apache/geode/internal/cache/DiskStoreImpl.java 
> b97f4286b6e2352a4ec5637477641d868cb05a6c 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/DiskStoreMonitor.java
>  2bb510720f2374ae1159095bff293f88465e600c 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/DistTXStateProxyImplOnCoordinator.java
>  52d155f5eebff2dd6eb50fbada159aca6629c1ec 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/DistributedRegion.java
>  68fdbebac6a50efb7092717d56243c7b88a47ec5 
>   geode-core/src/main/java/org/apache/geode/internal/cache/ExpiryTask.java 
> e12622d070b932979a6ca400d47eeff36c142f21 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java
>  869181432a64c2683e1b606e621cb5dbd1b42589 
>   geode-core/src/main/java/org/apache/geode/internal/cache/InternalCache.java 
> ee80014b393ba5d625cb78cf12a2a6e2c2fc24b3 
>   geode-core/src/main/java/org/apache/geode/internal/cache/LocalRegion.java 
> 55ee6a8e1ba7351c87d6f63f530469699efa8ee2 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegion.java
>  8db89699ceb2e23fd4ae8ce62b0fad76421656b0 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegionHelper.java
>  99ab281052b11e1a1168d99f8e1047fb4f822ca2 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/ProxyBucketRegion.java
>  27f73c7514b3ff6f20041ac6c8ce72d3c1798977 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/SearchLoadAndWriteProcessor.java
>  2a10792a7a26ead58fcf941fe4190117f552a6c5 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/ServerPingMessage.java
>  0e468912614292d23cda0fd32e4126a0e0235a59 
>   geode-core/src/main/java/org/apache/geode/internal/cache/TXMessage.java 
> 08ce99ba1b58d2f80815807a97ab943589b64e5f 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/control/HeapMemoryMonitor.java
>  0de41bf7da6731df146749571bb3e951764a3444 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache

[jira] [Commented] (GEODE-2703) Improve error message that Lucene queries are not supported in the context of a transaction

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973728#comment-15973728
 ] 

ASF subversion and git services commented on GEODE-2703:


Commit 10770973daa3ea2cd9dce2439a90f1242b6129b5 in geode's branch 
refs/heads/feature/GEODE-2632-1 from [~huynhja]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=1077097 ]

GEODE-2703: Improve exception message when executing lucene within a transaction

  * Throw a LuceneQueryException instead of a TransactionException


> Improve error message that Lucene queries are not supported in the context of 
> a transaction
> ---
>
> Key: GEODE-2703
> URL: https://issues.apache.org/jira/browse/GEODE-2703
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Diane Hardman
>Assignee: Jason Huynh
> Fix For: 1.2.0
>
>
> We currently do not support Lucene queries in the context of a transaction. 
> The exception thrown, however, may be confusing to the user.
> ERROR org.apache.geode.cache.TransactionException: Function inside a 
> transaction cannot execute on more than one node
> org.apache.geode.cache.TransactionException: Function inside a transaction 
> cannot execute on more than one node
> at 
> org.apache.geode.internal.cache.execute.PartitionedRegionFunctionExecutor.validateExecution(PartitionedRegionFunctionExecutor.java:344)
> at 
> org.apache.geode.internal.cache.PartitionedRegion.executeOnAllBuckets(PartitionedRegion.java:3840)
> at 
> org.apache.geode.internal.cache.PartitionedRegion.executeFunction(PartitionedRegion.java:3353)
> at 
> org.apache.geode.internal.cache.execute.PartitionedRegionFunctionExecutor.executeFunction(PartitionedRegionFunctionExecutor.java:228)
> at 
> org.apache.geode.internal.cache.execute.AbstractExecution.execute(AbstractExecution.java:376)
> at 
> org.apache.geode.cache.lucene.internal.LuceneQueryImpl.findTopEntries(LuceneQueryImpl.java:115)
> at 
> org.apache.geode.cache.lucene.internal.LuceneQueryImpl.findPages(LuceneQueryImpl.java:95)
> at 
> org.apache.geode.cache.lucene.internal.LuceneQueryImpl.findResults(LuceneQueryImpl.java:81)
> at lucene.LuceneTest.executeLuceneQuery(LuceneTest.java:154)
> at parReg.ParRegTest.doEntryOperations(ParRegTest.java:2929)
> at parReg.ParRegTest.doRROpsAndVerify(ParRegTest.java:1709)
> at parReg.ParRegTest.HydraTask_doRROpsAndVerify(ParRegTest.java:958)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at hydra.MethExecutor.execute(MethExecutor.java:182)
> at hydra.MethExecutor.execute(MethExecutor.java:150)
> at hydra.TestTask.execute(TestTask.java:192)
> at hydra.RemoteTestModule$1.run(RemoteTestModule.java:212)
> ```



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2653) GMSJoinLeaveJUnitTest.testRemoveMember fails with AssertionError

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973730#comment-15973730
 ] 

ASF subversion and git services commented on GEODE-2653:


Commit c5ee7cd4338a91ab40ee355612057b05b299b6d6 in geode's branch 
refs/heads/feature/GEODE-2632-1 from [~gosullivan]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=c5ee7cd ]

GEODE-2653: Fix testRemoveMember and remove FlakyTest. This closes #437

Test removed self instead of the other member, and used the `any`
matcher instead of `isA`.

Cleanup GMSJoinLeaveJUnitTest.

* Change Mockito's `any` to `isA`.
* Replace some `Thread.sleep()` calls with Awaitility calls.
* Remove our `MethodExecuted` class -- this can be done with Mockito's
  `verify()`.

Remove a redundant assert.


> GMSJoinLeaveJUnitTest.testRemoveMember fails with AssertionError
> 
>
> Key: GEODE-2653
> URL: https://issues.apache.org/jira/browse/GEODE-2653
> Project: Geode
>  Issue Type: Bug
>  Components: membership, tests
>Reporter: Kirk Lund
>Assignee: Galen O'Sullivan
>  Labels: Flaky
>
> Intermittent failure stack:
> {noformat}
> org.apache.geode.distributed.internal.membership.gms.membership.GMSJoinLeaveJUnitTest
>  > testRemoveMember FAILED
> java.lang.AssertionError
> at org.junit.Assert.fail(Assert.java:86)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at org.junit.Assert.assertTrue(Assert.java:52)
> at 
> org.apache.geode.distributed.internal.membership.gms.membership.GMSJoinLeaveJUnitTest.testRemoveMember(GMSJoinLeaveJUnitTest.java:337)
> {noformat}
> This test looks like it's flaky due to the Thread sleep:
> {noformat}
>   @Test
>   public void testRemoveMember() throws Exception {
> initMocks();
> prepareAndInstallView(mockMembers[0], createMemberList(mockMembers[0], 
> gmsJoinLeaveMemberId));
> MethodExecuted removeMessageSent = new MethodExecuted();
> 
> when(messenger.send(any(RemoveMemberMessage.class))).thenAnswer(removeMessageSent);
> gmsJoinLeave.remove(mockMembers[0], "removing for test");
> Thread.sleep(ServiceConfig.MEMBER_REQUEST_COLLECTION_INTERVAL * 2);
> assertTrue(removeMessageSent.methodExecuted);
>   }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (GEODE-2673) PartitionedRegionMultipleDUnitTest.testPartitionedRegionDestroyAndContainsAPI fails intermittently with ForcedDisconnectException

[Bruce Schuchardt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bruce Schuchardt resolved GEODE-2673.
-
Resolution: Won't Fix

A ForcedDisconnectException in a distributed test indicates either a sick JVM, 
often doing GC and sometimes on the metaspace, or an environmental problem such 
as insufficient resources to run the host VM.  As this test hasn't failed in 
Geode Jenkins or any Pivotal-private concourse runs that I can find I have no 
way of checking on the environment or the logs of this particular run.

If this test, or any other for that matter, fails with a 
ForcedDisconnectException the machine hosting the run should be examined and 
the logs of the failed test should be examined for GC activity.

> PartitionedRegionMultipleDUnitTest.testPartitionedRegionDestroyAndContainsAPI 
> fails intermittently with ForcedDisconnectException
> -
>
> Key: GEODE-2673
> URL: https://issues.apache.org/jira/browse/GEODE-2673
> Project: Geode
>  Issue Type: Bug
>  Components: membership, tests
>Reporter: Kirk Lund
>  Labels: Flaky
>
> Test passes when run by itself:
> {noformat}
> ./gradlew -DdistributedTest.single=PartitionedRegionMultipleDUnitTest 
> geode-core:distributedTest
> {noformat}
> But fails intermittently in precheckin:
> {noformat}
> org.apache.geode.internal.cache.PartitionedRegionMultipleDUnitTest > 
> testPartitionedRegionDestroyAndContainsAPI FAILED
> java.lang.AssertionError: exception during 0
> at org.apache.geode.test.dunit.Assert.fail(Assert.java:60)
> at 
> org.apache.geode.internal.cache.PartitionedRegionMultipleDUnitTest.testPartitionedRegionDestroyAndContainsAPI(PartitionedRegionMultipleDUnitTest.java:231)
> Caused by:
> java.lang.AssertionError: Validation failed for key = 
> 0testPartitionedRegionDestroyAndContainsAPI3Value got = null
> java.lang.AssertionError: Suspicious strings were written to the log 
> during this run.
> Fix the strings or use IgnoredException.addIgnoredException to ignore.
> ---
> Found suspect string in log4j at line 1807
> [fatal 2017/03/13 23:48:06.633 UTC  
> tid=0xc5] Membership service failure: this member is no longer in the view 
> but is initiating connections
> org.apache.geode.ForcedDisconnectException: this member is no longer in 
> the view but is initiating connections
>   at 
> org.apache.geode.distributed.internal.membership.gms.mgr.GMSMembershipManager.forceDisconnect(GMSMembershipManager.java:2517)
>   at 
> org.apache.geode.distributed.internal.membership.gms.membership.GMSJoinLeave.forceDisconnect(GMSJoinLeave.java:998)
>   at 
> org.apache.geode.distributed.internal.membership.gms.membership.GMSJoinLeave.processRemoveRequest(GMSJoinLeave.java:635)
>   at 
> org.apache.geode.distributed.internal.membership.gms.membership.GMSJoinLeave.processMessage(GMSJoinLeave.java:1702)
>   at 
> org.apache.geode.distributed.internal.membership.gms.messenger.JGroupsMessenger$JGroupsReceiver.receive(JGroupsMessenger.java:1286)
>   at org.jgroups.JChannel.invokeCallback(JChannel.java:816)
>   at org.jgroups.JChannel.up(JChannel.java:741)
>   at org.jgroups.stack.ProtocolStack.up(ProtocolStack.java:1030)
>   at org.jgroups.protocols.FRAG2.up(FRAG2.java:165)
>   at org.jgroups.protocols.FlowControl.up(FlowControl.java:390)
>   at org.jgroups.protocols.UNICAST3.deliverMessage(UNICAST3.java:1070)
>   at org.jgroups.protocols.UNICAST3.handleDataReceived(UNICAST3.java:785)
>   at org.jgroups.protocols.UNICAST3.up(UNICAST3.java:426)
>   at 
> org.apache.geode.distributed.internal.membership.gms.messenger.StatRecorder.up(StatRecorder.java:74)
>   at 
> org.apache.geode.distributed.internal.membership.gms.messenger.AddressManager.up(AddressManager.java:72)
>   at org.jgroups.protocols.TP.passMessageUp(TP.java:1601)
>   at org.jgroups.protocols.TP$SingleMessageHandler.run(TP.java:1817)
>   at org.jgroups.util.DirectExecutor.execute(DirectExecutor.java:10)
>   at org.jgroups.protocols.TP.handleSingleMessage(TP.java:1729)
>   at org.jgroups.protocols.TP.receive(TP.java:1654)
>   at 
> org.apache.geode.distributed.internal.membership.gms.messenger.Transport.receive(Transport.java:160)
>   at org.jgroups.protocols.UDP$PacketReceiver.run(UDP.java:701)
>   at java.lang.Thread.run(Thread.java:745)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode pull request #462: GEODE-2103 Update gfsh start server|locator command

[karensmolermiller]

GitHub user karensmolermiller opened a pull request:

https://github.com/apache/geode/pull/462

GEODE-2103 Update gfsh start server|locator command

reference page.

- the optional http-service-port defaults to 7070
- both http-service-port and http-service-bind-address
are available for gfsh start server and gfsh start locator

New PR for the doc task.  @kirklund @joeymcallister @davebarnes97 
@kohlmu-pivotal  please review.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/karensmolermiller/geode feature/GEODE-2103-2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/462.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #462


commit 3a4c6fc66afc59ba907ca815274a1ca73db0a8c3
Author: Karen Miller 
Date:   2017-04-18T22:11:38Z

GEODE-2103 Update gfsh start server|locator command
reference page.

- the optional http-service-port defaults to 7070
- both http-service-port and http-service-bind-address
are available for gfsh start server and gfsh start locator




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2103) start locator command should include --http-service-port and --http-service-bind-address

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973782#comment-15973782
 ] 

ASF GitHub Bot commented on GEODE-2103:
---

GitHub user karensmolermiller opened a pull request:

https://github.com/apache/geode/pull/462

GEODE-2103 Update gfsh start server|locator command

reference page.

- the optional http-service-port defaults to 7070
- both http-service-port and http-service-bind-address
are available for gfsh start server and gfsh start locator

New PR for the doc task.  @kirklund @joeymcallister @davebarnes97 
@kohlmu-pivotal  please review.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/karensmolermiller/geode feature/GEODE-2103-2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/462.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #462


commit 3a4c6fc66afc59ba907ca815274a1ca73db0a8c3
Author: Karen Miller 
Date:   2017-04-18T22:11:38Z

GEODE-2103 Update gfsh start server|locator command
reference page.

- the optional http-service-port defaults to 7070
- both http-service-port and http-service-bind-address
are available for gfsh start server and gfsh start locator




> start locator command should include --http-service-port and 
> --http-service-bind-address
> 
>
> Key: GEODE-2103
> URL: https://issues.apache.org/jira/browse/GEODE-2103
> Project: Geode
>  Issue Type: Improvement
>  Components: docs, management
>Affects Versions: 1.0.0-incubating
>Reporter: Kirk Lund
>Assignee: Karen Smoler Miller
> Fix For: 1.2.0
>
>
> To facilitate starting the Admin REST API on a Locator, start locator command 
> should include --http-service-port and --http-service-bind-address.
> Workaround is to specify these configuration properties with --J:
> --J=-Dgemfire.http-service-port=
> --J=-Dgemfire.http-service-bind-address=



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Review Request 58520: GEODE-2799: suspend the transaction when creating iterator if necessary

[Eric Shu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58520/
---

Review request for geode, anilkumar gingade, Darrel Schneider, and Lynn 
Gallinat.


Bugs: GEODE-2799
https://issues.apache.org/jira/browse/GEODE-2799


Repository: geode


Description
---

Return correct region keys in a transaction when creating iterator which will 
be consumed later.


Diffs
-

  
geode-core/src/main/java/org/apache/geode/internal/cache/TXStateProxyImpl.java 
49922a0 


Diff: https://reviews.apache.org/r/58520/diff/1/


Testing
---

precheckin.


Thanks,

Eric Shu

Re: Review Request 58520: GEODE-2799: suspend the transaction when creating iterator if necessary

[Eric Shu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58520/
---

(Updated April 19, 2017, 12:36 a.m.)


Review request for geode, anilkumar gingade, Darrel Schneider, and Lynn 
Gallinat.


Changes
---

avoid else statement.


Bugs: GEODE-2799
https://issues.apache.org/jira/browse/GEODE-2799


Repository: geode


Description
---

Return correct region keys in a transaction when creating iterator which will 
be consumed later.


Diffs (updated)
-

  
geode-core/src/main/java/org/apache/geode/internal/cache/TXStateProxyImpl.java 
49922a0 


Diff: https://reviews.apache.org/r/58520/diff/2/

Changes: https://reviews.apache.org/r/58520/diff/1-2/


Testing
---

precheckin.


Thanks,

Eric Shu

[jira] [Commented] (GEODE-2788) Add official Socket timeout parameter when connecting to servers/locators

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973854#comment-15973854
 ] 

ASF GitHub Bot commented on GEODE-2788:
---

Github user masaki-yamakawa commented on the issue:

https://github.com/apache/geode/pull/458
  
Thank you for confirmation. Change to add attribute of the connection pool.


> Add official Socket timeout parameter when connecting to servers/locators
> -
>
> Key: GEODE-2788
> URL: https://issues.apache.org/jira/browse/GEODE-2788
> Project: Geode
>  Issue Type: Improvement
>  Components: client/server, docs
>Reporter: Masaki Yamakawa
>Priority: Minor
>  Labels: patch
>
> When connecting from the client to the servers/locators, if the 
> servers/locators is not started, the connection can not be established and a 
> Socket timeout occurs.
> This timeout value is 59 seconds by default. This timeout value is too long. 
> This timeout value can be changed by specifying the unofficial parameter 
> "gemfire.PoolImpl.HANDSHAKE_TIMEOUT" in java system property, but I 
> corresponded so that it can be specified by official parameters.
> Like the NativeClient, the official parameters should be specified by 
> "connect-timeout" in gemfire.properties.
> Timeout values ​​are determined in the following order of priority.
> 1. java system property:gemfire.PoolImpl.HANDSHAKE_TIMEOUT
> 2. java system property:gemfire.connect-timeout
> 3. gemfire.properties:connect-timeout
> 4. default:59000 milli seconds
> As another idea, there is also an idea to make it possible to specify it as 
> an attribute of Pool. In that case NativeClient needs the same modification.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode issue #458: GEODE-2788: Add official Socket timeout parameter when con...

[masaki-yamakawa]

Github user masaki-yamakawa commented on the issue:

https://github.com/apache/geode/pull/458
  
Thank you for confirmation. Change to add attribute of the connection pool.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---