Build failed in Jenkins: Geode-nightly #657

[Apache Jenkins Server]

See 

Changes:

[klund] GEODE-2126: apply FlakyTest category to flaky test

[gzhou] GEODE-2120: The test needs to wait longer for compaction to finish.

--
[...truncated 513 lines...]
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-cq:processTestResources
:geode-cq:testClasses
:geode-cq:checkMissedTests
:geode-cq:spotlessJavaCheck
:geode-cq:spotlessCheck
:geode-cq:test
:geode-cq:check
:geode-cq:build
:geode-cq:distributedTest
:geode-cq:flakyTest
:geode-cq:integrationTest
:geode-json:assemble
:geode-json:compileTestJava UP-TO-DATE
:geode-json:processTestResources UP-TO-DATE
:geode-json:testClasses UP-TO-DATE
:geode-json:checkMissedTests UP-TO-DATE
:geode-json:spotlessJavaCheck
:geode-json:spotlessCheck
:geode-json:test UP-TO-DATE
:geode-json:check
:geode-json:build
:geode-json:distributedTest UP-TO-DATE
:geode-json:flakyTest UP-TO-DATE
:geode-json:integrationTest UP-TO-DATE
:geode-junit:javadoc
:geode-junit:javadocJar
:geode-junit:sourcesJar
:geode-junit:signArchives SKIPPED
:geode-junit:assemble
:geode-junit:compileTestJava
:geode-junit:processTestResources UP-TO-DATE
:geode-junit:testClasses
:geode-junit:checkMissedTests
:geode-junit:spotlessJavaCheck
:geode-junit:spotlessCheck
:geode-junit:test
:geode-junit:check
:geode-junit:build
:geode-junit:distributedTest
:geode-junit:flakyTest
:geode-junit:integrationTest
:geode-lucene:assemble
:geode-lucene:compileTestJavaNote: Some input files use or override a 
deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-lucene:processTestResources
:geode-lucene:testClasses
:geode-lucene:checkMissedTests
:geode-lucene:spotlessJavaCheck
:geode-lucene:spotlessCheck
:geode-lucene:test
:geode-lucene:check
:geode-lucene:build
:geode-lucene:distributedTest
:geode-lucene:flakyTest
:geode-lucene:integrationTest
:geode-old-client-support:assemble
:geode-old-client-support:compileTestJava
:geode-old-client-support:processTestResources UP-TO-DATE
:geode-old-client-support:testClasses
:geode-old-client-support:checkMissedTests
:geode-old-client-support:spotlessJavaCheck
:geode-old-client-support:spotlessCheck
:geode-old-client-support:test
:geode-old-client-support:check
:geode-old-client-support:build
:geode-old-client-support:distributedTest
:geode-old-client-support:flakyTest
:geode-old-client-support:integrationTest
:geode-pulse:assemble
:geode-pulse:compileTestJavaNote: 

 uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-pulse:processTestResources
:geode-pulse:testClasses
:geode-pulse:checkMissedTests
:geode-pulse:spotlessJavaCheck
:geode-pulse:spotlessCheck
:geode-pulse:test
:geode-pulse:check
:geode-pulse:build
:geode-pulse:distributedTest
:geode-pulse:flakyTest
:geode-pulse:integrationTest
:geode-rebalancer:assemble
:geode-rebalancer:compileTestJava
:geode-rebalancer:processTestResources UP-TO-DATE
:geode-rebalancer:testClasses
:geode-rebalancer:checkMissedTests
:geode-rebalancer:spotlessJavaCheck
:geode-rebalancer:spotlessCheck
:geode-rebalancer:test
:geode-rebalancer:check
:geode-rebalancer:build
:geode-rebalancer:distributedTest
:geode-rebalancer:flakyTest
:geode-rebalancer:integrationTest
:geode-wan:assemble
:geode-wan:compileTestJavaNote: Some input files use or override a deprecated 
API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-wan:processTestResources
:geode-wan:testClasses
:geode-wan:checkMissedTests
:geode-wan:spotlessJavaCheck
:geode-wan:spotlessCheck
:geode-wan:test
:geode-wan:check
:geode-wan:build
:geode-wan:distributedTest
:geode-wan:flakyTest
:geode-wan:integrationTest
:geode-web:assemble
:geode-web:compileTestJavaNote: Some input files use or override a deprecated 
API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-web:processTestResources UP-TO-DATE
:geode-web:testClasses
:geode-web:checkMissedTests
:geode-web:spotlessJavaCheck
:geode-web:spotlessCheck
:geode-web:test
:geode-web:check
:geode-web:build
:geode-web:distributedTest
:geode-web:flakyTest
:geode-web:integrationTest
:geode-web-api:assemble
:geode-web-api:compileTestJava UP-TO-DATE
:geode-web-api:processTestResources UP-TO-DATE
:geode-web-api:testClasses UP-TO-DATE
:geode-web-api:checkMissedTests UP-TO-DATE
:geode

build failure - MultipleOplogsRollingFeatureJUnitTest

[Bruce Schuchardt]

All of the builds are failing in spotless checks on this class.

Re: build failure - MultipleOplogsRollingFeatureJUnitTest

[Xiaojian Zhou]

fixed

On Fri, Nov 18, 2016 at 8:44 AM, Bruce Schuchardt 
wrote:

> All of the builds are failing in spotless checks on this class.
>

Re: Review Request 53867: GEODE-2129 make pdxtype id random(not sequential)

[Bruce Schuchardt]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53867/#review156309
---




geode-core/src/main/java/org/apache/geode/pdx/internal/PeerTypeRegistration.java
 (line 284)


Shouldn't this be using newEnumId?  I think you should delete nextEnumId as 
it caused confusion here and it's not needed anymore.



geode-core/src/main/java/org/apache/geode/pdx/internal/PeerTypeRegistration.java
 (line 562)


The check for totalPdxTypeIdInDS == maxTypeId should be moved to this 
method and you should delete the instance variable totalPdxTypeIdInDS.  
Otherwise you've introduced a weird dependency between the two methods.  Rename 
this method to indicate it is doing this check.



geode-core/src/main/java/org/apache/geode/pdx/internal/PeerTypeRegistration.java
 (line 596)


Same comment here - get rid of this.totalEnumIdInDS and throw the exception 
in this method.

If it shouldn't perform the check in some code paths you could parameterize 
the method to turn the check on/off.


- Bruce Schuchardt


On Nov. 18, 2016, 12:41 a.m., Hitesh Khamesra wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53867/
> ---
> 
> (Updated Nov. 18, 2016, 12:41 a.m.)
> 
> 
> Review request for geode, Bruce Schuchardt and Udo Kohlmeyer.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Right now pdxtype id has 4 bytes. Out of those 4 bytes, one byte reserved for 
> distributed-system-id, this make sure type id generated from different 
> cluster has different id. For rest of the three bytes we just increment 
> counter to create new pdxtype id. In the field, we have observed that 
> sometimes this pdxType Id collides. One reason could be they end up having 
> same distributed-system-id for the different cluster.
> Thus to avoid a collision, we will be using hashcode of pdxType for three 
> bytes of pdxType id. That will reduce the possibility of collision.
> 
> 
> Diffs
> -
> 
>   geode-core/src/main/java/org/apache/geode/pdx/internal/EnumId.java 5d399eb 
>   geode-core/src/main/java/org/apache/geode/pdx/internal/PdxType.java b586f64 
>   
> geode-core/src/main/java/org/apache/geode/pdx/internal/PeerTypeRegistration.java
>  0226cca 
>   geode-core/src/test/java/org/apache/geode/pdx/PdxAttributesJUnitTest.java 
> c45abce 
>   geode-core/src/test/java/org/apache/geode/pdx/PdxSerializableJUnitTest.java 
> 5cd822c 
>   
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/WANTestBase.java 
> f9c18ec 
>   
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/misc/PDXNewWanDUnitTest.java
>  f1e8f42 
> 
> Diff: https://reviews.apache.org/r/53867/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Hitesh Khamesra
> 
>

[GitHub] incubator-geode pull request #287: GEODE-2112: Fix UITests failing due to in...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-geode/pull/287


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-geode pull request #289: GEODE-2117: Pulse handles float type mbea...

[jaredjstewart]

GitHub user jaredjstewart opened a pull request:

https://github.com/apache/incubator-geode/pull/289

GEODE-2117: Pulse handles float type mbean attributes

 - Added tests for JMXDataUpdater::getDoubleAttribute()
 - JMXDataUpdater::getDoubleAttribute() now returns double approximations 
for floats rather than logging an error and returning zero.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jaredjstewart/incubator-geode 
feature/GEODE-2117

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/289.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #289


commit 36929fe5282339a7c0ac4aa4dbc5ee529524b642
Author: Jared Stewart 
Date:   2016-11-16T23:22:34Z

GEODE-2117: Pulse handles float type mbean attributes

 - Added tests for JMXDataUpdater::getDoubleAttribute()
 - JMXDataUpdater::getDoubleAttribute() now returns double approximations 
for floats rather than logging an error and returning zero.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-geode issue #289: GEODE-2117: Pulse handles float type mbean attri...

[jaredjstewart]

Github user jaredjstewart commented on the issue:

https://github.com/apache/incubator-geode/pull/289
  
Precheckin started


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 53865: GEODE-2127 old client support service is not set up to handle arrays

[Hitesh Khamesra]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53865/#review156322
---


Ship it!




Ship It!

- Hitesh Khamesra


On Nov. 17, 2016, 11:33 p.m., Bruce Schuchardt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53865/
> ---
> 
> (Updated Nov. 17, 2016, 11:33 p.m.)
> 
> 
> Review request for geode, Hitesh Khamesra and Udo Kohlmeyer.
> 
> 
> Bugs: GEODE-2127
> https://issues.apache.org/jira/browse/GEODE-2127
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Array classes start with some number of left-brackets ("[") followed by "L" 
> and the name of the class the array contains.  This adds a unit test for 
> arrays and adds support for handling them in OldClientSupportProvider.
> 
> 
> Diffs
> -
> 
>   geode-core/src/main/java/org/apache/geode/DataSerializer.java 
> 29b20a22ffe0f08fece15429816901370015c35a 
>   
> geode-core/src/main/java/org/apache/geode/internal/InternalDataSerializer.java
>  d136b87681066e9ae516382b9311f130d5c81f06 
>   
> geode-old-client-support/src/main/java/com/gemstone/gemfire/OldClientSupportProvider.java
>  a012c1689ba2dd3fe78b73001d4baa4340e8ac6f 
>   
> geode-old-client-support/src/test/java/org/apache/geode/OldClientSupportDUnitTest.java
>  0844bf084c47c89748079a00988768da309c6d1a 
> 
> Diff: https://reviews.apache.org/r/53865/diff/
> 
> 
> Testing
> ---
> 
> new test, precheckin
> 
> 
> Thanks,
> 
> Bruce Schuchardt
> 
>

Re: Review Request 53864: GEODE-2121 add DLockTest, MembershipTest, ClientServerTest, ClientSubscriptionTest and RestAPITest categories

[Hitesh Khamesra]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53864/#review156329
---


Ship it!




Ship It!

- Hitesh Khamesra


On Nov. 17, 2016, 11:07 p.m., Bruce Schuchardt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53864/
> ---
> 
> (Updated Nov. 17, 2016, 11:07 p.m.)
> 
> 
> Review request for geode, Hitesh Khamesra and Udo Kohlmeyer.
> 
> 
> Bugs: GEODE-2121
> https://issues.apache.org/jira/browse/GEODE-2121
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> This adds more unit test categories to augment the ones that we already have. 
>  The new categories are areas where I do most of my work and will enable 
> people to run the category of tests to see if the associated component of 
> Geode has been adversely affected by a change before running a complete 
> precheckin.  It also lets us do code-coverage runs for these specific 
> components.
> 
> 
> Diffs
> -
> 
>   geode-assembly/src/test/java/org/apache/geode/BundledJarsJUnitTest.java 
> 8c228f21b5b00f66c2b75b14c0292eaf113e54c5 
>   
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestInterfaceJUnitTest.java
>  932119d7813533af6f1812b2be172b5a1ad5ea1c 
>   
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestServersJUnitTest.java
>  b49e6cad6c3d3f2a151e9d87426859ddd8e20e6b 
>   
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/SwaggerVerificationTest.java
>  e706b0ed18e61f58bc230d86ac42c7c0af395589 
>   
> geode-core/src/test/java/org/apache/geode/cache/ClientServerTimeSyncDUnitTest.java
>  6d5e840843b7ebd53724a752aceae2320a35780c 
>   
> geode-core/src/test/java/org/apache/geode/cache/ConnectionPoolAndLoaderDUnitTest.java
>  8c02589bffc918faa6b1b6db83a42f84b32a6824 
>   
> geode-core/src/test/java/org/apache/geode/cache/ConnectionPoolAutoDUnitTest.java
>  68269e3111ddedded41e8816b2d6e100217e9aad 
>   
> geode-core/src/test/java/org/apache/geode/cache/ConnectionPoolDUnitTest.java 
> 8bff8be6e235df8c32a52385e2b959f7cb49c762 
>   
> geode-core/src/test/java/org/apache/geode/cache/ConnectionPoolFactoryJUnitTest.java
>  b2be14ab75ae69ca661df2893e5bbf837f527442 
>   
> geode-core/src/test/java/org/apache/geode/cache/MembershipAttributesAreSerializableTest.java
>  93d702b1cff33f1b940e0041a1ed565771426617 
>   geode-core/src/test/java/org/apache/geode/cache/PoolManagerJUnitTest.java 
> 23d8d9823b0543c4090bbc94a63bf7f4afc724f2 
>   
> geode-core/src/test/java/org/apache/geode/cache/client/ClientCacheFactoryJUnitTest.java
>  a2339e25f8cbdd51c9d229e74a4ccfd177728982 
>   
> geode-core/src/test/java/org/apache/geode/cache/client/ClientRegionFactoryJUnitTest.java
>  d099b06f7e00cb99cd3c6f25e951492d1dd866a5 
>   
> geode-core/src/test/java/org/apache/geode/cache/client/ClientServerRegisterInterestsDUnitTest.java
>  9c8044d6a24d507b893bf329ab6f1129d9d6a300 
>   
> geode-core/src/test/java/org/apache/geode/cache/client/internal/AutoConnectionSourceDUnitTest.java
>  f0fd7a675618fe6ebc2de5dd49f32335607185dd 
>   
> geode-core/src/test/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImplJUnitTest.java
>  fdde35c35b9e09a38e629e105916b5080173f52c 
>   
> geode-core/src/test/java/org/apache/geode/cache/client/internal/CacheServerSSLConnectionDUnitTest.java
>  d3c4e3cc8cc26f5f7be303ede04e477d32d04234 
>   
> geode-core/src/test/java/org/apache/geode/cache/client/internal/ConnectionPoolImplJUnitTest.java
>  a9eb6721b6b53acb0b6c8f162e94df28edd9fb19 
>   
> geode-core/src/test/java/org/apache/geode/cache/client/internal/LocatorLoadBalancingDUnitTest.java
>  f468e93a415973ede52309f193d59cd955728b88 
>   
> geode-core/src/test/java/org/apache/geode/cache/client/internal/OpExecutorImplJUnitTest.java
>  37511cfc73239759e5fdbf8107f018b7558a2a73 
>   
> geode-core/src/test/java/org/apache/geode/cache/client/internal/QueueManagerJUnitTest.java
>  812ce16c3d9802b411e3351d11e6e438115c9c6a 
>   
> geode-core/src/test/java/org/apache/geode/cache/client/internal/SSLNoClientAuthDUnitTest.java
>  bba6d5470099e98e1bc5fc454f49a1b817314c12 
>   
> geode-core/src/test/java/org/apache/geode/cache/client/internal/ServerBlackListJUnitTest.java
>  eccbefdb208214e704b1f4963fb73facaac8e5b3 
>   
> geode-core/src/test/java/org/apache/geode/cache/client/internal/pooling/ConnectionManagerJUnitTest.java
>  0f632b822c1d3f4d165a2a6b4a056eaef8551f2e 
>   
> geode-core/src/test/java/org/apache/geode/cache/mapInterface/PutAllGlobalLockJUnitTest.java
>  bc88b7a2218c29484f5959ad086b65e6c3944c4c 
>   geode-core/src/test/java/org/apache/geode/cache30/Bug38741DUnitTest.java 
> 2c8b0f7441a534ebedacd875dd3e9ed11d201f22 
>   
> geode-core/src/test/java/org/apache/geode/cache30/ClientMembershipDUnitTest.java

PartitionedRegionLoadModelJUnitTest > testRedundancySatisfactionPreferRemoteIp FAILED

[Kevin Duling]

I'm receiving the following assertion error when compiling:

org.apache.geode.internal.cache.partitioned.PartitionedRegionLoadModelJUnitTest
> testRedundancySatisfactionPreferRemoteIp FAILED

java.lang.AssertionError: expected:<[Create[member=10.
64.251.218(1639):3,bucketId=0], Create[member=10.64.251.218(1639)
*:3*,bucketId=1], Create[member=10.64.251.218(1639):3,bucketId=2]]>
but was:<[Create[member=10.64.251.218(1639):3,bucketId=0],
Create[member=10.64.251.218(1639)*:1*,bucketId=1],
Create[member=10.64.251.218(1639):3,bucketId=2]]>

at org.junit.Assert.fail(Assert.java:88)

at org.junit.Assert.failNotEquals(Assert.java:834)

at org.junit.Assert.assertEquals(Assert.java:118)

at org.junit.Assert.assertEquals(Assert.java:144)

at org.apache.geode.internal.cache.partitioned.
PartitionedRegionLoadModelJUnitTest.testRedundancySatisfactionPref
erRemoteIp(PartitionedRegionLoadModelJUnitTest.java:227)


I've tracked the problem down to being related to entires in my /etc/hosts
file.  Trying to address a slow startup of the JVM and DNS lookups, I
followed the suggestion on this site:

https://thoeni.io/post/macos-sierra-java/
By changing my line:

*127.0.0.1 localhost*

to

*127.0.0.1 localhost kduling-mbro*

it causes the test above to fail consistently on my home network.

Re: PartitionedRegionLoadModelJUnitTest > testRedundancySatisfactionPreferRemoteIp FAILED

[Anthony Baker]

On your home network is kduling-mbpro a valid hostname?

Anthony

> On Nov 18, 2016, at 1:00 PM, Kevin Duling  wrote:
> 
> I'm receiving the following assertion error when compiling:
> 
> org.apache.geode.internal.cache.partitioned.PartitionedRegionLoadModelJUnitTest
>> testRedundancySatisfactionPreferRemoteIp FAILED
> 
>java.lang.AssertionError: expected:<[Create[member=10.
> 64.251.218(1639):3,bucketId=0], Create[member=10.64.251.218(1639)
> *:3*,bucketId=1], Create[member=10.64.251.218(1639):3,bucketId=2]]>
> but was:<[Create[member=10.64.251.218(1639):3,bucketId=0],
> Create[member=10.64.251.218(1639)*:1*,bucketId=1],
> Create[member=10.64.251.218(1639):3,bucketId=2]]>
> 
>at org.junit.Assert.fail(Assert.java:88)
> 
>at org.junit.Assert.failNotEquals(Assert.java:834)
> 
>at org.junit.Assert.assertEquals(Assert.java:118)
> 
>at org.junit.Assert.assertEquals(Assert.java:144)
> 
>at org.apache.geode.internal.cache.partitioned.
> PartitionedRegionLoadModelJUnitTest.testRedundancySatisfactionPref
> erRemoteIp(PartitionedRegionLoadModelJUnitTest.java:227)
> 
> 
> I've tracked the problem down to being related to entires in my /etc/hosts
> file.  Trying to address a slow startup of the JVM and DNS lookups, I
> followed the suggestion on this site:
> 
> https://thoeni.io/post/macos-sierra-java/
> By changing my line:
> 
> *127.0.0.1 localhost*
> 
> to
> 
> *127.0.0.1 localhost kduling-mbro*
> 
> it causes the test above to fail consistently on my home network.

[GitHub] incubator-geode pull request #288: GEODE-2092 - Security examples should not...

[kjduling]

Github user kjduling closed the pull request at:

https://github.com/apache/incubator-geode/pull/288


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-geode issue #288: GEODE-2092 - Security examples should not be in ...

[kjduling]

Github user kjduling commented on the issue:

https://github.com/apache/incubator-geode/pull/288
  
Cancelling this one to resubmit as a single, clean commit.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-geode pull request #290: GEODE-2092: Security examples should not ...

[kjduling]

GitHub user kjduling opened a pull request:

https://github.com/apache/incubator-geode/pull/290

GEODE-2092: Security examples should not be in the product code

Moved examples to 
geode-core/src/main/java/org/apache/geode/examples/security/
Copied old Sample/Simple code to test packages as many tests rely on these 
classes.
Deleted SimpleSecurityManager example class

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kjduling/incubator-geode feature/GEODE-2092

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/290.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #290


commit a3bb5aa6d2de757ae2a9a9f461c852dfa8731141
Author: Kevin Duling 
Date:   2016-11-17T18:57:00Z

GEODE-2092: Security examples should not be in the product code

Moved examples to 
geode-core/src/main/java/org/apache/geode/examples/security/
Copied old Sample/Simple code to test packages as many tests rely on these 
classes.
Deleted SimpleSecurityManager example class




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Someone to pull in #288

[Kirk Lund]

Can someone else please pull in #288, resolve conflicts and rebase it into
one commit? When I attempt to do this, the "author" gets reset to me
instead of Kevin. My git knowledge isn't good enough for multi-commit PRs
that include conflicts with develop.

-Kirk

Re: Someone to pull in #288

[Kevin Duling]

Needs to be #290.  I closed 288 in an attempt to have it merge cleaner.

What should happen:

SimpleSecurityManager -> moved to
./geode-core/src/test/java/org/apache/geode/security/SimpleTestSecurityManager.java
SampleSecurityManager -> moved to
./geode-core/src/test/java/org/apache/geode/security/TestSecurityManager.java
SamplePostProcessor -> moved to
./geode-core/src/test/java/org/apache/geode/security/TestPostProcessor.java

also

SampleSecurityManager is also copied to
./geode-core/src/main/java/org/apache/geode/examples/security/SampleSecurityManager.java
SamplePostProcessor is also copied to
./geode-core/src/main/java/org/apache/geode/examples/security/SamplePostProcessor.java

and

a whole lot of tests are changed to point to SimpleTestSecurityManager,
TestSecurityManager, and TestPostProcessor


On Fri, Nov 18, 2016 at 3:11 PM, Kirk Lund  wrote:

> Can someone else please pull in #288, resolve conflicts and rebase it into
> one commit? When I attempt to do this, the "author" gets reset to me
> instead of Kevin. My git knowledge isn't good enough for multi-commit PRs
> that include conflicts with develop.
>
> -Kirk
>

Cluster Configuration files

[Jared Stewart]

The cluster.xml and cluster.properties files seem to contain the entirety of a 
given cluster configuration.  These are the only files included in the zip file 
produced by ‘export cluster-configuration’.  Does anyone know what the 
ConfigDiskDir files are used for?  Are they just redundant versions of the 
information stored in the .xml and .properties files?

./cluster_config
./cluster_config/cluster
./cluster_config/cluster/cluster.properties
./cluster_config/cluster/cluster.xml
./ConfigDiskDir_l1
./ConfigDiskDir_l1/BACKUPcluster_config.if
./ConfigDiskDir_l1/BACKUPcluster_config_1.crf
./ConfigDiskDir_l1/BACKUPcluster_config_1.drf
./ConfigDiskDir_l1/DRLK_IFcluster_config.lk

[GitHub] incubator-geode issue #289: GEODE-2117: Pulse handles float type mbean attri...

[jaredjstewart]

Github user jaredjstewart commented on the issue:

https://github.com/apache/incubator-geode/pull/289
  
Precheckin passed except for a FlakyTest:

```

org.apache.geode.management.internal.cli.commands.IndexCommandsDUnitTest > 
testCreateDestroyUpdatesSharedConfig FAILED
org.apache.geode.test.dunit.RMIException: While invoking 
org.apache.geode.management.internal.cli.commands.IndexCommandsDUnitTest$4.run 
in VM 1 running on Host 7f51a3c2-f764-4e03-5bec-1821c26ca879 with 4 VMs
at org.apache.geode.test.dunit.VM.invoke(VM.java:344)
at org.apache.geode.test.dunit.VM.invoke(VM.java:314)
at org.apache.geode.test.dunit.VM.invoke(VM.java:259)
at 
org.apache.geode.management.internal.cli.commands.IndexCommandsDUnitTest.testCreateDestroyUpdatesSharedConfig(IndexCommandsDUnitTest.java:686)

Caused by:
java.lang.AssertionError
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 53867: GEODE-2129 make pdxtype id random(not sequential)

[Hitesh Khamesra]

Before using hashcode for pdxType creation, we will check whether it is 
available or not. If it's not available then, we will use next available id. We 
have introduced this mechanism to harden the cases where the user ends up 
having two clusters with the same dsid.    From: Vishal Rao 

 To: dev@geode.apache.org; Hitesh Khamesra  
Cc: Udo Kohlmeyer ; Bruce Schuchardt 
; geode 
 Sent: Thursday, November 17, 2016 11:51 PM
 Subject: Re: Review Request 53867: GEODE-2129 make pdxtype id random(not 
sequential)
   
Apologies if this is noise, but wouldn't using the hash code actually
increase the likelihood of ID collisions?

On Fri, Nov 18, 2016 at 6:11 AM, Hitesh Khamesra 
wrote:

>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53867/
> ---
>
> Review request for geode, Bruce Schuchardt and Udo Kohlmeyer.
>
>
> Repository: geode
>
>
> Description
> ---
>
> Right now pdxtype id has 4 bytes. Out of those 4 bytes, one byte reserved
> for distributed-system-id, this make sure type id generated from different
> cluster has different id. For rest of the three bytes we just increment
> counter to create new pdxtype id. In the field, we have observed that
> sometimes this pdxType Id collides. One reason could be they end up having
> same distributed-system-id for the different cluster.
> Thus to avoid a collision, we will be using hashcode of pdxType for three
> bytes of pdxType id. That will reduce the possibility of collision.
>
>
> Diffs
> -
>
>  geode-core/src/main/java/org/apache/geode/pdx/internal/EnumId.java
> 5d399eb
>  geode-core/src/main/java/org/apache/geode/pdx/internal/PdxType.java
> b586f64
>  
>geode-core/src/main/java/org/apache/geode/pdx/internal/PeerTypeRegistration.java
> 0226cca
>  geode-core/src/test/java/org/apache/geode/pdx/PdxAttributesJUnitTest.java
> c45abce
>  geode-core/src/test/java/org/apache/geode/pdx/PdxSerializableJUnitTest.java
> 5cd822c
>  geode-wan/src/test/java/org/apache/geode/internal/cache/wan/WANTestBase.java
> f9c18ec
>  geode-wan/src/test/java/org/apache/geode/internal/cache/
> wan/misc/PDXNewWanDUnitTest.java f1e8f42
>
> Diff: https://reviews.apache.org/r/53867/diff/
>
>
> Testing
> ---
>
>
> Thanks,
>
> Hitesh Khamesra
>
>


-- 
"The World is a book, and those who do not travel read only a page." - St.
Augustine.


   

Re: Cluster Configuration files

[Jinmei Liao]

As far as I remember, cluster configurations files are saved in an internal
region as well, and that region is defined as replicate_persistent, so the
content of it gets written to the disk as well in those ConfigDistDir
backup files. This is something we need to clean up as well. Just use one
way of saving the content, either in file system or internal region. I
would prefer internal region since it will do data propagation and
persistence for us for free, but we still need to have a place to save the
jars as well.

On Sat, Nov 19, 2016 at 12:32 AM, Jared Stewart  wrote:

> The cluster.xml and cluster.properties files seem to contain the entirety
> of a given cluster configuration.  These are the only files included in the
> zip file produced by ‘export cluster-configuration’.  Does anyone know what
> the ConfigDiskDir files are used for?  Are they just redundant versions of
> the information stored in the .xml and .properties files?
>
> ./cluster_config
> ./cluster_config/cluster
> ./cluster_config/cluster/cluster.properties
> ./cluster_config/cluster/cluster.xml
> ./ConfigDiskDir_l1
> ./ConfigDiskDir_l1/BACKUPcluster_config.if
> ./ConfigDiskDir_l1/BACKUPcluster_config_1.crf
> ./ConfigDiskDir_l1/BACKUPcluster_config_1.drf
> ./ConfigDiskDir_l1/DRLK_IFcluster_config.lk




-- 
Cheers

Jinmei

Review Request 53910: GEODE-2124: Queries that invoke StructSet addAll fail with ClassCastException

[Jason Huynh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53910/
---

Review request for geode, Barry Oglesby and Dan Smith.


Repository: geode


Description
---

StructSet add all should use the overridden add method.  This prevents 
StructImpls from entering the set and converts them to Object[]


Diffs
-

  geode-core/src/main/java/org/apache/geode/cache/query/internal/StructSet.java 
6d04c02 
  
geode-core/src/test/java/org/apache/geode/cache/query/dunit/SelectStarQueryDUnitTest.java
 4596fdc 

Diff: https://reviews.apache.org/r/53910/diff/


Testing
---


Thanks,

Jason Huynh

Re: Cluster Configuration files

[Jacob Barrett]

In my memory the reason the files are written to disk is because nobody
wrote a input/output stream or other io interfaces for the XML parser to
use. Easy enough to do through.
On Fri, Nov 18, 2016 at 3:50 PM Jinmei Liao  wrote:

> As far as I remember, cluster configurations files are saved in an internal
> region as well, and that region is defined as replicate_persistent, so the
> content of it gets written to the disk as well in those ConfigDistDir
> backup files. This is something we need to clean up as well. Just use one
> way of saving the content, either in file system or internal region. I
> would prefer internal region since it will do data propagation and
> persistence for us for free, but we still need to have a place to save the
> jars as well.
>
> On Sat, Nov 19, 2016 at 12:32 AM, Jared Stewart 
> wrote:
>
> > The cluster.xml and cluster.properties files seem to contain the entirety
> > of a given cluster configuration.  These are the only files included in
> the
> > zip file produced by ‘export cluster-configuration’.  Does anyone know
> what
> > the ConfigDiskDir files are used for?  Are they just redundant versions
> of
> > the information stored in the .xml and .properties files?
> >
> > ./cluster_config
> > ./cluster_config/cluster
> > ./cluster_config/cluster/cluster.properties
> > ./cluster_config/cluster/cluster.xml
> > ./ConfigDiskDir_l1
> > ./ConfigDiskDir_l1/BACKUPcluster_config.if
> > ./ConfigDiskDir_l1/BACKUPcluster_config_1.crf
> > ./ConfigDiskDir_l1/BACKUPcluster_config_1.drf
> > ./ConfigDiskDir_l1/DRLK_IFcluster_config.lk
>
>
>
>
> --
> Cheers
>
> Jinmei
>

Review Request 53917: GEODE-2123 Replace static members in ParallelgatewaySenderQueues with instance variables

[nabarun nag]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53917/
---

Review request for geode, Barry Oglesby, Jason Huynh, Dan Smith, and xiaojian 
zhou.


Repository: geode


Description
---

All parallel sender queues shared one BatchRemovalThread, which led to the case 
that if BatchRemovalThread thread was killed by one sender, all secondary 
sender queues will keep growing as no prq remove messages will be sent to them.
Also, the static variables in ParallelGatewaySenderQueue needs to be converted 
in to instance variables, so that the senders don't share these variables and 
work independent of each other.

Fix:
statics converted to final instance variables.
cleanUpStatics function removed.


Diffs
-

  
geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java 
7b2e7ca 
  
geode-core/src/main/java/org/apache/geode/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java
 30773f9 

Diff: https://reviews.apache.org/r/53917/diff/


Testing
---


Thanks,

nabarun nag

Re: Review Request 53910: GEODE-2124: Queries that invoke StructSet addAll fail with ClassCastException

[Barry Oglesby]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53910/#review156359
---


Ship it!




Ship It!

- Barry Oglesby


On Nov. 19, 2016, 12:01 a.m., Jason Huynh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53910/
> ---
> 
> (Updated Nov. 19, 2016, 12:01 a.m.)
> 
> 
> Review request for geode, Barry Oglesby and Dan Smith.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> StructSet add all should use the overridden add method.  This prevents 
> StructImpls from entering the set and converts them to Object[]
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/cache/query/internal/StructSet.java 
> 6d04c02 
>   
> geode-core/src/test/java/org/apache/geode/cache/query/dunit/SelectStarQueryDUnitTest.java
>  4596fdc 
> 
> Diff: https://reviews.apache.org/r/53910/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jason Huynh
> 
>

Re: Review Request 53910: GEODE-2124: Queries that invoke StructSet addAll fail with ClassCastException

[Dan Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53910/#review156360
---


Fix it, then Ship it!





geode-core/src/main/java/org/apache/geode/cache/query/internal/StructSet.java 
(line 246)


Shouldn't this be modified |= add?



geode-core/src/main/java/org/apache/geode/cache/query/internal/StructSet.java 
(line 258)


modified |= remove


- Dan Smith


On Nov. 19, 2016, 12:01 a.m., Jason Huynh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53910/
> ---
> 
> (Updated Nov. 19, 2016, 12:01 a.m.)
> 
> 
> Review request for geode, Barry Oglesby and Dan Smith.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> StructSet add all should use the overridden add method.  This prevents 
> StructImpls from entering the set and converts them to Object[]
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/cache/query/internal/StructSet.java 
> 6d04c02 
>   
> geode-core/src/test/java/org/apache/geode/cache/query/dunit/SelectStarQueryDUnitTest.java
>  4596fdc 
> 
> Diff: https://reviews.apache.org/r/53910/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jason Huynh
> 
>

[GitHub] incubator-geode pull request #289: GEODE-2117: Pulse handles float type mbea...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-geode/pull/289


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 53917: GEODE-2123 Replace static members in ParallelgatewaySenderQueues with instance variables

[Barry Oglesby]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53917/#review156363
---




geode-core/src/main/java/org/apache/geode/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java
 


Why did you take the removeMembersWithSameOrNewerVersion and 
retainMembersWithSameOrNewerVersion calls out? Is it because every member is 
newer than 8.0? If so, then can we get rid of all the processing below the 
removeMembersWithSameOrNewerVersion call since the recipients will be empty?


- Barry Oglesby


On Nov. 19, 2016, 12:35 a.m., nabarun nag wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53917/
> ---
> 
> (Updated Nov. 19, 2016, 12:35 a.m.)
> 
> 
> Review request for geode, Barry Oglesby, Jason Huynh, Dan Smith, and xiaojian 
> zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> All parallel sender queues shared one BatchRemovalThread, which led to the 
> case that if BatchRemovalThread thread was killed by one sender, all 
> secondary sender queues will keep growing as no prq remove messages will be 
> sent to them.
> Also, the static variables in ParallelGatewaySenderQueue needs to be 
> converted in to instance variables, so that the senders don't share these 
> variables and work independent of each other.
> 
> Fix:
> statics converted to final instance variables.
> cleanUpStatics function removed.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java
>  7b2e7ca 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java
>  30773f9 
> 
> Diff: https://reviews.apache.org/r/53917/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> nabarun nag
> 
>

Re: Review Request 53917: GEODE-2123 Replace static members in ParallelgatewaySenderQueues with instance variables

[Jason Huynh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53917/#review156370
---




geode-core/src/main/java/org/apache/geode/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java
 (line 1710)


This and the below if statement can be removed...



geode-core/src/main/java/org/apache/geode/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java
 


This needs to stay


- Jason Huynh


On Nov. 19, 2016, 12:35 a.m., nabarun nag wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53917/
> ---
> 
> (Updated Nov. 19, 2016, 12:35 a.m.)
> 
> 
> Review request for geode, Barry Oglesby, Jason Huynh, Dan Smith, and xiaojian 
> zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> All parallel sender queues shared one BatchRemovalThread, which led to the 
> case that if BatchRemovalThread thread was killed by one sender, all 
> secondary sender queues will keep growing as no prq remove messages will be 
> sent to them.
> Also, the static variables in ParallelGatewaySenderQueue needs to be 
> converted in to instance variables, so that the senders don't share these 
> variables and work independent of each other.
> 
> Fix:
> statics converted to final instance variables.
> cleanUpStatics function removed.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java
>  7b2e7ca 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java
>  30773f9 
> 
> Diff: https://reviews.apache.org/r/53917/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> nabarun nag
> 
>

Re: Review Request 53917: GEODE-2123 Replace static members in ParallelgatewaySenderQueues with instance variables

[nabarun nag]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53917/
---

(Updated Nov. 19, 2016, 1:12 a.m.)


Review request for geode, Barry Oglesby, Jason Huynh, Dan Smith, and xiaojian 
zhou.


Repository: geode


Description
---

All parallel sender queues shared one BatchRemovalThread, which led to the case 
that if BatchRemovalThread thread was killed by one sender, all secondary 
sender queues will keep growing as no prq remove messages will be sent to them.
Also, the static variables in ParallelGatewaySenderQueue needs to be converted 
in to instance variables, so that the senders don't share these variables and 
work independent of each other.

Fix:
statics converted to final instance variables.
cleanUpStatics function removed.


Diffs (updated)
-

  
geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java 
7b2e7ca 
  
geode-core/src/main/java/org/apache/geode/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java
 30773f9 

Diff: https://reviews.apache.org/r/53917/diff/


Testing
---


Thanks,

nabarun nag

Re: Review Request 53917: GEODE-2123 Replace static members in ParallelgatewaySenderQueues with instance variables

[nabarun nag]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53917/
---

(Updated Nov. 19, 2016, 1:14 a.m.)


Review request for geode, Barry Oglesby, Jason Huynh, Dan Smith, and xiaojian 
zhou.


Repository: geode


Description
---

All parallel sender queues shared one BatchRemovalThread, which led to the case 
that if BatchRemovalThread thread was killed by one sender, all secondary 
sender queues will keep growing as no prq remove messages will be sent to them.
Also, the static variables in ParallelGatewaySenderQueue needs to be converted 
in to instance variables, so that the senders don't share these variables and 
work independent of each other.

Fix:
statics converted to final instance variables.
cleanUpStatics function removed.


Diffs (updated)
-

  
geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java 
7b2e7ca 
  
geode-core/src/main/java/org/apache/geode/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java
 30773f9 

Diff: https://reviews.apache.org/r/53917/diff/


Testing
---


Thanks,

nabarun nag