Build failed in Jenkins: Geode-nightly #656

2016-11-17 Thread Apache Jenkins Server 
See 

Changes:

[adongre] GEODE-2098: Moved gfsh history file location from .gemfire to .geode

[bschuchardt] GEODE-2073 CI Failure:

[kmiller] GEODE-2114 Revise user and password options to gfsh connect

[huynhja] GEODE-2100: Add new version of query client server messages

[gzhou] GEODE-2107: fix the threadleak when a secondary sender is closed

--
[...truncated 536 lines...]
:geode-json:testClasses UP-TO-DATE
:geode-json:checkMissedTests UP-TO-DATE
:geode-json:spotlessJavaCheck
:geode-json:spotlessCheck
:geode-json:test UP-TO-DATE
:geode-json:check
:geode-json:build
:geode-json:distributedTest UP-TO-DATE
:geode-json:flakyTest UP-TO-DATE
:geode-json:integrationTest UP-TO-DATE
:geode-junit:javadoc
:geode-junit:javadocJar
:geode-junit:sourcesJar
:geode-junit:signArchives SKIPPED
:geode-junit:assemble
:geode-junit:compileTestJava
:geode-junit:processTestResources UP-TO-DATE
:geode-junit:testClasses
:geode-junit:checkMissedTests
:geode-junit:spotlessJavaCheck
:geode-junit:spotlessCheck
:geode-junit:test
:geode-junit:check
:geode-junit:build
:geode-junit:distributedTest
:geode-junit:flakyTest
:geode-junit:integrationTest
:geode-lucene:assemble
:geode-lucene:compileTestJavaNote: Some input files use or override a 
deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-lucene:processTestResources
:geode-lucene:testClasses
:geode-lucene:checkMissedTests
:geode-lucene:spotlessJavaCheck
:geode-lucene:spotlessCheck
:geode-lucene:test
:geode-lucene:check
:geode-lucene:build
:geode-lucene:distributedTest
:geode-lucene:flakyTest

org.apache.geode.cache.lucene.LuceneQueriesPeerPRRedundancyDUnitTest > 
returnCorrectResultsWhenCloseCacheHappensOnIndexUpdate FAILED
org.apache.geode.test.dunit.RMIException: While invoking 
org.apache.geode.cache.lucene.LuceneQueriesPeerPRRedundancyDUnitTest$$Lambda$26/928359344.run
 in VM 0 running on Host asf920.gq1.ygridcore.net with 4 VMs
at org.apache.geode.test.dunit.VM.invoke(VM.java:344)
at org.apache.geode.test.dunit.VM.invoke(VM.java:314)
at org.apache.geode.test.dunit.VM.invoke(VM.java:259)
at 
org.apache.geode.cache.lucene.LuceneQueriesPeerPRRedundancyDUnitTest.returnCorrectResultsWhenCloseCacheHappensOnIndexUpdate(LuceneQueriesPeerPRRedundancyDUnitTest.java:83)

Caused by:
com.jayway.awaitility.core.ConditionTimeoutException: Condition with 
lambda expression in 
org.apache.geode.cache.lucene.LuceneQueriesPeerPRRedundancyDUnitTest that uses 
org.apache.geode.cache.Cache was not fulfilled within 60 seconds.
at 
com.jayway.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:122)
at 
com.jayway.awaitility.core.CallableCondition.await(CallableCondition.java:79)
at 
com.jayway.awaitility.core.CallableCondition.await(CallableCondition.java:27)
at 
com.jayway.awaitility.core.ConditionFactory.until(ConditionFactory.java:764)
at 
com.jayway.awaitility.core.ConditionFactory.until(ConditionFactory.java:741)
at 
org.apache.geode.cache.lucene.LuceneQueriesPeerPRRedundancyDUnitTest.lambda$returnCorrectResultsWhenCloseCacheHappensOnIndexUpdate$bb17a952$2(LuceneQueriesPeerPRRedundancyDUnitTest.java:84)

2 tests completed, 1 failed
:geode-lucene:flakyTest FAILED
:geode-lucene:integrationTest
:geode-old-client-support:assemble
:geode-old-client-support:compileTestJava
:geode-old-client-support:processTestResources UP-TO-DATE
:geode-old-client-support:testClasses
:geode-old-client-support:checkMissedTests
:geode-old-client-support:spotlessJavaCheck
:geode-old-client-support:spotlessCheck
:geode-old-client-support:test
:geode-old-client-support:check
:geode-old-client-support:build
:geode-old-client-support:distributedTest
:geode-old-client-support:flakyTest
:geode-old-client-support:integrationTest
:geode-pulse:assemble
:geode-pulse:compileTestJavaNote: 

 uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-pulse:processTestResources
:geode-pulse:testClasses
:geode-pulse:checkMissedTests
:geode-pulse:spotlessJavaCheck
:geode-pulse:spotlessCheck
:geode-pulse:test
:geode-pulse:check
:geode-pulse:build
:geode-pulse:distributedTest
:geode-pulse:flakyTest
:geode-pulse:integrationTest
:geode-rebalancer:assemble
:geode-rebalancer:compileTestJava
:geode-rebalancer:processTestResources UP-TO-DATE
:geode-rebalancer:testClasses
:geode-rebalancer:checkMissedTests
:geode-rebalancer:spotlessJavaCheck
:geode-rebalancer:spotlessCheck
:geode-rebalancer:test
:geode-rebalance

Review Request 53856: concurse is slower, so we need to wait longer for results

2016-11-17 Thread xiaojian zhou 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53856/
---

Review request for geode, Darrel Schneider and Dan Smith.


Bugs: geode-2120
https://issues.apache.org/jira/browse/geode-2120


Repository: geode


Description
---

The test waited for up to 5 seconds for the compaction, usually it only took 
30ms to finish. However, sometimes in concurse, it did took more than 5 seconds 
to finish (In the reproduced failure, it took 7 seconds).

The fix is to wait longer.


Diffs
-

  
geode-core/src/test/java/org/apache/geode/internal/cache/MultipleOplogsRollingFeatureJUnitTest.java
 1f61be3 

Diff: https://reviews.apache.org/r/53856/diff/


Testing
---


Thanks,

xiaojian zhou

Re: Review Request 53856: concurse is slower, so we need to wait longer for results

2016-11-17 Thread Dan Smith 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53856/#review156223
---


Fix it, then Ship it!





geode-core/src/test/java/org/apache/geode/internal/cache/MultipleOplogsRollingFeatureJUnitTest.java
 (line 154)


This could be replaced with awaitility.


- Dan Smith


On Nov. 17, 2016, 6:06 p.m., xiaojian zhou wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53856/
> ---
> 
> (Updated Nov. 17, 2016, 6:06 p.m.)
> 
> 
> Review request for geode, Darrel Schneider and Dan Smith.
> 
> 
> Bugs: geode-2120
> https://issues.apache.org/jira/browse/geode-2120
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> The test waited for up to 5 seconds for the compaction, usually it only took 
> 30ms to finish. However, sometimes in concurse, it did took more than 5 
> seconds to finish (In the reproduced failure, it took 7 seconds).
> 
> The fix is to wait longer.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/MultipleOplogsRollingFeatureJUnitTest.java
>  1f61be3 
> 
> Diff: https://reviews.apache.org/r/53856/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> xiaojian zhou
> 
>

Re: Review Request 53856: concurse is slower, so we need to wait longer for results

2016-11-17 Thread Jason Huynh 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53856/#review156224
---



Should we rename this to IntegrationTest instead of JUnitTest (Not sure what 
our conventions are...)

- Jason Huynh


On Nov. 17, 2016, 6:06 p.m., xiaojian zhou wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53856/
> ---
> 
> (Updated Nov. 17, 2016, 6:06 p.m.)
> 
> 
> Review request for geode, Darrel Schneider and Dan Smith.
> 
> 
> Bugs: geode-2120
> https://issues.apache.org/jira/browse/geode-2120
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> The test waited for up to 5 seconds for the compaction, usually it only took 
> 30ms to finish. However, sometimes in concurse, it did took more than 5 
> seconds to finish (In the reproduced failure, it took 7 seconds).
> 
> The fix is to wait longer.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/MultipleOplogsRollingFeatureJUnitTest.java
>  1f61be3 
> 
> Diff: https://reviews.apache.org/r/53856/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> xiaojian zhou
> 
>

Review Request 53857: GEODE-2095: Stabilize flaky tests

2016-11-17 Thread Ken Howe 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53857/
---

Review request for geode.


Repository: geode


Description
---

Changed checks for expected log messages from time based to event based.

Tests that verify that log messages occured as expected were using an overly 
optimistic test for 'n'
logs after a set period of time. The Mockito.verify calls are now placed within 
the swait()'s. Also simplified tests that have a final check to make sure 
missing colocated region logging stopped after all child PRs are created.


Diffs
-

  
geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/PersistentColocatedPartitionedRegionDUnitTest.java
 a044a612fbbc6b905e3ad1389a9c0d7994f8598a 

Diff: https://reviews.apache.org/r/53857/diff/


Testing
---

Ran spotlessCheck (and spotlessApply to fix some formatting)

Precheckin is in progress


Thanks,

Ken Howe

Re: Review Request 53857: GEODE-2095: Stabilize flaky tests

2016-11-17 Thread Ken Howe 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53857/
---

(Updated Nov. 17, 2016, 10:38 p.m.)


Review request for geode, anilkumar gingade, Darrel Schneider, and Eric Shu.


Changes
---

Adding sepcifc reviewers. Precheckin tests passed.


Repository: geode


Description
---

Changed checks for expected log messages from time based to event based.

Tests that verify that log messages occured as expected were using an overly 
optimistic test for 'n'
logs after a set period of time. The Mockito.verify calls are now placed within 
the swait()'s. Also simplified tests that have a final check to make sure 
missing colocated region logging stopped after all child PRs are created.


Diffs
-

  
geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/PersistentColocatedPartitionedRegionDUnitTest.java
 a044a612fbbc6b905e3ad1389a9c0d7994f8598a 

Diff: https://reviews.apache.org/r/53857/diff/


Testing (updated)
---

Ran spotlessCheck (and spotlessApply to fix some formatting)

Precheckin copmleted successfully


Thanks,

Ken Howe

[GitHub] incubator-geode pull request #287: GEODE-2112: Fix UITests failing due to in...

2016-11-17 Thread jaredjstewart 
GitHub user jaredjstewart opened a pull request:

https://github.com/apache/incubator-geode/pull/287

GEODE-2112: Fix UITests failing due to insufficient cleanup

 - Extracted setup of the Server and WebDriver for Pulse tests into JUnit 
Rules
 - Refactored UITests
 - Removed a lot of unused test code

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jaredjstewart/incubator-geode 
feature/GEODE-2112-2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/287.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #287


commit 124dacfab1e48e3a32eae867c77e9e4733aab096
Author: Jared Stewart 
Date:   2016-11-17T22:59:20Z

GEODE-2112: Fix UITests failing due to insufficient cleanup

 - Extracted setup of the Server and WebDriver for Pulse tests into JUnit 
Rules
 - Refactored UITests
 - Removed a lot of unused test code




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-geode issue #287: GEODE-2112: Fix UITests failing due to insuffici...

2016-11-17 Thread jaredjstewart 
Github user jaredjstewart commented on the issue:

https://github.com/apache/incubator-geode/pull/287
  
Precheckin started


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-geode pull request #288: GEODE-2092 - Security examples should not...

2016-11-17 Thread kjduling 
GitHub user kjduling opened a pull request:

https://github.com/apache/incubator-geode/pull/288

GEODE-2092 - Security examples should not be in the product code

Moved examples to geode-examples project
Copied old Sample/Simple code to test packages as many tests rely on these 
classes.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kjduling/incubator-geode feature/GEODE-2092

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/288.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #288


commit 1099d9cbc868d0ad93f76b18de82e69400339e5a
Author: Kevin Duling 
Date:   2016-11-17T18:57:00Z

GEODE-2092 - Security examples should not be in the product code

Moved examples to geode-examples project
Copied old Sample/Simple code to test packages as many tests rely on these 
classes.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Review Request 53864: GEODE-2121 add DLockTest, MembershipTest, ClientServerTest, ClientSubscriptionTest and RestAPITest categories

2016-11-17 Thread Bruce Schuchardt 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53864/
---

Review request for geode, Hitesh Khamesra and Udo Kohlmeyer.


Bugs: GEODE-2121
https://issues.apache.org/jira/browse/GEODE-2121


Repository: geode


Description
---

This adds more unit test categories to augment the ones that we already have.  
The new categories are areas where I do most of my work and will enable people 
to run the category of tests to see if the associated component of Geode has 
been adversely affected by a change before running a complete precheckin.  It 
also lets us do code-coverage runs for these specific components.


Diffs
-

  geode-assembly/src/test/java/org/apache/geode/BundledJarsJUnitTest.java 
8c228f21b5b00f66c2b75b14c0292eaf113e54c5 
  
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestInterfaceJUnitTest.java
 932119d7813533af6f1812b2be172b5a1ad5ea1c 
  
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestServersJUnitTest.java
 b49e6cad6c3d3f2a151e9d87426859ddd8e20e6b 
  
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/SwaggerVerificationTest.java
 e706b0ed18e61f58bc230d86ac42c7c0af395589 
  
geode-core/src/test/java/org/apache/geode/cache/ClientServerTimeSyncDUnitTest.java
 6d5e840843b7ebd53724a752aceae2320a35780c 
  
geode-core/src/test/java/org/apache/geode/cache/ConnectionPoolAndLoaderDUnitTest.java
 8c02589bffc918faa6b1b6db83a42f84b32a6824 
  
geode-core/src/test/java/org/apache/geode/cache/ConnectionPoolAutoDUnitTest.java
 68269e3111ddedded41e8816b2d6e100217e9aad 
  geode-core/src/test/java/org/apache/geode/cache/ConnectionPoolDUnitTest.java 
8bff8be6e235df8c32a52385e2b959f7cb49c762 
  
geode-core/src/test/java/org/apache/geode/cache/ConnectionPoolFactoryJUnitTest.java
 b2be14ab75ae69ca661df2893e5bbf837f527442 
  
geode-core/src/test/java/org/apache/geode/cache/MembershipAttributesAreSerializableTest.java
 93d702b1cff33f1b940e0041a1ed565771426617 
  geode-core/src/test/java/org/apache/geode/cache/PoolManagerJUnitTest.java 
23d8d9823b0543c4090bbc94a63bf7f4afc724f2 
  
geode-core/src/test/java/org/apache/geode/cache/client/ClientCacheFactoryJUnitTest.java
 a2339e25f8cbdd51c9d229e74a4ccfd177728982 
  
geode-core/src/test/java/org/apache/geode/cache/client/ClientRegionFactoryJUnitTest.java
 d099b06f7e00cb99cd3c6f25e951492d1dd866a5 
  
geode-core/src/test/java/org/apache/geode/cache/client/ClientServerRegisterInterestsDUnitTest.java
 9c8044d6a24d507b893bf329ab6f1129d9d6a300 
  
geode-core/src/test/java/org/apache/geode/cache/client/internal/AutoConnectionSourceDUnitTest.java
 f0fd7a675618fe6ebc2de5dd49f32335607185dd 
  
geode-core/src/test/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImplJUnitTest.java
 fdde35c35b9e09a38e629e105916b5080173f52c 
  
geode-core/src/test/java/org/apache/geode/cache/client/internal/CacheServerSSLConnectionDUnitTest.java
 d3c4e3cc8cc26f5f7be303ede04e477d32d04234 
  
geode-core/src/test/java/org/apache/geode/cache/client/internal/ConnectionPoolImplJUnitTest.java
 a9eb6721b6b53acb0b6c8f162e94df28edd9fb19 
  
geode-core/src/test/java/org/apache/geode/cache/client/internal/LocatorLoadBalancingDUnitTest.java
 f468e93a415973ede52309f193d59cd955728b88 
  
geode-core/src/test/java/org/apache/geode/cache/client/internal/OpExecutorImplJUnitTest.java
 37511cfc73239759e5fdbf8107f018b7558a2a73 
  
geode-core/src/test/java/org/apache/geode/cache/client/internal/QueueManagerJUnitTest.java
 812ce16c3d9802b411e3351d11e6e438115c9c6a 
  
geode-core/src/test/java/org/apache/geode/cache/client/internal/SSLNoClientAuthDUnitTest.java
 bba6d5470099e98e1bc5fc454f49a1b817314c12 
  
geode-core/src/test/java/org/apache/geode/cache/client/internal/ServerBlackListJUnitTest.java
 eccbefdb208214e704b1f4963fb73facaac8e5b3 
  
geode-core/src/test/java/org/apache/geode/cache/client/internal/pooling/ConnectionManagerJUnitTest.java
 0f632b822c1d3f4d165a2a6b4a056eaef8551f2e 
  
geode-core/src/test/java/org/apache/geode/cache/mapInterface/PutAllGlobalLockJUnitTest.java
 bc88b7a2218c29484f5959ad086b65e6c3944c4c 
  geode-core/src/test/java/org/apache/geode/cache30/Bug38741DUnitTest.java 
2c8b0f7441a534ebedacd875dd3e9ed11d201f22 
  
geode-core/src/test/java/org/apache/geode/cache30/ClientMembershipDUnitTest.java
 67b1e9e7076f129b6edff8e0223a80b6d5edf5e2 
  
geode-core/src/test/java/org/apache/geode/cache30/ClientMembershipSelectorDUnitTest.java
 c066bcca517670f01320c2948937c589352dc47a 
  
geode-core/src/test/java/org/apache/geode/cache30/ClientRegisterInterestDUnitTest.java
 447cca6a28112475282e1b8975231607cc271795 
  
geode-core/src/test/java/org/apache/geode/cache30/ClientRegisterInterestSelectorDUnitTest.java
 3c0dddfce42148328ee2f30abfdbdde1c6c420ae 
  
geode-core/src/test/java/org/apache/geode/cache30/ClientServerCCEDUnitTest.java 
19e9ea60328e2ba5461e65c909a4f7aa5aba3fe1 
  geode-co

Review Request 53865: GEODE-2127 old client support service is not set up to handle arrays

2016-11-17 Thread Bruce Schuchardt 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53865/
---

Review request for geode, Hitesh Khamesra and Udo Kohlmeyer.


Bugs: GEODE-2127
https://issues.apache.org/jira/browse/GEODE-2127


Repository: geode


Description
---

Array classes start with some number of left-brackets ("[") followed by "L" and 
the name of the class the array contains.  This adds a unit test for arrays and 
adds support for handling them in OldClientSupportProvider.


Diffs
-

  geode-core/src/main/java/org/apache/geode/DataSerializer.java 
29b20a22ffe0f08fece15429816901370015c35a 
  
geode-core/src/main/java/org/apache/geode/internal/InternalDataSerializer.java 
d136b87681066e9ae516382b9311f130d5c81f06 
  
geode-old-client-support/src/main/java/com/gemstone/gemfire/OldClientSupportProvider.java
 a012c1689ba2dd3fe78b73001d4baa4340e8ac6f 
  
geode-old-client-support/src/test/java/org/apache/geode/OldClientSupportDUnitTest.java
 0844bf084c47c89748079a00988768da309c6d1a 

Diff: https://reviews.apache.org/r/53865/diff/


Testing
---

new test, precheckin


Thanks,

Bruce Schuchardt

[GitHub] incubator-geode issue #288: GEODE-2092 - Security examples should not be in ...

2016-11-17 Thread kjduling 
Github user kjduling commented on the issue:

https://github.com/apache/incubator-geode/pull/288
  
I moved the examples in to 
geode-examples/utils/src/main/java/org/apache/geode/example/security/ so it 
looks like I misunderstood and jumped the gun.  So, I'll undo that, and move 
them to geode-core/src/main/java/org/apache/geode/examples/security/

#2 should be correct.  No test should depend on any production code in 
geode-core.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Review Request 53867: GEODE-2129 make pdxtype id random(not sequential)

2016-11-17 Thread Hitesh Khamesra 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53867/
---

Review request for geode, Bruce Schuchardt and Udo Kohlmeyer.


Repository: geode


Description
---

Right now pdxtype id has 4 bytes. Out of those 4 bytes, one byte reserved for 
distributed-system-id, this make sure type id generated from different cluster 
has different id. For rest of the three bytes we just increment counter to 
create new pdxtype id. In the field, we have observed that sometimes this 
pdxType Id collides. One reason could be they end up having same 
distributed-system-id for the different cluster.
Thus to avoid a collision, we will be using hashcode of pdxType for three bytes 
of pdxType id. That will reduce the possibility of collision.


Diffs
-

  geode-core/src/main/java/org/apache/geode/pdx/internal/EnumId.java 5d399eb 
  geode-core/src/main/java/org/apache/geode/pdx/internal/PdxType.java b586f64 
  
geode-core/src/main/java/org/apache/geode/pdx/internal/PeerTypeRegistration.java
 0226cca 
  geode-core/src/test/java/org/apache/geode/pdx/PdxAttributesJUnitTest.java 
c45abce 
  geode-core/src/test/java/org/apache/geode/pdx/PdxSerializableJUnitTest.java 
5cd822c 
  geode-wan/src/test/java/org/apache/geode/internal/cache/wan/WANTestBase.java 
f9c18ec 
  
geode-wan/src/test/java/org/apache/geode/internal/cache/wan/misc/PDXNewWanDUnitTest.java
 f1e8f42 

Diff: https://reviews.apache.org/r/53867/diff/


Testing
---


Thanks,

Hitesh Khamesra

Re: Review Request 53867: GEODE-2129 make pdxtype id random(not sequential)

2016-11-17 Thread Vishal Rao 
Apologies if this is noise, but wouldn't using the hash code actually
increase the likelihood of ID collisions?

On Fri, Nov 18, 2016 at 6:11 AM, Hitesh Khamesra 
wrote:

>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53867/
> ---
>
> Review request for geode, Bruce Schuchardt and Udo Kohlmeyer.
>
>
> Repository: geode
>
>
> Description
> ---
>
> Right now pdxtype id has 4 bytes. Out of those 4 bytes, one byte reserved
> for distributed-system-id, this make sure type id generated from different
> cluster has different id. For rest of the three bytes we just increment
> counter to create new pdxtype id. In the field, we have observed that
> sometimes this pdxType Id collides. One reason could be they end up having
> same distributed-system-id for the different cluster.
> Thus to avoid a collision, we will be using hashcode of pdxType for three
> bytes of pdxType id. That will reduce the possibility of collision.
>
>
> Diffs
> -
>
>   geode-core/src/main/java/org/apache/geode/pdx/internal/EnumId.java
> 5d399eb
>   geode-core/src/main/java/org/apache/geode/pdx/internal/PdxType.java
> b586f64
>   
> geode-core/src/main/java/org/apache/geode/pdx/internal/PeerTypeRegistration.java
> 0226cca
>   geode-core/src/test/java/org/apache/geode/pdx/PdxAttributesJUnitTest.java
> c45abce
>   geode-core/src/test/java/org/apache/geode/pdx/PdxSerializableJUnitTest.java
> 5cd822c
>   geode-wan/src/test/java/org/apache/geode/internal/cache/wan/WANTestBase.java
> f9c18ec
>   geode-wan/src/test/java/org/apache/geode/internal/cache/
> wan/misc/PDXNewWanDUnitTest.java f1e8f42
>
> Diff: https://reviews.apache.org/r/53867/diff/
>
>
> Testing
> ---
>
>
> Thanks,
>
> Hitesh Khamesra
>
>


-- 
"The World is a book, and those who do not travel read only a page." - St.
Augustine.