[GitHub] [incubator-doris] imay commented on a change in pull request #1154: Add logic of cancel job
imay commented on a change in pull request #1154: Add logic of cancel job
URL: https://github.com/apache/incubator-doris/pull/1154#discussion_r283659159
##
File path: fe/src/main/java/org/apache/doris/load/loadv2/LoadManager.java
##
@@ -113,10 +114,11 @@ public void cancelLoadJob(CancelLoadStmt stmt) throws
DdlException {
if (!dbIdToLabelToLoadJobs.containsKey(db.getId())) {
throw new DdlException("Load job does not exist");
}
-if
(!dbIdToLabelToLoadJobs.get(db.getId()).containsKey(stmt.getLabel())) {
+Map> labelToLoadJobs =
dbIdToLabelToLoadJobs.get(db.getId());
+if (!labelToLoadJobs.containsKey(stmt.getLabel())) {
throw new DdlException("Load job does not exist");
}
-List loadJobList =
dbIdToLabelToLoadJobs.get(db.getId()).get(stmt.getLabel());
+List loadJobList = labelToLoadJobs.get(stmt.getLabel());
Review comment:
Hash the key is the first operation, `containsKey` will also check if two
keys are equal, because hash of two keys may equal. And these operation's cost
is less than a `get` operation.
Yes, in this case you add a readLock. But what I want to say is that it is
good habit to check get's value
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] imay commented on issue #1157: Use inexistent key (in prefix-index) to filter rows will cost too much time to return.
imay commented on issue #1157: Use inexistent key (in prefix-index) to filter rows will cost too much time to return. URL: https://github.com/apache/incubator-doris/issues/1157#issuecomment-492115378 It seems like a bad case for Doris, We will look into it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman closed issue #1145: BE process exits because of failure of loading index
morningman closed issue #1145: BE process exits because of failure of loading index URL: https://github.com/apache/incubator-doris/issues/1145 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman closed issue #1099: Broker load is not cancelled even if some instances already failed
morningman closed issue #1099: Broker load is not cancelled even if some instances already failed URL: https://github.com/apache/incubator-doris/issues/1099 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman closed issue #1111: NullpointerException encountered in transaction process
morningman closed issue #: NullpointerException encountered in transaction process URL: https://github.com/apache/incubator-doris/issues/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman closed issue #903: Modify the method to obtain some metrics
morningman closed issue #903: Modify the method to obtain some metrics URL: https://github.com/apache/incubator-doris/issues/903 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman closed issue #794: Use funciton (count and HLL_UNION_AGG) in one column cause doris return wrong value
morningman closed issue #794: Use funciton (count and HLL_UNION_AGG) in one column cause doris return wrong value URL: https://github.com/apache/incubator-doris/issues/794 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman closed issue #1148: Partition pruning support more function
morningman closed issue #1148: Partition pruning support more function URL: https://github.com/apache/incubator-doris/issues/1148 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman closed issue #1115: Add str_to_date function in fe
morningman closed issue #1115: Add str_to_date function in fe URL: https://github.com/apache/incubator-doris/issues/1115 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman closed issue #1090: Bugs when using function in both stream load request and routine load job
morningman closed issue #1090: Bugs when using function in both stream load request and routine load job URL: https://github.com/apache/incubator-doris/issues/1090 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman commented on issue #681: BE can't start
morningman commented on issue #681: BE can't start URL: https://github.com/apache/incubator-doris/issues/681#issuecomment-492119644 related to #1145 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman closed issue #681: BE can't start
morningman closed issue #681: BE can't start URL: https://github.com/apache/incubator-doris/issues/681 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman closed issue #677: Running partition mark does not remove when delete operation encounter errors
morningman closed issue #677: Running partition mark does not remove when delete operation encounter errors URL: https://github.com/apache/incubator-doris/issues/677 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman closed issue #679: Did not clear dpp temp file after load finished
morningman closed issue #679: Did not clear dpp temp file after load finished URL: https://github.com/apache/incubator-doris/issues/679 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman closed issue #768: Add HLL colum by alter table result in doris all be core dump
morningman closed issue #768: Add HLL colum by alter table result in doris all be core dump URL: https://github.com/apache/incubator-doris/issues/768 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman closed issue #774: BE core when build in debug mode for es table
morningman closed issue #774: BE core when build in debug mode for es table URL: https://github.com/apache/incubator-doris/issues/774 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #1154: Add logic of cancel job
EmmyMiao87 commented on a change in pull request #1154: Add logic of cancel job
URL: https://github.com/apache/incubator-doris/pull/1154#discussion_r283668614
##
File path: fe/src/main/java/org/apache/doris/load/loadv2/LoadManager.java
##
@@ -113,10 +114,11 @@ public void cancelLoadJob(CancelLoadStmt stmt) throws
DdlException {
if (!dbIdToLabelToLoadJobs.containsKey(db.getId())) {
throw new DdlException("Load job does not exist");
}
-if
(!dbIdToLabelToLoadJobs.get(db.getId()).containsKey(stmt.getLabel())) {
+Map> labelToLoadJobs =
dbIdToLabelToLoadJobs.get(db.getId());
+if (!labelToLoadJobs.containsKey(stmt.getLabel())) {
throw new DdlException("Load job does not exist");
}
-List loadJobList =
dbIdToLabelToLoadJobs.get(db.getId()).get(stmt.getLabel());
+List loadJobList = labelToLoadJobs.get(stmt.getLabel());
Review comment:
Yes, you are right. If I only check the key, the containsKey is better. If I
need to check and get in concurrent situation, the get and check null is better.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman closed issue #936: Fail to load indices due to balance when adding be
morningman closed issue #936: Fail to load indices due to balance when adding be URL: https://github.com/apache/incubator-doris/issues/936 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman commented on issue #936: Fail to load indices due to balance when adding be
morningman commented on issue #936: Fail to load indices due to balance when adding be URL: https://github.com/apache/incubator-doris/issues/936#issuecomment-492120776 related to ISSUE #1145 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman closed issue #955: Constant predicate related bug
morningman closed issue #955: Constant predicate related bug URL: https://github.com/apache/incubator-doris/issues/955 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman closed issue #1073: No rule to make target
morningman closed issue #1073: No rule to make target URL: https://github.com/apache/incubator-doris/issues/1073 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman commented on issue #1073: No rule to make target
morningman commented on issue #1073: No rule to make target URL: https://github.com/apache/incubator-doris/issues/1073#issuecomment-492121399 It does not reproduce in my environment, may be rebuild thrift can solve this problem. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman closed issue #28: Fedora编译be模块失败
morningman closed issue #28: Fedora编译be模块失败 URL: https://github.com/apache/incubator-doris/issues/28 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman commented on issue #14: 编译be出错，重复定义struct std::hash<__int128>
morningman commented on issue #14: 编译be出错，重复定义struct std::hash<__int128> URL: https://github.com/apache/incubator-doris/issues/14#issuecomment-492121797 Not a problem anymore, using docker dev environment instead This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman commented on issue #28: Fedora编译be模块失败
morningman commented on issue #28: Fedora编译be模块失败 URL: https://github.com/apache/incubator-doris/issues/28#issuecomment-492121864 Not a problem anymore, using docker dev environment instead This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman closed issue #14: 编译be出错，重复定义struct std::hash<__int128>
morningman closed issue #14: 编译be出错，重复定义struct std::hash<__int128> URL: https://github.com/apache/incubator-doris/issues/14 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman closed issue #97: ubuntu16.04下编译palo报错
morningman closed issue #97: ubuntu16.04下编译palo报错 URL: https://github.com/apache/incubator-doris/issues/97 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman commented on issue #97: ubuntu16.04下编译palo报错
morningman commented on issue #97: ubuntu16.04下编译palo报错 URL: https://github.com/apache/incubator-doris/issues/97#issuecomment-492122007 Not a problem anymore, using docker dev environment instead This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman commented on issue #109: ERROR 5036 (HY000): exec rpc errorUNKONWN
morningman commented on issue #109: ERROR 5036 (HY000): exec rpc errorUNKONWN URL: https://github.com/apache/incubator-doris/issues/109#issuecomment-492122188 Reopen it if happening again This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman closed issue #116: Readme文档写得真不错，3个问题，希望能够回答
morningman closed issue #116: Readme文档写得真不错，3个问题，希望能够回答 URL: https://github.com/apache/incubator-doris/issues/116 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] chaoyli commented on issue #1157: Use inexistent key (in prefix-index) to filter rows will cost too much time to return.
chaoyli commented on issue #1157: Use inexistent key (in prefix-index) to filter rows will cost too much time to return. URL: https://github.com/apache/incubator-doris/issues/1157#issuecomment-492122337 There may be has something with VARCHAR type. You can try it in another type. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman closed issue #109: ERROR 5036 (HY000): exec rpc errorUNKONWN
morningman closed issue #109: ERROR 5036 (HY000): exec rpc errorUNKONWN URL: https://github.com/apache/incubator-doris/issues/109 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman closed issue #485: Backend start fail cause unable to find tablet
morningman closed issue #485: Backend start fail cause unable to find tablet URL: https://github.com/apache/incubator-doris/issues/485 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman commented on issue #485: Backend start fail cause unable to find tablet
morningman commented on issue #485: Backend start fail cause unable to find tablet URL: https://github.com/apache/incubator-doris/issues/485#issuecomment-492123237 related to #1145 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman closed issue #522: Index id in Partition instance is different from index id in OlapTable instance
morningman closed issue #522: Index id in Partition instance is different from index id in OlapTable instance URL: https://github.com/apache/incubator-doris/issues/522 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman closed issue #444: Sometimes insert operation does not generate rollup's data file
morningman closed issue #444: Sometimes insert operation does not generate rollup's data file URL: https://github.com/apache/incubator-doris/issues/444 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman closed issue #455: Failed to build doris
morningman closed issue #455: Failed to build doris URL: https://github.com/apache/incubator-doris/issues/455 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman closed issue #406: Doris 0.9.0-incubating release notes
morningman closed issue #406: Doris 0.9.0-incubating release notes URL: https://github.com/apache/incubator-doris/issues/406 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman closed issue #405: The Release of Doris 0.9.0-incubating
morningman closed issue #405: The Release of Doris 0.9.0-incubating URL: https://github.com/apache/incubator-doris/issues/405 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman closed issue #365: Failed to start Doris BE on centos 7
morningman closed issue #365: Failed to start Doris BE on centos 7 URL: https://github.com/apache/incubator-doris/issues/365 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman closed issue #346: BE olap_common_test couldn't run
morningman closed issue #346: BE olap_common_test couldn't run URL: https://github.com/apache/incubator-doris/issues/346 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman closed issue #353: Support loading data from Kafka
morningman closed issue #353: Support loading data from Kafka URL: https://github.com/apache/incubator-doris/issues/353 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman closed issue #307: The BE storage_root_path is set to a soft symlink, causing the load task to stay in the QUORUM_FINIHSED state
morningman closed issue #307: The BE storage_root_path is set to a soft symlink, causing the load task to stay in the QUORUM_FINIHSED state URL: https://github.com/apache/incubator-doris/issues/307 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman closed issue #297: Support for custom gcc paths
morningman closed issue #297: Support for custom gcc paths URL: https://github.com/apache/incubator-doris/issues/297 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman commented on issue #517: build local source code with docker met error "mkdir: cannot create directory 'build': File exists"
morningman commented on issue #517: build local source code with docker met error "mkdir: cannot create directory 'build': File exists" URL: https://github.com/apache/incubator-doris/issues/517#issuecomment-492127678 plz use docker dev env to build from source This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman closed issue #517: build local source code with docker met error "mkdir: cannot create directory 'build': File exists"
morningman closed issue #517: build local source code with docker met error "mkdir: cannot create directory 'build': File exists" URL: https://github.com/apache/incubator-doris/issues/517 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman commented on issue #242: Poor query performance under high concurrence
morningman commented on issue #242: Poor query performance under high concurrence URL: https://github.com/apache/incubator-doris/issues/242#issuecomment-492129186 Reopen it if it still a problem This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman closed issue #242: Poor query performance under high concurrence
morningman closed issue #242: Poor query performance under high concurrence URL: https://github.com/apache/incubator-doris/issues/242 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman closed issue #211: Improve exception safety with smart pointers
morningman closed issue #211: Improve exception safety with smart pointers URL: https://github.com/apache/incubator-doris/issues/211 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman commented on issue #211: Improve exception safety with smart pointers
morningman commented on issue #211: Improve exception safety with smart pointers URL: https://github.com/apache/incubator-doris/issues/211#issuecomment-492129837 Yes, we already change some ptr to smart pointer like shared_ptr or unique_ptr. Just close this issue. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman closed issue #199: Palo导入数据问题
morningman closed issue #199: Palo导入数据问题 URL: https://github.com/apache/incubator-doris/issues/199 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman commented on issue #199: Palo导入数据问题
morningman commented on issue #199: Palo导入数据问题 URL: https://github.com/apache/incubator-doris/issues/199#issuecomment-492130804 目前我们提供了流式导入的接口，外层需要适配。详细情况可以见wiki This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] elfring commented on issue #211: Improve exception safety with smart pointers
elfring commented on issue #211: Improve exception safety with smart pointers URL: https://github.com/apache/incubator-doris/issues/211#issuecomment-492132819 How are the chances to [fix the class “TaskWorkerPool”](https://github.com/apache/incubator-doris/blob/a08170fd501c9a41aa0ce5a7811bbf2f64483308/be/src/agent/task_worker_pool.cpp#L91 "Update candidate")? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] imay merged pull request #1154: Add logic of cancel job
imay merged pull request #1154: Add logic of cancel job URL: https://github.com/apache/incubator-doris/pull/1154 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman opened a new pull request #1158: Fix bug that bad tablet blocking compaction of other tablets
morningman opened a new pull request #1158: Fix bug that bad tablet blocking compaction of other tablets URL: https://github.com/apache/incubator-doris/pull/1158 A bad tablet is always be chosen to do compaction, and failed again and again, which may block compaction of other tablets. Add a BE config 'min_compaction_failure_interval_ms' to avoid choosing bad tablet again at a certain interval, so that other tablets have chance to do the compaction. Also fix a bug that using avg() function on varchar column return unexpected exception. ISSUE: #363 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] yiguolei opened a new pull request #1159: Check _empty when convert old files or make snapshots
yiguolei opened a new pull request #1159: Check _empty when convert old files or make snapshots URL: https://github.com/apache/incubator-doris/pull/1159 1. check _empty when convert old files or make snapshots 2. change segment group id from -1 to 0 when convert old files. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1159: Check _empty when convert old files or make snapshots
kangpinghuang commented on a change in pull request #1159: Check _empty when
convert old files or make snapshots
URL: https://github.com/apache/incubator-doris/pull/1159#discussion_r284051285
##
File path: be/src/olap/olap_snapshot_converter.cpp
##
@@ -497,4 +502,21 @@ OLAPStatus OlapSnapshotConverter::save(const string&
file_path, const OLAPHeader
return OLAP_SUCCESS;
}
+void OlapSnapshotConverter::_modify_old_segment_group_id(RowsetMetaPB&
rowset_meta) {
+if (!rowset_meta.has_alpha_rowset_extra_meta_pb()) {
+return;
+}
+AlphaRowsetExtraMetaPB* alpha_rowset_extra_meta_pb =
rowset_meta.mutable_alpha_rowset_extra_meta_pb();
+for (auto& segment_group_pb :
alpha_rowset_extra_meta_pb->segment_groups()) {
+if (segment_group_pb.segment_group_id() == -1) {
+// check if segment groups size == 1
+if (alpha_rowset_extra_meta_pb->segment_groups().size() != 1) {
+LOG(FATAL) << "the rowset has a segment group's id == -1 but
it contains more than one segment group"
+ << " it should not happen";
+}
+
(const_cast(segment_group_pb)).set_segment_group_id(0);
Review comment:
do you rename the old file name to new file name when segment group id is -1?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] chaoyli opened a new pull request #1160: Skip tablet under compaction when choose candidate
chaoyli opened a new pull request #1160: Skip tablet under compaction when choose candidate URL: https://github.com/apache/incubator-doris/pull/1160 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] imay commented on a change in pull request #1160: Skip tablet under compaction when choose candidate
imay commented on a change in pull request #1160: Skip tablet under compaction when choose candidate URL: https://github.com/apache/incubator-doris/pull/1160#discussion_r284083165 ## File path: be/src/olap/segment_group.cpp ## @@ -568,6 +568,7 @@ OLAPStatus SegmentGroup::add_short_key(const RowCursor& short_key, const uint32_ _check_io_error(res); return res; } +_file_created=true; Review comment: ```suggestion _file_created = true; ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] chaoyli commented on a change in pull request #1158: Fix bug that bad tablet blocking compaction of other tablets
chaoyli commented on a change in pull request #1158: Fix bug that bad tablet
blocking compaction of other tablets
URL: https://github.com/apache/incubator-doris/pull/1158#discussion_r284084857
##
File path: be/src/common/config.h
##
@@ -248,6 +248,10 @@ namespace config {
CONF_Int64(cumulative_compaction_budgeted_bytes, "104857600");
CONF_Int32(cumulative_compaction_write_mbytes_per_sec, "100");
+// if compaction of a tablet failed, this tablet should not be chosen to
+// compaction until this interval passes.
+CONF_Int64(min_compaction_failure_interval_ms, "60") // 10 min
Review comment:
Unify to seconds.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] chaoyli merged pull request #1158: Fix bug that bad tablet blocking compaction of other tablets
chaoyli merged pull request #1158: Fix bug that bad tablet blocking compaction of other tablets URL: https://github.com/apache/incubator-doris/pull/1158 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] chaoyli commented on a change in pull request #1158: Fix bug that bad tablet blocking compaction of other tablets
chaoyli commented on a change in pull request #1158: Fix bug that bad tablet
blocking compaction of other tablets
URL: https://github.com/apache/incubator-doris/pull/1158#discussion_r284083155
##
File path: be/src/common/config.h
##
@@ -248,6 +248,10 @@ namespace config {
CONF_Int64(cumulative_compaction_budgeted_bytes, "104857600");
CONF_Int32(cumulative_compaction_write_mbytes_per_sec, "100");
+// if compaction of a tablet failed, this tablet should not be chosen to
+// compaction until this interval passes.
+CONF_Int64(min_compaction_failure_interval_ms, "60") // 10 min
Review comment:
cumulative compaction should have another interval?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] chaoyli merged pull request #1160: Skip tablet under compaction when choose candidate
chaoyli merged pull request #1160: Skip tablet under compaction when choose candidate URL: https://github.com/apache/incubator-doris/pull/1160 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] yiguolei opened a new pull request #1161: One thread per disk in compaction
yiguolei opened a new pull request #1161: One thread per disk in compaction URL: https://github.com/apache/incubator-doris/pull/1161 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #1161: One thread per disk in compaction
morningman commented on a change in pull request #1161: One thread per disk in
compaction
URL: https://github.com/apache/incubator-doris/pull/1161#discussion_r284097282
##
File path: be/src/olap/olap_server.cpp
##
@@ -57,23 +57,30 @@ OLAPStatus OLAPEngine::_start_bg_worker() {
[this] {
_unused_index_thread_callback(nullptr);
});
-
+
+uint32_t file_system_num = get_file_system_count();
Review comment:
rename to get_store_num() is better
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman commented on issue #1074: whether there is an QQ group or wechat group?
morningman commented on issue #1074: whether there is an QQ group or wechat group? URL: https://github.com/apache/incubator-doris/issues/1074#issuecomment-492516894 Currently Wechat is enough, because there isn't much people of our age using QQ ... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman closed issue #1074: whether there is an QQ group or wechat group?
morningman closed issue #1074: whether there is an QQ group or wechat group? URL: https://github.com/apache/incubator-doris/issues/1074 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman closed issue #581: install document issue
morningman closed issue #581: install document issue URL: https://github.com/apache/incubator-doris/issues/581 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman closed issue #639: LICENSE is missing MIT licensed Sizzle.js
morningman closed issue #639: LICENSE is missing MIT licensed Sizzle.js URL: https://github.com/apache/incubator-doris/issues/639 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] chaoyli closed issue #593: TabletMeta in RocksDB is not trashed
chaoyli closed issue #593: TabletMeta in RocksDB is not trashed URL: https://github.com/apache/incubator-doris/issues/593 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman closed issue #558: Add column to multi rollup index in one ALTER TABLE stmt
morningman closed issue #558: Add column to multi rollup index in one ALTER TABLE stmt URL: https://github.com/apache/incubator-doris/issues/558 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman closed issue #555: Meaningless saving tablet_meta leads to too many sync
morningman closed issue #555: Meaningless saving tablet_meta leads to too many sync URL: https://github.com/apache/incubator-doris/issues/555 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman commented on issue #555: Meaningless saving tablet_meta leads to too many sync
morningman commented on issue #555: Meaningless saving tablet_meta leads to too many sync URL: https://github.com/apache/incubator-doris/issues/555#issuecomment-492517479 This is already fixed This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman closed issue #661: delete data from table is not user-friendly
morningman closed issue #661: delete data from table is not user-friendly URL: https://github.com/apache/incubator-doris/issues/661 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman closed issue #554: ERROR 1064 (HY000): convert_tzcan't support
morningman closed issue #554: ERROR 1064 (HY000): convert_tzcan't support URL: https://github.com/apache/incubator-doris/issues/554 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #1161: One thread per disk in compaction
morningman merged pull request #1161: One thread per disk in compaction URL: https://github.com/apache/incubator-doris/pull/1161 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] imay opened a new pull request #1162: Add support column reference in LOAD statement
imay opened a new pull request #1162: Add support column reference in LOAD statement URL: https://github.com/apache/incubator-doris/pull/1162 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #1162: Add support column reference in LOAD statement
EmmyMiao87 commented on a change in pull request #1162: Add support column reference in LOAD statement URL: https://github.com/apache/incubator-doris/pull/1162#discussion_r284153537 ## File path: fe/src/main/cup/sql_parser.cup ## @@ -198,7 +198,7 @@ terminal String KW_ADD, KW_ADMIN, KW_AFTER, KW_AGGREGATE, KW_ALL, KW_ALTER, KW_A KW_DATA, KW_DATABASE, KW_DATABASES, KW_DATE, KW_DATETIME, KW_DECIMAL, KW_DECOMMISSION, KW_DEFAULT, KW_DESC, KW_DESCRIBE, KW_DELETE, KW_DISTINCT, KW_DISTINCTPC, KW_DISTINCTPCSA, KW_DISTRIBUTED, KW_DISTRIBUTION, KW_BUCKETS, KW_DIV, KW_DOUBLE, KW_DROP, KW_DROPP, KW_DUPLICATE, KW_ELSE, KW_END, KW_ENGINE, KW_ENGINES, KW_ENTER, KW_ERRORS, KW_EVENTS, KW_EXISTS, KW_EXPORT, KW_EXTERNAL, KW_EXTRACT, -KW_FALSE, KW_FOLLOWER, KW_FOLLOWING, KW_FREE, KW_FROM, KW_FIRST, KW_FLOAT, KW_FOR, KW_FRONTEND, KW_FRONTENDS, KW_FULL, KW_FUNCTION, +KW_FALSE, KW_FOLLOWER, KW_FOLLOWING, KW_FREE, KW_FROM, KW_FIRST, KW_FLOAT, KW_FOR, KW_FORMAT, KW_FRONTEND, KW_FRONTENDS, KW_FULL, KW_FUNCTION, Review comment: you need to add the kw_format into keyword which we allow for identifiers. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #1162: Add support column reference in LOAD statement
EmmyMiao87 commented on a change in pull request #1162: Add support column
reference in LOAD statement
URL: https://github.com/apache/incubator-doris/pull/1162#discussion_r284156312
##
File path: fe/src/main/java/org/apache/doris/analysis/DataDescription.java
##
@@ -216,6 +244,12 @@ private void checkColumnMapping() throws
AnalysisException {
parsedExprMap.put(column, child1);
+if (!(child1 instanceof FunctionCallExpr)) {
+// only just for pass later check
+columnToFunction.put(column, Pair.create("__slot_ref",
Lists.newArrayList()));
Review comment:
```suggestion
columnToFunction.put(column, Pair.create("slot_ref",
Lists.newArrayList()));
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #1162: Add support column reference in LOAD statement
EmmyMiao87 commented on a change in pull request #1162: Add support column
reference in LOAD statement
URL: https://github.com/apache/incubator-doris/pull/1162#discussion_r284158524
##
File path: fe/src/main/java/org/apache/doris/load/BrokerFileGroup.java
##
@@ -129,10 +131,13 @@ public void parse(Database db) throws DdlException {
if (lineDelimiter == null) {
lineDelimiter = "\n";
}
+
+fileFormat = dataDescription.getFileFormat();
+
isNegative = dataDescription.isNegative();
// FilePath
-filePathes = dataDescription.getFilePathes();
+filePaths = dataDescription.getFilePathes();
Review comment:
```suggestion
filePaths = dataDescription.getFilePaths();
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman opened a new pull request #1163: Add some logs for compaction process
morningman opened a new pull request #1163: Add some logs for compaction process URL: https://github.com/apache/incubator-doris/pull/1163 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman closed pull request #1163: Add some logs for compaction process
morningman closed pull request #1163: Add some logs for compaction process URL: https://github.com/apache/incubator-doris/pull/1163 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman opened a new pull request #1163: Add some logs for compaction process
morningman opened a new pull request #1163: Add some logs for compaction process URL: https://github.com/apache/incubator-doris/pull/1163 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman opened a new pull request #1164: Modify dockerfile
morningman opened a new pull request #1164: Modify dockerfile URL: https://github.com/apache/incubator-doris/pull/1164 New docker image includes new thirdparties This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] imay merged pull request #1164: Modify dockerfile
imay merged pull request #1164: Modify dockerfile URL: https://github.com/apache/incubator-doris/pull/1164 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] imay commented on a change in pull request #1162: Add support column reference in LOAD statement
imay commented on a change in pull request #1162: Add support column reference
in LOAD statement
URL: https://github.com/apache/incubator-doris/pull/1162#discussion_r284191766
##
File path: fe/src/main/java/org/apache/doris/load/BrokerFileGroup.java
##
@@ -129,10 +131,13 @@ public void parse(Database db) throws DdlException {
if (lineDelimiter == null) {
lineDelimiter = "\n";
}
+
+fileFormat = dataDescription.getFileFormat();
+
isNegative = dataDescription.isNegative();
// FilePath
-filePathes = dataDescription.getFilePathes();
+filePaths = dataDescription.getFilePathes();
Review comment:
OK
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] imay commented on a change in pull request #1162: Add support column reference in LOAD statement
imay commented on a change in pull request #1162: Add support column reference in LOAD statement URL: https://github.com/apache/incubator-doris/pull/1162#discussion_r284191640 ## File path: fe/src/main/cup/sql_parser.cup ## @@ -198,7 +198,7 @@ terminal String KW_ADD, KW_ADMIN, KW_AFTER, KW_AGGREGATE, KW_ALL, KW_ALTER, KW_A KW_DATA, KW_DATABASE, KW_DATABASES, KW_DATE, KW_DATETIME, KW_DECIMAL, KW_DECOMMISSION, KW_DEFAULT, KW_DESC, KW_DESCRIBE, KW_DELETE, KW_DISTINCT, KW_DISTINCTPC, KW_DISTINCTPCSA, KW_DISTRIBUTED, KW_DISTRIBUTION, KW_BUCKETS, KW_DIV, KW_DOUBLE, KW_DROP, KW_DROPP, KW_DUPLICATE, KW_ELSE, KW_END, KW_ENGINE, KW_ENGINES, KW_ENTER, KW_ERRORS, KW_EVENTS, KW_EXISTS, KW_EXPORT, KW_EXTERNAL, KW_EXTRACT, -KW_FALSE, KW_FOLLOWER, KW_FOLLOWING, KW_FREE, KW_FROM, KW_FIRST, KW_FLOAT, KW_FOR, KW_FRONTEND, KW_FRONTENDS, KW_FULL, KW_FUNCTION, +KW_FALSE, KW_FOLLOWER, KW_FOLLOWING, KW_FREE, KW_FROM, KW_FIRST, KW_FLOAT, KW_FOR, KW_FORMAT, KW_FRONTEND, KW_FRONTENDS, KW_FULL, KW_FUNCTION, Review comment: Yes, you are right This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #1163: Add some logs for compaction process
morningman merged pull request #1163: Add some logs for compaction process URL: https://github.com/apache/incubator-doris/pull/1163 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] imay merged pull request #1162: Add support column reference in LOAD statement
imay merged pull request #1162: Add support column reference in LOAD statement URL: https://github.com/apache/incubator-doris/pull/1162 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman opened a new issue #1165: Routine load task thread block in BE
morningman opened a new issue #1165: Routine load task thread block in BE URL: https://github.com/apache/incubator-doris/issues/1165 **Describe the bug** Routine load task thread block, and following tasks can not be scheduled. **How to resolve** Data consumer group should wait all data consumers to be finished before return This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman opened a new pull request #1166: Fix bug that routine load task may be blocked due to premature deconstruction
morningman opened a new pull request #1166: Fix bug that routine load task may be blocked due to premature deconstruction URL: https://github.com/apache/incubator-doris/pull/1166 ISSUE: #1165 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #1166: Fix bug that routine load task may be blocked due to premature deconstruction
morningman commented on a change in pull request #1166: Fix bug that routine
load task may be blocked due to premature deconstruction
URL: https://github.com/apache/incubator-doris/pull/1166#discussion_r284560064
##
File path: be/src/runtime/routine_load/routine_load_task_executor.cpp
##
@@ -41,6 +41,11 @@ Status RoutineLoadTaskExecutor::submit_task(const
TRoutineLoadTask& task) {
return Status::OK;
}
+if (_thread_pool.get_queue_size() > 100) {
+LOG(INFO) << "too much task in queue: " <<
_thread_pool.get_queue_size() << ", reject task: " << UniqueId(task.id);
Review comment:
```suggestion
LOG(INFO) << "too many tasks in queue: " <<
_thread_pool.get_queue_size() << ", reject task: " << UniqueId(task.id);
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #1166: Fix bug that routine load task may be blocked due to premature deconstruction
morningman merged pull request #1166: Fix bug that routine load task may be blocked due to premature deconstruction URL: https://github.com/apache/incubator-doris/pull/1166 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] kangpinghuang opened a new pull request #1167: Fix position seek bug for varchar short key
kangpinghuang opened a new pull request #1167: Fix position seek bug for varchar short key URL: https://github.com/apache/incubator-doris/pull/1167 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] gaodayue opened a new issue #1168: The download link for doris-incubating-thirdparty-20190414 is broken
gaodayue opened a new issue #1168: The download link for
doris-incubating-thirdparty-20190414 is broken
URL: https://github.com/apache/incubator-doris/issues/1168
When I am trying to download
https://doris-incubating-repo.bj.bcebos.com/doris-incubating-thirdparty-20190414.tar.gz
in
[Doris-Install](https://github.com/apache/incubator-doris/wiki/Doris-Install),
it says
```
{
"code": "NoSuchKey",
"message": "The specified key does not exist.",
"requestId": "cb2fcf45-f5d0-429c-a0cd-9e72b635c25c"
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] kangpinghuang commented on issue #1169: invalid position seek when key is varchar type
kangpinghuang commented on issue #1169: invalid position seek when key is varchar type URL: https://github.com/apache/incubator-doris/issues/1169#issuecomment-492991820 Fixed by #1167 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] kangpinghuang opened a new issue #1169: invalid position seek when key is varchar type
kangpinghuang opened a new issue #1169: invalid position seek when key is varchar type URL: https://github.com/apache/incubator-doris/issues/1169 When tablet's short key type is varchar, the Segment Position seek is invalid. There is a bug in Field::index_cmp for key length is less than compare_size(eg: empty string is 0), the compare range is out of range. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] kangpinghuang commented on issue #1157: Use inexistent key (in prefix-index) to filter rows will cost too much time to return.
kangpinghuang commented on issue #1157: Use inexistent key (in prefix-index) to filter rows will cost too much time to return. URL: https://github.com/apache/incubator-doris/issues/1157#issuecomment-492991757 there two reasons for this problem: 1. there is data skew in your table, The data size and row size of one tablet is 10x larger than other. and I find out that the skewed data is the data with empty cuid. And the slow cuid is in this tablet 2. there is a bug when seek position in the data with the short key of varchar type. This is fixed by pr #1167 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] kangpinghuang closed issue #1169: invalid position seek when key is varchar type
kangpinghuang closed issue #1169: invalid position seek when key is varchar type URL: https://github.com/apache/incubator-doris/issues/1169 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] imay merged pull request #1167: Fix position seek bug for varchar short key
imay merged pull request #1167: Fix position seek bug for varchar short key URL: https://github.com/apache/incubator-doris/pull/1167 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
