[commons-daemon] more on PR238 procrun fixes

[jean-frederic clere]

Hi,

I am rework my PR, added tests and fixes for procrun, from the moment 
the tests are in src/native/windows/apps/prunsrv/test.bat and the java 
part in src/test/java/org/apache/commons/daemon/ProcrunDaemon.java.


Testing a service on windows is a bit complex we need to 
install/start/test/stop/delete the service creating a new process and 
waiting doing that in java would make in more complex.


I have 2 questions:
- It is OK to have the java part in src/test/java and the script part in 
src/test/scripts.

- Do we want a java wrapper for the tests?

Any comments? Here or on the 
https://github.com/apache/commons-daemon/pull/238 ;-)


--
Cheers

Jean-Frederic


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

lang - Syntax error in DiffBuilder documentation

[Ceria Mitchell]

Hello,

  Thank you for a great product. I just wanted to notify you that the code
example shown in the DiffBuilder documentation (
https://commons.apache.org/proper/commons-lang/apidocs/org/apache/commons/lang3/builder/DiffBuilder.html)
for the DiffBuilder deprecation is syntactically incorrect.  It should be
corrected to  (the change is shown in bold)

   public DiffResult diff(Person obj) {
 // No need for null check, as NullPointerException correct if obj is null
 return new *DiffBuilder.Builder()*
 .setLeft(this)
 .setRight(obj)
 .setStyle(ToStringStyle.SHORT_PREFIX_STYLE))
 .build()
   .append("name", this.name, obj.name)
   .append("age", this.age, obj.age)
   .append("smoker", this.smoker, obj.smoker)
   .build();
   }