Re: [VOTE] Release Apache Commons Compress 1.26.2 based on RC1

[Rob Tompkins]

+1

> On May 18, 2024, at 12:56 PM, Gary Gregory  wrote:
> 
> We have fixed a few bugs since Apache Commons Compress 1.26.1 was
> released, so I would like to release Apache Commons Compress 1.26.2.
> 
> Apache Commons Compress 1.26.2 RC1 is available for review here:
>https://dist.apache.org/repos/dist/dev/commons/compress/1.26.2-RC1
> (svn revision 69274)
> 
> The Git tag commons-compress-1.26.2-RC1 commit for this RC is
> 95727006cac0892c654951c4e7f1db142462f22a which you can browse here:
>
> https://gitbox.apache.org/repos/asf?p=commons-compress.git;a=commit;h=95727006cac0892c654951c4e7f1db142462f22a
> You may checkout this tag using:
>git clone https://gitbox.apache.org/repos/asf/commons-compress.git
> --branch commons-compress-1.26.2-RC1 commons-compress-1.26.2-RC1
> 
> Maven artifacts are here:
>
> https://repository.apache.org/content/repositories/orgapachecommons-1731/org/apache/commons/commons-compress/1.26.2/
> 
> These are the artifacts and their hashes:
> 
> #Release SHA-512s
> #Sat May 18 15:37:35 UTC 2024
> Apache\ Commons\
> Compress-1.26.2.spdx.rdf.xml=ffdf07261043faff9909ae884a516ace28980157cc71c8e336b36d1cb873fda20ebe61159ff38605fe8b3d30d4a11d18cfafaa8d15220ea95e4094f1498a67cc
> commons-compress-1.26.2-bin.tar.gz=216e931578c51d2ebf9d62e3f7b0b9c38efd1d1fa670d44bfa05fefa164740d56f3c42da97846a8692240217d0c6ed786b341dc91278a7ffdd5d96fc0a8e0baf
> commons-compress-1.26.2-bin.zip=0d4d0e956c9a541a07351ce80c80f2c558e66bf9eb27942a9b7103fbce3167289e6bb781fbd5408a9437d54d5b8da51cb56e73efe62986b98f64adeaba1ee150
> commons-compress-1.26.2-bom.json=4015d88bf4b8b533ed8794d8affa4a44b01332232c84df19f821b9461ca084fbeae663dda53f2a9f1a976bb3c1235e5ce3bdf7ba6855e21768fe6c0ecebdc806
> commons-compress-1.26.2-bom.xml=443b8db7d307f546df3543ee713f6b90de4be124bf90d835838c56eaaadfd84fcfab4714a084d254e8cf2862c55234178db4bfcf33e30472f9b49b67d452f1fe
> commons-compress-1.26.2-javadoc.jar=a040ead1b81c8dfd90e6c6447493deaae2826e0994ed156aee54be3fdc5e479181f319e31342a6e172d66226936f89f427a6afd90bd5ff6765123cf34d1a51af
> commons-compress-1.26.2-sources.jar=14ce48f50ffb4e7699c5d5fb8d3d57f61bcad42a17086fba6bc71eb5063e4c3dde6aaadb87b6d04897d6a939bce469f1ebedbfc49c87bff1cb98c0b277d41431
> commons-compress-1.26.2-src.tar.gz=cdbc34f42a05534d56315d5765650c0dd58103e081dcce4c2bed1386b6047beab25139d1dff28788b3674a05163cc44d6b7e764eb2105cb1fea40c7bfd1be653
> commons-compress-1.26.2-src.zip=8787caf8e0a306dcfbea9e89a2833243616d5ab194aa094a6b4761de63ddd77d87d151682d271da4477d338feb5a97231ee7ca533c4f008048f66354f712d369
> commons-compress-1.26.2-test-sources.jar=a92cbcbb97eeb5a2474b53e88a132d02716fc88e693ea2052788ad613746d33340af1e43966bcb39d26935cd3a9e300ff13125575d46d297ece40bef50379acf
> commons-compress-1.26.2-tests.jar=e8a0afb84f274ce55c6a48722f5a835c8274c9fc5ea115e02dd4ffc96f9a86399f33ebeaa2f533913457bc498a50f508b250bff9a9d7e27f138cacebac31334f
> 
> I have tested this with 'mvn' and 'mvn -V -Prelease -Ptest-deploy -P
> jacoco -P japicmp clean package site deploy' using:
> 
> openjdk version "17.0.11" 2024-04-16
> OpenJDK Runtime Environment Homebrew (build 17.0.11+0)
> OpenJDK 64-Bit Server VM Homebrew (build 17.0.11+0, mixed mode, sharing)
> 
> Apache Maven 3.9.6 (bc0240f3c744dd6b6ec2920b3cd08dcc295161ae)
> Maven home: /usr/local/Cellar/maven/3.9.6/libexec
> Java version: 17.0.11, vendor: Homebrew, runtime:
> /usr/local/Cellar/openjdk@17/17.0.11/libexec/openjdk.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "14.4.1", arch: "x86_64", family: "mac"
> 
> Darwin  23.4.0 Darwin Kernel Version 23.4.0: Fri Mar 15 00:11:05
> PDT 2024; root:xnu-10063.101.17~1/RELEASE_X86_64 x86_64
> 
> Details of changes since 1.26.1 are in the release notes:
>
> https://dist.apache.org/repos/dist/dev/commons/compress/1.26.2-RC1/RELEASE-NOTES.txt
>
> https://dist.apache.org/repos/dist/dev/commons/compress/1.26.2-RC1/site/changes-report.html
> 
> Site:
>
> https://dist.apache.org/repos/dist/dev/commons/compress/1.26.2-RC1/site/index.html
>(note some *relative* links are broken and the 1.26.2 directories
> are not yet created - these will be OK once the site is deployed.)
> 
> JApiCmp Report (compared to 1.26.1):
>
> https://dist.apache.org/repos/dist/dev/commons/compress/1.26.2-RC1/site/japicmp.html
> 
> RAT Report:
>
> https://dist.apache.org/repos/dist/dev/commons/compress/1.26.2-RC1/site/rat-report.html
> 
> KEYS:
>https://downloads.apache.org/commons/KEYS
> 
> Please review the release candidate and vote.
> This vote will close no sooner than 72 hours from now.
> 
>  [ ] +1 Release these artifacts
>  [ ] +0 OK, but...
>  [ ] -0 OK, but really should fix...
>  [ ] -1 I oppose this release because...
> 
> Thank you,
> 
> Gary Gregory,
> Release Manager (using key 86fdc7e2a11262cb)
> 
> For following is intended as a helper and refresher for reviewers.
> 
> Validating a release candidate
> ==
> 
> These guidelines are NOT comple

Re: [VOTE] Release Apache Commons Compress 1.26.2 based on RC1

[Henri Biestro]

[ +1 ]

Site looks good, javadoc looks good, reports Ok (nit jacoco missing).

Tested using:
mvn clean install site
On:
Apache Maven 3.8.6 (84538c9988a25aec085021c365c560670ad80f63)
Maven home: /Users/hbiestro/Java/apache-maven-3.8.6
Java version: 17.0.8, vendor: Oracle Corporation, runtime: 
/Library/Java/JavaVirtualMachines/jdk-17.jdk/Contents/Home
Default locale: en_US, platform encoding: UTF-8
OS name: "mac os x", version: "14.5", arch: "aarch64", family: "Mac"



-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [VOTE] Release Apache Commons CLI 1.8.0 based on RC2

[Henri Biestro]

[ +1 ]

Site, Javadoc, reports look good.
Nit: site refers to version 1.7.0, so are the release notes and the JIRA report 
is not helpful.

Using:
mvn clean install site
On:
mvn -version
Apache Maven 3.8.6 (84538c9988a25aec085021c365c560670ad80f63)
Maven home: /Users/hbiestro/Java/apache-maven-3.8.6
Java version: 17.0.8, vendor: Oracle Corporation, runtime: 
/Library/Java/JavaVirtualMachines/jdk-17.jdk/Contents/Home
Default locale: en_US, platform encoding: UTF-8
OS name: "mac os x", version: "14.5", arch: "aarch64", family: "mac"

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [VOTE] Release Apache Commons CLI 1.8.0 based on RC2

[Emmanuel Bourg]

-0

The javadoc was built with Java 17 and is less usable than the javadoc 
generated by Java 8. I recommend building the next release with Java 8 
instead.


Emmanuel Bourg


Le 19/05/2024 à 16:55, Gary Gregory a écrit :

We have fixed a few bugs and added enhancements since Apache Commons
CLI 1.7.0 was released, so I would like to release Apache Commons CLI
1.8.0.

Apache Commons CLI 1.8.0 RC2 is available for review here:
 https://dist.apache.org/repos/dist/dev/commons/cli/1.8.0-RC2 (svn
revision 69280)

The Git tag commons-cli-1.8.0-RC2 commit for this RC is
91369572408eff424ff5cec2d46dd9667ceba1b3 which you can browse here:
 
https://gitbox.apache.org/repos/asf?p=commons-cli.git;a=commit;h=91369572408eff424ff5cec2d46dd9667ceba1b3
You may checkout this tag using:
 git clone https://gitbox.apache.org/repos/asf/commons-cli.git
--branch commons-cli-1.8.0-RC2 commons-cli-1.8.0-RC2

Maven artifacts are here:
 
https://repository.apache.org/content/repositories/orgapachecommons-1732/commons-cli/commons-cli/1.8.0/

These are the artifacts and their hashes:

#Release SHA-512s
#Sun May 19 14:50:37 UTC 2024
commons-cli-1.8.0-bin.tar.gz=9e8072c9d1efc8f8d5ecb65d82a02a8e573837ebf6e699b9675db7769c21fadc7157e7691e2a8dfb91267ccdac2671f64403631a394dc094a8481b8d5ffd190f
commons-cli-1.8.0-bin.zip=281019ef7dbb94702f5b7e5bcd0ed8947bcc55a62f87c4a93c97e34d95751352ccb191a368d8ff59ba389f342b2a7335effee0cf60fa4bbf2428f90ec648e530
commons-cli-1.8.0-bom.json=2d9b8cb5333bf31a48fdb1037dec84c48434c619a4fe421529df7386f2ede67b76c61d2c490bbb5b6af301f92262a95fb3dff30b91468bb4b6ce555f2f1e1026
commons-cli-1.8.0-bom.xml=00f5c34db21083b3f2677a931d9b2e10de60c40fa3f58fc2a01ea34e4b5227b800d58231df9194f2a39d2c40e062b859bce5399f93d2188ca230be81bfb93106
commons-cli-1.8.0-javadoc.jar=ec49e3a71f26ac91b5ce16b6390d82d605cc78843fb93f6bef56484a306bcb2230d173569adfb0b28b3b222396313ecec4b852fd33745000d8712b55b8ad6dbf
commons-cli-1.8.0-sources.jar=f2740e9695d43cf56f111d47a7fb53ec99044eb69b259921096be0b57c963a19f4282579acf58052d5724cb6273028fe0457309b0b21c59f4039a0960f09c985
commons-cli-1.8.0-src.tar.gz=588d89d86deb60ac0e182bd4b574e30aac4000dde9da13ee1080844a4982d45f4a4d29fc3ee54c904c74ed6bf14dbb3bffdcbad0eab86ddde8418811f2efb5c2
commons-cli-1.8.0-src.zip=48513dc3fdf7deae5bfc94c4ef1975659a851a12432f3158ff764fd30ce03bdefeba0e255829e1c4d84f5a6185dbaabec1570917cf73360f395ab6b5b54f9613
commons-cli-1.8.0-test-sources.jar=a59ae8590b6ebf4a25fe01e18fa55d6b5769b425d6363943671ae32271a17bd3ed226e3e35f0bcc3fafe0aca06a726f2211049cbad1fbb39d3cda008b894c689
commons-cli-1.8.0-tests.jar=3a85ff142f3ea9ebf5d6d9c5efe407754803424e29f07e18ac8429f3a7c1dd706f518fee669f2108414d7120f8e5fdd2ee464d2096766beca7ec9ce3b80074b4
commons-cli_commons-cli-1.8.0.spdx.json=1df478ac114f20e50fa7717a12d8838c03bd104f66b277a59b0e640a992e0c25894fc67ee7fde5927b3c5dc1ce6170bcc2010ef55abaec6484a6eae82c60d652

I have tested this with 'mvn' and 'mvn -V -Prelease -Ptest-deploy -P
jacoco -P japicmp clean package site deploy' using:

openjdk version "17.0.11" 2024-04-16
OpenJDK Runtime Environment Homebrew (build 17.0.11+0)
OpenJDK 64-Bit Server VM Homebrew (build 17.0.11+0, mixed mode, sharing)

Apache Maven 3.9.6 (bc0240f3c744dd6b6ec2920b3cd08dcc295161ae)
Maven home: /usr/local/Cellar/maven/3.9.6/libexec
Java version: 17.0.11, vendor: Homebrew, runtime:
/usr/local/Cellar/openjdk@17/17.0.11/libexec/openjdk.jdk/Contents/Home
Default locale: en_US, platform encoding: UTF-8
OS name: "mac os x", version: "14.5", arch: "x86_64", family: "mac"

Darwin  23.5.0 Darwin Kernel Version 23.5.0: Wed May  1 20:09:52
PDT 2024; root:xnu-10063.121.3~5/RELEASE_X86_64 x86_64

Details of changes since 1.7.0 are in the release notes:
 
https://dist.apache.org/repos/dist/dev/commons/cli/1.8.0-RC2/RELEASE-NOTES.txt
 
https://dist.apache.org/repos/dist/dev/commons/cli/1.8.0-RC2/site/changes-report.html

Site:
 
https://dist.apache.org/repos/dist/dev/commons/cli/1.8.0-RC2/site/index.html
 (note some *relative* links are broken and the 1.8.0 directories
are not yet created - these will be OK once the site is deployed.)

JApiCmp Report (compared to 1.7.0):
 
https://dist.apache.org/repos/dist/dev/commons/cli/1.8.0-RC2/site/japicmp.html

RAT Report:
 
https://dist.apache.org/repos/dist/dev/commons/cli/1.8.0-RC2/site/rat-report.html

KEYS:
   https://downloads.apache.org/commons/KEYS

Please review the release candidate and vote.
This vote will close no sooner than 72 hours from now.

   [ ] +1 Release these artifacts
   [ ] +0 OK, but...
   [ ] -0 OK, but really should fix...
   [ ] -1 I oppose this release because...

Thank you,

Gary Gregory,
Release Manager (using key 86fdc7e2a11262cb)

For following is intended as a helper and refresher for reviewers.

Validating a release candidate
==

These guidelines are NOT complete.

Requirements: Git, Java, Maven.

You can validate a release from a release candidate (RC) tag as follows.

1a) Clone and checkout the RC t

Re: [VOTE] Release Apache Commons CLI 1.8.0 based on RC2

[Gary Gregory]

I disagree, I think the search box is a great feature.

Gary

On Thu, May 23, 2024, 11:26 AM Emmanuel Bourg  wrote:

> -0
>
> The javadoc was built with Java 17 and is less usable than the javadoc
> generated by Java 8. I recommend building the next release with Java 8
> instead.
>
> Emmanuel Bourg
>
>
> Le 19/05/2024 à 16:55, Gary Gregory a écrit :
> > We have fixed a few bugs and added enhancements since Apache Commons
> > CLI 1.7.0 was released, so I would like to release Apache Commons CLI
> > 1.8.0.
> >
> > Apache Commons CLI 1.8.0 RC2 is available for review here:
> >  https://dist.apache.org/repos/dist/dev/commons/cli/1.8.0-RC2 (svn
> > revision 69280)
> >
> > The Git tag commons-cli-1.8.0-RC2 commit for this RC is
> > 91369572408eff424ff5cec2d46dd9667ceba1b3 which you can browse here:
> >
> https://gitbox.apache.org/repos/asf?p=commons-cli.git;a=commit;h=91369572408eff424ff5cec2d46dd9667ceba1b3
> > You may checkout this tag using:
> >  git clone https://gitbox.apache.org/repos/asf/commons-cli.git
> > --branch commons-cli-1.8.0-RC2 commons-cli-1.8.0-RC2
> >
> > Maven artifacts are here:
> >
> https://repository.apache.org/content/repositories/orgapachecommons-1732/commons-cli/commons-cli/1.8.0/
> >
> > These are the artifacts and their hashes:
> >
> > #Release SHA-512s
> > #Sun May 19 14:50:37 UTC 2024
> >
> commons-cli-1.8.0-bin.tar.gz=9e8072c9d1efc8f8d5ecb65d82a02a8e573837ebf6e699b9675db7769c21fadc7157e7691e2a8dfb91267ccdac2671f64403631a394dc094a8481b8d5ffd190f
> >
> commons-cli-1.8.0-bin.zip=281019ef7dbb94702f5b7e5bcd0ed8947bcc55a62f87c4a93c97e34d95751352ccb191a368d8ff59ba389f342b2a7335effee0cf60fa4bbf2428f90ec648e530
> >
> commons-cli-1.8.0-bom.json=2d9b8cb5333bf31a48fdb1037dec84c48434c619a4fe421529df7386f2ede67b76c61d2c490bbb5b6af301f92262a95fb3dff30b91468bb4b6ce555f2f1e1026
> >
> commons-cli-1.8.0-bom.xml=00f5c34db21083b3f2677a931d9b2e10de60c40fa3f58fc2a01ea34e4b5227b800d58231df9194f2a39d2c40e062b859bce5399f93d2188ca230be81bfb93106
> >
> commons-cli-1.8.0-javadoc.jar=ec49e3a71f26ac91b5ce16b6390d82d605cc78843fb93f6bef56484a306bcb2230d173569adfb0b28b3b222396313ecec4b852fd33745000d8712b55b8ad6dbf
> >
> commons-cli-1.8.0-sources.jar=f2740e9695d43cf56f111d47a7fb53ec99044eb69b259921096be0b57c963a19f4282579acf58052d5724cb6273028fe0457309b0b21c59f4039a0960f09c985
> >
> commons-cli-1.8.0-src.tar.gz=588d89d86deb60ac0e182bd4b574e30aac4000dde9da13ee1080844a4982d45f4a4d29fc3ee54c904c74ed6bf14dbb3bffdcbad0eab86ddde8418811f2efb5c2
> >
> commons-cli-1.8.0-src.zip=48513dc3fdf7deae5bfc94c4ef1975659a851a12432f3158ff764fd30ce03bdefeba0e255829e1c4d84f5a6185dbaabec1570917cf73360f395ab6b5b54f9613
> >
> commons-cli-1.8.0-test-sources.jar=a59ae8590b6ebf4a25fe01e18fa55d6b5769b425d6363943671ae32271a17bd3ed226e3e35f0bcc3fafe0aca06a726f2211049cbad1fbb39d3cda008b894c689
> >
> commons-cli-1.8.0-tests.jar=3a85ff142f3ea9ebf5d6d9c5efe407754803424e29f07e18ac8429f3a7c1dd706f518fee669f2108414d7120f8e5fdd2ee464d2096766beca7ec9ce3b80074b4
> >
> commons-cli_commons-cli-1.8.0.spdx.json=1df478ac114f20e50fa7717a12d8838c03bd104f66b277a59b0e640a992e0c25894fc67ee7fde5927b3c5dc1ce6170bcc2010ef55abaec6484a6eae82c60d652
> >
> > I have tested this with 'mvn' and 'mvn -V -Prelease -Ptest-deploy -P
> > jacoco -P japicmp clean package site deploy' using:
> >
> > openjdk version "17.0.11" 2024-04-16
> > OpenJDK Runtime Environment Homebrew (build 17.0.11+0)
> > OpenJDK 64-Bit Server VM Homebrew (build 17.0.11+0, mixed mode, sharing)
> >
> > Apache Maven 3.9.6 (bc0240f3c744dd6b6ec2920b3cd08dcc295161ae)
> > Maven home: /usr/local/Cellar/maven/3.9.6/libexec
> > Java version: 17.0.11, vendor: Homebrew, runtime:
> > /usr/local/Cellar/openjdk@17/17.0.11/libexec/openjdk.jdk/Contents/Home
> > Default locale: en_US, platform encoding: UTF-8
> > OS name: "mac os x", version: "14.5", arch: "x86_64", family: "mac"
> >
> > Darwin  23.5.0 Darwin Kernel Version 23.5.0: Wed May  1 20:09:52
> > PDT 2024; root:xnu-10063.121.3~5/RELEASE_X86_64 x86_64
> >
> > Details of changes since 1.7.0 are in the release notes:
> >
> https://dist.apache.org/repos/dist/dev/commons/cli/1.8.0-RC2/RELEASE-NOTES.txt
> >
> https://dist.apache.org/repos/dist/dev/commons/cli/1.8.0-RC2/site/changes-report.html
> >
> > Site:
> >
> https://dist.apache.org/repos/dist/dev/commons/cli/1.8.0-RC2/site/index.html
> >  (note some *relative* links are broken and the 1.8.0 directories
> > are not yet created - these will be OK once the site is deployed.)
> >
> > JApiCmp Report (compared to 1.7.0):
> >
> https://dist.apache.org/repos/dist/dev/commons/cli/1.8.0-RC2/site/japicmp.html
> >
> > RAT Report:
> >
> https://dist.apache.org/repos/dist/dev/commons/cli/1.8.0-RC2/site/rat-report.html
> >
> > KEYS:
> >https://downloads.apache.org/commons/KEYS
> >
> > Please review the release candidate and vote.
> > This vote will close no sooner than 72 hours from now.
> >
> >[ ] +1 Release these artifacts
> >[ ] +0 OK, but...
> >[ ] -0 OK, but really should fix...
> >[ ] -1 I

[VFS] Duplicate Listeners

[Bernd Eckenfels]

Hello,

I am dealing with a heapdump of VFS where I see a lot of WeakRefFileListener
and all of them have a empty WeakRef to no listener. While I think I found the
reason for that and fixed it on a dependent project, it still does not clean
up correctly. I think the reason is that it does not store the WeakRefListener
directly, but it stores a WeakReflistener of it. This will then immediatelly
result in a unreferencedreferent - so it never works (it surely does fix the 
leak :)

Gary, while cleaning up lint errors in fba04f3e5 you made a change, but I asume 
it was
only a mechanical replacement - or did you actually checkedif it is correct?


https://github.com/apache/commons-vfs/blob/dc9ad7677a020b2d4c571f7dcc858cdbae2bb538/commons-vfs2/src/main/java/org/apache/commons/vfs2/util/WeakRefFileListener.java#L41

Cleaned up code:
public static void installListener(final FileObject file, final FileListener 
listener) {
file.getFileSystem().addListener(file, new WeakRefFileListener(file, new 
WeakRefFileListener(file, listener)));
}

initial version:
final WeakRefFileListener weakListener = new WeakRefFileListener(file, 
listener);
file.getFileSystem().addListener(file, new WeakRefFileListener(file, 
weakListener));


but I think it should be only a single wrapper:

public static void installListener(final FileObject file, final FileListener 
listener) {
file.getFileSystem().addListener(file, new WeakRefFileListener(file, 
listener));
}

There is a mention of VFS-143, but itintroduced the whole code with the double 
indirection
and it does not explain why it is needed.

What do you think, should we change it? 

I also wonder why no tests sees it (in factI try to add a test to reproduce 
what I think
shows its not working).

Gruss
Bernd

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [VFS] Duplicate Listeners

[Gary D. Gregory]

Hi Bernd,

Thank you for researching this issue and presenting your findings.

In 2.9.0, we had (as you found):

public static void installListener(final FileObject file, final 
FileListener listener) {
final WeakRefFileListener weakListener = new WeakRefFileListener(file, 
listener);

file.getFileSystem().addListener(file, new WeakRefFileListener(file, 
weakListener));
}

Which already contains the "WeakRefFileListener in a WeakRefFileListener".

Unless I am missing something, the change in git master now just in inlines the 
local variable.

Are we saying that:
(1) We should not have a "WeakRefFileListener in a WeakRefFileListener"
(2) This problem already existed in 2.9.0.
(3) This problem existed when the class was introduced in 2.2 (despite the 2.0 
Javadoc since tag).

Let me know how you see it.

I can't say if your proposed change has any unintended side-effects; it should 
be accompanied with some kind of test, at the very least to avoid a regression.

TY!
Gary


On 2024/05/23 17:08:00 Bernd Eckenfels wrote:
> Hello,
> 
> I am dealing with a heapdump of VFS where I see a lot of WeakRefFileListener
> and all of them have a empty WeakRef to no listener. While I think I found the
> reason for that and fixed it on a dependent project, it still does not clean
> up correctly. I think the reason is that it does not store the WeakRefListener
> directly, but it stores a WeakReflistener of it. This will then immediatelly
> result in a unreferencedreferent - so it never works (it surely does fix the 
> leak :)
> 
> Gary, while cleaning up lint errors in fba04f3e5 you made a change, but I 
> asume it was
> only a mechanical replacement - or did you actually checkedif it is correct?
> 
> 
> https://github.com/apache/commons-vfs/blob/dc9ad7677a020b2d4c571f7dcc858cdbae2bb538/commons-vfs2/src/main/java/org/apache/commons/vfs2/util/WeakRefFileListener.java#L41
> 
> Cleaned up code:
> public static void installListener(final FileObject file, final FileListener 
> listener) {
> file.getFileSystem().addListener(file, new WeakRefFileListener(file, new 
> WeakRefFileListener(file, listener)));
> }
> 
> initial version:
> final WeakRefFileListener weakListener = new WeakRefFileListener(file, 
> listener);
> file.getFileSystem().addListener(file, new WeakRefFileListener(file, 
> weakListener));
> 
> 
> but I think it should be only a single wrapper:
> 
> public static void installListener(final FileObject file, final FileListener 
> listener) {
> file.getFileSystem().addListener(file, new WeakRefFileListener(file, 
> listener));
> }
> 
> There is a mention of VFS-143, but itintroduced the whole code with the 
> double indirection
> and it does not explain why it is needed.
> 
> What do you think, should we change it? 
> 
> I also wonder why no tests sees it (in factI try to add a test to reproduce 
> what I think
> shows its not working).
> 
> Gruss
> Bernd
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
> 
> 

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [VOTE] Release Apache Commons CLI 1.8.0 based on RC2

[Emmanuel Bourg]

What about building with JDK 11 and the -frame option then? That's the 
best of both worlds.


Emmanuel Bourg

Le 23/05/2024 à 18:44, Gary Gregory a écrit :

I disagree, I think the search box is a great feature.

Gary

On Thu, May 23, 2024, 11:26 AM Emmanuel Bourg  wrote:


-0

The javadoc was built with Java 17 and is less usable than the javadoc
generated by Java 8. I recommend building the next release with Java 8
instead.

Emmanuel Bourg




-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [VOTE] Release Apache Commons CLI 1.8.0 based on RC2

[Gary Gregory]

ATM, I am using Java 17 for everything, at work, at FOSS.

Gary

On Thu, May 23, 2024, 2:28 PM Emmanuel Bourg  wrote:

> What about building with JDK 11 and the -frame option then? That's the
> best of both worlds.
>
> Emmanuel Bourg
>
> Le 23/05/2024 à 18:44, Gary Gregory a écrit :
> > I disagree, I think the search box is a great feature.
> >
> > Gary
> >
> > On Thu, May 23, 2024, 11:26 AM Emmanuel Bourg  wrote:
> >
> >> -0
> >>
> >> The javadoc was built with Java 17 and is less usable than the javadoc
> >> generated by Java 8. I recommend building the next release with Java 8
> >> instead.
> >>
> >> Emmanuel Bourg
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>

Re: [VOTE] Release Apache Commons CLI 1.8.0 based on RC2

[Emmanuel Bourg]

So there is nothing I can do to convince you to install OpenJDK 11 to 
improve the user experience? Having multiple JDKs installed isn't 
uncommon though.


Emmanuel Bourg


Le 23/05/2024 à 20:47, Gary Gregory a écrit :

ATM, I am using Java 17 for everything, at work, at FOSS.

Gary

On Thu, May 23, 2024, 2:28 PM Emmanuel Bourg  wrote:


What about building with JDK 11 and the -frame option then? That's the
best of both worlds.

Emmanuel Bourg

Le 23/05/2024 à 18:44, Gary Gregory a écrit :

I disagree, I think the search box is a great feature.

Gary

On Thu, May 23, 2024, 11:26 AM Emmanuel Bourg  wrote:


-0

The javadoc was built with Java 17 and is less usable than the javadoc
generated by Java 8. I recommend building the next release with Java 8
instead.

Emmanuel Bourg


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [VOTE] Release Apache Commons CLI 1.8.0 based on RC2

[Gary Gregory]

User experience is subjective... ;-)

What happens when Java 11 is EOL? The frames will be gone for good anyway.

Gary

On Thu, May 23, 2024, 3:41 PM Emmanuel Bourg  wrote:

> So there is nothing I can do to convince you to install OpenJDK 11 to
> improve the user experience? Having multiple JDKs installed isn't
> uncommon though.
>
> Emmanuel Bourg
>
>
> Le 23/05/2024 à 20:47, Gary Gregory a écrit :
> > ATM, I am using Java 17 for everything, at work, at FOSS.
> >
> > Gary
> >
> > On Thu, May 23, 2024, 2:28 PM Emmanuel Bourg  wrote:
> >
> >> What about building with JDK 11 and the -frame option then? That's the
> >> best of both worlds.
> >>
> >> Emmanuel Bourg
> >>
> >> Le 23/05/2024 à 18:44, Gary Gregory a écrit :
> >>> I disagree, I think the search box is a great feature.
> >>>
> >>> Gary
> >>>
> >>> On Thu, May 23, 2024, 11:26 AM Emmanuel Bourg 
> wrote:
> >>>
>  -0
> 
>  The javadoc was built with Java 17 and is less usable than the javadoc
>  generated by Java 8. I recommend building the next release with Java 8
>  instead.
> 
>  Emmanuel Bourg
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>

Re: [VOTE] Release Apache Commons CLI 1.8.0 based on RC2

[Eric Pugh]

From my perspective, we all need to move on to newer versions of Java, and 
while it’s a pain, it’s also key to gaining new capabilities.  

> On May 23, 2024, at 3:42 PM, Gary Gregory  wrote:
> 
> User experience is subjective... ;-)
> 
> What happens when Java 11 is EOL? The frames will be gone for good anyway.
> 
> Gary
> 
> On Thu, May 23, 2024, 3:41 PM Emmanuel Bourg  wrote:
> 
>> So there is nothing I can do to convince you to install OpenJDK 11 to
>> improve the user experience? Having multiple JDKs installed isn't
>> uncommon though.
>> 
>> Emmanuel Bourg
>> 
>> 
>> Le 23/05/2024 à 20:47, Gary Gregory a écrit :
>>> ATM, I am using Java 17 for everything, at work, at FOSS.
>>> 
>>> Gary
>>> 
>>> On Thu, May 23, 2024, 2:28 PM Emmanuel Bourg  wrote:
>>> 
 What about building with JDK 11 and the -frame option then? That's the
 best of both worlds.
 
 Emmanuel Bourg
 
 Le 23/05/2024 à 18:44, Gary Gregory a écrit :
> I disagree, I think the search box is a great feature.
> 
> Gary
> 
> On Thu, May 23, 2024, 11:26 AM Emmanuel Bourg 
>> wrote:
> 
>> -0
>> 
>> The javadoc was built with Java 17 and is less usable than the javadoc
>> generated by Java 8. I recommend building the next release with Java 8
>> instead.
>> 
>> Emmanuel Bourg
>> 
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
>> For additional commands, e-mail: dev-h...@commons.apache.org
>> 
>> 

___
Eric Pugh | Founder | OpenSource Connections, LLC | 434.466.1467 | 
http://www.opensourceconnections.com  | 
My Free/Busy   
Co-Author: Apache Solr Enterprise Search Server, 3rd Ed 


This e-mail and all contents, including attachments, is considered to be 
Company Confidential unless explicitly stated otherwise, regardless of whether 
attachments are marked as such.

[RESULT][VOTE] Release Apache Commons CLI 1.8.0 based on RC2

[Gary Gregory]

This vote thread passes with the following 3 +1 binding votes, with
other votes listed:

- Gary Gregory (ggregory, binding) +1
- Eric Pugh (epugh, non-binding) +1
- Rob Tompkins (chtompki, binding) +1
- Paul King (non-binding) +1
- Henri Biestro (henrib, binding) +1
- Emmanuel Bourg (ebourg, binding) -0

Gary

On Thu, May 23, 2024 at 3:49 PM Eric Pugh
 wrote:
>
> From my perspective, we all need to move on to newer versions of Java, and 
> while it’s a pain, it’s also key to gaining new capabilities.
>
> > On May 23, 2024, at 3:42 PM, Gary Gregory  wrote:
> >
> > User experience is subjective... ;-)
> >
> > What happens when Java 11 is EOL? The frames will be gone for good anyway.
> >
> > Gary
> >
> > On Thu, May 23, 2024, 3:41 PM Emmanuel Bourg  wrote:
> >
> >> So there is nothing I can do to convince you to install OpenJDK 11 to
> >> improve the user experience? Having multiple JDKs installed isn't
> >> uncommon though.
> >>
> >> Emmanuel Bourg
> >>
> >>
> >> Le 23/05/2024 à 20:47, Gary Gregory a écrit :
> >>> ATM, I am using Java 17 for everything, at work, at FOSS.
> >>>
> >>> Gary
> >>>
> >>> On Thu, May 23, 2024, 2:28 PM Emmanuel Bourg  wrote:
> >>>
>  What about building with JDK 11 and the -frame option then? That's the
>  best of both worlds.
> 
>  Emmanuel Bourg
> 
>  Le 23/05/2024 à 18:44, Gary Gregory a écrit :
> > I disagree, I think the search box is a great feature.
> >
> > Gary
> >
> > On Thu, May 23, 2024, 11:26 AM Emmanuel Bourg 
> >> wrote:
> >
> >> -0
> >>
> >> The javadoc was built with Java 17 and is less usable than the javadoc
> >> generated by Java 8. I recommend building the next release with Java 8
> >> instead.
> >>
> >> Emmanuel Bourg
> >>
> >> -
> >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> >> For additional commands, e-mail: dev-h...@commons.apache.org
> >>
> >>
>
> ___
> Eric Pugh | Founder | OpenSource Connections, LLC | 434.466.1467 | 
> http://www.opensourceconnections.com  
> | My Free/Busy 
> Co-Author: Apache Solr Enterprise Search Server, 3rd Ed 
> 
> This e-mail and all contents, including attachments, is considered to be 
> Company Confidential unless explicitly stated otherwise, regardless of 
> whether attachments are marked as such.
>

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[ANNOUNCE] Apache Commons CLI Version 1.8.0

[Gary Gregory]

The Apache Commons Team is pleased to announce Apache Commons CLI Version 1.8.0.

Apache Commons CLI provides a simple API for presenting, processing,
and validating a Command Line Interface.

This release contains new features and bug fixes and requires Java 8 or above.

New Features


* CLI-332: Add optional HelpFormatter Function to document Deprecated
options #271. Thanks to Claude Warren, Gary Gregory.

* Add PMD check to default Maven goal. Thanks to Gary Gregory.

Fixed Bugs
--

* CLI-331: Handle reporting of deprecated options when parameters are
not String type. #270. Thanks to Claude Warren, Gary Gregory.

* Avoid throwing NullPointerException when calling CommandLineParser
will null array elements. Thanks to Claude Warren, Gary Gregory.

* Cleanup deprecation issues #272. Thanks to Claude Warren.

* Fix PMD UnnecessaryFullyQualifiedName issues. Thanks to Gary Gregory.

Updates
---

* Bump commons-parent from 69 to 70. Thanks to Gary Gregory.

Historical list of changes:
https://commons.apache.org/proper/commons-cli/changes-report.html

For complete information on Apache Commons CLI, including instructions
on how to submit bug reports, patches, or suggestions for improvement,
see the Apache Commons CLI website:

https://commons.apache.org/proper/commons-cli/

Download page: https://commons.apache.org/proper/commons-cli/download_cli.cgi

Have fun!

Gary Gregory,
The Apache Commons Team

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[RESULT][VOTE] Release Apache Commons Compress 1.26.2 based on RC1

[Gary Gregory]

This vote thread passes with the following +1 binding votes:

- Gary Gregory (ggregory)
- Rob Tompkins (chtompki)
- Henri Biestro (henrib)

Gary

On Thu, May 23, 2024 at 9:26 AM Henri Biestro  wrote:
>
> [ +1 ]
>
> Site looks good, javadoc looks good, reports Ok (nit jacoco missing).
>
> Tested using:
> mvn clean install site
> On:
> Apache Maven 3.8.6 (84538c9988a25aec085021c365c560670ad80f63)
> Maven home: /Users/hbiestro/Java/apache-maven-3.8.6
> Java version: 17.0.8, vendor: Oracle Corporation, runtime: 
> /Library/Java/JavaVirtualMachines/jdk-17.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "14.5", arch: "aarch64", family: "Mac"
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [VOTE] Release Apache Commons CLI 1.8.0 based on RC2

[Emmanuel Bourg]

Le 23/05/2024 à 21:42, Gary Gregory a écrit :


What happens when Java 11 is EOL? The frames will be gone for good anyway.


Java 11 won't be EOL before 2032 [1], that leaves some time to find an 
alternative. I wouldn't be surprised if someone releases a doclet 
supporting frames by then.


Btw I've pushed the necessary changes to commons-parent to enable the 
frames with JDK 11.


Emmanuel Bourg

[1] https://www.azul.com/fr/azul-support-roadmap/


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [VOTE] Release Apache Commons CLI 1.8.0 based on RC2

[Emmanuel Bourg]

Le 23/05/2024 à 21:48, Eric Pugh a écrit :

 From my perspective, we all need to move on to newer versions of Java, and 
while it’s a pain, it’s also key to gaining new capabilities.


I'm not advocating staying on older JDKs to keep a usable javadoc, that 
wouldn't make sense. But if a component is at the Java 8-11 level, just 
use JDK 11 to build the releases.


Emmanuel Bourg


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org