[BUILD] plugin assumes default branch is 'master'

2023-10-09 Thread sebb
The build plugin currently assumes that the default github branch is 'master'.

The references in text can be addressed, but there is also a reference
in the URL for the CodeCov badge.

Sebb

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



[WEAVER] - move to dormant?

2023-10-09 Thread sebb
Does not seem to be active.

Last release 2018.

Compilation failures on all Java versions with:

org/apache/commons/weaver/privilizer/PrivilizingVisitor.java:[55,76]
an enclosing instance that contains
org.apache.commons.weaver.privilizer.Privilizer.PrivilizerClassVisitor
is required

Tests fail on Java15+ with:

IllegalArgument Unsupported class file...

Download stats show almost no traffic over last 3 months:
https://infra-reports.apache.org/#downloads&project=commons/weaver
What traffic there is looks like it comes from bots.

Sebb

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



Re: [VOTE][LAZY] Release Apache Commons Parent 64 based on RC1

2023-10-09 Thread Gary Gregory
My +1

Gary

On Fri, Oct 6, 2023 at 11:06 AM Gary Gregory  wrote:
>
> We have fixed a few bugs and added some enhancements since Apache
> Commons Parent 63 was released, so I would like to release Apache
> Commons Parent 64.
>
> Apache Commons Parent 64 RC1 is available for review here:
> https://dist.apache.org/repos/dist/dev/commons/parent/64-RC1 (svn
> revision 64373)
>
> The Git tag commons-parent-64-RC1 commit for this RC is
> 57c39ef2790fd05151d8564d9d16baa79ebca97c which you can browse here:
> 
> https://gitbox.apache.org/repos/asf?p=commons-parent.git;a=commit;h=57c39ef2790fd05151d8564d9d16baa79ebca97c
> You may checkout this tag using:
> git clone https://gitbox.apache.org/repos/asf/commons-parent.git
> --branch commons-parent-64-RC1 commons-parent-64-RC1
>
> Maven artifacts are here:
> 
> https://repository.apache.org/content/repositories/orgapachecommons-1664/org/apache/commons/commons-parent/64/
>
> These are the artifacts and their hashes:
>
> #Release SHA-512s
> #Fri Oct 06 10:59:23 EDT 2023
> commons-parent-64-bom.xml=6ca3ed4ee54408562cb7c7ffc6f7dda70c6d174d4628a45e1027d404cf7d52f18f6e81bbf7ffb2874358b020c6d55699faeabfc8ba7f5ee73f67f3316fa7607d
> commons-parent-64-site.xml=5f045989b2c281c567467548678fe8685efabf5c13104299eea87b6ab6b6a75c9e98b590d7b288b8ec3a06934061709d0851a6dd9d9b45100ee2950908ec2d6c
> commons-parent-64-bom.json=1de50d27562639fe188c272e4b84ee57402379e9f7add528fe5b16248dce255d017f6b0521e2e8eb9f39354fc0e780a73962f705873d70939357944d12bf8e9f
> commons-parent-64-src.tar.gz=fc86c6007301ab77207453f926be162e95e811b535c4cd3194c660007a4cfe6587df151fa4fbbe5aee92b7553a8d5631106297613a25aa78fc07c6d5ab69c74c
> commons-parent-64-src.zip=ae0c9c41e94f79e475b29122b9695edbdae2e712892d6b5c2dbebeee96fbdc15380babb8805962a15c3c51eac21c5c9e62369c8cba9c455d6eca43d110527fa9
> org.apache.commons_commons-parent-64.spdx.json=d687c07dd4731ae2e9ea8da4cd684153a3cc09dc1dac92df4d9f03c2c72c37748e3d4a8514d89471b6897668f618a4d3eaf6692b087e3b5b13b301c74f957935
>
>
> I have tested this with:
>
> mvn -V -Prelease -Ptest-deploy -P jacoco -P japicmp clean package site deploy
>
> using:
>
> Maven home: /usr/local/Cellar/maven/3.9.4/libexec
> Java version: 17.0.8.1, vendor: Homebrew, runtime:
> /usr/local/Cellar/openjdk@17/17.0.8.1/libexec/openjdk.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "14.0", arch: "x86_64", family: "mac"
> Darwin  23.0.0 Darwin Kernel Version 23.0.0: Fri Sep 15 14:42:42
> PDT 2023; root:xnu-10002.1.13~1/RELEASE_X86_64 x86_64
>
> Details of changes since 63 are in the release notes:
> 
> https://dist.apache.org/repos/dist/dev/commons/parent/64-RC1/RELEASE-NOTES.txt
> 
> https://dist.apache.org/repos/dist/dev/commons/parent/64-RC1/site/changes-report.html
>
> Site:
> 
> https://dist.apache.org/repos/dist/dev/commons/parent/64-RC1/site/index.html
> (note some *relative* links are broken and the 64 directories are
> not yet created - these will be OK once the site is deployed.)
>
> RAT Report:
> 
> https://dist.apache.org/repos/dist/dev/commons/parent/64-RC1/site/rat-report.html
>
> KEYS:
>   https://downloads.apache.org/commons/KEYS
>
> Please review the release candidate and vote.
> This vote will close no sooner than 72 hours from now.
>
>   [ ] +1 Release these artifacts
>   [ ] +0 OK, but...
>   [ ] -0 OK, but really should fix...
>   [ ] -1 I oppose this release because...
>
> Thank you,
>
> Gary Gregory,
> Release Manager (using key 86fdc7e2a11262cb)
>
> For following is intended as a helper and refresher for reviewers.
>
> Validating a release candidate
> ==
>
> These guidelines are NOT complete.
>
> Requirements: Git, Java, Maven.
>
> You can validate a release from a release candidate (RC) tag as follows.
>
> 1a) Clone and checkout the RC tag
>
> git clone https://gitbox.apache.org/repos/asf/commons-parent.git
> --branch commons-parent-64-RC1 commons-parent-64-RC1
> cd commons-parent-64-RC1
>
> 1b) Download and unpack the source archive from:
>
> https://dist.apache.org/repos/dist/dev/commons/parent/64-RC1/source
>
> 2) Check Apache licenses
>
> This step is not required if the site includes a RAT report page which
> you then must check.
>
> mvn apache-rat:check
>
> 3) Check binary compatibility
>
> Older components still use Apache Clirr:
>
> This step is not required if the site includes a Clirr report page
> which you then must check.
>
> mvn clirr:check
>
> Newer components use JApiCmp with the japicmp Maven Profile:
>
> This step is not required if the site includes a JApiCmp report page
> which you then must check.
>
> mvn install -DskipTests -P japicmp japicmp:cmp
>
> 4) Build the package
>
> mvn -V clean package
>
> You can record the Maven and Java version produced by -V in your VOTE reply.
> To gather OS information from a command line:
> Windows: ver
> Linux: uname -a
>
> 5) Build the site for a single module project
>
> Note: Some plugins require the comp

[RESULT][VOTE][LAZY] Release Apache Commons Parent 64 based on RC1

2023-10-09 Thread Gary Gregory
This lazy vote passes with one binding +1 vote from Gary Gregory.

Gary

On Mon, Oct 9, 2023 at 12:58 PM Gary Gregory  wrote:
>
> My +1
>
> Gary
>
> On Fri, Oct 6, 2023 at 11:06 AM Gary Gregory  wrote:
> >
> > We have fixed a few bugs and added some enhancements since Apache
> > Commons Parent 63 was released, so I would like to release Apache
> > Commons Parent 64.
> >
> > Apache Commons Parent 64 RC1 is available for review here:
> > https://dist.apache.org/repos/dist/dev/commons/parent/64-RC1 (svn
> > revision 64373)
> >
> > The Git tag commons-parent-64-RC1 commit for this RC is
> > 57c39ef2790fd05151d8564d9d16baa79ebca97c which you can browse here:
> > 
> > https://gitbox.apache.org/repos/asf?p=commons-parent.git;a=commit;h=57c39ef2790fd05151d8564d9d16baa79ebca97c
> > You may checkout this tag using:
> > git clone https://gitbox.apache.org/repos/asf/commons-parent.git
> > --branch commons-parent-64-RC1 commons-parent-64-RC1
> >
> > Maven artifacts are here:
> > 
> > https://repository.apache.org/content/repositories/orgapachecommons-1664/org/apache/commons/commons-parent/64/
> >
> > These are the artifacts and their hashes:
> >
> > #Release SHA-512s
> > #Fri Oct 06 10:59:23 EDT 2023
> > commons-parent-64-bom.xml=6ca3ed4ee54408562cb7c7ffc6f7dda70c6d174d4628a45e1027d404cf7d52f18f6e81bbf7ffb2874358b020c6d55699faeabfc8ba7f5ee73f67f3316fa7607d
> > commons-parent-64-site.xml=5f045989b2c281c567467548678fe8685efabf5c13104299eea87b6ab6b6a75c9e98b590d7b288b8ec3a06934061709d0851a6dd9d9b45100ee2950908ec2d6c
> > commons-parent-64-bom.json=1de50d27562639fe188c272e4b84ee57402379e9f7add528fe5b16248dce255d017f6b0521e2e8eb9f39354fc0e780a73962f705873d70939357944d12bf8e9f
> > commons-parent-64-src.tar.gz=fc86c6007301ab77207453f926be162e95e811b535c4cd3194c660007a4cfe6587df151fa4fbbe5aee92b7553a8d5631106297613a25aa78fc07c6d5ab69c74c
> > commons-parent-64-src.zip=ae0c9c41e94f79e475b29122b9695edbdae2e712892d6b5c2dbebeee96fbdc15380babb8805962a15c3c51eac21c5c9e62369c8cba9c455d6eca43d110527fa9
> > org.apache.commons_commons-parent-64.spdx.json=d687c07dd4731ae2e9ea8da4cd684153a3cc09dc1dac92df4d9f03c2c72c37748e3d4a8514d89471b6897668f618a4d3eaf6692b087e3b5b13b301c74f957935
> >
> >
> > I have tested this with:
> >
> > mvn -V -Prelease -Ptest-deploy -P jacoco -P japicmp clean package site 
> > deploy
> >
> > using:
> >
> > Maven home: /usr/local/Cellar/maven/3.9.4/libexec
> > Java version: 17.0.8.1, vendor: Homebrew, runtime:
> > /usr/local/Cellar/openjdk@17/17.0.8.1/libexec/openjdk.jdk/Contents/Home
> > Default locale: en_US, platform encoding: UTF-8
> > OS name: "mac os x", version: "14.0", arch: "x86_64", family: "mac"
> > Darwin  23.0.0 Darwin Kernel Version 23.0.0: Fri Sep 15 14:42:42
> > PDT 2023; root:xnu-10002.1.13~1/RELEASE_X86_64 x86_64
> >
> > Details of changes since 63 are in the release notes:
> > 
> > https://dist.apache.org/repos/dist/dev/commons/parent/64-RC1/RELEASE-NOTES.txt
> > 
> > https://dist.apache.org/repos/dist/dev/commons/parent/64-RC1/site/changes-report.html
> >
> > Site:
> > 
> > https://dist.apache.org/repos/dist/dev/commons/parent/64-RC1/site/index.html
> > (note some *relative* links are broken and the 64 directories are
> > not yet created - these will be OK once the site is deployed.)
> >
> > RAT Report:
> > 
> > https://dist.apache.org/repos/dist/dev/commons/parent/64-RC1/site/rat-report.html
> >
> > KEYS:
> >   https://downloads.apache.org/commons/KEYS
> >
> > Please review the release candidate and vote.
> > This vote will close no sooner than 72 hours from now.
> >
> >   [ ] +1 Release these artifacts
> >   [ ] +0 OK, but...
> >   [ ] -0 OK, but really should fix...
> >   [ ] -1 I oppose this release because...
> >
> > Thank you,
> >
> > Gary Gregory,
> > Release Manager (using key 86fdc7e2a11262cb)
> >
> > For following is intended as a helper and refresher for reviewers.
> >
> > Validating a release candidate
> > ==
> >
> > These guidelines are NOT complete.
> >
> > Requirements: Git, Java, Maven.
> >
> > You can validate a release from a release candidate (RC) tag as follows.
> >
> > 1a) Clone and checkout the RC tag
> >
> > git clone https://gitbox.apache.org/repos/asf/commons-parent.git
> > --branch commons-parent-64-RC1 commons-parent-64-RC1
> > cd commons-parent-64-RC1
> >
> > 1b) Download and unpack the source archive from:
> >
> > https://dist.apache.org/repos/dist/dev/commons/parent/64-RC1/source
> >
> > 2) Check Apache licenses
> >
> > This step is not required if the site includes a RAT report page which
> > you then must check.
> >
> > mvn apache-rat:check
> >
> > 3) Check binary compatibility
> >
> > Older components still use Apache Clirr:
> >
> > This step is not required if the site includes a Clirr report page
> > which you then must check.
> >
> > mvn clirr:check
> >
> > Newer components use JApiCmp with the japicmp Maven Profile:
> >
> > This step is not required if the site includes a JApiCmp report page
> 

Re: [WEAVER] - move to dormant?

2023-10-09 Thread Matt Benson
This was spun out to support security manager stuff in Apache BVal. Until
that known ASF client is able (at the specification level) to exclusively
support Java versions with no SecurityManager whatsoever, I'd personally
prefer to fix [weaver], but having made my preference known I will defer to
the consensus of the community.

Matt

On Mon, Oct 9, 2023, 10:26 AM sebb  wrote:

> Does not seem to be active.
>
> Last release 2018.
>
> Compilation failures on all Java versions with:
>
> org/apache/commons/weaver/privilizer/PrivilizingVisitor.java:[55,76]
> an enclosing instance that contains
> org.apache.commons.weaver.privilizer.Privilizer.PrivilizerClassVisitor
> is required
>
> Tests fail on Java15+ with:
>
> IllegalArgument Unsupported class file...
>
> Download stats show almost no traffic over last 3 months:
> https://infra-reports.apache.org/#downloads&project=commons/weaver
> What traffic there is looks like it comes from bots.
>
> Sebb
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>


Re: [ALL] Standardise Maven defaultGoal in components?

2023-10-09 Thread sebb
On Sun, 8 Oct 2023 at 18:52, Gary Gregory  wrote:
>
> The default goal is always used by GitHub builds

Are you sure about that?

GH does not automatically know how to call Maven.
We have to configure the calls in the workflows.
Not all workflows rely on the default goal, though most do.

> and it is nice to use as a dev before you push.
> This lets us avoid putting some custom mvn call in the
> GH build definition. We can also document to users that calling 'mvn' is a
> all you need to do to validate a PR or push.

But only if the defaultGoal is suitably configured.
AFAICT that is not the case for all components at present.

> Gary
>
> On Sun, Oct 8, 2023, 1:25 PM Phil Steitz  wrote:
>
> > What exactly is the point of the default goal?  I mean when is it expected
> > to be used?  Automations?  Pipes of some kind?  It’s not always executed,
> > right?  So if I say “clean” was the default, “mvn test” would not mean “mvn
> > clean test”, right?
> >
> > Phil
> >
> > > On Oct 8, 2023, at 7:11 AM, sebb  wrote:
> > >
> > > There are currently lots of variations of the defaultGoal in different
> > > components.
> > >
> > > It may be sensible to establish a standard setting which components
> > > should adopt (unless there is a good reason to do otherwise).
> > >
> > > If so, what should that be, and where does it get documented?
> > >
> > > Personally, I don't think install should ever be a default goal as it
> > > changes the environment outside the component.
> > >
> > > Main goals seen:
> > > clean
> > > install
> > > package
> > > site
> > > test
> > > verify
> > >
> > > Other goals seen:
> > > apache-rat:check
> > > checkstyle:check
> > > clirr:check
> > > findbugs:check
> > > japicmp:cmp
> > > javadoc:javadoc
> > > pmd:check
> > > pmd:cpd-check
> > > spotbugs:check
> > >
> > > Sebb
> > >
> > > -
> > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> > > For additional commands, e-mail: dev-h...@commons.apache.org
> > >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> > For additional commands, e-mail: dev-h...@commons.apache.org
> >
> >

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



Re: [WEAVER] - move to dormant?

2023-10-09 Thread Romain Manni-Bucau
Guess we can delay it of a few years (maybe one more LTS) to avoid to
import it in bval to drop it later, sounds like useless work, but overall,
also sounds like java direction for the project.

Le mar. 10 oct. 2023 à 00:36, Matt Benson  a écrit :

> This was spun out to support security manager stuff in Apache BVal. Until
> that known ASF client is able (at the specification level) to exclusively
> support Java versions with no SecurityManager whatsoever, I'd personally
> prefer to fix [weaver], but having made my preference known I will defer to
> the consensus of the community.
>
> Matt
>
> On Mon, Oct 9, 2023, 10:26 AM sebb  wrote:
>
> > Does not seem to be active.
> >
> > Last release 2018.
> >
> > Compilation failures on all Java versions with:
> >
> > org/apache/commons/weaver/privilizer/PrivilizingVisitor.java:[55,76]
> > an enclosing instance that contains
> > org.apache.commons.weaver.privilizer.Privilizer.PrivilizerClassVisitor
> > is required
> >
> > Tests fail on Java15+ with:
> >
> > IllegalArgument Unsupported class file...
> >
> > Download stats show almost no traffic over last 3 months:
> > https://infra-reports.apache.org/#downloads&project=commons/weaver
> > What traffic there is looks like it comes from bots.
> >
> > Sebb
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> > For additional commands, e-mail: dev-h...@commons.apache.org
> >
> >
>