Re: findbugs

[Zoltan Farkas]

In general, I prefer integrating findbugs into the build process and fail the 
build if issues are found. I am a strong believer in this approach, increases 
the quality of the project significantly.

Enforcing coding style and complexity rules is one step further...

Cheers

--z

On Jul 23, 2012, at 3:39 AM, Radim Kolar  wrote:

> The line numbers here don't appear to match with trunk.
> 
> you are right, it was from old trunk 415 commits old. It was just demo of 
> findbugs, for serious use developers should install findbugs maven plugin or 
> eclipse plugin (preferred).

Re: findbugs

[Zoltan Farkas]

Findbugs can be customized with a exclude filter to exclude from checking 
issues that produce a high number of false positives.

For the rest of "false positives" @suppresswarnings annotation can be used.

I suggest Understanding the issue Findbugs highlights before suppressing it, I 
did see devs being lazy and causing production outages...

There is no good reason for not running Findbugs as part of the build.

cheers.

--z

On Jul 30, 2012, at 10:53 AM, Brandon Williams  wrote:

> On Mon, Jul 30, 2012 at 9:52 AM, Jonathan Ellis  wrote:
>> Is Jenkins smart enough to be able to say, "I know we had X findbugs
>> warnings previously, which are known to be false positives, but now
>> there are X+1" ?
> 
> In my experience, jenkins hasn't even been smart enough to build
> cassandra in a couple of years.
> 
> -Brandon

Re: findbugs

[Zoltan Farkas]

Running Findbugs from ant is simple as  well, just google "ant Findbugs", 
plenty of doc and examples on how to do it...

--z

On Jul 30, 2012, at 11:18 AM, Radim Kolar  wrote:

> i am using maven to build cassandra. i didnt have in mind to contribute build 
> system because you are not interested in maven. In maven you just call 
> findbugs plugin, nothing special to contribute. I had in mind patch fixing 
> various FB discovered problems. but because its difficult to post it as many 
> JIRA tickets, it will not be much useful. Maybe post report to list?
> 
> you can create exlude list for FB with list of known false positives, its an 
> xml file.
> 
> 
> 
>  
> 
>