Re: [DISCUSS] CIP-9: Make SSLContext creation pluggable

2021-05-27 Thread Maulin Vasavada 
Hi all

I think I am close to raising a PR now but my CircleCI job

doesn't make progress beyond key tasks success like unit tests, dtests,
cqlshlibtests. Any recommendation on if we need to see the whole CircleCI
job green before raising the PR?

Thanks
Maulin

On Fri, May 21, 2021 at 8:54 PM Maulin Vasavada 
wrote:

> I am almost done with all changes except the code snippet in the
> EncryptioOptions.java which determines 'enabled' and 'optional' encryption
> flags. Will raise the PR soon once I see my CircleCI getting green.
>
> On Fri, May 21, 2021 at 9:24 AM Maulin Vasavada 
> wrote:
>
>> FYI - I am working on PR. I made some changes and trying to run tests.
>>
>> On Tue, May 18, 2021 at 10:14 PM Maulin Vasavada <
>> maulin.vasav...@gmail.com> wrote:
>>
>>> Thanks Nate for reviewing the CEP. Yes for change #3 in the CEP, I mean
>>> to have only single Default Impl and that would be a final class, not
>>> overridable. It will be basically an internal implementation. I've updated
>>> the CEP to reflect this.
>>>
>>> On Tue, May 18, 2021 at 7:21 PM Nate McCall  wrote:
>>>
 Hi Maulin,
 Thanks for putting this together!

 Took a quick glance, and I can't think of a compelling reason on why
 SSLContext should be final and your point about organization/compliance
 issues requiring different implementations is a good one.

 Per #3 on your proposed changes, I'm keen to only support a single
 default
 impl in-tree. I don't think we should be in the business of picking
 implementation to support. It looks like this is your intention as well?

 Thanks again,
 -Nate

 On Wed, May 19, 2021 at 12:05 PM Maulin Vasavada <
 maulin.vasav...@gmail.com>
 wrote:

 > Hi all
 >
 > Starting a discussion thread for the CIP-9 -
 >
 >
 https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-9%3A+Make+SSLContext+creation+pluggable
 >
 >
 > However, while writing the CIP two areas that came up in my mind
 where I
 > need to seek guidance apart from the other discussion that we would
 have
 > here,
 >
 > 1. Whether to consider SSLFactory#tlsInstanceProtocolSubstitution()
 > <
 >
 https://github.com/apache/cassandra/blob/cassandra-4.0/src/java/org/apache/cassandra/security/SSLFactory.java#L169
 > >
 > for pluggability (noted this on the CIP as well)
 >
 > 2. For Test Plan, apart from Integration Test and local system test
 what
 > would be recommended?
 >
 > Thanks
 > Maulin
 >

>>>

Re: [DISCUSS] CIP-9: Make SSLContext creation pluggable

2021-05-27 Thread Brandon Williams 
You can raise a PR in any state, but review will be a different
matter.  I would go ahead and raise it and the testing can be sorted
out from there.

On Thu, May 27, 2021 at 12:12 PM Maulin Vasavada
 wrote:
>
> Hi all
>
> I think I am close to raising a PR now but my CircleCI job
> 
> doesn't make progress beyond key tasks success like unit tests, dtests,
> cqlshlibtests. Any recommendation on if we need to see the whole CircleCI
> job green before raising the PR?
>
> Thanks
> Maulin
>
> On Fri, May 21, 2021 at 8:54 PM Maulin Vasavada 
> wrote:
>
> > I am almost done with all changes except the code snippet in the
> > EncryptioOptions.java which determines 'enabled' and 'optional' encryption
> > flags. Will raise the PR soon once I see my CircleCI getting green.
> >
> > On Fri, May 21, 2021 at 9:24 AM Maulin Vasavada 
> > wrote:
> >
> >> FYI - I am working on PR. I made some changes and trying to run tests.
> >>
> >> On Tue, May 18, 2021 at 10:14 PM Maulin Vasavada <
> >> maulin.vasav...@gmail.com> wrote:
> >>
> >>> Thanks Nate for reviewing the CEP. Yes for change #3 in the CEP, I mean
> >>> to have only single Default Impl and that would be a final class, not
> >>> overridable. It will be basically an internal implementation. I've updated
> >>> the CEP to reflect this.
> >>>
> >>> On Tue, May 18, 2021 at 7:21 PM Nate McCall  wrote:
> >>>
>  Hi Maulin,
>  Thanks for putting this together!
> 
>  Took a quick glance, and I can't think of a compelling reason on why
>  SSLContext should be final and your point about organization/compliance
>  issues requiring different implementations is a good one.
> 
>  Per #3 on your proposed changes, I'm keen to only support a single
>  default
>  impl in-tree. I don't think we should be in the business of picking
>  implementation to support. It looks like this is your intention as well?
> 
>  Thanks again,
>  -Nate
> 
>  On Wed, May 19, 2021 at 12:05 PM Maulin Vasavada <
>  maulin.vasav...@gmail.com>
>  wrote:
> 
>  > Hi all
>  >
>  > Starting a discussion thread for the CIP-9 -
>  >
>  >
>  https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-9%3A+Make+SSLContext+creation+pluggable
>  >
>  >
>  > However, while writing the CIP two areas that came up in my mind
>  where I
>  > need to seek guidance apart from the other discussion that we would
>  have
>  > here,
>  >
>  > 1. Whether to consider SSLFactory#tlsInstanceProtocolSubstitution()
>  > <
>  >
>  https://github.com/apache/cassandra/blob/cassandra-4.0/src/java/org/apache/cassandra/security/SSLFactory.java#L169
>  > >
>  > for pluggability (noted this on the CIP as well)
>  >
>  > 2. For Test Plan, apart from Integration Test and local system test
>  what
>  > would be recommended?
>  >
>  > Thanks
>  > Maulin
>  >
> 
> >>>

-
To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org
For additional commands, e-mail: dev-h...@cassandra.apache.org

Re: [DISCUSS] CIP-9: Make SSLContext creation pluggable

2021-05-27 Thread Maulin Vasavada 
Sounds good Brandon. I'll raise the PR in a couple of hours from now.
Thanks.

On Thu, May 27, 2021 at 10:14 AM Brandon Williams  wrote:

> You can raise a PR in any state, but review will be a different
> matter.  I would go ahead and raise it and the testing can be sorted
> out from there.
>
> On Thu, May 27, 2021 at 12:12 PM Maulin Vasavada
>  wrote:
> >
> > Hi all
> >
> > I think I am close to raising a PR now but my CircleCI job
> > 
> > doesn't make progress beyond key tasks success like unit tests, dtests,
> > cqlshlibtests. Any recommendation on if we need to see the whole CircleCI
> > job green before raising the PR?
> >
> > Thanks
> > Maulin
> >
> > On Fri, May 21, 2021 at 8:54 PM Maulin Vasavada <
> maulin.vasav...@gmail.com>
> > wrote:
> >
> > > I am almost done with all changes except the code snippet in the
> > > EncryptioOptions.java which determines 'enabled' and 'optional'
> encryption
> > > flags. Will raise the PR soon once I see my CircleCI getting green.
> > >
> > > On Fri, May 21, 2021 at 9:24 AM Maulin Vasavada <
> maulin.vasav...@gmail.com>
> > > wrote:
> > >
> > >> FYI - I am working on PR. I made some changes and trying to run tests.
> > >>
> > >> On Tue, May 18, 2021 at 10:14 PM Maulin Vasavada <
> > >> maulin.vasav...@gmail.com> wrote:
> > >>
> > >>> Thanks Nate for reviewing the CEP. Yes for change #3 in the CEP, I
> mean
> > >>> to have only single Default Impl and that would be a final class, not
> > >>> overridable. It will be basically an internal implementation. I've
> updated
> > >>> the CEP to reflect this.
> > >>>
> > >>> On Tue, May 18, 2021 at 7:21 PM Nate McCall 
> wrote:
> > >>>
> >  Hi Maulin,
> >  Thanks for putting this together!
> > 
> >  Took a quick glance, and I can't think of a compelling reason on why
> >  SSLContext should be final and your point about
> organization/compliance
> >  issues requiring different implementations is a good one.
> > 
> >  Per #3 on your proposed changes, I'm keen to only support a single
> >  default
> >  impl in-tree. I don't think we should be in the business of picking
> >  implementation to support. It looks like this is your intention as
> well?
> > 
> >  Thanks again,
> >  -Nate
> > 
> >  On Wed, May 19, 2021 at 12:05 PM Maulin Vasavada <
> >  maulin.vasav...@gmail.com>
> >  wrote:
> > 
> >  > Hi all
> >  >
> >  > Starting a discussion thread for the CIP-9 -
> >  >
> >  >
> > 
> https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-9%3A+Make+SSLContext+creation+pluggable
> >  >
> >  >
> >  > However, while writing the CIP two areas that came up in my mind
> >  where I
> >  > need to seek guidance apart from the other discussion that we
> would
> >  have
> >  > here,
> >  >
> >  > 1. Whether to consider
> SSLFactory#tlsInstanceProtocolSubstitution()
> >  > <
> >  >
> > 
> https://github.com/apache/cassandra/blob/cassandra-4.0/src/java/org/apache/cassandra/security/SSLFactory.java#L169
> >  > >
> >  > for pluggability (noted this on the CIP as well)
> >  >
> >  > 2. For Test Plan, apart from Integration Test and local system
> test
> >  what
> >  > would be recommended?
> >  >
> >  > Thanks
> >  > Maulin
> >  >
> > 
> > >>>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org
> For additional commands, e-mail: dev-h...@cassandra.apache.org
>
>

Re: [DISCUSS] CIP-9: Make SSLContext creation pluggable

2021-05-27 Thread Maulin Vasavada 
HI all

I've raised the PR with the changes. Specifically I would appreciate the
community's input on this section of the CEP

.

Once we get some consensus on the PR (except minor code improvement
suggestions) I'll start a VOTE thread for the CEP.

I thank all the reviewers of the CEP and the PR in advance and am
completely excited to contribute to Apache Cassandra.

Thanks
Maulin

On Thu, May 27, 2021 at 11:04 AM Maulin Vasavada 
wrote:

> Sounds good Brandon. I'll raise the PR in a couple of hours from now.
> Thanks.
>
> On Thu, May 27, 2021 at 10:14 AM Brandon Williams 
> wrote:
>
>> You can raise a PR in any state, but review will be a different
>> matter.  I would go ahead and raise it and the testing can be sorted
>> out from there.
>>
>> On Thu, May 27, 2021 at 12:12 PM Maulin Vasavada
>>  wrote:
>> >
>> > Hi all
>> >
>> > I think I am close to raising a PR now but my CircleCI job
>> > 
>> > doesn't make progress beyond key tasks success like unit tests, dtests,
>> > cqlshlibtests. Any recommendation on if we need to see the whole
>> CircleCI
>> > job green before raising the PR?
>> >
>> > Thanks
>> > Maulin
>> >
>> > On Fri, May 21, 2021 at 8:54 PM Maulin Vasavada <
>> maulin.vasav...@gmail.com>
>> > wrote:
>> >
>> > > I am almost done with all changes except the code snippet in the
>> > > EncryptioOptions.java which determines 'enabled' and 'optional'
>> encryption
>> > > flags. Will raise the PR soon once I see my CircleCI getting green.
>> > >
>> > > On Fri, May 21, 2021 at 9:24 AM Maulin Vasavada <
>> maulin.vasav...@gmail.com>
>> > > wrote:
>> > >
>> > >> FYI - I am working on PR. I made some changes and trying to run
>> tests.
>> > >>
>> > >> On Tue, May 18, 2021 at 10:14 PM Maulin Vasavada <
>> > >> maulin.vasav...@gmail.com> wrote:
>> > >>
>> > >>> Thanks Nate for reviewing the CEP. Yes for change #3 in the CEP, I
>> mean
>> > >>> to have only single Default Impl and that would be a final class,
>> not
>> > >>> overridable. It will be basically an internal implementation. I've
>> updated
>> > >>> the CEP to reflect this.
>> > >>>
>> > >>> On Tue, May 18, 2021 at 7:21 PM Nate McCall 
>> wrote:
>> > >>>
>> >  Hi Maulin,
>> >  Thanks for putting this together!
>> > 
>> >  Took a quick glance, and I can't think of a compelling reason on
>> why
>> >  SSLContext should be final and your point about
>> organization/compliance
>> >  issues requiring different implementations is a good one.
>> > 
>> >  Per #3 on your proposed changes, I'm keen to only support a single
>> >  default
>> >  impl in-tree. I don't think we should be in the business of picking
>> >  implementation to support. It looks like this is your intention as
>> well?
>> > 
>> >  Thanks again,
>> >  -Nate
>> > 
>> >  On Wed, May 19, 2021 at 12:05 PM Maulin Vasavada <
>> >  maulin.vasav...@gmail.com>
>> >  wrote:
>> > 
>> >  > Hi all
>> >  >
>> >  > Starting a discussion thread for the CIP-9 -
>> >  >
>> >  >
>> > 
>> https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-9%3A+Make+SSLContext+creation+pluggable
>> >  >
>> >  >
>> >  > However, while writing the CIP two areas that came up in my mind
>> >  where I
>> >  > need to seek guidance apart from the other discussion that we
>> would
>> >  have
>> >  > here,
>> >  >
>> >  > 1. Whether to consider
>> SSLFactory#tlsInstanceProtocolSubstitution()
>> >  > <
>> >  >
>> > 
>> https://github.com/apache/cassandra/blob/cassandra-4.0/src/java/org/apache/cassandra/security/SSLFactory.java#L169
>> >  > >
>> >  > for pluggability (noted this on the CIP as well)
>> >  >
>> >  > 2. For Test Plan, apart from Integration Test and local system
>> test
>> >  what
>> >  > would be recommended?
>> >  >
>> >  > Thanks
>> >  > Maulin
>> >  >
>> > 
>> > >>>
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org
>> For additional commands, e-mail: dev-h...@cassandra.apache.org
>>
>>