[VOTE] Release dtest-api 0.0.3
This is a somewhat special vote that requires at least minimal understanding of the patch it is related to [1], since it's also the first release. This version has to be released _before_ Cassandra version that its future versions are released, since we can't rely on unreleased artifact in Cassandra, since any change in dtest api would break Cassandra builds, which we'd like to avoid. There's a detailed description of the release plan in 15539. If you have any questions and/or concerns, now is the second-best time to raise them. Code: https://github.com/apache/cassandra-in-jvm-dtest-api Artifact: https://repository.apache.org/content/repositories/orgapachecassandra-1195/org/apache/cassandra/dtest-api/0.0.3/ The vote will be open for 72 hours (longer if needed). Everyone who has tested the build is invited to vote. Votes by PMC members are considered binding. A vote passes if there are at least three binding +1s. -- Alex [1] https://issues.apache.org/jira/browse/CASSANDRA-15539
Re: [VOTE] Release dtest-api 0.0.3
+1 (non binding) Sent from my iPhone > On Mar 20, 2020, at 9:32 AM, Oleksandr Petrov > wrote: > > This is a somewhat special vote that requires at least minimal > understanding of the patch it is related to [1], since it's also the first > release. > > This version has to be released _before_ Cassandra version that its future > versions are released, since we can't rely on unreleased artifact in > Cassandra, since any change in dtest api would break Cassandra builds, > which we'd like to avoid. There's a detailed description of the release > plan in 15539. > > If you have any questions and/or concerns, now is the second-best time to > raise them. > > Code: https://github.com/apache/cassandra-in-jvm-dtest-api > Artifact: > https://repository.apache.org/content/repositories/orgapachecassandra-1195/org/apache/cassandra/dtest-api/0.0.3/ > > The vote will be open for 72 hours (longer if needed). Everyone who has > tested the build is invited to vote. Votes by PMC members are considered > binding. A vote passes if there are at least three binding +1s. > > -- Alex > > [1] https://issues.apache.org/jira/browse/CASSANDRA-15539 - To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org For additional commands, e-mail: dev-h...@cassandra.apache.org
Re: [VOTE] Release dtest-api 0.0.3
+1 Code link is actually a branch at: https://github.com/apache/cassandra-in-jvm-dtest-api/tree/CASSANDRA-15539 Just curious why master isn't the active dev branch, since there's nothing but a license and blank readme there. No biggie, just had to go look for it when I followed the link. Michael On 3/20/20 11:34 AM, David Capwell wrote: +1 (non binding) Sent from my iPhone On Mar 20, 2020, at 9:32 AM, Oleksandr Petrov wrote: This is a somewhat special vote that requires at least minimal understanding of the patch it is related to [1], since it's also the first release. This version has to be released _before_ Cassandra version that its future versions are released, since we can't rely on unreleased artifact in Cassandra, since any change in dtest api would break Cassandra builds, which we'd like to avoid. There's a detailed description of the release plan in 15539. If you have any questions and/or concerns, now is the second-best time to raise them. Code: https://github.com/apache/cassandra-in-jvm-dtest-api Artifact: https://repository.apache.org/content/repositories/orgapachecassandra-1195/org/apache/cassandra/dtest-api/0.0.3/ The vote will be open for 72 hours (longer if needed). Everyone who has tested the build is invited to vote. Votes by PMC members are considered binding. A vote passes if there are at least three binding +1s. -- Alex [1] https://issues.apache.org/jira/browse/CASSANDRA-15539 - To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org For additional commands, e-mail: dev-h...@cassandra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org For additional commands, e-mail: dev-h...@cassandra.apache.org
Re: [VOTE] Release dtest-api 0.0.3
> The vote will be open for 72 hours (longer if needed). Everyone who has > tested the build is invited to vote. Votes by PMC members are considered > binding. A vote passes if there are at least three binding +1s. > -1 A few things here don't meet the requirements. * There's no copyright or NOTICE file in source jar artifact. * The license is not present in all files (eg AssertUtils.java) * What key has been used to sign? * Source artifacts does not compile. They depend on snapshot dependency, see below. * There's a ".git" directory in the source jar artifact. Additionally, * `mvn rat:check` does not pass. (relates back to license and .git directory) * There's unnecessary duplicate source artifacts. * The source zip file does not have sha256 or sha512 checksums. * The contents of the source zip artifact do not match what's in scm. * The scm SHA is not mentioned in the vote. * Where's the scm tag for this scm SHA? * Erroneous `.asc.asc` files. The build failure I get is: ``` [ERROR] Failed to execute goal on project dtest-api: Could not resolve dependencies for project org.apache.cassandra:dtest-api:jar:0.0.4-SNAPSHOT: Could not find artifact org.apache.cassandra:in-jvm-dtest-cassandra-tryout:jar:0.0.1-2.2-1 in central (https://repo.maven.apache.org/maven2) -> [Help 1] ``` The source zip artifact can just be removed (not generated) as there's no need (afaik) for any artifacts outside of the maven repository. But add those manually added files into git. This will solve the sha256 and sha512 problem, and that the build that doesn't match scm contents. I've got a few hours in front of me and will try to send some PRs to fix what I can here. regards, Mick
Re: [VOTE] Release dtest-api 0.0.3
Adding my PMC binding -1 until Mick's comments are addressed. On Fri, Mar 20, 2020 at 11:39 AM Mick Semb Wever wrote: > > The vote will be open for 72 hours (longer if needed). Everyone who has > > tested the build is invited to vote. Votes by PMC members are considered > > binding. A vote passes if there are at least three binding +1s. > > > > > -1 > > A few things here don't meet the requirements. > > * There's no copyright or NOTICE file in source jar artifact. > * The license is not present in all files (eg AssertUtils.java) > * What key has been used to sign? > * Source artifacts does not compile. They depend on snapshot dependency, > see below. > * There's a ".git" directory in the source jar artifact. > > Additionally, > * `mvn rat:check` does not pass. (relates back to license and .git > directory) > * There's unnecessary duplicate source artifacts. > * The source zip file does not have sha256 or sha512 checksums. > * The contents of the source zip artifact do not match what's in scm. > * The scm SHA is not mentioned in the vote. > * Where's the scm tag for this scm SHA? > * Erroneous `.asc.asc` files. > > > The build failure I get is: > ``` > [ERROR] Failed to execute goal on project dtest-api: Could not resolve > dependencies for project org.apache.cassandra:dtest-api:jar:0.0.4-SNAPSHOT: > Could not find artifact > org.apache.cassandra:in-jvm-dtest-cassandra-tryout:jar:0.0.1-2.2-1 in > central (https://repo.maven.apache.org/maven2) -> [Help 1] > ``` > > The source zip artifact can just be removed (not generated) as there's no > need (afaik) for any artifacts outside of the maven repository. But add > those manually added files into git. This will solve the sha256 and sha512 > problem, and that the build that doesn't match scm contents. > > > I've got a few hours in front of me and will try to send some PRs to fix > what I can here. > > regards, > Mick >
Re: [VOTE] Release dtest-api 0.0.3
Thanks Mick, -1 as well. On Fri, Mar 20, 2020 at 11:39 AM Mick Semb Wever wrote: > > The vote will be open for 72 hours (longer if needed). Everyone who has > > tested the build is invited to vote. Votes by PMC members are considered > > binding. A vote passes if there are at least three binding +1s. > > > > > -1 > > A few things here don't meet the requirements. > > * There's no copyright or NOTICE file in source jar artifact. > * The license is not present in all files (eg AssertUtils.java) > * What key has been used to sign? > * Source artifacts does not compile. They depend on snapshot dependency, > see below. > * There's a ".git" directory in the source jar artifact. > > Additionally, > * `mvn rat:check` does not pass. (relates back to license and .git > directory) > * There's unnecessary duplicate source artifacts. > * The source zip file does not have sha256 or sha512 checksums. > * The contents of the source zip artifact do not match what's in scm. > * The scm SHA is not mentioned in the vote. > * Where's the scm tag for this scm SHA? > * Erroneous `.asc.asc` files. > > > The build failure I get is: > ``` > [ERROR] Failed to execute goal on project dtest-api: Could not resolve > dependencies for project org.apache.cassandra:dtest-api:jar:0.0.4-SNAPSHOT: > Could not find artifact > org.apache.cassandra:in-jvm-dtest-cassandra-tryout:jar:0.0.1-2.2-1 in > central (https://repo.maven.apache.org/maven2) -> [Help 1] > ``` > > The source zip artifact can just be removed (not generated) as there's no > need (afaik) for any artifacts outside of the maven repository. But add > those manually added files into git. This will solve the sha256 and sha512 > problem, and that the build that doesn't match scm contents. > > > I've got a few hours in front of me and will try to send some PRs to fix > what I can here. > > regards, > Mick >
Re: [VOTE] Release dtest-api 0.0.3
-1 binding. On Fri, Mar 20, 2020, 1:39 PM Mick Semb Wever wrote: > > The vote will be open for 72 hours (longer if needed). Everyone who has > > tested the build is invited to vote. Votes by PMC members are considered > > binding. A vote passes if there are at least three binding +1s. > > > > > -1 > > A few things here don't meet the requirements. > > * There's no copyright or NOTICE file in source jar artifact. > * The license is not present in all files (eg AssertUtils.java) > * What key has been used to sign? > * Source artifacts does not compile. They depend on snapshot dependency, > see below. > * There's a ".git" directory in the source jar artifact. > > Additionally, > * `mvn rat:check` does not pass. (relates back to license and .git > directory) > * There's unnecessary duplicate source artifacts. > * The source zip file does not have sha256 or sha512 checksums. > * The contents of the source zip artifact do not match what's in scm. > * The scm SHA is not mentioned in the vote. > * Where's the scm tag for this scm SHA? > * Erroneous `.asc.asc` files. > > > The build failure I get is: > ``` > [ERROR] Failed to execute goal on project dtest-api: Could not resolve > dependencies for project org.apache.cassandra:dtest-api:jar:0.0.4-SNAPSHOT: > Could not find artifact > org.apache.cassandra:in-jvm-dtest-cassandra-tryout:jar:0.0.1-2.2-1 in > central (https://repo.maven.apache.org/maven2) -> [Help 1] > ``` > > The source zip artifact can just be removed (not generated) as there's no > need (afaik) for any artifacts outside of the maven repository. But add > those manually added files into git. This will solve the sha256 and sha512 > problem, and that the build that doesn't match scm contents. > > > I've got a few hours in front of me and will try to send some PRs to fix > what I can here. > > regards, > Mick >
Re: [VOTE] Release dtest-api 0.0.3
updated vote: -1 Thanks for the run through, Mick. On 3/20/20 12:01 PM, Michael Shuler wrote: +1 Code link is actually a branch at: https://github.com/apache/cassandra-in-jvm-dtest-api/tree/CASSANDRA-15539 Just curious why master isn't the active dev branch, since there's nothing but a license and blank readme there. No biggie, just had to go look for it when I followed the link. Michael On 3/20/20 11:34 AM, David Capwell wrote: +1 (non binding) Sent from my iPhone On Mar 20, 2020, at 9:32 AM, Oleksandr Petrov wrote: This is a somewhat special vote that requires at least minimal understanding of the patch it is related to [1], since it's also the first release. This version has to be released _before_ Cassandra version that its future versions are released, since we can't rely on unreleased artifact in Cassandra, since any change in dtest api would break Cassandra builds, which we'd like to avoid. There's a detailed description of the release plan in 15539. If you have any questions and/or concerns, now is the second-best time to raise them. Code: https://github.com/apache/cassandra-in-jvm-dtest-api Artifact: https://repository.apache.org/content/repositories/orgapachecassandra-1195/org/apache/cassandra/dtest-api/0.0.3/ The vote will be open for 72 hours (longer if needed). Everyone who has tested the build is invited to vote. Votes by PMC members are considered binding. A vote passes if there are at least three binding +1s. -- Alex [1] https://issues.apache.org/jira/browse/CASSANDRA-15539 - To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org For additional commands, e-mail: dev-h...@cassandra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org For additional commands, e-mail: dev-h...@cassandra.apache.org
Re: [VOTE] Release dtest-api 0.0.3
> I've got a few hours in front of me and will try to send some PRs to fix > what I can here. > Alex, this fixes everything but the signing key used issue: https://github.com/apache/cassandra-in-jvm-dtest-api/pull/2 regards, Mick
