Typo in comment for maxFunctionForCounter in AggregateFcts.java
Comment typo for maxFunctionForCounter in AggregateFcts.java:
/**
* AVG function for counter column values.
*/
public static final AggregateFunction maxFunctionForCounter =
new NativeAggregateFunction("max", CounterColumnType.instance,
CounterColumnType.instance)
That comment should be "MAX" rather than "AVG"
See:
https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/cql3/functions/AggregateFcts.java#L760
Oops... I see more copy and paste typos, where the type for the function is
wrong in the comment:
https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/cql3/functions/AggregateFcts.java#L284
https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/cql3/functions/AggregateFcts.java#L320
https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/cql3/functions/AggregateFcts.java#L362
https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/cql3/functions/AggregateFcts.java#L398
Let me know if this needs a Jia ticket or if somebody can just fix it
without the paperwork.
-- Jack Krupansky
Re: Typo in comment for maxFunctionForCounter in AggregateFcts.java
I will fix it. I am the one that has probably done them anyway.
Benjamin
On Tue, Apr 19, 2016 at 4:57 PM, Jack Krupansky
wrote:
> Comment typo for maxFunctionForCounter in AggregateFcts.java:
>
> /**
> * AVG function for counter column values.
> */
> public static final AggregateFunction maxFunctionForCounter =
> new NativeAggregateFunction("max", CounterColumnType.instance,
> CounterColumnType.instance)
>
> That comment should be "MAX" rather than "AVG"
>
> See:
>
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/cql3/functions/AggregateFcts.java#L760
>
> Oops... I see more copy and paste typos, where the type for the function is
> wrong in the comment:
>
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/cql3/functions/AggregateFcts.java#L284
>
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/cql3/functions/AggregateFcts.java#L320
>
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/cql3/functions/AggregateFcts.java#L362
>
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/cql3/functions/AggregateFcts.java#L398
>
> Let me know if this needs a Jia ticket or if somebody can just fix it
> without the paperwork.
>
> -- Jack Krupansky
>
Re: Typo in comment for maxFunctionForCounter in AggregateFcts.java
Done. Thanks for reporting the problem.
On Tuesday, April 19, 2016, Benjamin Lerer
wrote:
> I will fix it. I am the one that has probably done them anyway.
>
> Benjamin
>
> On Tue, Apr 19, 2016 at 4:57 PM, Jack Krupansky > wrote:
>
>> Comment typo for maxFunctionForCounter in AggregateFcts.java:
>>
>> /**
>> * AVG function for counter column values.
>> */
>> public static final AggregateFunction maxFunctionForCounter =
>> new NativeAggregateFunction("max", CounterColumnType.instance,
>> CounterColumnType.instance)
>>
>> That comment should be "MAX" rather than "AVG"
>>
>> See:
>>
>> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/cql3/functions/AggregateFcts.java#L760
>>
>> Oops... I see more copy and paste typos, where the type for the function
>> is
>> wrong in the comment:
>>
>> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/cql3/functions/AggregateFcts.java#L284
>>
>> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/cql3/functions/AggregateFcts.java#L320
>>
>> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/cql3/functions/AggregateFcts.java#L362
>>
>> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/cql3/functions/AggregateFcts.java#L398
>>
>> Let me know if this needs a Jia ticket or if somebody can just fix it
>> without the paperwork.
>>
>> -- Jack Krupansky
>>
>
>
Re: Typo in comment for maxFunctionForCounter in AggregateFcts.java
Thanks for the prompt service!
-- Jack Krupansky
On Tue, Apr 19, 2016 at 12:16 PM, Benjamin Lerer <
benjamin.le...@datastax.com> wrote:
> Done. Thanks for reporting the problem.
>
> On Tuesday, April 19, 2016, Benjamin Lerer
> wrote:
>
> > I will fix it. I am the one that has probably done them anyway.
> >
> > Benjamin
> >
> > On Tue, Apr 19, 2016 at 4:57 PM, Jack Krupansky <
> jack.krupan...@gmail.com
> > > wrote:
> >
> >> Comment typo for maxFunctionForCounter in AggregateFcts.java:
> >>
> >> /**
> >> * AVG function for counter column values.
> >> */
> >> public static final AggregateFunction maxFunctionForCounter =
> >> new NativeAggregateFunction("max", CounterColumnType.instance,
> >> CounterColumnType.instance)
> >>
> >> That comment should be "MAX" rather than "AVG"
> >>
> >> See:
> >>
> >>
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/cql3/functions/AggregateFcts.java#L760
> >>
> >> Oops... I see more copy and paste typos, where the type for the function
> >> is
> >> wrong in the comment:
> >>
> >>
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/cql3/functions/AggregateFcts.java#L284
> >>
> >>
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/cql3/functions/AggregateFcts.java#L320
> >>
> >>
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/cql3/functions/AggregateFcts.java#L362
> >>
> >>
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/cql3/functions/AggregateFcts.java#L398
> >>
> >> Let me know if this needs a Jia ticket or if somebody can just fix it
> >> without the paperwork.
> >>
> >> -- Jack Krupansky
> >>
> >
> >
>
Cassandra 2.0.x OOM during bootstrap
Hi, all, We have recently encountered a Cassandra OOM issue when Cassandra is brought up sometimes (but not always) in our 4-node cluster test bed. After analyzing the heap dump, we could find the Internal-Response thread pool (JMXEnabledThreadPoolExecutor) is filled with thounds of 'org.apache.cassandra.net.MessageIn' objects, and occupy > 2 gigabytes of heap memory. According to the documents on internet, it seems internal-response thread pool is somewhat related to schema-checking. Has anyone encountered similar issue before? We are using Cassandra 2.0.17 and JDK 1.8. Thanks in advance! Sincerely, Michael Fong
