Re: CQL unit tests vs dtests
On Wed, May 21, 2014 at 10:46 PM, Jonathan Ellis wrote: > I do think that CQL tests in general make more sense as unit tests, > but I'm not so anal that I'm going to insist on rewriting existing > ones. But in theory, if I had an infinite army of interns, sure. I'd > have one of them do that. :) > > But in the real world, compared to saying "we don't have any cql unit > tests, so we should always write them as dtests to be consistent" I > think having mixed unit + dtests is the lesser of evils. > Fair enough. I'll try to make CQL tests as unit tests from now on as much as possible (I can't promise a few misfire in the short term). Let's hope you find your infinite intern army someday. -- Sylvain
Re: CQL unit tests vs dtests
The only thing I worry about here is that the unit tests don't come into the system the same way user queries will. So we still need the system level dtests. So I don't think all CQL tests should be unit tests, but I am all for there being unit level CQL tests. On May 22, 2014, at 10:58 AM, Sylvain Lebresne wrote: > On Wed, May 21, 2014 at 10:46 PM, Jonathan Ellis wrote: > >> I do think that CQL tests in general make more sense as unit tests, >> but I'm not so anal that I'm going to insist on rewriting existing >> ones. But in theory, if I had an infinite army of interns, sure. I'd >> have one of them do that. :) >> >> But in the real world, compared to saying "we don't have any cql unit >> tests, so we should always write them as dtests to be consistent" I >> think having mixed unit + dtests is the lesser of evils. >> > > Fair enough. I'll try to make CQL tests as unit tests from now on as much > as possible (I can't promise a few misfire in the short term). Let's hope > you > find your infinite intern army someday. > > -- > Sylvain
Re: CQL unit tests vs dtests
I would for defining the cql tests in a way that permits them being run as both dtests and unit tests. But since we're on python for dtests that could be troublesome. On 22 May 2014 17:03, Jeremiah D Jordan wrote: > The only thing I worry about here is that the unit tests don't come into > the system the same way user queries will. So we still need the system > level dtests. So I don't think all CQL tests should be unit tests, but I > am all for there being unit level CQL tests. > > On May 22, 2014, at 10:58 AM, Sylvain Lebresne > wrote: > > > On Wed, May 21, 2014 at 10:46 PM, Jonathan Ellis > wrote: > > > >> I do think that CQL tests in general make more sense as unit tests, > >> but I'm not so anal that I'm going to insist on rewriting existing > >> ones. But in theory, if I had an infinite army of interns, sure. I'd > >> have one of them do that. :) > >> > >> But in the real world, compared to saying "we don't have any cql unit > >> tests, so we should always write them as dtests to be consistent" I > >> think having mixed unit + dtests is the lesser of evils. > >> > > > > Fair enough. I'll try to make CQL tests as unit tests from now on as much > > as possible (I can't promise a few misfire in the short term). Let's hope > > you > > find your infinite intern army someday. > > > > -- > > Sylvain > >
Re: CQL unit tests vs dtests
Jython! :D On Thu, May 22, 2014 at 12:09 PM, Benedict Elliott Smith < belliottsm...@datastax.com> wrote: > I would for defining the cql tests in a way that permits them being run as > both dtests and unit tests. But since we're on python for dtests that could > be troublesome. > > > On 22 May 2014 17:03, Jeremiah D Jordan wrote: > > > The only thing I worry about here is that the unit tests don't come into > > the system the same way user queries will. So we still need the system > > level dtests. So I don't think all CQL tests should be unit tests, but I > > am all for there being unit level CQL tests. > > > > On May 22, 2014, at 10:58 AM, Sylvain Lebresne > > wrote: > > > > > On Wed, May 21, 2014 at 10:46 PM, Jonathan Ellis > > wrote: > > > > > >> I do think that CQL tests in general make more sense as unit tests, > > >> but I'm not so anal that I'm going to insist on rewriting existing > > >> ones. But in theory, if I had an infinite army of interns, sure. I'd > > >> have one of them do that. :) > > >> > > >> But in the real world, compared to saying "we don't have any cql unit > > >> tests, so we should always write them as dtests to be consistent" I > > >> think having mixed unit + dtests is the lesser of evils. > > >> > > > > > > Fair enough. I'll try to make CQL tests as unit tests from now on as > much > > > as possible (I can't promise a few misfire in the short term). Let's > hope > > > you > > > find your infinite intern army someday. > > > > > > -- > > > Sylvain > > > > > -- http://twitter.com/tjake
Re: CQL unit tests vs dtests
We actually have some jython tests for a few test suites we wanted to use the java driver with: https://github.com/riptano/cassandra-dtest-jython On Thu, May 22, 2014 at 2:36 PM, Jake Luciani wrote: > Jython! :D > > > On Thu, May 22, 2014 at 12:09 PM, Benedict Elliott Smith < > belliottsm...@datastax.com> wrote: > > > I would for defining the cql tests in a way that permits them being run > as > > both dtests and unit tests. But since we're on python for dtests that > could > > be troublesome. > > > > > > On 22 May 2014 17:03, Jeremiah D Jordan wrote: > > > > > The only thing I worry about here is that the unit tests don't come > into > > > the system the same way user queries will. So we still need the system > > > level dtests. So I don't think all CQL tests should be unit tests, > but I > > > am all for there being unit level CQL tests. > > > > > > On May 22, 2014, at 10:58 AM, Sylvain Lebresne > > > wrote: > > > > > > > On Wed, May 21, 2014 at 10:46 PM, Jonathan Ellis > > > wrote: > > > > > > > >> I do think that CQL tests in general make more sense as unit tests, > > > >> but I'm not so anal that I'm going to insist on rewriting existing > > > >> ones. But in theory, if I had an infinite army of interns, sure. > I'd > > > >> have one of them do that. :) > > > >> > > > >> But in the real world, compared to saying "we don't have any cql > unit > > > >> tests, so we should always write them as dtests to be consistent" I > > > >> think having mixed unit + dtests is the lesser of evils. > > > >> > > > > > > > > Fair enough. I'll try to make CQL tests as unit tests from now on as > > much > > > > as possible (I can't promise a few misfire in the short term). Let's > > hope > > > > you > > > > find your infinite intern army someday. > > > > > > > > -- > > > > Sylvain > > > > > > > > > > > > -- > http://twitter.com/tjake >
