Re: Client side issues with implementing new Collections support in 1.2

2012-08-06 Thread Sylvain Lebresne
> 1. There does not seem to be a notion of a reflexive o.a.c.cql.jdbc.* class 
> for the new collection classes in o.a.c.db.marshall. Is that intentional or 
> was that to be "left to be implemented student", which for me is now. I am 
> trying to make sure I understand to broader design so I do not go off half 
> cocked.

There isn't one yet, no. We probably need to get CASSANDRA-4453 in
first though, as it brings real compose and decompose methods for the
collections.

As a side note, I don't like at all that we have those jdbc type
classes inside Cassandra. That is, I understand that we want to allow
java clients to use the AbstractType classe without pulling all of C*,
but making that jdbc specific feels like a mistake. Anyway, that a
separate debate and I'll open a ticket for that, just wanted to bring
it up.

> 2. JSON does not have a rich enough vocabulary to imply all of the CQL types 
> without this additional information.

JSON really just was a kind of first try, because it made it easy to
test the collection code. CASSANDRA-4453 brings a more suitable
encoding (I note that the currently patch attached stick to json for
thrift, but as I said in the comments, it's a one line change to
modify that).

--
Sylvain


Re: Client side issues with implementing new Collections support in 1.2

2012-08-06 Thread Jonathan Ellis
On Mon, Aug 6, 2012 at 4:49 AM, Sylvain Lebresne  wrote:
>> 2. JSON does not have a rich enough vocabulary to imply all of the CQL types 
>> without this additional information.
>
> JSON really just was a kind of first try, because it made it easy to
> test the collection code. CASSANDRA-4453 brings a more suitable
> encoding (I note that the currently patch attached stick to json for
> thrift, but as I said in the comments, it's a one line change to
> modify that).

That said, it should still be possible to decode correctly by using
the type information from CqlMetadata.value_types.

-- 
Jonathan Ellis
Project Chair, Apache Cassandra
co-founder of DataStax, the source for professional Cassandra support
http://www.datastax.com


Re: Client side issues with implementing new Collections support in 1.2

2012-08-06 Thread Jonathan Ellis
On Mon, Aug 6, 2012 at 10:15 AM, Jonathan Ellis  wrote:
> That said, it should still be possible to decode correctly by using
> the type information from CqlMetadata.value_types.

Hmm, apparently we only send "set", not "set".  Probably a bug,
but maybe it will be simpler to just switch to a more type-aware
encoding as Sylvain suggested.

-- 
Jonathan Ellis
Project Chair, Apache Cassandra
co-founder of DataStax, the source for professional Cassandra support
http://www.datastax.com


Re: Client side issues with implementing new Collections support in 1.2

2012-08-06 Thread Rick Shaw
If the data type comes across in the "generic" part of the type name in the
metadata, that should be enough for the client side to do its job. (i.e.
ListType or MapType )

I'm happy to change the way to access the compose/decompose fucnctions and
handle the JDBC specific stuff based on Type name and not have a Jdbc
specific set of methods. Just commit in trunk and we will get going.

On Mon, Aug 6, 2012 at 11:20 AM, Jonathan Ellis  wrote:

> On Mon, Aug 6, 2012 at 10:15 AM, Jonathan Ellis  wrote:
> > That said, it should still be possible to decode correctly by using
> > the type information from CqlMetadata.value_types.
>
> Hmm, apparently we only send "set", not "set".  Probably a bug,
> but maybe it will be simpler to just switch to a more type-aware
> encoding as Sylvain suggested.
>
> --
> Jonathan Ellis
> Project Chair, Apache Cassandra
> co-founder of DataStax, the source for professional Cassandra support
> http://www.datastax.com
>


Build failed in Jenkins: Cassandra-quick #1053

2012-08-06 Thread Apache Jenkins Server
See 

--
[...truncated 388 lines...]
[junit] Testsuite: org.apache.cassandra.io.BloomFilterTrackerTest
[junit] Tests run: 3, Failures: 0, Errors: 0, Time elapsed: 5.69 sec
[junit] 
[junit] Testsuite: org.apache.cassandra.io.CompactSerializerTest
[junit] Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 7.881 sec
[junit] 
[junit] Testsuite: org.apache.cassandra.io.LazilyCompactedRowTest
[junit] Tests run: 7, Failures: 0, Errors: 0, Time elapsed: 7.345 sec
[junit] 
[junit] Testsuite: 
org.apache.cassandra.io.compress.CompressedRandomAccessReaderTest
[junit] Tests run: 3, Failures: 0, Errors: 0, Time elapsed: 1.065 sec
[junit] 
[junit] - Standard Error -
[junit]  WARN 21:53:50,390 open(null, O_RDONLY) failed, errno (14).
[junit] -  ---
[junit] Testsuite: org.apache.cassandra.io.sstable.DescriptorTest
[junit] Tests run: 3, Failures: 0, Errors: 0, Time elapsed: 0.065 sec
[junit] 
[junit] Testsuite: org.apache.cassandra.io.sstable.IndexHelperTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0.068 sec
[junit] 
[junit] Testsuite: org.apache.cassandra.io.sstable.LegacySSTableTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 6.739 sec
[junit] 
[junit] Testsuite: 
org.apache.cassandra.io.sstable.SSTableMetadataSerializerTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0.146 sec
[junit] 
[junit] Testsuite: org.apache.cassandra.io.sstable.SSTableReaderTest
[junit] Tests run: 8, Failures: 0, Errors: 0, Time elapsed: 6.229 sec
[junit] 
[junit] - Standard Error -
[junit]  WARN 21:54:06,298 setting live ratio to maximum of 64.0 instead of 
85.44
[junit]  WARN 21:54:06,451 setting live ratio to maximum of 64.0 instead of 
67.31313131313131
[junit] -  ---
[junit] Testsuite: org.apache.cassandra.io.sstable.SSTableSimpleWriterTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 6.226 sec
[junit] 
[junit] Testsuite: org.apache.cassandra.io.sstable.SSTableTest
[junit] Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 5.917 sec
[junit] 
[junit] Testsuite: org.apache.cassandra.io.util.BufferedRandomAccessFileTest
[junit] Tests run: 18, Failures: 0, Errors: 0, Time elapsed: 1.145 sec
[junit] 
[junit] Testsuite: org.apache.cassandra.locator.DynamicEndpointSnitchTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 2.361 sec
[junit] 
[junit] Testsuite: org.apache.cassandra.locator.EC2SnitchTest
[junit] Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 0.974 sec
[junit] 
[junit] Testsuite: org.apache.cassandra.locator.NetworkTopologyStrategyTest
[junit] Tests run: 3, Failures: 0, Errors: 0, Time elapsed: 1.168 sec
[junit] 
[junit] Testsuite: 
org.apache.cassandra.locator.OldNetworkTopologyStrategyTest
[junit] Tests run: 8, Failures: 0, Errors: 0, Time elapsed: 5.861 sec
[junit] 
[junit] - Standard Output ---
[junit] toStream : [(158873535527910577765226390751398592512,0], 
(0,34028236692093846346337460743176821145]]
[junit] toFetch : 
[(127605887595351923798765477786913079296,148873535527910577765226390751398592512]]
[junit] toStreamExpected : [(158873535527910577765226390751398592512,0], 
(0,34028236692093846346337460743176821145]]
[junit] toFetchExpected : 
[(127605887595351923798765477786913079296,148873535527910577765226390751398592512]]
[junit] -  ---
[junit] Testsuite: 
org.apache.cassandra.locator.ReplicationStrategyEndpointCacheTest
[junit] Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 5.906 sec
[junit] 
[junit] Testsuite: org.apache.cassandra.locator.SimpleStrategyTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Time elapsed: 6.683 sec
[junit] 
[junit] Testsuite: org.apache.cassandra.locator.TokenMetadataTest
[junit] Tests run: 3, Failures: 0, Errors: 0, Time elapsed: 0.974 sec
[junit] 
[junit] Testsuite: 
org.apache.cassandra.service.AntiEntropyServiceCounterTest
[junit] Tests run: 6, Failures: 0, Errors: 0, Time elapsed: 7.38 sec
[junit] 
[junit] - Standard Error -
[junit]  WARN 21:54:58,824 No host ID found, created 
084555b5-2986-48d2-ac67-a41fa5c931bb (Note: This should happen exactly once per 
node).
[junit]  WARN 21:54:59,033 Generated random token 
[Token(bytes[90f1e8a57b6958e8669012885f8e2dad])]. Random tokens will result in 
an unbalanced ring; see http://wiki.apache.org/cassandra/Operations
[junit] -  ---
[junit] Testsuite: 
org.apache.cassandra.service.AntiEntropyServiceSt