Bug#821270: Review of git version
Updated: * Reworded the description. * There is no override anymore, although this is not yet perfect. The package *generates* files using various tools. The Debian policy requires the inclusion of source files. Thus this package can't be like a typical simple add-on package. * Corrected the changelog. On 26/05/16 07:57, Sean Whitton wrote: > Hello, > > Thank you for getting this project onto alioth.[1] Here's my review of > the version I found there: > > 1. Have you considered reworking the long description as I suggested >previously? > > 2. Are you sure you aren't willing to rework the organisation of the >project to avoid the override in d/rules? I don't think that's a >reason not to upload the package, but it would be a nice improvement. > > 3. You should have exactly one debian/changelog entry, saying something >like "Initial release (Closes: #821210)." You shouldn't have >changelog entries tracking changes made in response to comments in >this RFS thread since those were not uploaded to Debian. > > [1] https://anonscm.debian.org/git/pkg-mozext/iceweasel-branding.git > signature.asc Description: OpenPGP digital signature
Bug#821270: Review of git version
Done. Will this close the ITP bug automatically? On 28/05/16 00:10, Sean Whitton wrote: > On Sat, May 28, 2016 at 08:38:02AM +0900, Sean Whitton wrote: >> It needs to close the RFS bug! E.g. > > The ITP bug** > signature.asc Description: OpenPGP digital signature
Bug#815006: Bug#821270: Review of git version
Source: firefox-branding-iceweasel This package includes files under: * MPL-2.0 (which is compatible with GPL-2.0+ and LGPL-2.1+) * Triple licensing: MPL-1.1 or GPL-2.1+ or LGPL-2.1+ (compatible with the above) This is largely the same as just 'MPL-2.0' nord-stream On 06/01/2016 03:06 AM, Sean Whitton wrote: > control: tag -1 +moreinfo > > Hello, > > Gianfranco took a look at the package and pointed out to me that the > line > > License: MPL-2.0, and MPL-1.1 or GPL-2.0+ or LGPL-2.1+ > > in d/copyright doesn't really make sense. What are you trying to say? > > I pushed a commit to the team repo to use secure Vcs-* URIs. > signature.asc Description: OpenPGP digital signature
Bug#815006: Restore Iceweasel branding
About Iceweasel branding restoration add-on: Got a preliminary review by Mozilla. More publicity is needed to get a full review. https://addons.mozilla.org/en-US/firefox/addon/iceweasel-branding/ Git repository is here (cleanup needed): https://notabug.org/desktopd/iceweasel-branding nord-stream
Bug#815006: Restore Iceweasel branding
If a package name like xul-ext-* is not mandatory, I think we should go with a nicer name. Probably firefox-branding-iceweasel is the best because it makes clear that it is for Firefox. By the way, can we make the transitional package suggest it then? I'm reading Debian documents now :) Should I put a debian/ directory into the original source repository since it is mostly Debian-specific? nord-stream On 06/04/16 13:09, Sylvestre Ledru wrote: > Le 06/04/2016 à 15:04, Paul Wise a écrit : >> On Wed, 2016-04-06 at 14:35 +0200, Sylvestre Ledru wrote: >> >>> If people wants to get Iceweasel, they should install this theme. >> Fair enough. > Thanks for your flexibility :) >> What would you recommend as a package name? Options: >> >> xul-ext-iceweasel >> firefox-branding-iceweasel >> iceweasel-branding >> > The first one is too technical to me. > > The two others are fine by me! > > Sylvestre > >
Bug#815006: Restore Iceweasel branding
https://packages.debian.org/sid/xul-ext-iceweasel-branding Can we do something to make this available to the users as soon as possible? Now firefox-esr is out for stable users, too. Also, we should consider adding a .desktop file to the package in order to correct the inconsistent user experience caused by Firefox not having the Iceweasel icon as expected. Currently, alternatives and dpkg-divert are proposed. Any ideas? /usr/share/applications/iceweasel.desktop (Iceweasel→Firefox ESR) Thanks. nord-stream signature.asc Description: OpenPGP digital signature
Bug#815006: Restore Iceweasel branding
I've implemented dpkg-divert scripts and Iceweasel desktop icon works
beautifully for me with this change.
https://anonscm.debian.org/cgit/pkg-mozext/iceweasel-branding.git/
On 16/06/16 05:34, Sean Whitton wrote:
> Hello,
>
> On Wed, Jun 15, 2016 at 02:06:56PM +, Gianfranco Costamagna wrote:
>> the "bug" is introduce with a stable-release-update, and should be fixed
>> with another s-p-u
>>
>> fixing it with a backport means the user should be aware of the fix in
>> another
>> pocket, enable it, install it, and so on.
>> I guess having both "issue" and "fix" on the same pocket is reasonable
>> (note: I have no authoritative hat on)
>
> Ah right, I see what you mean. I guess it's up to nord-stream whether
> he thinks the package is fixing a bug or not, and whether it should go
I'm a female student in Japan (".jp." in the email address), but I
didn't said that. As I have nothing to do with 'computer science', I
don't have so much time to work on coding. BTW, 'nord-stream' in my
email address refers to a Russian pipeline (just because the SMTP server
is in Russia).
> into s-p-u or just bpo.
>
I'd like to submit the package to stable-release-update.
Thanks.
nord-stream
signature.asc
Description: OpenPGP digital signature
Bug#815006: Restore Iceweasel branding
Yes, as I consulted that section in Policy, I CC'd all of these messages to pkg-mozilla-maintainers list. I haven't received any response about it yet. Explaining the topic here again: * firefox-branding-iceweasel (Binary: xul-ext-iceweasel-branding), the package to restore Iceweasel experience, did not provide a correctly branded desktop icon as of the version 0.2.3 (now in testing). * I've written a new version that substitutes the two .desktop files from firefox(-esr) with Iceweasel ones to complete the rebranding, using dpkg-divert. * Since the use of dpkg-divert requires attention from the affected maintainers, I'd like Mozilla packages maintainers to check the package. Any piece of advice is welcome. Git repository at pkg-mozext: https://anonscm.debian.org/cgit/pkg-mozext/iceweasel-branding.git/ I intend to submit this for stable-release-update. Thanks, nord-stream On 19/06/16 06:42, Sean Whitton wrote: > Hello again nord-stream, > > On Fri, Jun 17, 2016 at 06:27:28AM +, nord-stream wrote: >> I've implemented dpkg-divert scripts and Iceweasel desktop icon works >> beautifully for me with this change. >> >> https://anonscm.debian.org/cgit/pkg-mozext/iceweasel-branding.git/ > > I just checked the Debian Policy Manual on dpkg-divert. It says "You > should not use `dpkg-divert' on a file belonging to another package > without consulting the maintainer of that package first." Have you done > this? > signature.asc Description: OpenPGP digital signature
Bug#821270: RFS: firefox-branding-iceweasel/0.3.0 [ITP] -- Preserves Iceweasel branding for new Firefox packages
Fixed in Git. I will upload the new package with other proposed changes soon. On 18/04/16 18:47, Ben Finney wrote: > nord-stream writes: > >> It builds those binary packages: >> >> firefox-branding-iceweasel - Preserves Iceweasel branding for new Firefox >> packages > > Please change the description synopsis, to conform to the Developer's > Reference §6.2.2. > > That entails that it should not be a sentence itself, but a phrase > describing what the package *is*. > > The synopsis “” should make sense when inserted into a > sentence of the form “The package installs .”. > > So a proper sentence is not appropriate as the “”. > > I suggest: > > branding for Firefox to apply Iceweasel name and images > -- nord-stream signature.asc Description: OpenPGP digital signature
Bug#821270: Review of firefox-branding-iceweasel
On 18/04/16 20:20, Sean Whitton wrote: > The package is mostly fine. Here are some points: > > - binary package name should be xul-ext-iceweasel-branding or similar I thought of creating packages named firefox-branding-iceweasel, thunderbird-branding-icedove, etc. I am aware of the naming convention, but these extensions are not much like extensions but just branding packages. (In fact it Provides: xul-ext-iceweasel-branding.) Is that naming mandatory? I also found many of xul-ext-* packages do not include a single XUL file. (Neither does firefox-branding-iceweasel.) More discussion at: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=815006#145 > - is it possible to generalise this to restore both icedove and > iceweasel branding in one binary package? (icedove will soon become > thunderbird) It may be possible, but many people use one and not another, so one binary package may not be desirable. One source package may be a good idea, though. > - don't install the MPL-* files using debian/docs. Instead, include > the full license text in debian/copyright. firefox-esr package seems to do this. Do you mean that it is not appropriate for a branding package? > - as Gianfranco suggested, this should be team maintained. Your name > should be in the Uploaders: field in debian/control, and Maintainer: > should be the Mozilla extensions packaging team. You should upload > the git repository to the Mozilla extensions team section of alioth. That seems right. Please tell me more. > Do you have an alioth account? I don't. What does it mean? I'm willing to do what's needed. > - the long description is not, IMO, appropriate. You should include > the history of the package in the README.markdown, and just give a > terse description of what it does in the long description (or at > least in the first paragraph of the long description) I'll consider this point later. > - on my machine, the package doesn't change the application icon -- > see the top of the attached screenshot. Maybe you can't fix that, > though. Not possible with an extension. Doable with a .desktop file, I think. On 19/04/16 02:18, Sean Whitton wrote: > I just took a closer look at your debian/rules file. You don't need the > boilerplate. This is enough: Done. Will upload later. > However, since this is a native package, would you consider editing your > Makefile so that dh_xul-ext can do your whole build for you? Take a > look at the source package y-u-no-validate. It uses this main Makefile > target: > > , > | %: > | dh $@ --with xul-ext --buildsystem=xul_ext --sourcedirectory=src > ` > > There is an override, but it's just something minor. This works because > the source code is organised in a standard way, but your code seems to > be organised in a non-standard way which is why you need a complex > Makefile and dh overrides. The complex part of Makefile is from Iceweasel package. Although most extensions' Makefiles just pack files into .xpi, it generates files from source files. This tiny override just saved me of hours of studying more about customizing dh_xul-ext. Thank you for reviewing, -- nord-stream signature.asc Description: OpenPGP digital signature
Bug#831447: firefox-branding-iceweasel 0.4.0 MIGRATED to testing
Any progress on this? **Please support user choice.** If 20% of firefox-esr users want Iceweasel back, that's still a large number of users. Thank you for understanding... nord-stream signature.asc Description: OpenPGP digital signature
Bug#821210: ITP: firefox-branding-iceweasel -- Preserves Iceweasel branding for new Firefox packages
Package: wnpp Owner: "nord-stream" Severity: wishlist * Package name: firefox-branding-iceweasel Version : 0.3.0 Upstream Author : nord-stream" * URL : https://notabug.org/desktopd/iceweasel-branding * License : MPL-2.0 Programming Lang: JavaScript Description : Preserves Iceweasel branding for new Firefox packages Debian distributed a rebranded version of Firefox called Iceweasel. This was due to legal concerns. In 2016 Debian and Mozilla developers agreed that Debian can legally package Firefox without violating DFSG. Firefox is back in Debian and Iceweasel is now gone! However, some people want to continue using Iceweasel, and Iceweasel does have a historical value. So this rebranding package was created to restore Iceweasel branding for Firefox. Most files are just copied from the original Iceweasel package. This will be a native package. Mozilla Extension Packaging Team may be relevant. I hope that this will be available when Iceweasel disappears from stable.
Bug#815006: Ready for review: firefox-branding-iceweasel
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 I've just created a native package firefox-branding-iceweasel, which can be built off the git repository at https://notabug.org/desktopd/iceweasel-branding This is installed as a Firefox extension. I hope that this will be available when Iceweasel disappears from stable. Mozilla Extension Packaging Team may be relevant. -BEGIN PGP SIGNATURE- Version: GnuPG v2 iQIcBAEBCAAGBQJXEoHWAAoJELLXhgqJeBA2vGcQAIzZKXVFoGOWwux0gzahplU/ pkVfIvY9Oa/GbcftQ8IeTX4Im8dd53uK/t5siB5hCGI6dRKcmaeMb6zka4REUDiX IjTC3S4zgwS9MW/gZe97JJ4kit3ITeBvT8+f1Srv0qsUE3dTLxjyYCn7kYhCQhbG fHrkD8XCBNAevLXE70wSBxTPS1TILedTHp1fF0vtBOconSbqL+uxkUyyyxJutzZ9 zDrVLMfpNf/8s4S/FSoYVAv3sNwSgfY8i0Q4jBEwxCBpl9MzrBeVySUSJvtvFDDV 1xxiOcuUwNg95U0gEqQMGAmKfMOEWZT2PkrgI/O9MmNU9ZKPoIsChP/1zvpLOJIQ J+xqpKNropb+HOvQyv9i/Ecw5qRIdaC9aCO0BazJHJKCTOGnMOnniP8rYaCXVoH/ IB1QHKmYWkZ0YxjUT9as+jiGvKO+RAmzjULEsWN72rdVSfDT68SAHcmBNakeVyw7 HotSFYh0xQ6gwN+sevYFkXhg5FH3SK341Sv0Hk/cVc0WB5+nFZr7CbF6jb4jD7pw 6CEGJ5vYTicQ1rsE/U/SMgU4pQNCDRCdLv7IU8IpsKJzqr1HGd6vVnjtZ13ALKiF DFQxK1uEzalCHydmQh1CEwUC2bXAZQVuwAKUvwyj9YY28ZtvP3aWzc7udF3m4J2l TVRjg7owglh5GS+zerK+ =d7dw -END PGP SIGNATURE-
Bug#821270: RFS: firefox-branding-iceweasel/0.3.0 [ITP] -- Preserves Iceweasel branding for new Firefox packages
Package: sponsorship-requests Severity: wishlist Dear mentors, I am looking for a sponsor for my package "firefox-branding-iceweasel" * Package name: firefox-branding-iceweasel Version : 0.3.0 Upstream Author : nord-stream * URL : https://notabug.org/desktopd/iceweasel-branding * License : MPL-2.0 Section : web It builds those binary packages: firefox-branding-iceweasel - Preserves Iceweasel branding for new Firefox packages To access further information about this package, please visit the following URL: http://mentors.debian.net/package/firefox-branding-iceweasel Alternatively, one can download the package with dget using this command: dget -x http://mentors.debian.net/debian/pool/main/f/firefox-branding-iceweasel/firefox-branding-iceweasel_0.3.0.dsc More information about this package can be obtained from https://notabug.org/desktopd/iceweasel-branding. Changelog: * Initial Debian packaging. * Removed support for older Firefox releases (<45.0). Regards, nord-stream signature.asc Description: OpenPGP digital signature
Bug#821270: RFS: firefox-branding-iceweasel/0.3.0 [ITP] -- Preserves Iceweasel branding for new Firefox packages
On 18/04/16 08:05, Paul Wise wrote:
> On Sun, Apr 17, 2016 at 3:25 PM, nord-stream wrote:
>
>> * Package name: firefox-branding-iceweasel
>
> Thoughts:
>
> Should the vendorShortName be Debian instead of Mozilla?
I think that file was copied as-is from the last Iceweasel source package.
>
> One thing that isn't rebranded is the window icon, when I do alt-tab I
> get the Firefox icon.
Technically a Firefox extension cannot change this. It's a .desktop
file's job, I assume. But can we replace a .desktop file from another
package? Adding extra files to be installed also complicates rules a lot.
>
> Automatic checks:
>
> Build:
>
> ...
> make[1]: Entering directory
> '/home/pabs/devel/debian/mentors/firefox-branding-iceweasel-0.3.0'
> xpi-pack ./xpi-build ./build.xpi
> Packing ./build.xpi
> Packed XPI file. It is located in
> /home/pabs/devel/debian/mentors/firefox-branding-iceweasel-0.3.0
> install-xpi ./build.xpi
> Archive: ./build.xpi
> ...
> inflating:
> /home/pabs/devel/debian/mentors/firefox-branding-iceweasel-0.3.0/debian/firefox-branding-iceweasel/usr/share/xul-ext/firefox-branding-iceweasel/install.rdf
> /usr/lib/python2.7/dist-packages/RDF.py:2014: RedlandWarning: Variable
> bnodeid1 was bound but is unused in the query
> results = Redland.librdf_query_execute(self._query,model._model)
> /usr/lib/python2.7/dist-packages/RDF.py:2014: RedlandWarning: Variable
> bnodeid2 was bound but is unused in the query
> results = Redland.librdf_query_execute(self._query,model._model)
> ...
>dh_xul-ext -O--parallel
> /usr/lib/python2.7/dist-packages/RDF.py:2014: RedlandWarning: Variable
> bnodeid1 was bound but is unused in the query
> results = Redland.librdf_query_execute(self._query,model._model)
>
>
> check-all-the-things:
>
> $ find -type f -iname '*.css' -exec csslint-0.6 {} \; > /dev/null
> parsing error: 4:1:could not recognize next production
> parsing error: 6:1:while parsing rulset: current char must be a '}'
> parsing error: 5:15:while parsing declaration: next property is malformed
> parsing error: 4:1:could not recognize next production
> parsing error: 6:1:while parsing rulset: current char must be a '}'
> parsing error: 5:15:while parsing declaration: next property is malformed
> parsing error: 4:1:could not recognize next production
> parsing error: 6:1:while parsing rulset: current char must be a '}'
> parsing error: 5:15:while parsing declaration: next property is malformed
>
> $ debmake -k
> ...
> === debian/copyright checked for 102 data ===
> Pattern #00: *
> File: xpi-build/chrome/content/aboutIceweasel/aboutIce.js
> - MPL-2.0
> + MPL-1.1
>
> Pattern #01: src/iceweasel/*
> File: src/iceweasel/content/aboutIceweasel/aboutIce.js
> - MPL-2.0, and MPL-1.1 or GPL-2.0+ or LGPL-2.1+
> + MPL-1.1
>
> Pattern #01: src/iceweasel/*
> File: src/iceweasel/content/aboutDialog.css
> src/iceweasel/content/browser-overlay.css
> - MPL-2.0, and MPL-1.1 or GPL-2.0+ or LGPL-2.1+
> + MPL-2.0
>
> # check if these can be switched to https://
> $ grep -rF http: .
>
>
> $ license-reconcile
> ...
> License mismatch: File
> src/iceweasel/content/aboutIceweasel/aboutIce.js has license MPL
> (v1.1) GPL (unversioned/unknown version) which does not match GPL-2.0+
> or LGPL-2.1+ or MPL-2.0, and MPL-1.1. at
> /usr/share/perl5/Debian/LicenseReconcile/App.pm line 222, line
> 3.
> ...
> License mismatch: File src/iceweasel/content/aboutIceweasel/ice.xhtml
> has license MPL (v1.1) GPL (unversioned/unknown version) which does
> not match GPL-2.0+ or LGPL-2.1+ or MPL-2.0, and MPL-1.1. at
> /usr/share/perl5/Debian/LicenseReconcile/App.pm line 222, line
> 3.
> ...
> License mismatch: File src/iceweasel/content/browser-overlay.css has
> license MPL-2.0 which does not match GPL-2.0+ or LGPL-2.1+ or MPL-2.0,
> and MPL-1.1. at /usr/share/perl5/Debian/LicenseReconcile/App.pm line
> 222, line 3.
>
> $ find -type d \( -iname .bzr -o -iname .git -o -iname .hg -o -iname
> .svn -o -iname CVS -o -iname RCS -o -iname SCCS -o -iname _MTN -o
> -iname _darcs -o -iname .pc -o -iname .cabal-sandbox -o -iname .cdv -o
> -iname .metadata -o -iname CMakeFiles -o -iname _build -o -iname
> _sgbak -o -iname autom4te.cache -o -iname blib -o -iname cover_db -o
> -iname node_modules -o -iname '~.dep' -o -iname '~.dot' -o -iname
> '~.nib' -o -iname '~.plst' \) -prune -o -type f ! \( -iname '*.bak' -o
> -iname '*.swp' -o -iname '#.*' -o -iname '#*#' -o -iname 'core.*' -o
> -iname '*~' -o -iname '*.gif' -o -iname '*.jpg' -o -iname '*.jpeg' -o
> -iname '*.png' -o -iname '*.min.js' -o -iname '*.js.map' -o -iname
> '*.js.min' -o -iname '*.min.css' -o -iname '*.css.map' -o -iname
> '*.css.min' \) -exec spellintian --picky {} +
> ./README.markdown: debian -> Debian
>
Bug#831447: jessie-pu: package firefox-branding-iceweasel/0.4.0
Package: release.debian.org Severity: normal Tags: jessie User: release.debian@packages.debian.org Usertags: pu With the introduction of firefox-esr in stable Iceweasel is gone. Because many users want to keep the branding, I've packaged the branding into a native moz-ext package: firefox-branding-iceweasel (binary: xul-ext-iceweasel-branding). It is in testing now. It provides an option to restore Iceweasel branding. As it is important to have this option also in stable, I'd like the package in stable. Description: Branding for Firefox to apply Iceweasel name and images This package preserves and restores the look and feel of Iceweasel, the Debian- rebranded version of Firefox distributed before Firefox came back to Debian. Most files were just copied from the original Iceweasel package, including the famous about:iceweasel page of historic value. firefox-branding-iceweasel (0.4.0) unstable; urgency=low * Register a .desktop file and icons. * Marked as multiprocess-compatible. firefox-branding-iceweasel (0.3.2) unstable; urgency=low * Initial Debian packaging. (Closes: #821210) * Removed support for older Firefox releases (<45.0). Correct me if wrong. Thanks. nord-stream
Bug#831447: firefox-branding-iceweasel 0.4.0 MIGRATED to testing
On 18/07/16 17:57, Adam D. Barratt wrote: > [Why is this CCed to quite so many places / people?] Sponsor, reviewer, related package maintainers... > A debdiff between two versions of the package is not that helpful to > convince anyone that the new version should be added to stable, given > that no version is currently in stable. I'm aware of that. ;) > As a more general note, adding packages to stable is something that's > done very sparingly and at least this SRM would need more convincing > that it should be done - rather than, say, using jessie-backports - than > "it's important". I understand that and I don't intend to make such a request regularly. It's because the package is part of the follow-up UX work of firefox-esr's migration into jessie, targeted at a significant portion of general stable Debian users. (I'm sorry for the delay) People who don't use backports have got firefox-esr. Quite a few users seem confused. This is important for consistency and usability. With this in stable, we can say to anyone who wants to keep Iceweasel: "Run this command: sudo apt-get install xul-ext-iceweasel-branding" Without bothering about backports. It is just a rare exception. Quote (from 815...@bugs.debian.org and pkg-mozilla-maintain...@lists.alioth.debian.org lists): On 15/06/16 14:06, Gianfranco Costamagna wrote: > the "bug" is introduce with a stable-release-update, and should be fixed > with another s-p-u Thank you for the reply. nord-stream signature.asc Description: OpenPGP digital signature
