Re: [Cython] Issues with CYTHON_FALLTHROUGH

2017-10-14 Thread Lisandro Dalcin
Folks, let me fix the the  CYTHON_FALLTHROUGH the right way.
Additionally, I'll extend the Travis-CI build matrix with python 2/3
and a couple of xcode images.

On 14 October 2017 at 01:22, Stefan Behnel  wrote:
> Lisandro Dalcin schrieb am 13.10.2017 um 21:42:
>> This is from a conda-forge build of petsc4py on Travis-CI with
>> "osx_image: xcode6.4"
>>
>> https://travis-ci.org/conda-forge/petsc4py-feedstock/jobs/287563030
>>
>>
>> Maybe a better definition is the one below?
>>
>>   #ifndef CYTHON_FALLTHROUGH
>> #if defined(__clang__) && __has_attribute(fallthrough)
>>   #define CYTHON_FALLTHROUGH __attribute__((fallthrough))
>> #elif defined(__GNUC__) && defined(__attribute__)
>>   #define CYTHON_FALLTHROUGH __attribute__((fallthrough))
>> #else
>>   #define CYTHON_FALLTHROUGH
>> #endif
>>   #endif
>
> Applied it here:
>
> https://github.com/cython/cython/commit/207d694ac2a580f02b28e216d0843308f5ad129b
>
> Stefan
> ___
> cython-devel mailing list
> cython-devel@python.org
> https://mail.python.org/mailman/listinfo/cython-devel



-- 
Lisandro Dalcin

Research Scientist
Computer, Electrical and Mathematical Sciences & Engineering (CEMSE)
Extreme Computing Research Center (ECRC)
King Abdullah University of Science and Technology (KAUST)
http://ecrc.kaust.edu.sa/

4700 King Abdullah University of Science and Technology
al-Khawarizmi Bldg (Bldg 1), Office # 0109
Thuwal 23955-6900, Kingdom of Saudi Arabia
http://www.kaust.edu.sa

Office Phone: +966 12 808-0459
___
cython-devel mailing list
cython-devel@python.org
https://mail.python.org/mailman/listinfo/cython-devel


Re: [Cython] Issues with CYTHON_FALLTHROUGH

2017-10-14 Thread Stefan Behnel
Lisandro Dalcin schrieb am 14.10.2017 um 15:03:
> Folks, let me fix the the  CYTHON_FALLTHROUGH the right way.
> Additionally, I'll extend the Travis-CI build matrix with python 2/3
> and a couple of xcode images.

Go for it. I was planning to release 0.27.2 shortly, so I'll just wait for
your PR and then get it out.

Stefan
___
cython-devel mailing list
cython-devel@python.org
https://mail.python.org/mailman/listinfo/cython-devel