Re: [Cython] Cython 0.26 release
Could the error from https://github.com/cython/cython/issues/1732 at https://github.com/cython/cython/blob/master/Cython/Compiler/Symtab.py#L2099 be a warning instead? SageMath has quite a bit of code hitting this error. It would make our life easier if we could fix it gradually instead of being forced to fix it all before upgrading to Cython 0.26. ___ cython-devel mailing list cython-devel@python.org https://mail.python.org/mailman/listinfo/cython-devel
Re: [Cython] Cython 0.26 release
I'm getting an infinite recursion in deepcopy() in fresh_finally_clause() here: https://github.com/cython/cython/blob/master/Cython/Compiler/Nodes.py#L7022 I'm reporting it now in case you immediately know what the problem is. I'll try to analyse it later. ___ cython-devel mailing list cython-devel@python.org https://mail.python.org/mailman/listinfo/cython-devel
Re: [Cython] Cython 0.26 release
See https://github.com/cython/cython/issues/1744 This seems to be the final issue breaking SageMath with Cython master. ___ cython-devel mailing list cython-devel@python.org https://mail.python.org/mailman/listinfo/cython-devel
Re: [Cython] Cython 0.26 release
On Wed, Jun 21, 2017 at 5:29 AM, Jeroen Demeyer wrote: > Could the error from > https://github.com/cython/cython/issues/1732 > at > https://github.com/cython/cython/blob/master/Cython/Compiler/Symtab.py#L2099 > be a warning instead? > > SageMath has quite a bit of code hitting this error. It would make our life > easier if we could fix it gradually instead of being forced to fix it all > before upgrading to Cython 0.26. Could you give some examples? Is it cdef->cpdef, or something else? It's possible that the error needs to be made narrower, but I'd really like to avoid incorrect code that could lead to wrong methods being called. ___ cython-devel mailing list cython-devel@python.org https://mail.python.org/mailman/listinfo/cython-devel
Re: [Cython] Cython 0.26 release
On 2017-06-21 17:44, Robert Bradshaw wrote: Is it cdef->cpdef, or something else? Yes, it is. It's possible that the error needs to be made narrower, but I'd really like to avoid incorrect code that could lead to wrong methods being called. Fine... we can still patch Cython in Sage. ___ cython-devel mailing list cython-devel@python.org https://mail.python.org/mailman/listinfo/cython-devel
Re: [Cython] Cython 0.26 release
On Mon, Jun 19, 2017 at 4:27 PM Robert Bradshaw wrote: > I'd like to officially start off the release process with an alpha > candidate. This does necessarily contain everything that will be in > the final release, but given the amount of time that has passed I > would recommend everyone test this out with their projects sooner > rather than later. > > Download: https://github.com/cython/cython/archive/0.26.alpha0.zip > Initial changelog: > https://github.com/cython/cython/blob/0.26.alpha0/CHANGES.rst > > Please feel free to respond to this thread or file bugs as necessary. > > Thanks, > Robert > I ran a quick test against dynd-python with master this morning. Everything looks fine there. Thanks for managing the release. Best, Ian Henriksen ___ cython-devel mailing list cython-devel@python.org https://mail.python.org/mailman/listinfo/cython-devel
Re: [Cython] Cython 0.26 release
On Wed, Jun 21, 2017 at 9:59 AM, Jeroen Demeyer wrote: > On 2017-06-21 17:44, Robert Bradshaw wrote: >> >> Is it cdef->cpdef, or something else? > > Yes, it is. > >> It's possible that the error needs to be made narrower, but I'd really >> like to avoid incorrect code that could lead to wrong methods being >> called. > > Fine... we can still patch Cython in Sage. I suppose in that case we just got lucky that no one cimported these classes and tried to use methods after this point in the vtable... ___ cython-devel mailing list cython-devel@python.org https://mail.python.org/mailman/listinfo/cython-devel
Re: [Cython] Cython 0.26 release
On 2017-06-21 20:25, Robert Bradshaw wrote: I suppose in that case we just got lucky that no one cimported these classes and tried to use methods after this point in the vtable... I think that's the case indeed. ___ cython-devel mailing list cython-devel@python.org https://mail.python.org/mailman/listinfo/cython-devel
Re: [Cython] Cython 0.26 release
On Wed, Jun 21, 2017 at 12:41 PM, Jeroen Demeyer wrote: > On 2017-06-21 20:25, Robert Bradshaw wrote: >> >> I suppose in that case we just got lucky that no one cimported these >> classes and tried to use methods after this point in the vtable... > > I think that's the case indeed. I'll see if I can put together a patch. ___ cython-devel mailing list cython-devel@python.org https://mail.python.org/mailman/listinfo/cython-devel
